Skip to contentSkip to conversation

sched: completion: use bool in try_wait_for_completion

PATCH In review gaurav jindal 2 participants 2 messages Feb 14, 2018 – Feb 19, 2018 Scheduler

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sched: completion: use bool in try_wait_for_completion

Use bool in place of int in the function try_wait_for_completion.

---

kernel/sched/completion.c +3 -3
index 0926aef..3e15e8d 100644
@@ -283,7 +283,7 @@ int __sched wait_for_completion_killable(struct completion *x)
 bool try_wait_for_completion(struct completion *x)
 {
        unsigned long flags;
-       int ret = 1;
+       bool ret = true;
 
        /*
         * Since x->done will need to be locked only
@@ -292,11 +292,11 @@ bool try_wait_for_completion(struct completion *x)
         * return early in the blocking case.
         */
        if (!READ_ONCE(x->done))
-               return 0;
+               return false;
 
        spin_lock_irqsave(&x->wait.lock, flags);
        if (!x->done)
-               ret = 0;
+               ret = false;
        else if (x->done != UINT_MAX)
                x->done--;
        spin_unlock_irqrestore(&x->wait.lock, flags);
maintainer
#1 lore raw
Quoted 1 line · gaurav jindal

Use bool in place of int in the function try_wait_for_completion.

I can see that from the patch; what you failed to describe is why you've bothered to do the patch.

Which doesn't apply because of whitespace damage; please re-read the documentation on how to send patches.