ARM: OMAP: clock: Fix debugfs_create_*() usage
Subsystems (5)
PATCH 1/1 ARM: OMAP: clock: Fix debugfs_create_*() usage
When exposing data access through debugfs, the correct debugfs_create_*() functions must be used, depending on data type.
Remove all casts from data pointers passed to debugfs_create_*() functions, as such casts prevent the compiler from flagging bugs.
Correct all wrong usage:
- clk.rate is unsigned long, not u32,
- clk.flags is u8, not u32, which exposed the successive clk.rate_offset and clk.src_offset fields.
---
Compile-tested only.
--- arch/arm/mach-omap1/clock.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/mach-omap1/clock.c +3 -3
@@ -1011,17 +1011,17 @@ static int clk_debugfs_register_one(struct clk *c)return -ENOMEM ; c->dent = d; - d =debugfs_create_u8 ("usecount" ,S_IRUGO , c->dent, (u8 *)&c->usecount); + d =debugfs_create_u8 ("usecount" ,S_IRUGO , c->dent, &c->usecount);if (!d) { err = -ENOMEM ; goto err_out; } - d =debugfs_create_u32 ("rate" ,S_IRUGO , c->dent, (u32 *)&c->rate); + d =debugfs_create_ulong ("rate" ,S_IRUGO , c->dent, &c->rate);if (!d) { err = -ENOMEM ; goto err_out; } - d =debugfs_create_x32 ("flags" ,S_IRUGO , c->dent, (u32 *)&c->flags); + d =debugfs_create_x8 ("flags" ,S_IRUGO , c->dent, &c->flags);if (!d) { err = -ENOMEM ; goto err_out;
Signature · 1 line
2.7.4
Aaro Koskinen
maintainerPATCH 1/1 ARM: OMAP: clock: Fix debugfs_create_*() usage
Hi,
Quoted 6 lines · Geert Uytterhoeven
When exposing data access through debugfs, the correct debugfs_create_*() functions must be used, depending on data type.
Remove all casts from data pointers passed to debugfs_create_*() functions, as such casts prevent the compiler from flagging bugs.
Quoted 6 lines
Correct all wrong usage:
- clk.rate is unsigned long, not u32,
- clk.flags is u8, not u32, which exposed the successive clk.rate_offset and clk.src_offset fields.Signed-off-by Geert Uytterhoeven <[email protected]>
A.
Quoted 34 lines
---
Compile-tested only.--- arch/arm/mach-omap1/clock.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)arch/arm/mach-omap1/clock.c +3
-3@@ -1011,17 +1011,17 @@ static int clk_debugfs_register_one(struct clk *c)return -ENOMEM ; c->dent = d; - d =debugfs_create_u8 ("usecount" ,S_IRUGO , c->dent, (u8 *)&c->usecount); + d =debugfs_create_u8 ("usecount" ,S_IRUGO , c->dent, &c->usecount);if (!d) { err = -ENOMEM ; goto err_out; } - d =debugfs_create_u32 ("rate" ,S_IRUGO , c->dent, (u32 *)&c->rate); + d =debugfs_create_ulong ("rate" ,S_IRUGO , c->dent, &c->rate);if (!d) { err = -ENOMEM ; goto err_out; } - d =debugfs_create_x32 ("flags" ,S_IRUGO , c->dent, (u32 *)&c->flags); + d =debugfs_create_x8 ("flags" ,S_IRUGO , c->dent, &c->flags);if (!d) { err = -ENOMEM ; goto err_out;Signature · 1 line
2.7.4
Tony Lindgren
reviewerPATCH 1/1 ARM: OMAP: clock: Fix debugfs_create_*() usage
Quoted 9 lines · Aaro Koskinen
Hi,
Quoted 6 lines · Geert Uytterhoeven
When exposing data access through debugfs, the correct debugfs_create_*() functions must be used, depending on data type.
Remove all casts from data pointers passed to debugfs_create_*() functions, as such casts prevent the compiler from flagging bugs.
Quoted 8 lines
Quoted 6 lines
Correct all wrong usage:
- clk.rate is unsigned long, not u32,
- clk.flags is u8, not u32, which exposed the successive clk.rate_offset and clk.src_offset fields.Signed-off-by Geert Uytterhoeven <[email protected]>Acked-by Aaro Koskinen <[email protected]>
Applying into omap-for-v4.16/fixes thanks.
Tony