Skip to contentSkip to conversation

set_elem: nftnl_set_elems_parse() returns 0 if set is empty

PATCH New Pablo Neira Ayuso 1 participant 1 message Feb 14, 2018 netfilter

lore
Share & tools
lore

Pablo Neira Ayuso

author maintainer
#0 lore raw

PATCH 1/1 set_elem: nftnl_set_elems_parse() returns 0 if set is empty

Instead of -1, which results n misleading error propagate to the caller with errno == 0 (success).

---
 src/set_elem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
src/set_elem.c +1 -1
index e02a38791c9a..1ac53dadbb75 100644
@@ -490,7 +490,7 @@ nftnl_set_elem_list_parse_attr_cb(const struct nlattr *attr, void *data)
 static int nftnl_set_elems_parse(struct nftnl_set *s, const struct nlattr *nest)
 {
 	struct nlattr *attr;
-	int ret = -1;
+	int ret = 0;
 
 	mnl_attr_for_each_nested(attr, nest) {
 		if (mnl_attr_get_type(attr) != NFTA_LIST_ELEM)
Signature · 1 line
2.11.0