Skip to contentSkip to conversation

Config.in{,host}: check-package pass

PATCH New Gaël PORTAY 3 participants 6 messages Feb 14, 2018 Tegra architecture support

lore
Share & tools
lore
#0 lore raw

cover Config.in{,host}: check-package pass

Hi,

Here are some fixes about warning reported by check-package.

Regards,
Ga?l PORTAY (3):
package/*/Config.in.host: fix help text check-package warnings
gconf: Config.in: fix help text wrapping
pure-ftpd: Config.in: fix help text wrapping

 package/gconf/Config.in                  | 6 +++---
 package/mtools/Config.in.host            | 8 ++++----
 package/omap-u-boot-utils/Config.in.host | 4 ++--
 package/pkgconf/Config.in.host           | 9 +++++----
 package/pure-ftpd/Config.in              | 4 ++--
 package/pwgen/Config.in.host             | 4 ++--
 package/qemu/Config.in.host              | 3 ++-
 package/tegrarcm/Config.in.host          | 4 ++--
 8 files changed, 22 insertions(+), 20 deletions(-)
Signature · 1 line
2.15.1
#1 lore raw

PATCH 1/3 package/*/Config.in.host: fix help text check-package warnings

This commit fixes the warnings reported by check-package on the help text of all package Config.in.host files, related to the formatting of the help text: should start with a tab, then 2 spaces, then at most 62 characters.

---
 package/mtools/Config.in.host            | 8 ++++----
 package/omap-u-boot-utils/Config.in.host | 4 ++--
 package/pkgconf/Config.in.host           | 9 +++++----
 package/pwgen/Config.in.host             | 4 ++--
 package/qemu/Config.in.host              | 3 ++-
 package/tegrarcm/Config.in.host          | 4 ++--
 6 files changed, 17 insertions(+), 15 deletions(-)
package/mtools/Config.in.host +4 -4
index 96b332b039..42cb6f80fb 100644
@@ -1,9 +1,9 @@
 config BR2_PACKAGE_HOST_MTOOLS
 	bool "host mtools"
 	help
-	  Mtools is a collection of utilities to access MS-DOS disks from
-	  Unix without mounting them. It supports Win'95 style long file
-	  names, OS/2 Xdf disks and 2m disks (store up to 1992k on a high
-	  density 3 1/2 disk).
+	  Mtools is a collection of utilities to access MS-DOS disks
+	  from Unix without mounting them. It supports Win'95 style long
+	  file names, OS/2 Xdf disks and 2m disks (store up to 1992k on
+	  a high density 3 1/2 disk).
 
 	  http://www.gnu.org/software/mtools/
package/omap-u-boot-utils/Config.in.host +2 -2
index 87dcc06938..1549674f01 100644
@@ -3,7 +3,7 @@ config BR2_PACKAGE_HOST_OMAP_U_BOOT_UTILS
 	depends on BR2_arm || BR2_armeb
 	help
 	  U-Boot Utilities for Texas Instrument's OMAP platforms.
-	  This is a set of tools to control U-Boot from scripts, generate
-	  OMAP-specific signed image files and more.
+	  This is a set of tools to control U-Boot from scripts,
+	  generate OMAP-specific signed image files and more.
 
 	  https://github.com/nmenon/omap-u-boot-utils
package/pkgconf/Config.in.host +5 -4
index 437a7bf6f9..56836a5cbf 100644
@@ -1,9 +1,10 @@
 config BR2_PACKAGE_HOST_PKGCONF
 	bool "host pkgconf"
 	help
-	  pkgconf is a program which helps to configure compiler and linker
-	  flags for development frameworks. It is similar to pkg-config,
-	  but was written from scratch in the summer of 2011 to replace
-	  pkg-config, which now needs itself to build itself
+	  pkgconf is a program which helps to configure compiler and
+	  linker flags for development frameworks. It is similar to
+	  pkg-config, but was written from scratch in the summer of
+	  2011 to replace pkg-config, which now needs itself to build
+	  itself
 
 	  https://github.com/pkgconf/pkgconf
package/pwgen/Config.in.host +2 -2
index 0c56851dcb..20b55f3fc0 100644
@@ -1,7 +1,7 @@
 config BR2_PACKAGE_HOST_PWGEN
 	bool "host pwgen"
 	help
-	  Pwgen is a small, GPL'ed password generator which creates passwords
-	  which can be easily memorized by a human.
+	  Pwgen is a small, GPL'ed password generator which creates
+	  passwords which can be easily memorized by a human.
 
 	  http://sourceforge.net/projects/pwgen/
package/qemu/Config.in.host +2 -1
index 71f38ef41f..f14bcec6d6 100644
@@ -9,7 +9,8 @@ config BR2_PACKAGE_HOST_QEMU
 	select BR2_PACKAGE_HOST_QEMU_LINUX_USER_MODE \
 		if !BR2_PACKAGE_HOST_QEMU_SYSTEM_MODE
 	help
-	  QEMU is a generic and open source machine emulator and virtualizer.
+	  QEMU is a generic and open source machine emulator and
+	  virtualizer.
 
 	  This option builds an emulator for your selected architecture.
 
package/tegrarcm/Config.in.host +2 -2
index 47590fa127..d8cbb947d6 100644
@@ -2,7 +2,7 @@ config BR2_PACKAGE_HOST_TEGRARCM
 	bool "host tegrarcm"
 	depends on BR2_arm || BR2_armeb
 	help
-	  This program is used to send code to a Tegra device in recovery
-	  mode.
+	  This program is used to send code to a Tegra device in
+	  recovery mode.
 
 	  https://github.com/NVIDIA/tegrarcm
Signature · 1 line
2.15.1
#2 lore raw

PATCH 2/3 gconf: Config.in: fix help text wrapping

In reply to Gaël PORTAY

This commit fixes the warnings reported by check-package on the help text of package Config.in file, related to the formatting of the help
text: should start with a tab, then 2 spaces, then at most 62 characters.

---
 package/gconf/Config.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
package/gconf/Config.in +3 -3
index a967d61644..a2371b3f23 100644
@@ -9,9 +9,9 @@ config BR2_PACKAGE_GCONF
 	select BR2_PACKAGE_LIBGLIB2
 	select BR2_PACKAGE_LIBXML2
 	help
-	  GConf was a system used by the GNOME desktop environment for storing
-	  configuration settings for the desktop and applications. It is similar
-	  to the Windows Registry.
+	  GConf was a system used by the GNOME desktop environment for
+	  storing configuration settings for the desktop and
+	  applications. It is similar to the Windows Registry.
 
 	  https://projects.gnome.org/gconf/
 
Signature · 1 line
2.15.1
#3 lore raw

PATCH 3/3 pure-ftpd: Config.in: fix help text wrapping

In reply to Gaël PORTAY

This commit fixes the warnings reported by check-package on the help text of package Config.in file, related to the formatting of the help
text: should start with a tab, then 2 spaces, then at most 62 characters.

---
 package/pure-ftpd/Config.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/pure-ftpd/Config.in +2 -2
index d03170b7cf..c060102650 100644
@@ -33,7 +33,7 @@ config BR2_PACKAGE_PURE_FTPD_QUOTAS
 config BR2_PACKAGE_PURE_FTPD_UPLOADSCRIPT
 	bool "uploadscript"
 	help
-	  Enable pure-upload script. Automatically run an external program
-	  after a successful upload.
+	  Enable pure-upload script. Automatically run an external
+	  program after a successful upload.
 
 endif
Signature · 1 line
2.15.1
#4 lore raw

PATCH 3/3 pure-ftpd: Config.in: fix help text wrapping

Quoted 4 lines · Ga?l PORTAY

This commit fixes the warnings reported by check-package on the help text of package Config.in file, related to the formatting of the help
text: should start with a tab, then 2 spaces, then at most 62 characters.

I thought I checked this, sorry.

Quoted 2 lines
Quoted 25 lines
---
 package/pure-ftpd/Config.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/pure-ftpd/Config.in +2 -3
index d03170b7cf..c060102650 100644
@@ -33,7 +33,7 @@ config BR2_PACKAGE_PURE_FTPD_QUOTAS
 config BR2_PACKAGE_PURE_FTPD_UPLOADSCRIPT
        bool "uploadscript"
        help
-         Enable pure-upload script. Automatically run an external program
-         after a successful upload.
+         Enable pure-upload script. Automatically run an external
+         program after a successful upload.
 
 endif
--

2.15.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

#5 lore raw

cover Config.in{,host}: check-package pass

In reply to Gaël PORTAY

Hello,

Quoted 4 lines · Ga?l PORTAY

Ga?l PORTAY (3):
package/*/Config.in.host: fix help text check-package warnings
gconf: Config.in: fix help text wrapping
pure-ftpd: Config.in: fix help text wrapping

I've applied the patches to the master branch, thanks. However, I'd like to finally find a solution to validate all those Config.in files from our .gitlab-ci.yml.

The blocking problem is that package/Config.in and package/x11r7/Config.in generate a lot of warnings, but we in fact want to keep them as-is. See the thread at
http://patchwork.ozlabs.org/patch/849882/.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com