Skip to contentSkip to conversation

debian: add build-depends on pkg-config

PATCH In review Darrick J. Wong 3 participants 4 messages Feb 15, 2018 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 debian: add build-depends on pkg-config

From: Darrick J. Wong <[email protected]>

Since the configure scripts now depend on pkg-config to autodetect where systemd service files go, we need to list pkg-config as a build dependency.

---
 debian/control |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
debian/control +1 -1
index 60fcc46..78720bd 100644
@@ -3,7 +3,7 @@ Section: admin
 Priority: optional
 Maintainer: XFS Development Team <[email protected]>
 Uploaders: Nathan Scott <[email protected]>, Anibal Monsalve Salazar <[email protected]>
-Build-Depends: uuid-dev, dh-autoreconf, debhelper (>= 5), gettext, libtool, libreadline-gplv2-dev, libblkid-dev (>= 2.17), linux-libc-dev, libdevmapper-dev, libattr1-dev, libunistring-dev, dh-python
+Build-Depends: uuid-dev, dh-autoreconf, debhelper (>= 5), gettext, libtool, libreadline-gplv2-dev, libblkid-dev (>= 2.17), linux-libc-dev, libdevmapper-dev, libattr1-dev, libunistring-dev, dh-python, pkg-config
 Standards-Version: 3.9.1
 Homepage: https://xfs.wiki.kernel.org/
 
#1 lore raw
Quoted 7 lines · Darrick J. Wong

From: Darrick J. Wong <[email protected]>

Since the configure scripts now depend on pkg-config to autodetect where systemd service files go, we need to list pkg-config as a build dependency.

I'd love to have a Debian-savvy person look over these things.

Nathan maybe? :)

Thanks,
-Eric

Quoted 22 lines
---
 debian/control |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
debian/control +1 -2
index 60fcc46..78720bd 100644
@@ -3,7 +3,7 @@ Section: admin
 Priority: optional
 Maintainer: XFS Development Team <[email protected]>
 Uploaders: Nathan Scott <[email protected]>, Anibal Monsalve Salazar <[email protected]>
-Build-Depends: uuid-dev, dh-autoreconf, debhelper (>= 5), gettext, libtool, libreadline-gplv2-dev, libblkid-dev (>= 2.17), linux-libc-dev, libdevmapper-dev, libattr1-dev, libunistring-dev, dh-python
+Build-Depends: uuid-dev, dh-autoreconf, debhelper (>= 5), gettext, libtool, libreadline-gplv2-dev, libblkid-dev (>= 2.17), linux-libc-dev, libdevmapper-dev, libattr1-dev, libunistring-dev, dh-python, pkg-config
 Standards-Version: 3.9.1
 Homepage: https://xfs.wiki.kernel.org/
 
--

To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): CAFMei7PkvECcgsuj610O=PsrbqYD3mw0Wnc-Z71n5PZFtRkLYg@mail.gmail.com

#3 lore raw
Quoted 18 lines · Nathan Scott

On Fri, Feb 16, 2018 at 4:02 AM, Eric Sandeen <[email protected] <mailto:[email protected]>> wrote:

On 2/15/18 12:51 AM, Darrick J. Wong wrote:
> From: Darrick J. Wong <[email protected] <mailto:[email protected]>> >
> Since the configure scripts now depend on pkg-config to autodetect where
> systemd service files go, we need to list pkg-config as a build
> dependency.
>
> Signed-off-by: Darrick J. Wong <[email protected] <mailto:[email protected]>>

I'd love to have a Debian-savvy person look over these things.

Nathan maybe? :)

Quoted 7 lines

LGTM.  Feel free to add

Reviewed-by Nathan Scott <[email protected] <mailto:[email protected]>>

I also have a couple of other debian packaging tweaks I'd like to make, but no time this week - is the release pending immediately or is there any time early next week Eric?  (else it can wait for next time of course)

Not immediately, if you'd like to fix some things next week I'll try to remember to wait. :)

Thanks,
-Eric

Reviewed-by
#4 lore raw
In reply to Eric Sandeen
Quoted 10 lines · Eric Sandeen
Quoted 7 lines · Darrick J. Wong

From: Darrick J. Wong <[email protected]>

Since the configure scripts now depend on pkg-config to autodetect where systemd service files go, we need to list pkg-config as a build dependency.

I'd love to have a Debian-savvy person look over these things.

I hit this a couple of days ago doing a normal build and having config fail due to a missing pkg-config package. The build-dep update looks fine.

Signature · 2 lines
Dave Chinner
[email protected]