Skip to contentSkip to conversation

debian: Guard udevadm call again

PATCH New Benjamin Drung 1 participant 3 messages Feb 15, 2018 1 message not in the archive InfiniBand

lore
Share & tools
lore

Benjamin Drung

author
#0 lore raw

PATCH 1/3 debian: Guard udevadm call again

lintian complains with udevadm-called-without-guard:

udevadm can exist but be non-functional (such as inside a chroot) and thus can result in package installation or upgrade failure if the call fails.

Please guard the return code of the call via wrapping it in a suitable if construct or by appending || true.

Refer to https://bugs.debian.org/890224 and the udevadm(8) manual page for details.

Signed-off-by Benjamin Drung <[email protected]>
---
 debian/rdma-core.postinst | 6 +++---
 debian/srptools.postinst  | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)
debian/rdma-core.postinst +3 -3
index a76368a4..6486f62e 100644
@@ -6,7 +6,7 @@ set -e
 if [ "$1" = "configure" ]; then
     # we ship udev rules, so trigger an update. This has to be done after
     # DEBHELPER restarts systemd to get our new service files loaded.
-    udevadm trigger --subsystem-match=infiniband --action=change
-    udevadm trigger --subsystem-match=net --action=change
-    udevadm trigger --subsystem-match=infiniband_mad --action=change
+    udevadm trigger --subsystem-match=infiniband --action=change || true
+    udevadm trigger --subsystem-match=net --action=change || true
+    udevadm trigger --subsystem-match=infiniband_mad --action=change || true
 fi
debian/srptools.postinst +1 -1
index c69a3ad1..398534db 100644
@@ -6,5 +6,5 @@ set -e
 if [ "$1" = "configure" ]; then
     # we ship udev rules, so trigger an update. This has to be done after
     # DEBHELPER restarts systemd to get our new service files loaded.
-    udevadm trigger --subsystem-match=infiniband_mad --action=change
+    udevadm trigger --subsystem-match=infiniband_mad --action=change || true
 fi
Signature · 6 lines
2.14.1

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 20180215110842.6375-1-benjamin.drung-EIkl63zCoXaH+58JC4qpiA@public.gmane.org

author
#2 lore raw

PATCH 2/3 debian: Override intentional WantedBy lintian warning

Lintian complains about unusual WantedBy= relationship in systemd service files. These WantedBy= relationships are intentional. Therefore override the lintian warnings.

Signed-off-by Benjamin Drung <[email protected]>
---
 debian/ibacm.lintian-overrides    | 2 ++
 debian/srptools.lintian-overrides | 2 ++
 2 files changed, 4 insertions(+)
 create mode 100644 debian/ibacm.lintian-overrides
 create mode 100644 debian/srptools.lintian-overrides
debian/ibacm.lintian-overrides new file +2 -0
new file mode 100644
index 00000000..66fffd93
@@ -0,0 +1,2 @@
+# The wantedby target rdma-hw.target is intentional (see rdma-core)
+ibacm: systemd-service-file-refers-to-unusual-wantedby-target lib/systemd/system/ibacm.service rdma-hw.target
debian/srptools.lintian-overrides new file +2 -0
new file mode 100644
index 00000000..86788994
@@ -0,0 +1,2 @@
+# The wantedby target remote-fs-pre.target is intentional
+srptools: systemd-service-file-refers-to-unusual-wantedby-target lib/systemd/system/*.service remote-fs-pre.target
Signature · 6 lines
2.14.1

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
author
#3 lore raw

PATCH 3/3 debian: Add Debian uploads up to version 16.2-1

In reply to a message not in the archive

rdma-core 16.1-2 and 16.2-1 were uploaded to Debian unstable. Include the changelogs from these uploads and update the timestamp from the top commit.

---
 debian/changelog | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)
debian/changelog +15 -1
index 7aa1408d..8dcb371f 100644
@@ -2,7 +2,21 @@ rdma-core (17.0-1) unstable; urgency=medium
 
   * New upstream release.
 
- -- Jason Gunthorpe <jgg-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>  Thu, 04 Jan 2018 15:25:06 +0100
+ -- Jason Gunthorpe <jgg-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>  Thu, 15 Feb 2018 12:06:48 +0100
+
+rdma-core (16.2-1) unstable; urgency=medium
+
+  * New upstream bugfix release
+  * Guard udevadm call again
+  * Override intentional systemd WantedBy= relationship lintian warning
+
+ -- Benjamin Drung <[email protected]>  Thu, 15 Feb 2018 11:41:14 +0100
+
+rdma-core (16.1-2) unstable; urgency=medium
+
+  * Do not require valgrind on ia64 (Closes: #887511)
+
+ -- Benjamin Drung <[email protected]>  Fri, 19 Jan 2018 12:37:05 +0100
 
 rdma-core (16.1-1) unstable; urgency=medium
Signature · 6 lines
2.14.1

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html