Skip to contentSkip to conversation

qtbase: Replace -isystem with -I

PATCH In review Khem Raj 2 participants 11 messages Feb 15, 2018 – Feb 24, 2018

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 qtbase: Replace -isystem with -I

Fixes no-x11 builds (eglfs)

---
 recipes-qt/qt5/qtbase-native_git.bb                |  1 +
 ...mon-gcc-base.conf-Use-I-instead-of-isyste.patch | 36 ++++++++++++++++++++++
 recipes-qt/qt5/qtbase_git.bb                       |  1 +
 3 files changed, 38 insertions(+)
 create mode 100644 recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch
recipes-qt/qt5/qtbase-native_git.bb +1 -0
index ac3924e..ffde8ee 100644
@@ -34,6 +34,7 @@ SRC_URI += "\
     file://0009-Add-OE-specific-specs-for-clang-compiler.patch \
     file://0010-linux-clang-Invert-conditional-for-defining-QT_SOCKL.patch \
     file://0011-tst_qlocale-Enable-QT_USE_FENV-only-on-glibc.patch \
+    file://0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch \
 "
 
 # common for qtbase-native and nativesdk-qtbase
recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch new file +36 -0
new file mode 100644
index 0000000..44e9009
@@ -0,0 +1,36 @@
+From 61c858474804fd772d612e6c5b4bb6df261d521a Mon Sep 17 00:00:00 2001
+From: Khem Raj <[email protected]>
+Date: Wed, 14 Feb 2018 17:08:43 -0800
+Subject: [PATCH] mkspecs/common/gcc-base.conf: Use -I instead of -isystem
+
+-isystem fails to build when code uses include_next on certain files e.g.
+
+qtbase/5.10.0+gitAUTOINC+50117d738a-r0/recipe-sysroot/usr/include/c++/7.3.0/cstdlib:75:15: fatal error: stdlib.h: No such file or directory
+ #include_next <stdlib.h>
+               ^~~~~~~~~~
+compilation terminated.
+make[2]: *** [Makefile:11592: .obj/qgenericpluginfactory.o] Error 1
+
+Upstream-Status: Pending
+
+Signed-off-by: Khem Raj <[email protected]>
+---
+ mkspecs/common/gcc-base.conf | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/mkspecs/common/gcc-base.conf b/mkspecs/common/gcc-base.conf
+index 234f71d495..ee3da023e6 100644
+--- a/mkspecs/common/gcc-base.conf
++++ b/mkspecs/common/gcc-base.conf
+@@ -46,7 +46,7 @@ QMAKE_CFLAGS_DEBUG         += -g
+ QMAKE_CFLAGS_SHLIB         += $$QMAKE_CFLAGS_PIC
+ QMAKE_CFLAGS_STATIC_LIB    += $$QMAKE_CFLAGS_PIC
+ QMAKE_CFLAGS_APP           += $$QMAKE_CFLAGS_PIC
+-QMAKE_CFLAGS_ISYSTEM        = -isystem
++QMAKE_CFLAGS_ISYSTEM        = -I
+ QMAKE_CFLAGS_YACC          += -Wno-unused -Wno-parentheses
+ QMAKE_CFLAGS_HIDESYMS      += -fvisibility=hidden
+ QMAKE_CFLAGS_EXCEPTIONS_OFF += -fno-exceptions
+-- 
+2.16.1
+
recipes-qt/qt5/qtbase_git.bb +1 -0
index 4f3ade2..cc9bce3 100644
@@ -29,6 +29,7 @@ SRC_URI += "\
     file://0009-Add-OE-specific-specs-for-clang-compiler.patch \
     file://0010-linux-clang-Invert-conditional-for-defining-QT_SOCKL.patch \
     file://0011-tst_qlocale-Enable-QT_USE_FENV-only-on-glibc.patch \
+    file://0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch \
     file://run-ptest \
 "
 
Signature · 1 line
2.16.1
#1 lore raw
Quoted 28 lines · Khem Raj

Fixes no-x11 builds (eglfs)

---
 recipes-qt/qt5/qtbase-native_git.bb                |  1 +
 ...mon-gcc-base.conf-Use-I-instead-of-isyste.patch | 36 ++++++++++++++++++++++
 recipes-qt/qt5/qtbase_git.bb                       |  1 +
 3 files changed, 38 insertions(+)
 create mode 100644 recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch
recipes-qt/qt5/qtbase-native_git.bb +1 -0
index ac3924e..ffde8ee 100644
@@ -34,6 +34,7 @@ SRC_URI += "\
     file://0009-Add-OE-specific-specs-for-clang-compiler.patch \
     file://0010-linux-clang-Invert-conditional-for-defining-QT_SOCKL.patch \
     file://0011-tst_qlocale-Enable-QT_USE_FENV-only-on-glibc.patch \
+    file://0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch \
 "
 
 # common for qtbase-native and nativesdk-qtbase
recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch new file +0 -0
new file mode 100644
index 0000000..44e9009

recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch line 10

Quoted 10 lines
recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch new file +10 -0
@@ -0,0 +1,36 @@
+From 61c858474804fd772d612e6c5b4bb6df261d521a Mon Sep 17 00:00:00 2001
+From: Khem Raj <[email protected]>
+Date: Wed, 14 Feb 2018 17:08:43 -0800
+Subject: [PATCH] mkspecs/common/gcc-base.conf: Use -I instead of -isystem
+
+-isystem fails to build when code uses include_next on certain files e.g.
+
+qtbase/5.10.0+gitAUTOINC+50117d738a-r0/recipe-sysroot/usr/include/c++/7.3.0/cstdlib:75:15: fatal error: stdlib.h: No such file or directory
+ #include_next <stdlib.h>
+               ^~~~~~~~~~

I'm building qt 5.10.0 in master with gcc 7.3.0 in a no-x11 environment with eglfs and not seeing this issue. What else is different?

Quoted 46 lines
recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch new file +26 -0
+compilation terminated.
+make[2]: *** [Makefile:11592: .obj/qgenericpluginfactory.o] Error 1
+
+Upstream-Status: Pending
+
+Signed-off-by: Khem Raj <[email protected]>
+---
+ mkspecs/common/gcc-base.conf | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/mkspecs/common/gcc-base.conf b/mkspecs/common/gcc-base.conf
+index 234f71d495..ee3da023e6 100644
+--- a/mkspecs/common/gcc-base.conf
++++ b/mkspecs/common/gcc-base.conf
+@@ -46,7 +46,7 @@ QMAKE_CFLAGS_DEBUG         += -g
+ QMAKE_CFLAGS_SHLIB         += $$QMAKE_CFLAGS_PIC
+ QMAKE_CFLAGS_STATIC_LIB    += $$QMAKE_CFLAGS_PIC
+ QMAKE_CFLAGS_APP           += $$QMAKE_CFLAGS_PIC
+-QMAKE_CFLAGS_ISYSTEM        = -isystem
++QMAKE_CFLAGS_ISYSTEM        = -I
+ QMAKE_CFLAGS_YACC          += -Wno-unused -Wno-parentheses
+ QMAKE_CFLAGS_HIDESYMS      += -fvisibility=hidden
+ QMAKE_CFLAGS_EXCEPTIONS_OFF += -fno-exceptions
+-- 
+2.16.1
+
recipes-qt/qt5/qtbase_git.bb +1 -0
index 4f3ade2..cc9bce3 100644
@@ -29,6 +29,7 @@ SRC_URI += "\
     file://0009-Add-OE-specific-specs-for-clang-compiler.patch \
     file://0010-linux-clang-Invert-conditional-for-defining-QT_SOCKL.patch \
     file://0011-tst_qlocale-Enable-QT_USE_FENV-only-on-glibc.patch \
+    file://0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch \
     file://run-ptest \
 "
 
Signature · 7 lines
2.16.1

-- 
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
author
#2 lore raw
Quoted 34 lines · Denys Dmytriyenko
Quoted 33 lines · Khem Raj

Fixes no-x11 builds (eglfs)

---
 recipes-qt/qt5/qtbase-native_git.bb                |  1 +
 ...mon-gcc-base.conf-Use-I-instead-of-isyste.patch | 36 ++++++++++++++++++++++
 recipes-qt/qt5/qtbase_git.bb                       |  1 +
 3 files changed, 38 insertions(+)
 create mode 100644 recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch
recipes-qt/qt5/qtbase-native_git.bb +1 -0
index ac3924e..ffde8ee 100644
@@ -34,6 +34,7 @@ SRC_URI += "\
     file://0009-Add-OE-specific-specs-for-clang-compiler.patch \
     file://0010-linux-clang-Invert-conditional-for-defining-QT_SOCKL.patch \
     file://0011-tst_qlocale-Enable-QT_USE_FENV-only-on-glibc.patch \
+    file://0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch \
 "
 
 # common for qtbase-native and nativesdk-qtbase
recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch new file +5 -0
new file mode 100644
index 0000000..44e9009
@@ -0,0 +1,36 @@
+From 61c858474804fd772d612e6c5b4bb6df261d521a Mon Sep 17 00:00:00 2001
+From: Khem Raj <[email protected]>
+Date: Wed, 14 Feb 2018 17:08:43 -0800
+Subject: [PATCH] mkspecs/common/gcc-base.conf: Use -I instead of -isystem
+
Quoted 8 lines

recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch line 10

Quoted 5 lines
recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch new file +5 -0
+-isystem fails to build when code uses include_next on certain files e.g.
+
+qtbase/5.10.0+gitAUTOINC+50117d738a-r0/recipe-sysroot/usr/include/c++/7.3.0/cstdlib:75:15: fatal error: stdlib.h: No such file or directory
+ #include_next <stdlib.h>
+               ^~~~~~~~~~

I'm building qt 5.10.0 in master with gcc 7.3.0 in a no-x11 environment with eglfs and not seeing this issue. What else is different?

DISTRO_FEATURES_remove = "x11"
DISTRO_FEATURES_remove = "wayland"
DISTRO_FEATURES_append = " directfb"

then in qtbase
PACKAGECONFIG_GL = "gles2"
PACKAGECONFIG_FONTS = "fontconfig"
PACKAGECONFIG_append = " libinput eglfs"
PACKAGECONFIG_remove = "tests"

Quoted 48 lines
Quoted 48 lines
recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch new file +26 -0
+compilation terminated.
+make[2]: *** [Makefile:11592: .obj/qgenericpluginfactory.o] Error 1
+
+Upstream-Status: Pending
+
+Signed-off-by: Khem Raj <[email protected]>
+---
+ mkspecs/common/gcc-base.conf | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/mkspecs/common/gcc-base.conf b/mkspecs/common/gcc-base.conf
+index 234f71d495..ee3da023e6 100644
+--- a/mkspecs/common/gcc-base.conf
++++ b/mkspecs/common/gcc-base.conf
+@@ -46,7 +46,7 @@ QMAKE_CFLAGS_DEBUG         += -g
+ QMAKE_CFLAGS_SHLIB         += $$QMAKE_CFLAGS_PIC
+ QMAKE_CFLAGS_STATIC_LIB    += $$QMAKE_CFLAGS_PIC
+ QMAKE_CFLAGS_APP           += $$QMAKE_CFLAGS_PIC
+-QMAKE_CFLAGS_ISYSTEM        = -isystem
++QMAKE_CFLAGS_ISYSTEM        = -I
+ QMAKE_CFLAGS_YACC          += -Wno-unused -Wno-parentheses
+ QMAKE_CFLAGS_HIDESYMS      += -fvisibility=hidden
+ QMAKE_CFLAGS_EXCEPTIONS_OFF += -fno-exceptions
+--
+2.16.1
+
recipes-qt/qt5/qtbase_git.bb +1 -1
index 4f3ade2..cc9bce3 100644
@@ -29,6 +29,7 @@ SRC_URI += "\
     file://0009-Add-OE-specific-specs-for-clang-compiler.patch \
     file://0010-linux-clang-Invert-conditional-for-defining-QT_SOCKL.patch \
     file://0011-tst_qlocale-Enable-QT_USE_FENV-only-on-glibc.patch \
+    file://0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch \
     file://run-ptest \
 "
 
--

2.16.1

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#3 lore raw
Quoted 48 lines · Khem Raj
Quoted 34 lines · Denys Dmytriyenko
Quoted 33 lines · Khem Raj

Fixes no-x11 builds (eglfs)

---
 recipes-qt/qt5/qtbase-native_git.bb                |  1 +
 ...mon-gcc-base.conf-Use-I-instead-of-isyste.patch | 36 ++++++++++++++++++++++
 recipes-qt/qt5/qtbase_git.bb                       |  1 +
 3 files changed, 38 insertions(+)
 create mode 100644 recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch
recipes-qt/qt5/qtbase-native_git.bb +1 -0
index ac3924e..ffde8ee 100644
@@ -34,6 +34,7 @@ SRC_URI += "\
     file://0009-Add-OE-specific-specs-for-clang-compiler.patch \
     file://0010-linux-clang-Invert-conditional-for-defining-QT_SOCKL.patch \
     file://0011-tst_qlocale-Enable-QT_USE_FENV-only-on-glibc.patch \
+    file://0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch \
 "
 
 # common for qtbase-native and nativesdk-qtbase
recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch new file +5 -0
new file mode 100644
index 0000000..44e9009
@@ -0,0 +1,36 @@
+From 61c858474804fd772d612e6c5b4bb6df261d521a Mon Sep 17 00:00:00 2001
+From: Khem Raj <[email protected]>
+Date: Wed, 14 Feb 2018 17:08:43 -0800
+Subject: [PATCH] mkspecs/common/gcc-base.conf: Use -I instead of -isystem
+
Quoted 8 lines

recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch line 10

Quoted 5 lines
recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch new file +5 -0
+-isystem fails to build when code uses include_next on certain files e.g.
+
+qtbase/5.10.0+gitAUTOINC+50117d738a-r0/recipe-sysroot/usr/include/c++/7.3.0/cstdlib:75:15: fatal error: stdlib.h: No such file or directory
+ #include_next <stdlib.h>
+               ^~~~~~~~~~

I'm building qt 5.10.0 in master with gcc 7.3.0 in a no-x11 environment with eglfs and not seeing this issue. What else is different?

DISTRO_FEATURES_remove = "x11"
DISTRO_FEATURES_remove = "wayland"
DISTRO_FEATURES_append = " directfb"

Quoted 5 lines

then in qtbase
PACKAGECONFIG_GL = "gles2"
PACKAGECONFIG_FONTS = "fontconfig"
PACKAGECONFIG_append = " libinput eglfs"
PACKAGECONFIG_remove = "tests"

Yeah, I had slightly different flags - no-x11, but wayland+kms.

After disabling wayland and enabling eglfs explicitly, I still don't see any issues building qtbase.

Anyone else see the problem?

Quoted 47 lines
Quoted 46 lines
Quoted 46 lines
recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch new file +26 -0
+compilation terminated.
+make[2]: *** [Makefile:11592: .obj/qgenericpluginfactory.o] Error 1
+
+Upstream-Status: Pending
+
+Signed-off-by: Khem Raj <[email protected]>
+---
+ mkspecs/common/gcc-base.conf | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/mkspecs/common/gcc-base.conf b/mkspecs/common/gcc-base.conf
+index 234f71d495..ee3da023e6 100644
+--- a/mkspecs/common/gcc-base.conf
++++ b/mkspecs/common/gcc-base.conf
+@@ -46,7 +46,7 @@ QMAKE_CFLAGS_DEBUG         += -g
+ QMAKE_CFLAGS_SHLIB         += $$QMAKE_CFLAGS_PIC
+ QMAKE_CFLAGS_STATIC_LIB    += $$QMAKE_CFLAGS_PIC
+ QMAKE_CFLAGS_APP           += $$QMAKE_CFLAGS_PIC
+-QMAKE_CFLAGS_ISYSTEM        = -isystem
++QMAKE_CFLAGS_ISYSTEM        = -I
+ QMAKE_CFLAGS_YACC          += -Wno-unused -Wno-parentheses
+ QMAKE_CFLAGS_HIDESYMS      += -fvisibility=hidden
+ QMAKE_CFLAGS_EXCEPTIONS_OFF += -fno-exceptions
+--
+2.16.1
+
recipes-qt/qt5/qtbase_git.bb +1 -1
index 4f3ade2..cc9bce3 100644
@@ -29,6 +29,7 @@ SRC_URI += "\
     file://0009-Add-OE-specific-specs-for-clang-compiler.patch \
     file://0010-linux-clang-Invert-conditional-for-defining-QT_SOCKL.patch \
     file://0011-tst_qlocale-Enable-QT_USE_FENV-only-on-glibc.patch \
+    file://0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch \
     file://run-ptest \
 "
 
--

2.16.1

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

author
#4 lore raw

I am using arch Linux for host distro and security flags enabled May be that is something

Quoted 131 lines · Denys Dmytriyenko
Quoted 1 line · Khem Raj

On Thu, Feb 15, 2018 at 3:41 PM, Denys Dmytriyenko <[email protected]>

Quoted 7 lines · wrote:
Quoted 7 lines · Khem Raj
Quoted 6 lines

Fixes no-x11 builds (eglfs)

---
 recipes-qt/qt5/qtbase-native_git.bb                |  1 +
 ...mon-gcc-base.conf-Use-I-instead-of-isyste.patch | 36

++++++++++++++++++++++

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
 recipes-qt/qt5/qtbase_git.bb                       |  1 +
 3 files changed, 38 insertions(+)
 create mode 100644

recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch

Quoted 2 lines
Quoted 2 lines

recipes-qt/qt5/

Quoted 2 lines
recipes-qt/qt5/ renamed from recipes-qt/qt5/qtbase-native_git.bb +0 -0

qtbase-native_git.bb

Quoted 6 lines
Quoted 6 lines

recipes-qt/qt5/qtbase-native_git.bb SRC_URI += "\ · line 35

Quoted 6 lines

index ac3924e..ffde8ee 100644

recipes-qt/qt5/qtbase-native_git.bb +0 -0
@@ -34,6 +34,7 @@ SRC_URI += "\
     file://0009-Add-OE-specific-specs-for-clang-compiler.patch \
 

file://0010-linux-clang-Invert-conditional-for-defining-QT_SOCKL.patch \

Quoted 2 lines
Quoted 2 lines

recipes-qt/qt5/qtbase-native_git.bb SRC_URI += "\ · line 37

Quoted 2 lines
recipes-qt/qt5/qtbase-native_git.bb +1 -0
     file://0011-tst_qlocale-Enable-QT_USE_FENV-only-on-glibc.patch \
+

file://0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch \

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
recipes-qt/qt5/qtbase-native_git.bb +0 -0
 "
 
 # common for qtbase-native and nativesdk-qtbase

diff --git

a/recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch b/recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

new file mode 100644
index 0000000..44e9009
--- /dev/null
+++

b/recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch

Quoted 2 lines
Quoted 2 lines

recipes-qt/qt5/qtbase-native_git.bb line 1

Quoted 2 lines
recipes-qt/qt5/qtbase-native_git.bb +1 -0
@@ -0,0 +1,36 @@
+From 61c858474804fd772d612e6c5b4bb6df261d521a Mon Sep 17 00:00:00

2001

Quoted 3 lines
Quoted 3 lines

recipes-qt/qt5/qtbase-native_git.bb line 4

Quoted 3 lines
recipes-qt/qt5/qtbase-native_git.bb +3 -0
+From: Khem Raj <[email protected]>
+Date: Wed, 14 Feb 2018 17:08:43 -0800
+Subject: [PATCH] mkspecs/common/gcc-base.conf: Use -I instead of

-isystem

Quoted 2 lines
Quoted 2 lines

recipes-qt/qt5/qtbase-native_git.bb line 6

Quoted 2 lines
recipes-qt/qt5/qtbase-native_git.bb +2 -0
+
+-isystem fails to build when code uses include_next on certain files

e.g.

Quoted 2 lines
Quoted 2 lines

recipes-qt/qt5/qtbase-native_git.bb line 7

Quoted 2 lines
recipes-qt/qt5/qtbase-native_git.bb +1 -0
+

+qtbase/5.10.0+gitAUTOINC+50117d738a-r0/recipe-sysroot/usr/include/c++/7.3.0/cstdlib:75:15:
fatal error: stdlib.h: No such file or directory

Quoted 4 lines
Quoted 4 lines

recipes-qt/qt5/qtbase-native_git.bb line 9

Quoted 2 lines
recipes-qt/qt5/qtbase-native_git.bb +2 -0
+ #include_next <stdlib.h>
+               ^~~~~~~~~~

I'm building qt 5.10.0 in master with gcc 7.3.0 in a no-x11

environment with

Quoted 11 lines
Quoted 1 line

eglfs and not seeing this issue. What else is different?

DISTRO_FEATURES_remove = "x11"
DISTRO_FEATURES_remove = "wayland"
DISTRO_FEATURES_append = " directfb"

then in qtbase
PACKAGECONFIG_GL = "gles2"
PACKAGECONFIG_FONTS = "fontconfig"
PACKAGECONFIG_append = " libinput eglfs"
PACKAGECONFIG_remove = "tests"

Yeah, I had slightly different flags - no-x11, but wayland+kms.

After disabling wayland and enabling eglfs explicitly, I still don't see any
issues building qtbase.

Anyone else see the problem?

Quoted 11 lines
Quoted 11 lines

recipes-qt/qt5/qtbase-native_git.bb line 20

Quoted 11 lines
recipes-qt/qt5/qtbase-native_git.bb +11 -0
+compilation terminated.
+make[2]: *** [Makefile:11592: .obj/qgenericpluginfactory.o] Error 1
+
+Upstream-Status: Pending
+
+Signed-off-by: Khem Raj <[email protected]>
+---
+ mkspecs/common/gcc-base.conf | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/mkspecs/common/gcc-base.conf

b/mkspecs/common/gcc-base.conf

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
recipes-qt/qt5/qtbase-native_git.bb +8 -0
+index 234f71d495..ee3da023e6 100644
+--- a/mkspecs/common/gcc-base.conf
++++ b/mkspecs/common/gcc-base.conf
+@@ -46,7 +46,7 @@ QMAKE_CFLAGS_DEBUG         += -g
+ QMAKE_CFLAGS_SHLIB         += $$QMAKE_CFLAGS_PIC
+ QMAKE_CFLAGS_STATIC_LIB    += $$QMAKE_CFLAGS_PIC
+ QMAKE_CFLAGS_APP           += $$QMAKE_CFLAGS_PIC
+-QMAKE_CFLAGS_ISYSTEM        = -isystem
Quoted 8 lines
Quoted 8 lines

recipes-qt/qt5/

Quoted 8 lines
recipes-qt/qt5/qtbase-native_git.bb +7 -0
++QMAKE_CFLAGS_ISYSTEM        = -I
+ QMAKE_CFLAGS_YACC          += -Wno-unused -Wno-parentheses
+ QMAKE_CFLAGS_HIDESYMS      += -fvisibility=hidden
+ QMAKE_CFLAGS_EXCEPTIONS_OFF += -fno-exceptions
+--
+2.16.1
+
recipes-qt/qt5/ renamed from recipes-qt/qt5/qtbase_git.bb +0 -0

qtbase_git.bb

Quoted 6 lines
Quoted 6 lines

recipes-qt/qt5/qtbase_git.bb SRC_URI += "\ · line 30

Quoted 6 lines

index 4f3ade2..cc9bce3 100644

recipes-qt/qt5/qtbase_git.bb +0 -0
@@ -29,6 +29,7 @@ SRC_URI += "\
     file://0009-Add-OE-specific-specs-for-clang-compiler.patch \
 

file://0010-linux-clang-Invert-conditional-for-defining-QT_SOCKL.patch \

Quoted 2 lines
Quoted 2 lines

recipes-qt/qt5/qtbase_git.bb SRC_URI += "\ · line 32

Quoted 2 lines
recipes-qt/qt5/qtbase_git.bb +1 -0
     file://0011-tst_qlocale-Enable-QT_USE_FENV-only-on-glibc.patch \
+

file://0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch \

Quoted 12 lines
Quoted 11 lines
Quoted 11 lines
recipes-qt/qt5/qtbase_git.bb +0 -1
     file://run-ptest \
 "
 
--

2.16.1

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#5 lore raw
Quoted 2 lines · Khem Raj

I am using arch Linux for host distro and security flags enabled May be that is something

Could be... I'm on Ubuntu 16.04.

Quoted 133 lines · Denys Dmytriyenko
Quoted 132 lines · Khem Raj
Quoted 1 line

On Thu, Feb 15, 2018 at 3:41 PM, Denys Dmytriyenko <[email protected]>

Quoted 7 lines · wrote:
Quoted 7 lines · Khem Raj
Quoted 6 lines

Fixes no-x11 builds (eglfs)

---
 recipes-qt/qt5/qtbase-native_git.bb                |  1 +
 ...mon-gcc-base.conf-Use-I-instead-of-isyste.patch | 36

++++++++++++++++++++++

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
 recipes-qt/qt5/qtbase_git.bb                       |  1 +
 3 files changed, 38 insertions(+)
 create mode 100644

recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch

Quoted 2 lines
Quoted 2 lines

recipes-qt/qt5/

Quoted 2 lines
recipes-qt/qt5/ renamed from recipes-qt/qt5/qtbase-native_git.bb +0 -0

qtbase-native_git.bb

Quoted 6 lines
Quoted 6 lines

recipes-qt/qt5/qtbase-native_git.bb SRC_URI += "\ · line 35

Quoted 6 lines

index ac3924e..ffde8ee 100644

recipes-qt/qt5/qtbase-native_git.bb +0 -0
@@ -34,6 +34,7 @@ SRC_URI += "\
     file://0009-Add-OE-specific-specs-for-clang-compiler.patch \
 

file://0010-linux-clang-Invert-conditional-for-defining-QT_SOCKL.patch \

Quoted 2 lines
Quoted 2 lines

recipes-qt/qt5/qtbase-native_git.bb SRC_URI += "\ · line 37

Quoted 2 lines
recipes-qt/qt5/qtbase-native_git.bb +1 -0
     file://0011-tst_qlocale-Enable-QT_USE_FENV-only-on-glibc.patch \
+

file://0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch \

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
recipes-qt/qt5/qtbase-native_git.bb +0 -0
 "
 
 # common for qtbase-native and nativesdk-qtbase

diff --git

a/recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch b/recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

new file mode 100644
index 0000000..44e9009
--- /dev/null
+++

b/recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch

Quoted 2 lines
Quoted 2 lines

recipes-qt/qt5/qtbase-native_git.bb line 1

Quoted 2 lines
recipes-qt/qt5/qtbase-native_git.bb +1 -0
@@ -0,0 +1,36 @@
+From 61c858474804fd772d612e6c5b4bb6df261d521a Mon Sep 17 00:00:00

2001

Quoted 3 lines
Quoted 3 lines

recipes-qt/qt5/qtbase-native_git.bb line 4

Quoted 3 lines
recipes-qt/qt5/qtbase-native_git.bb +3 -0
+From: Khem Raj <[email protected]>
+Date: Wed, 14 Feb 2018 17:08:43 -0800
+Subject: [PATCH] mkspecs/common/gcc-base.conf: Use -I instead of

-isystem

Quoted 2 lines
Quoted 2 lines

recipes-qt/qt5/qtbase-native_git.bb line 6

Quoted 2 lines
recipes-qt/qt5/qtbase-native_git.bb +2 -0
+
+-isystem fails to build when code uses include_next on certain files

e.g.

Quoted 2 lines
Quoted 2 lines

recipes-qt/qt5/qtbase-native_git.bb line 7

Quoted 2 lines
recipes-qt/qt5/qtbase-native_git.bb +1 -0
+

+qtbase/5.10.0+gitAUTOINC+50117d738a-r0/recipe-sysroot/usr/include/c++/7.3.0/cstdlib:75:15:
fatal error: stdlib.h: No such file or directory

Quoted 4 lines
Quoted 4 lines

recipes-qt/qt5/qtbase-native_git.bb line 9

Quoted 2 lines
recipes-qt/qt5/qtbase-native_git.bb +2 -0
+ #include_next <stdlib.h>
+               ^~~~~~~~~~

I'm building qt 5.10.0 in master with gcc 7.3.0 in a no-x11

environment with

Quoted 11 lines
Quoted 1 line

eglfs and not seeing this issue. What else is different?

DISTRO_FEATURES_remove = "x11"
DISTRO_FEATURES_remove = "wayland"
DISTRO_FEATURES_append = " directfb"

then in qtbase
PACKAGECONFIG_GL = "gles2"
PACKAGECONFIG_FONTS = "fontconfig"
PACKAGECONFIG_append = " libinput eglfs"
PACKAGECONFIG_remove = "tests"

Yeah, I had slightly different flags - no-x11, but wayland+kms.

After disabling wayland and enabling eglfs explicitly, I still don't see any
issues building qtbase.

Anyone else see the problem?

Quoted 11 lines
Quoted 11 lines

recipes-qt/qt5/qtbase-native_git.bb line 20

Quoted 11 lines
recipes-qt/qt5/qtbase-native_git.bb +11 -0
+compilation terminated.
+make[2]: *** [Makefile:11592: .obj/qgenericpluginfactory.o] Error 1
+
+Upstream-Status: Pending
+
+Signed-off-by: Khem Raj <[email protected]>
+---
+ mkspecs/common/gcc-base.conf | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/mkspecs/common/gcc-base.conf

b/mkspecs/common/gcc-base.conf

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
recipes-qt/qt5/qtbase-native_git.bb +8 -0
+index 234f71d495..ee3da023e6 100644
+--- a/mkspecs/common/gcc-base.conf
++++ b/mkspecs/common/gcc-base.conf
+@@ -46,7 +46,7 @@ QMAKE_CFLAGS_DEBUG         += -g
+ QMAKE_CFLAGS_SHLIB         += $$QMAKE_CFLAGS_PIC
+ QMAKE_CFLAGS_STATIC_LIB    += $$QMAKE_CFLAGS_PIC
+ QMAKE_CFLAGS_APP           += $$QMAKE_CFLAGS_PIC
+-QMAKE_CFLAGS_ISYSTEM        = -isystem
Quoted 8 lines
Quoted 8 lines

recipes-qt/qt5/

Quoted 8 lines
recipes-qt/qt5/qtbase-native_git.bb +7 -0
++QMAKE_CFLAGS_ISYSTEM        = -I
+ QMAKE_CFLAGS_YACC          += -Wno-unused -Wno-parentheses
+ QMAKE_CFLAGS_HIDESYMS      += -fvisibility=hidden
+ QMAKE_CFLAGS_EXCEPTIONS_OFF += -fno-exceptions
+--
+2.16.1
+
recipes-qt/qt5/ renamed from recipes-qt/qt5/qtbase_git.bb +0 -0

qtbase_git.bb

Quoted 6 lines
Quoted 6 lines

recipes-qt/qt5/qtbase_git.bb SRC_URI += "\ · line 30

Quoted 6 lines

index 4f3ade2..cc9bce3 100644

recipes-qt/qt5/qtbase_git.bb +0 -0
@@ -29,6 +29,7 @@ SRC_URI += "\
     file://0009-Add-OE-specific-specs-for-clang-compiler.patch \
 

file://0010-linux-clang-Invert-conditional-for-defining-QT_SOCKL.patch \

Quoted 2 lines
Quoted 2 lines

recipes-qt/qt5/qtbase_git.bb SRC_URI += "\ · line 32

Quoted 2 lines
recipes-qt/qt5/qtbase_git.bb +1 -0
     file://0011-tst_qlocale-Enable-QT_USE_FENV-only-on-glibc.patch \
+

file://0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch \

Quoted 12 lines
Quoted 11 lines
Quoted 11 lines
recipes-qt/qt5/qtbase_git.bb +0 -1
     file://run-ptest \
 "
 
--

2.16.1

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

author
#6 lore raw
Quoted 5 lines · Denys Dmytriyenko
Quoted 2 lines · Khem Raj

I am using arch Linux for host distro and security flags enabled May be that is something

Could be... I'm on Ubuntu 16.04.

maybe you can try to enable security flags and see if you see it

author
#7 lore raw

i can still see it with 5.10.1

from
/mnt/a/zonit/oe-build/build/tmp/work/aarch64-bec-linux/qtbase/5.10.1+gitAUTOINC+6c6ace9d23-r0/git/src/gui/kernel/qgenericpluginfactory.cpp:40:
/mnt/a/zonit/oe-build/build/tmp/work/aarch64-bec-linux/qtbase/5.10.1+gitAUTOINC+6c6ace9d23-r0/recipe-sysroot/usr/include/c++/7.3.0/cstdlib:75:15:
fatal error: stdlib.h: No such file or directory

 #include_next <stdlib.h>
               ^~~~~~~~~~

compilation terminated.
make[2]: *** [Makefile:11592: .obj/qgenericpluginfactory.o] Error 1
make[2]: Leaving directory '/mnt/a/zonit/oe-build/build/tmp/work/aarch64-bec-linux/qtbase/5.10.1+gitAUTOINC+6c6ace9d23-r0/build/src/gui'

Quoted 8 lines · Khem Raj
Quoted 5 lines · Denys Dmytriyenko
Quoted 2 lines · Khem Raj

I am using arch Linux for host distro and security flags enabled May be that is something

Could be... I'm on Ubuntu 16.04.

maybe you can try to enable security flags and see if you see it

#8 lore raw
Quoted 6 lines · Khem Raj

i can still see it with 5.10.1

from
/mnt/a/zonit/oe-build/build/tmp/work/aarch64-bec-linux/qtbase/5.10.1+gitAUTOINC+6c6ace9d23-r0/git/src/gui/kernel/qgenericpluginfactory.cpp:40:
/mnt/a/zonit/oe-build/build/tmp/work/aarch64-bec-linux/qtbase/5.10.1+gitAUTOINC+6c6ace9d23-r0/recipe-sysroot/usr/include/c++/7.3.0/cstdlib:75:15:
fatal error: stdlib.h: No such file or directory

Quoted 16 lines
 #include_next <stdlib.h>
               ^~~~~~~~~~

compilation terminated.
make[2]: *** [Makefile:11592: .obj/qgenericpluginfactory.o] Error 1
make[2]: Leaving directory '/mnt/a/zonit/oe-build/build/tmp/work/aarch64-bec-linux/qtbase/5.10.1+gitAUTOINC+6c6ace9d23-r0/build/src/gui'

Quoted 8 lines · Khem Raj
Quoted 5 lines · Denys Dmytriyenko
Quoted 2 lines · Khem Raj

I am using arch Linux for host distro and security flags enabled May be that is something

Could be... I'm on Ubuntu 16.04.

maybe you can try to enable security flags and see if you see it

Do you have any specifics regarding enabling security flags?

author
#9 lore raw
Quoted 17 lines · Denys Dmytriyenko
Quoted 16 lines · Khem Raj

i can still see it with 5.10.1

from
/mnt/a/zonit/oe-build/build/tmp/work/aarch64-bec-linux/qtbase/5.10.1+gitAUTOINC+6c6ace9d23-r0/git/src/gui/kernel/qgenericpluginfactory.cpp:40:
/mnt/a/zonit/oe-build/build/tmp/work/aarch64-bec-linux/qtbase/5.10.1+gitAUTOINC+6c6ace9d23-r0/recipe-sysroot/usr/include/c++/7.3.0/cstdlib:75:15:
fatal error: stdlib.h: No such file or directory

 #include_next <stdlib.h>
               ^~~~~~~~~~

compilation terminated.
make[2]: *** [Makefile:11592: .obj/qgenericpluginfactory.o] Error 1
make[2]: Leaving directory '/mnt/a/zonit/oe-build/build/tmp/work/aarch64-bec-linux/qtbase/5.10.1+gitAUTOINC+6c6ace9d23-r0/build/src/gui'

Quoted 2 lines · Khem Raj
Quoted 1 line · Denys Dmytriyenko

On Fri, Feb 16, 2018 at 10:59:39PM +0000, Khem Raj wrote:

Quoted 9 lines
Quoted 6 lines
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines

I am using arch Linux for host distro and security flags enabled May be that is something

Could be... I'm on Ubuntu 16.04.

maybe you can try to enable security flags and see if you see it

Do you have any specifics regarding enabling security flags?

add

require conf/distro/include/security_flags.inc

in local.conf

#10 lore raw
Quoted 25 lines · Khem Raj
Quoted 24 lines · Denys Dmytriyenko
Quoted 22 lines · Khem Raj

i can still see it with 5.10.1

from
/mnt/a/zonit/oe-build/build/tmp/work/aarch64-bec-linux/qtbase/5.10.1+gitAUTOINC+6c6ace9d23-r0/git/src/gui/kernel/qgenericpluginfactory.cpp:40:
/mnt/a/zonit/oe-build/build/tmp/work/aarch64-bec-linux/qtbase/5.10.1+gitAUTOINC+6c6ace9d23-r0/recipe-sysroot/usr/include/c++/7.3.0/cstdlib:75:15:
fatal error: stdlib.h: No such file or directory

 #include_next <stdlib.h>
               ^~~~~~~~~~

compilation terminated.
make[2]: *** [Makefile:11592: .obj/qgenericpluginfactory.o] Error 1
make[2]: Leaving directory '/mnt/a/zonit/oe-build/build/tmp/work/aarch64-bec-linux/qtbase/5.10.1+gitAUTOINC+6c6ace9d23-r0/build/src/gui'

Quoted 8 lines · Khem Raj
Quoted 5 lines · Denys Dmytriyenko
Quoted 2 lines · Khem Raj

I am using arch Linux for host distro and security flags enabled May be that is something

Could be... I'm on Ubuntu 16.04.

maybe you can try to enable security flags and see if you see it

Quoted 8 lines
Quoted 2 lines

Do you have any specifics regarding enabling security flags?

add

require conf/distro/include/security_flags.inc

in local.conf

Ha, got confused - thought you were talking about security (SELinux?) on the host...

Anyway, got some time to try it with security_flags.inc included and it still builds fine here on latest master.

Signature · 1 line
Denys