Skip to contentSkip to conversation

objtool/x86: Replace Non-standard Range Expression in Case

PATCH New Progyan Bhattacharya 3 participants 7 messages Feb 16, 2018 – Feb 18, 2018 objtool

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 objtool/x86: Replace Non-standard Range Expression in Case

Replace range expressions with seperate individual cases, i.e. convert case 1...3: to case 1: case 2: case 3 Range expression within case statements are non-standard C code and can create issues over compiler and platform variety.

While compiling with gcc 4.8 (RHEL) I encountered this error on range expression in case statements:
error: range expressions in switch statements are non-standard [-Werror=pedantic]

Cc Josh Poimboeuf <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Nick Desaulniers <[email protected]>
Cc Lukas Bulwahn <[email protected]>
Cc Nicholas Mc Guire <[email protected]>
---
 tools/objtool/arch/x86/decode.c | 35 ++++++++++++++++++++++++++++++++---
 1 file changed, 32 insertions(+), 3 deletions(-)
tools/objtool/arch/x86/decode.c +32 -3
index 540a209b78ab..b4433433863b 100644
@@ -143,7 +143,14 @@ int arch_decode_instruction(struct elf *elf, struct section *sec,
 		}
 		break;
 
-	case 0x50 ... 0x57:
+	case 0x50:
+    case 0x51:
+    case 0x52:
+    case 0x53:
+    case 0x54:
+    case 0x55:
+    case 0x56:
+    case 0x57:
 
 		/* push reg */
 		*type = INSN_STACK;
@@ -153,7 +160,14 @@ int arch_decode_instruction(struct elf *elf, struct section *sec,
 
 		break;
 
-	case 0x58 ... 0x5f:
+	case 0x58:
+    case 0x59:
+    case 0x5a:
+    case 0x5b:
+    case 0x5c:
+    case 0x5d:
+    case 0x5e:
+    case 0x5f:
 
 		/* pop reg */
 		*type = INSN_STACK;
@@ -171,7 +185,22 @@ int arch_decode_instruction(struct elf *elf, struct section *sec,
 		op->dest.type = OP_DEST_PUSH;
 		break;
 
-	case 0x70 ... 0x7f:
+	case 0x70:
+    case 0x71:
+    case 0x72:
+    case 0x73:
+    case 0x74:
+    case 0x75:
+    case 0x76:
+    case 0x77:
+    case 0x78:
+    case 0x79:
+    case 0x7a:
+    case 0x7b:
+    case 0x7c:
+    case 0x7d:
+    case 0x7e:
+    case 0x7f:
 		*type = INSN_JUMP_CONDITIONAL;
 		break;
 
Signature · 1 line
2.16.1
#1 lore raw

PATCH 1/1 objtool/x86: Replace Non-standard Range Expression in Case

Replace range expressions with seperate individual cases, i.e. convert case 1...3: to case 1: case 2: case 3 Range expression within case statements are non-standard C code and can create issues over compiler and platform variety.

While compiling with gcc 4.8 (RHEL) I encountered this error on range expression in case statements:
error: range expressions in switch statements are non-standard [-Werror=pedantic]

Cc Josh Poimboeuf <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Nick Desaulniers <[email protected]>
Cc Lukas Bulwahn <[email protected]>
Cc Nicholas Mc Guire <[email protected]>
---
 tools/objtool/arch/x86/decode.c | 35 ++++++++++++++++++++++++++++++++---
 1 file changed, 32 insertions(+), 3 deletions(-)
tools/objtool/arch/x86/decode.c +32 -3
index 540a209b78ab..4fb9b1307598 100644
@@ -143,7 +143,14 @@ int arch_decode_instruction(struct elf *elf, struct section *sec,
 		}
 		break;
 
-	case 0x50 ... 0x57:
+	case 0x50:
+        case 0x51:
+        case 0x52:
+        case 0x53:
+        case 0x54:
+        case 0x55:
+        case 0x56:
+        case 0x57:
 
 		/* push reg */
 		*type = INSN_STACK;
@@ -153,7 +160,14 @@ int arch_decode_instruction(struct elf *elf, struct section *sec,
 
 		break;
 
-	case 0x58 ... 0x5f:
+	case 0x58:
+        case 0x59:
+        case 0x5a:
+        case 0x5b:
+        case 0x5c:
+        case 0x5d:
+        case 0x5e:
+        case 0x5f:
 
 		/* pop reg */
 		*type = INSN_STACK;
@@ -171,7 +185,22 @@ int arch_decode_instruction(struct elf *elf, struct section *sec,
 		op->dest.type = OP_DEST_PUSH;
 		break;
 
-	case 0x70 ... 0x7f:
+	case 0x70:
+        case 0x71:
+        case 0x72:
+        case 0x73:
+        case 0x74:
+        case 0x75:
+        case 0x76:
+        case 0x77:
+        case 0x78:
+        case 0x79:
+        case 0x7a:
+        case 0x7b:
+        case 0x7c:
+        case 0x7d:
+        case 0x7e:
+        case 0x7f:
 		*type = INSN_JUMP_CONDITIONAL;
 		break;
 
Signature · 1 line
2.16.1
#2 lore raw
Quoted 7 lines · Progyan Bhattacharya

Replace range expressions with seperate individual cases, i.e. convert case 1...3: to case 1: case 2: case 3 Range expression within case statements are non-standard C code and can create issues over compiler and platform variety.

While compiling with gcc 4.8 (RHEL) I encountered this error on range expression in case statements:
error: range expressions in switch statements are non-standard [-Werror=pedantic]

Hi Progyan,

Thank you for the patch.

I think this makes the code unnecessarily verbose and less readable. We rely on many such GCC extensions, and we don't aim to comply with standard C. And AFAIK, we don't use -Werror=pedantic in the kernel.

Signature · 1 line
Josh
maintainer
#3 lore raw
Quoted 9 lines · Josh Poimboeuf
Quoted 7 lines · Progyan Bhattacharya

Replace range expressions with seperate individual cases, i.e. convert case 1...3: to case 1: case 2: case 3 Range expression within case statements are non-standard C code and can create issues over compiler and platform variety.

While compiling with gcc 4.8 (RHEL) I encountered this error on range expression in case statements:
error: range expressions in switch statements are non-standard [-Werror=pedantic]

Quoted 7 lines

Hi Progyan,

Thank you for the patch.

I think this makes the code unnecessarily verbose and less readable. We rely on many such GCC extensions, and we don't aim to comply with standard C. And AFAIK, we don't use -Werror=pedantic in the kernel.

Agreed, it makes the code actively worse. Just don't use error=pedantic.

#4 lore raw
Quoted 19 lines · Peter Zijlstra
Quoted 18 lines · Josh Poimboeuf
Quoted 11 lines · Progyan Bhattacharya

Replace range expressions with seperate individual cases, i.e. convert case 1...3: to case 1: case 2: case 3
Range expression within case statements are non-standard C code and can create issues over compiler and platform variety.

While compiling with gcc 4.8 (RHEL) I encountered this error on range expression in case statements:
error: range expressions in switch statements are non-standard [- Werror=pedantic]

Hi Progyan,

Thank you for the patch.

Quoted 8 lines
Quoted 5 lines

I think this makes the code unnecessarily verbose and less readable.  We
rely on many such GCC extensions, and we don't aim to comply with standard C.  And AFAIK, we don't use -Werror=pedantic in the kernel.

Agreed, it makes the code actively worse. Just don't use error=pedantic.

But I cannot figure it out how Werror=pedantic flag is being set. :(

Signature · 3 lines
Regards,
Progyan Bhattacharya
(http://codeprogyan.me)
#5 lore raw

PATCH 1/1 objtool/x86: Replace Non-standard Range Expression in Case

In reply to Progyan Bhattacharya

Replace range expressions with seperate individual cases, i.e. convert case 1...3: to case 1: case 2: case 3 Range expression within case statements are non-standard C code and can create issues over compiler and platform variety.

While compiling with gcc 4.8 (RHEL) I encountered this error on range expression in case statements:
error: range expressions in switch statements are non-standard [-Werror=pedantic]

Cc Josh Poimboeuf <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Nick Desaulniers <[email protected]>
Cc Lukas Bulwahn <[email protected]>
Cc Nicholas Mc Guire <[email protected]>
---
 tools/objtool/arch/x86/decode.c | 35 ++++++++++++++++++++++++++++++++---
 1 file changed, 32 insertions(+), 3 deletions(-)
tools/objtool/arch/x86/decode.c +32 -3
index 540a209b78ab..e6803dd79958 100644
@@ -143,7 +143,14 @@ int arch_decode_instruction(struct elf *elf, struct section *sec,
 		}
 		break;
 
-	case 0x50 ... 0x57:
+	case 0x50:
+	case 0x51:
+	case 0x52:
+	case 0x53:
+	case 0x54:
+	case 0x55:
+	case 0x56:
+	case 0x57:
 
 		/* push reg */
 		*type = INSN_STACK;
@@ -153,7 +160,14 @@ int arch_decode_instruction(struct elf *elf, struct section *sec,
 
 		break;
 
-	case 0x58 ... 0x5f:
+	case 0x58:
+	case 0x59:
+	case 0x5a:
+	case 0x5b:
+	case 0x5c:
+	case 0x5d:
+	case 0x5e:
+	case 0x5f:
 
 		/* pop reg */
 		*type = INSN_STACK;
@@ -171,7 +185,22 @@ int arch_decode_instruction(struct elf *elf, struct section *sec,
 		op->dest.type = OP_DEST_PUSH;
 		break;
 
-	case 0x70 ... 0x7f:
+	case 0x70:
+	case 0x71:
+	case 0x72:
+	case 0x73:
+	case 0x74:
+	case 0x75:
+	case 0x76:
+	case 0x77:
+	case 0x78:
+	case 0x79:
+	case 0x7a:
+	case 0x7b:
+	case 0x7c:
+	case 0x7d:
+	case 0x7e:
+	case 0x7f:
 		*type = INSN_JUMP_CONDITIONAL;
 		break;
 
Signature · 4 lines
Regards,
Progyan Bhattacharya
http://codeprogyan.me
2.16.1
#6 lore raw
Quoted 7 lines · Progyan Bhattacharya

Replace range expressions with seperate individual cases, i.e. convert case 1...3: to case 1: case 2: case 3 Range expression within case statements are non-standard C code and can create issues over compiler and platform variety.

While compiling with gcc 4.8 (RHEL) I encountered this error on range expression in case statements:
error: range expressions in switch statements are non-standard [-Werror=pedantic]

Progyan,

Please try to be respectful of reviewers' time by

a) running scripts/checkpatch.pl and closely reviewing your patch

     before sending;

b) not sending multiple revisions in a single day;

c) when sending a new revision, add the version number in the subject line and clarify what has changed.

I'd also recommend reviewing the following resources:

- https://www.youtube.com/watch?v=-3HNeoFuSH0

- Documentation/process/submitting-patches.rst

Signature · 1 line
Josh