clk: fix false-positive Wmaybe-uninitialized warning
Subsystems (3)
PATCH 1/1 clk: fix false-positive Wmaybe-uninitialized warning
When we build this driver with on x86-32, gcc produces a false-positive warning:
drivers/clk/renesas/clk-sh73a0.c: In function 'sh73a0_cpg_clocks_init':drivers/clk/renesas/clk-sh73a0.c:155:10: error: 'parent_name' may be used uninitialized in this function [-Werror=maybe-uninitialized]
return clk_register_fixed_factor(NULL, name, parent_name, 0,
We can work around that warning by adding a fake initialization, I tried and failed to come up with any better workaround. This is currently one of few remaining warnings for a 4.14.y randconfig build, so it would be good to also have it backported at least to that version. Older versions have more randconfig warnings, so we might not care.
I had not noticed this earlier, because one patch in my randconfig test tree removes the '-ffreestanding' option on x86-32, and that avoids the warning. The -ffreestanding flag was originally global but moved into arch/i386 by Andi Kleen in commit 6edfba1b33c7 ("[PATCH] x86_64:
Don't define string functions to builtin") as a 'temporary workaround'.
Like many temporary hacks, this turned out to be rather long-lived, from all I can tell we still need a simple fix to asm/string_32.h before it can be removed, but I'm not sure about how to best do that.
--- drivers/clk/renesas/clk-sh73a0.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/clk/renesas/clk-sh73a0.c +3 -3
@@ -46,7 +46,7 @@ struct div4_clk {unsigned int shift; }; -static struct div4_clk div4_clks[] = { +static const struct div4_clk div4_clks[] = { {"zg" ,"pll0" ,CPG_FRQCRA ,16 }, {"m3" ,"pll1" ,CPG_FRQCRA ,12 }, {"b" ,"pll1" ,CPG_FRQCRA ,8 },
@@ -79,7 +79,7 @@ sh73a0_cpg_register_clock(struct device_node *np, struct sh73a0_cpg *cpg, {const struct clk_div_table *table =NULL ;unsigned int shift, reg, width; -const char *parent_name; +const char *parent_name =NULL ;unsigned int mult =1 ;unsigned int div =1 ;
@@ -135,7 +135,7 @@ sh73a0_cpg_register_clock(struct device_node *np, struct sh73a0_cpg *cpg, shift =24 ; width =5 ; }else { -struct div4_clk *c; +const struct div4_clk *c;for (c = div4_clks; c->name; c++) {if (!strcmp (name, c->name)) {
Signature · 1 line
2.9.0
Hi Arnd,
Quoted 18 lines · Arnd Bergmann
When we build this driver with on x86-32, gcc produces a false-positive warning:
drivers/clk/renesas/clk-sh73a0.c: In function 'sh73a0_cpg_clocks_init':drivers/clk/renesas/clk-sh73a0.c:155:10: error: 'parent_name' may be used uninitialized in this function [-Werror=maybe-uninitialized]
return clk_register_fixed_factor(NULL, name,parent_name, 0,We can work around that warning by adding a fake initialization, I tried and failed to come up with any better workaround. This is currently one of few remaining warnings for a 4.14.y randconfig build, so it would be good to also have it backported at least to that version. Older versions have more randconfig warnings, so we might not care.
I had not noticed this earlier, because one patch in my randconfig test tree removes the '-ffreestanding' option on x86-32, and that avoids the warning. The -ffreestanding flag was originally global but moved into
arch/i386by Andi Kleen in commit6edfba1b33c7("[PATCH]x86_64:
Don't define string functions to builtin") as a 'temporary workaround'.
Quoted 7 lines
Like many temporary hacks, this turned out to be rather long-lived, from all I can tell we still need a simple fix to
asm/string_32.hbefore it can be removed, but I'm not sure about how to best do that.Cc Andi Kleen <[email protected]>Signed-off-by Arnd Bergmann <[email protected]>
Thanks, this is a known false positive.
Quoted 9 lines
--- drivers/clk/renesas/clk-sh73a0.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/clk/renesas/clk-sh73a0.c +0
-0
drivers/clk/renesas/clk-sh73a0.c struct div4_clk { · line 49
Quoted 5 lines
drivers/clk/renesas/clk-sh73a0.c +1
-1@@ -46,7 +46,7 @@ struct div4_clk {unsigned int shift; }; -static struct div4_clk div4_clks[] = { +static const struct div4_clk div4_clks[] = {
This change is not part of the fix...
Quoted 13 lines
drivers/clk/renesas/clk-sh73a0.c +1
-1{ "zg", "pll0", CPG_FRQCRA, 16 }, { "m3", "pll1", CPG_FRQCRA, 12 }, { "b", "pll1", CPG_FRQCRA, 8 },@@ -79,7 +79,7 @@ sh73a0_cpg_register_clock(struct device_node *np, struct sh73a0_cpg *cpg, {const struct clk_div_table *table =NULL ;unsigned int shift, reg, width; -const char *parent_name; +const char *parent_name =NULL ;unsigned int mult =1 ;unsigned int div =1 ;
drivers/clk/renesas/clk-sh73a0.c sh73a0_cpg_register_clock(struct device_node *np, struct sh73a0_cpg *cpg, · line 138
Quoted 5 lines
drivers/clk/renesas/clk-sh73a0.c +1
-1@@ -135,7 +135,7 @@ sh73a0_cpg_register_clock(struct device_node *np, struct sh73a0_cpg *cpg, shift =24 ; width =5 ; }else { -struct div4_clk *c; +const struct div4_clk *c;
... and neither is this one.
drivers/clk/renesas/clk-sh73a0.c sh73a0_cpg_register_clock(struct device_node *np, struct sh73a0_cpg *cpg, · line 141
Quoted 3 lines
drivers/clk/renesas/clk-sh73a0.c +0
-0for (c = div4_clks; c->name; c++) {if (!strcmp (name, c->name)) {
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Quoting Arnd Bergmann (2018-02-16 07:27:47)
Quoted 1 line
When we build this driver with on x86-32, gcc produces a false-positive w=
arning:
Quoted 4 lines
=
drivers/clk/renesas/clk-sh73a0.c: In function 'sh73a0_cpg_clocks_init':drivers/clk/renesas/clk-sh73a0.c:155:10: error: 'parent_name' may be used=
uninitialized in this function [-Werror=3Dmaybe-uninitialized]
Quoted 22 lines
return clk_register_fixed_factor(NULL, name,
parent_name, 0,
=We can work around that warning by adding a fake initialization, I tried and failed to come up with any better workaround. This is currently one of few remaining warnings for a 4.14.y randconfig build, so it would be good to also have it backported at least to that version. Older versions have more randconfig warnings, so we might not care.
=I had not noticed this earlier, because one patch in my randconfig test tree removes the '-ffreestanding' option on x86-32, and that avoids the warning. The -ffreestanding flag was originally global but moved into
arch/i386by Andi Kleen in commit6edfba1b33c7("[PATCH]x86_64:
Don't define string functions to builtin") as a 'temporary workaround'. =Like many temporary hacks, this turned out to be rather long-lived, from all I can tell we still need a simple fix to
asm/string_32.hbefore it can be removed, but I'm not sure about how to best do that. =
Quoted 4 lines
Cc Andi Kleen <[email protected]>Signed-off-by Arnd Bergmann <[email protected]>---
Applied to clk-next