drm/rcar-du: dw-hdmi: Fix compilation
Subsystems (3)
PATCH 1/1 drm/rcar-du: dw-hdmi: Fix compilation
Commit eea034af90c6 ("drm/bridge/synopsys: dw-hdmi: don't clobber drvdata") broke the build with one build error and one warning. Fix both.
--- drivers/gpu/drm/rcar-du/rcar_dw_hdmi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/gpu/drm/rcar-du/rcar_dw_hdmi.c +3 -1
@@ -75,11 +75,13 @@ static int rcar_dw_hdmi_probe(struct platform_device *pdev)return PTR_ERR (hdmi);platform_set_drvdata (pdev, hdmi); + +return 0 ; }static int rcar_dw_hdmi_remove (struct platform_device *pdev) { -struct dw_hdmi *hdmi =platform_get_drvdata (dev); +struct dw_hdmi *hdmi =platform_get_drvdata (pdev);dw_hdmi_remove (hdmi);
Signature · 6 lines
2.14.3 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 2 lines · Maxime Ripard
Commit
eea034af90c6("drm/bridge/synopsys: dw-hdmi: don't clobber drvdata") broke the build with one build error and one warning. Fix both.
Quoted 37 lines
Cc Archit Taneja <[email protected]>Cc Jernej Skrabec <[email protected]>Cc Laurent Pinchart <[email protected]>Fixes eea034af90c6 ("drm/bridge/synopsys: dw-hdmi: don't clobber drvdata")Reported-by kbuild test robot <[email protected]>Signed-off-by Maxime Ripard <[email protected]>--- drivers/gpu/drm/rcar-du/rcar_dw_hdmi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)drivers/gpu/drm/rcar-du/rcar_dw_hdmi.c +3
-1@@ -75,11 +75,13 @@ static int rcar_dw_hdmi_probe(struct platform_device *pdev)return PTR_ERR (hdmi);platform_set_drvdata (pdev, hdmi); + +return 0 ; }static int rcar_dw_hdmi_remove (struct platform_device *pdev) { -struct dw_hdmi *hdmi =platform_get_drvdata (dev); +struct dw_hdmi *hdmi =platform_get_drvdata (pdev);dw_hdmi_remove (hdmi);Signature · 6 lines
2.14.3 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 5 lines
Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 5 lines · Sean Paul
Quoted 2 lines · Maxime Ripard
Commit
eea034af90c6("drm/bridge/synopsys: dw-hdmi: don't clobber drvdata") broke the build with one build error and one warning. Fix both.Reviewed-by Sean Paul <[email protected]>
Pushed, sorry for the mess.
Maxime
Signature · 3 lines
Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering http://bootlin.com
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Maxime,
Quoted 9 lines · On Friday, 16 February 2018 17:44:12 EET Maxime Ripard wrote:
Commit
eea034af90c6("drm/bridge/synopsys: dw-hdmi: don't clobber drvdata") broke the build with one build error and one warning. Fix both.Cc Archit Taneja <[email protected]>Cc Jernej Skrabec <[email protected]>Cc Laurent Pinchart <[email protected]>Fixes eea034af90c6 ("drm/bridge/synopsys: dw-hdmi: don't clobber drvdata")Reported-by kbuild test robot <[email protected]>Signed-off-by Maxime Ripard <[email protected]>
A bit late as you've pushed the patch already, but
Quoted 23 lines
--- drivers/gpu/drm/rcar-du/rcar_dw_hdmi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)(quoted diff) +0
-0
b/drivers/gpu/drm/rcar-du/rcar_dw_hdmi.cindex3bebc6821e9c..76210ae25094100644drivers/gpu/drm/rcar-du/rcar_dw_hdmi.c +3
-1@@ -75,11 +75,13 @@ static int rcar_dw_hdmi_probe(struct platform_device *pdev) return PTR_ERR(hdmi);platform_set_drvdata (pdev, hdmi); + +return 0 ; }static int rcar_dw_hdmi_remove (struct platform_device *pdev) { -struct dw_hdmi *hdmi =platform_get_drvdata (dev); +struct dw_hdmi *hdmi =platform_get_drvdata (pdev);dw_hdmi_remove (hdmi);
Signature · 8 lines
Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel