Skip to contentSkip to conversation

proc: move /proc/sysvipc creation to where it belongs

PATCH In review Alexey Dobriyan 2 participants 2 messages Feb 16, 2018 – Mar 25, 2018 Proc filesystem

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 proc: move /proc/sysvipc creation to where it belongs

---

 fs/proc/root.c |    4 ----
 ipc/util.c     |    1 +
 2 files changed, 1 insertion(+), 4 deletions(-)
fs/proc/root.c +0 -4
@@ -136,10 +136,6 @@ void __init proc_root_init(void)
 	proc_symlink("mounts", NULL, "self/mounts");
 
 	proc_net_init();
-
-#ifdef CONFIG_SYSVIPC
-	proc_mkdir("sysvipc", NULL);
-#endif
 	proc_mkdir("fs", NULL);
 	proc_mkdir("driver", NULL);
 	proc_create_mount_point("fs/nfsd"); /* somewhere for the nfsd filesystem to be mounted */
ipc/util.c +1 -0
@@ -89,6 +89,7 @@ static int __init ipc_init(void)
 {
 	int err_sem, err_msg;
 
+	proc_mkdir("sysvipc", NULL);
 	err_sem = sem_init();
 	WARN(err_sem, "ipc: sysv sem_init failed: %d\n", err_sem);
 	err_msg = msg_init();
#1 lore raw
Quoted 1 line · Alexey Dobriyan

Acked. However, a small redundant description might be nice.

"
Move the proc_mkdir() call within the sysvipc subsystem such that we avoid polluting proc_root_init() with petty cpp.
"

Thanks,
Davidlohr