mm: Re-use DEFINE_SHOW_ATTRIBUTE() macro
Subsystems (5)
PATCH v2 1/1 mm: Re-use DEFINE_SHOW_ATTRIBUTE() macro
...instead of open coding file operations followed by custom ->open() callbacks per each attribute.
Reviewed-by Matthew Wilcox <[email protected]>
Reviewed-by Sergey Senozhatsky <[email protected]>
Signed-off-by Andy Shevchenko <[email protected]>
---
In v2:
- add tags
- fix compilation issue kbuild bot reported about
mm/backing-dev.c | 13 +------------ mm/memblock.c | 13 +------------ mm/percpu-stats.c | 13 +------------ mm/zsmalloc.c | 15 ++------------- 4 files changed, 5 insertions(+), 49 deletions(-)
mm/backing-dev.c +1 -12
@@ -100,18 +100,7 @@ static int bdi_debug_stats_show(struct seq_file *m, void *v)return 0 ; } - -static int bdi_debug_stats_open (struct inode *inode,struct file *file) -{ -return single_open (file, bdi_debug_stats_show, inode->i_private); -} - -static const struct file_operations bdi_debug_stats_fops = { - .open = bdi_debug_stats_open, - .read = seq_read, - .llseek = seq_lseek, - .release = single_release, -}; +DEFINE_SHOW_ATTRIBUTE (bdi_debug_stats);static int bdi_debug_register (struct backing_dev_info *bdi,const char *name) {
mm/memblock.c +1 -12
@@ -1846,18 +1846,7 @@ static int memblock_debug_show(struct seq_file *m, void *private) }return 0 ; } - -static int memblock_debug_open (struct inode *inode,struct file *file) -{ -return single_open (file, memblock_debug_show, inode->i_private); -} - -static const struct file_operations memblock_debug_fops = { - .open = memblock_debug_open, - .read = seq_read, - .llseek = seq_lseek, - .release = single_release, -}; +DEFINE_SHOW_ATTRIBUTE (memblock_debug);static int __init memblock_init_debugfs (void ) {
mm/percpu-stats.c +1 -12
@@ -223,18 +223,7 @@ static int percpu_stats_show(struct seq_file *m, void *v)return 0 ; } - -static int percpu_stats_open (struct inode *inode,struct file *filp) -{ -return single_open (filp, percpu_stats_show,NULL ); -} - -static const struct file_operations percpu_stats_fops = { - .open = percpu_stats_open, - .read = seq_read, - .llseek = seq_lseek, - .release = single_release, -}; +DEFINE_SHOW_ATTRIBUTE (percpu_stats);static int __init init_percpu_stats_debugfs (void ) {
mm/zsmalloc.c +2 -13
@@ -642,18 +642,7 @@ static int zs_stats_size_show(struct seq_file *s, void *v)return 0 ; } - -static int zs_stats_size_open (struct inode *inode,struct file *file) -{ -return single_open (file, zs_stats_size_show, inode->i_private); -} - -static const struct file_operations zs_stat_size_ops = { - .open = zs_stats_size_open, - .read = seq_read, - .llseek = seq_lseek, - .release = single_release, -}; +DEFINE_SHOW_ATTRIBUTE (zs_stats_size);static void zs_pool_stat_create (struct zs_pool *pool,const char *name) {
@@ -672,7 +661,7 @@ static void zs_pool_stat_create(struct zs_pool *pool, const char *name) pool->stat_dentry = entry; entry =debugfs_create_file ("classes" ,S_IFREG |S_IRUGO , - pool->stat_dentry, pool, &zs_stat_size_ops); + pool->stat_dentry, pool, &zs_stats_size_fops);if (!entry) {pr_warn ("%s: debugfs file entry <%s> creation failed\n" , name,"classes" );
Signature · 7 lines
2.15.1 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>