Skip to contentSkip to conversation

linux-next: build failure after merge of the sound-asoc tree

DISCUSSION Stephen Rothwell 3 participants 3 messages Feb 18, 2018 – Feb 19, 2018

lore
Share & tools
lore
#0 lore raw

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64 allmodconfig) failed like this:

sound/soc/amd/acp-da7219-max98357a.c: In function 'cz_da7219_init':
sound/soc/amd/acp-da7219-max98357a.c:79:22: error: passing argument 1 of 'da7219_aad_jack_det' from incompatible pointer type [-Werror=incompatible-pointer-types]

  da7219_aad_jack_det(codec, &cz_jack);
                      ^~~~~
In file included from sound/soc/amd/acp-da7219-max98357a.c:38:0:
sound/soc/amd/../codecs/da7219-aad.h:209:6: note: expected 'struct snd_soc_component *' but argument is of type 'struct snd_soc_codec *'
 void da7219_aad_jack_det(struct snd_soc_component *component, struct snd_soc_jack *jack);
      ^~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
sound/soc/intel/boards/kbl_da7219_max98357a.c: In function 'kabylake_da7219_codec_init':
sound/soc/intel/boards/kbl_da7219_max98357a.c:194:22: error: passing argument 1 of 'da7219_aad_jack_det' from incompatible pointer type [-Werror=incompatible-pointer-types]
  da7219_aad_jack_det(codec, &ctx->kabylake_headset);
                      ^~~~~
In file included from sound/soc/intel/boards/kbl_da7219_max98357a.c:23:0:
sound/soc/intel/boards/../../codecs/da7219-aad.h:209:6: note: expected 'struct snd_soc_component *' but argument is of type 'struct snd_soc_codec *'
 void da7219_aad_jack_det(struct snd_soc_component *component, struct snd_soc_jack *jack);
      ^~~~~~~~~~~~~~~~~~~
sound/soc/intel/boards/kbl_da7219_max98357a.c: In function 'kabylake_card_late_probe':
sound/soc/intel/boards/kbl_da7219_max98357a.c:552:34: error: passing argument 1 of 'hdac_hdmi_jack_port_init' from incompatible pointer type [-Werror=incompatible-pointer-types]
  return hdac_hdmi_jack_port_init(codec, &card->dapm);
                                  ^~~~~
In file included from sound/soc/intel/boards/kbl_da7219_max98357a.c:21:0:
sound/soc/intel/boards/../../codecs/hdac_hdmi.h:8:5: note: expected 'struct snd_soc_component *' but argument is of type 'struct snd_soc_codec *'
 int hdac_hdmi_jack_port_init(struct snd_soc_component *component,
     ^~~~~~~~~~~~~~~~~~~~~~~~

Caused by commits

608a300fc1f0 ("ASoC: AMD: Add machine driver for ST DA7219 MAX98357") b3ea70ee64ea ("ASoC: Intel: Add Kabylake-y Dialog Maxim machine driver")

interacting with commit

451011221711 ("ASoC: hdac_hdmi/nau8825/rt286/rt298/rt5663/da7219: replace codec to component")

I have used the sound-asoc tree from next-20180216 for today.

Signature · 2 lines
Cheers,
Stephen Rothwell
#1 lore raw

Hi Stephen

Thank you for your report.
It seems added new drivers are not based on new framework. I will post fixup patch for these.

Quoted 45 lines

After merging the sound-asoc tree, today's linux-next build (x86_64 allmodconfig) failed like this:

sound/soc/amd/acp-da7219-max98357a.c: In function 'cz_da7219_init':
sound/soc/amd/acp-da7219-max98357a.c:79:22: error: passing argument 1 of 'da7219_aad_jack_det' from incompatible pointer type [-Werror=incompatible-pointer-types]

  da7219_aad_jack_det(codec, &cz_jack);
                      ^~~~~
In file included from sound/soc/amd/acp-da7219-max98357a.c:38:0:
sound/soc/amd/../codecs/da7219-aad.h:209:6: note: expected 'struct snd_soc_component *' but argument is of type 'struct snd_soc_codec *'
 void da7219_aad_jack_det(struct snd_soc_component *component, struct snd_soc_jack *jack);
      ^~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
sound/soc/intel/boards/kbl_da7219_max98357a.c: In function 'kabylake_da7219_codec_init':
sound/soc/intel/boards/kbl_da7219_max98357a.c:194:22: error: passing argument 1 of 'da7219_aad_jack_det' from incompatible pointer type [-Werror=incompatible-pointer-types]
  da7219_aad_jack_det(codec, &ctx->kabylake_headset);
                      ^~~~~
In file included from sound/soc/intel/boards/kbl_da7219_max98357a.c:23:0:
sound/soc/intel/boards/../../codecs/da7219-aad.h:209:6: note: expected 'struct snd_soc_component *' but argument is of type 'struct snd_soc_codec *'
 void da7219_aad_jack_det(struct snd_soc_component *component, struct snd_soc_jack *jack);
      ^~~~~~~~~~~~~~~~~~~
sound/soc/intel/boards/kbl_da7219_max98357a.c: In function 'kabylake_card_late_probe':
sound/soc/intel/boards/kbl_da7219_max98357a.c:552:34: error: passing argument 1 of 'hdac_hdmi_jack_port_init' from incompatible pointer type [-Werror=incompatible-pointer-types]
  return hdac_hdmi_jack_port_init(codec, &card->dapm);
                                  ^~~~~
In file included from sound/soc/intel/boards/kbl_da7219_max98357a.c:21:0:
sound/soc/intel/boards/../../codecs/hdac_hdmi.h:8:5: note: expected 'struct snd_soc_component *' but argument is of type 'struct snd_soc_codec *'
 int hdac_hdmi_jack_port_init(struct snd_soc_component *component,
     ^~~~~~~~~~~~~~~~~~~~~~~~

Caused by commits

608a300fc1f0 ("ASoC: AMD: Add machine driver for ST DA7219 MAX98357") b3ea70ee64ea ("ASoC: Intel: Add Kabylake-y Dialog Maxim machine driver")

interacting with commit

451011221711 ("ASoC: hdac_hdmi/nau8825/rt286/rt298/rt5663/da7219: replace codec to component")

I have used the sound-asoc tree from next-20180216 for today.

Signature · 4 lines
Cheers,
Stephen Rothwell
[2 OpenPGP digital signature <application/pgp-signature (7bit)>]
No public key for 015042F34957D06C created at 2018-02-19T08:32:45+0900 using RSA
#2 lore raw
In reply to Stephen Rothwell
Quoted 33 lines · Stephen Rothwell

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64 allmodconfig) failed like this:

sound/soc/amd/acp-da7219-max98357a.c: In function 'cz_da7219_init':
sound/soc/amd/acp-da7219-max98357a.c:79:22: error: passing argument 1 of 'da7219_aad_jack_det' from incompatible pointer type [-Werror=incompatible-pointer-types]

   da7219_aad_jack_det(codec, &cz_jack);
                       ^~~~~
In file included from sound/soc/amd/acp-da7219-max98357a.c:38:0:
sound/soc/amd/../codecs/da7219-aad.h:209:6: note: expected 'struct snd_soc_component *' but argument is of type 'struct snd_soc_codec *'
  void da7219_aad_jack_det(struct snd_soc_component *component, struct snd_soc_jack *jack);
       ^~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
sound/soc/intel/boards/kbl_da7219_max98357a.c: In function 'kabylake_da7219_codec_init':
sound/soc/intel/boards/kbl_da7219_max98357a.c:194:22: error: passing argument 1 of 'da7219_aad_jack_det' from incompatible pointer type [-Werror=incompatible-pointer-types]
   da7219_aad_jack_det(codec, &ctx->kabylake_headset);
                       ^~~~~
In file included from sound/soc/intel/boards/kbl_da7219_max98357a.c:23:0:
sound/soc/intel/boards/../../codecs/da7219-aad.h:209:6: note: expected 'struct snd_soc_component *' but argument is of type 'struct snd_soc_codec *'
  void da7219_aad_jack_det(struct snd_soc_component *component, struct snd_soc_jack *jack);
       ^~~~~~~~~~~~~~~~~~~
sound/soc/intel/boards/kbl_da7219_max98357a.c: In function 'kabylake_card_late_probe':
sound/soc/intel/boards/kbl_da7219_max98357a.c:552:34: error: passing argument 1 of 'hdac_hdmi_jack_port_init' from incompatible pointer type [-Werror=incompatible-pointer-types]
   return hdac_hdmi_jack_port_init(codec, &card->dapm);
                                   ^~~~~
In file included from sound/soc/intel/boards/kbl_da7219_max98357a.c:21:0:
sound/soc/intel/boards/../../codecs/hdac_hdmi.h:8:5: note: expected 'struct snd_soc_component *' but argument is of type 'struct snd_soc_codec *'
  int hdac_hdmi_jack_port_init(struct snd_soc_component *component,
      ^~~~~~~~~~~~~~~~~~~~~~~~

Caused by commits

Quoted 9 lines

608a300fc1f0 ("ASoC: AMD: Add machine driver for ST DA7219 MAX98357") b3ea70ee64ea ("ASoC: Intel: Add Kabylake-y Dialog Maxim machine driver")

interacting with commit

451011221711 ("ASoC: hdac_hdmi/nau8825/rt286/rt298/rt5663/da7219: replace codec to component")

I have used the sound-asoc tree from next-20180216 for today.

Thanks Kuninori for updating the patches with fixes for the above failure.
https://patchwork.kernel.org/patch/10227101/
https://patchwork.kernel.org/patch/10227099/