Skip to contentSkip to conversation

ARM: dts: imx28-tx28: Pass the memory unit name

RFC Applied Fabio Estevam 3 participants 3 messages Feb 17, 2018 – Feb 24, 2018

Subsystems (2)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

RFC 1/1 ARM: dts: imx28-tx28: Pass the memory unit name

From: Fabio Estevam <[email protected]>

Pass the memory unit name in order to fix the following dtc warning with W=1:

arch/arm/boot/dts/imx28-tx28.dtb: Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name

---
Hi,

Currently the only dtc warnings observed with W=1 are the ones:
Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name

If this solution can be accepted I can clean all the other i.MX dts files.

Please advise.

 arch/arm/boot/dts/imx28-tx28.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/imx28-tx28.dts +2 -2
index 8a4f5bc..bbdf004 100644
@@ -65,8 +65,8 @@
 		usbotg = &usb0;
 	};
 
-	memory {
-		reg = <0 0>; /* will be filled in by U-Boot */
+	memory at 40000000 {
+		reg = <0x40000000 0>; /* will be filled in by U-Boot */
 	};
 
 	onewire {
Signature · 1 line
2.7.4
Acked-by on v1 1/1
#1 lore raw

Hi,

Quoted 27 lines · On Sat, 17 Feb 2018 13:41:43 -0200 Fabio Estevam wrote:

From: Fabio Estevam <[email protected]>

Pass the memory unit name in order to fix the following dtc warning with W=1:

arch/arm/boot/dts/imx28-tx28.dtb: Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name

---
Hi,

Currently the only dtc warnings observed with W=1 are the ones:
Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name

If this solution can be accepted I can clean all the other i.MX dts files.

Please advise.

 arch/arm/boot/dts/imx28-tx28.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/imx28-tx28.dts +0 -0
index 8a4f5bc..bbdf004 100644

arch/arm/boot/dts/imx28-tx28.dts line 72

Quoted 10 lines
arch/arm/boot/dts/imx28-tx28.dts +2 -2
@@ -65,8 +65,8 @@
 		usbotg = &usb0;
 	};
 
-	memory {
-		reg = <0 0>; /* will be filled in by U-Boot */
+	memory at 40000000 {
+		reg = <0x40000000 0>; /* will be filled in by U-Boot */
 	};
 
 	onewire {

I have no objections to this change. U-Boot still finds the memory node and puts the correct size into the 'reg' property.

Lothar Wa?mann