Skip to contentSkip to conversation

xen_wdt: fix build failure

PATCH In review Radu Rendec 2 participants 3 messages Feb 19, 2018 Watchdog device drivers

lore
Share & tools
lore
#0 lore raw

cover xen_wdt: fix build failure

Hi Guenter,

I just saw Matteo Croce's email/patch on the i6300esb build failure and I realized that xen_wdt has the exact same problem. I forgot to add a dependency on CONFIG_WATCHDOG_CORE for both drivers when I ported them to use the watchdog core.

This patch is the xen_wdt equivalent of Matteo Croce's patch for i6300esb.

Thanks!

Radu Rendec (1):
watchdog: xen_wdt: fix potential build failure

 drivers/watchdog/Kconfig | 1 +
 1 file changed, 1 insertion(+)
Signature · 1 line
2.13.6
#1 lore raw

PATCH 1/1 watchdog: xen_wdt: fix potential build failure

xen_wdt uses watchdog core functions (from watchdog_core.c) and, when compiled without CONFIG_WATCHDOG_CORE being set, it produces the following build error:

ERROR: "devm_watchdog_register_device" [drivers/watchdog/xen_wdt.ko] undefined!
ERROR: "watchdog_init_timeout" [drivers/watchdog/xen_wdt.ko] undefined!

Fix this by selecting CONFIG_WATCHDOG_CORE when CONFIG_XEN_WDT is set.

Fixes 18cffd68e0c4 ("watchdog: xen_wdt: use the watchdog subsystem")
---
 drivers/watchdog/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/watchdog/Kconfig +1 -0
index a16bad78679b..2953e9fbb818 100644
@@ -1838,6 +1838,7 @@ config WATCHDOG_SUN4V
 config XEN_WDT
 	tristate "Xen Watchdog support"
 	depends on XEN
+	select WATCHDOG_CORE
 	help
 	  Say Y here to support the hypervisor watchdog capability provided
 	  by Xen 4.0 and newer.  The watchdog timeout period is normally one
Signature · 1 line
2.13.6
maintainer Reviewed-by on v1 1/1
#2 lore raw

Re: [PATCH 1/1] watchdog: xen_wdt: fix potential build failure

Quoted 11 lines · Radu Rendec

xen_wdt uses watchdog core functions (from watchdog_core.c) and, when compiled without CONFIG_WATCHDOG_CORE being set, it produces the following build error:

ERROR: "devm_watchdog_register_device" [drivers/watchdog/xen_wdt.ko] undefined!
ERROR: "watchdog_init_timeout" [drivers/watchdog/xen_wdt.ko] undefined!

Fix this by selecting CONFIG_WATCHDOG_CORE when CONFIG_XEN_WDT is set.

Fixes 18cffd68e0c4 ("watchdog: xen_wdt: use the watchdog subsystem")

Sorry, should have caught that during the review.

Guenter

Quoted 17 lines
---
  drivers/watchdog/Kconfig | 1 +
  1 file changed, 1 insertion(+)
drivers/watchdog/Kconfig +1 -0
index a16bad78679b..2953e9fbb818 100644
@@ -1838,6 +1838,7 @@ config WATCHDOG_SUN4V
  config XEN_WDT
  	tristate "Xen Watchdog support"
  	depends on XEN
+	select WATCHDOG_CORE
  	help
  	  Say Y here to support the hypervisor watchdog capability provided
  	  by Xen 4.0 and newer.  The watchdog timeout period is normally one