Skip to contentSkip to conversation

watchdog: sp5100_tco.c: fix potential build failure

PATCH In review Wim Van Sebroeck 2 participants 2 messages Feb 19, 2018 Watchdog device drivers

lore
Share & tools
lore

Wim Van Sebroeck

author maintainer
#0 lore raw

PATCH 1/1 watchdog: sp5100_tco.c: fix potential build failure

isp5100_tco.c uses watchdog core functions (from watchdog_core.c) and, when compiled without CONFIG_WATCHDOG_CORE being set, it produces the following build error:

ERROR: "devm_watchdog_register_device" [drivers/watchdog/sp5100_tco.ko] undefined!
ERROR: "watchdog_init_timeout" [drivers/watchdog/sp5100_tco.ko] undefined!

Fix this by selecting CONFIG_WATCHDOG_CORE.

Fixes 7cd9d5fff792 ("watchdog: sp5100_tco: Convert to use watchdog subsystem")
---
 drivers/watchdog/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/watchdog/Kconfig +1 -0
index 3d984cd..37460cd 100644
@@ -904,6 +904,7 @@ config F71808E_WDT
 config SP5100_TCO
        tristate "AMD/ATI SP5100 TCO Timer/Watchdog"
        depends on X86 && PCI
+       select WATCHDOG_CORE
        ---help---
          Hardware watchdog driver for the AMD/ATI SP5100 chipset. The TCO
          (Total Cost of Ownership) timer is a watchdog timer that will reboot
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 11 lines · Wim Van Sebroeck

isp5100_tco.c uses watchdog core functions (from watchdog_core.c) and, when compiled without CONFIG_WATCHDOG_CORE being set, it produces the following build error:

ERROR: "devm_watchdog_register_device" [drivers/watchdog/sp5100_tco.ko] undefined!
ERROR: "watchdog_init_timeout" [drivers/watchdog/sp5100_tco.ko] undefined!

Fix this by selecting CONFIG_WATCHDOG_CORE.

Fixes 7cd9d5fff792 ("watchdog: sp5100_tco: Convert to use watchdog subsystem")

I really need to get better watching out for those dependencies :-(

Quoted 21 lines
---
  drivers/watchdog/Kconfig | 1 +
  1 file changed, 1 insertion(+)
drivers/watchdog/Kconfig +1 -1
index 3d984cd..37460cd 100644
@@ -904,6 +904,7 @@ config F71808E_WDT
  config SP5100_TCO
         tristate "AMD/ATI SP5100 TCO Timer/Watchdog"
         depends on X86 && PCI
+       select WATCHDOG_CORE
         ---help---
           Hardware watchdog driver for the AMD/ATI SP5100 chipset. The TCO
           (Total Cost of Ownership) timer is a watchdog timer that will reboot
--

To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html