Skip to contentSkip to conversation

Revert "mx6: ddr: Allow changing REFSEL and REFR fields"

PATCH New Maxim Yu. Osipov 2 participants 2 messages Feb 20, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Revert "mx6: ddr: Allow changing REFSEL and REFR fields"

This reverts commit edf0093732225c2fd0791c3864e9a3eef1f92f19 for cm_fx6 iMX.6 Solo module as it causes frequent (around 10 percent of power cycles) board's hangs.

These hangs happen in SPL when BSS is being initialized in SDRAM - it appear that variables from BSS contain trash values which lead to board hangs. Looks like that SDRAM doesn't yet finish initialization in these cases.

---
 board/compulab/cm_fx6/spl.c | 2 --
 1 file changed, 2 deletions(-)
board/compulab/cm_fx6/spl.c +0 -2
index 56aac60239..16e5bf8dfa 100644
@@ -107,8 +107,6 @@ static struct mx6_ddr_sysinfo cm_fx6_sysinfo_s = {
 	.mif3_mode	= 3,
 	.rst_to_cke	= 0x23,
 	.sde_to_rst	= 0x10,
-	.refsel = 1,		/* Refresh cycles at 32KHz */
-	.refr = 7,		/* 8 refresh commands per refresh cycle */
 };
 
 static struct mx6_ddr3_cfg cm_fx6_ddr3_cfg_s = {
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 Revert "mx6: ddr: Allow changing REFSEL and REFR fields"

Quoted 20 lines · Maxim Yu. Osipov

This reverts commit edf0093732225c2fd0791c3864e9a3eef1f92f19 for cm_fx6 iMX.6 Solo module as it causes frequent (around 10 percent of power cycles) board's hangs.

These hangs happen in SPL when BSS is being initialized in SDRAM - it appear that variables from BSS contain trash values which lead to board hangs. Looks like that SDRAM doesn't yet finish initialization in these cases.

---
 board/compulab/cm_fx6/spl.c | 2 --
 1 file changed, 2 deletions(-)
board/compulab/cm_fx6/spl.c +0 -0
index 56aac60239..16e5bf8dfa 100644

board/compulab/cm_fx6/spl.c static struct mx6_ddr_sysinfo cm_fx6_sysinfo_s = { · line 112

Quoted 8 lines
board/compulab/cm_fx6/spl.c +0 -2
@@ -107,8 +107,6 @@ static struct mx6_ddr_sysinfo cm_fx6_sysinfo_s = {
 	.mif3_mode	= 3,
 	.rst_to_cke	= 0x23,
 	.sde_to_rst	= 0x10,
-	.refsel = 1,		/* Refresh cycles at 32KHz */
-	.refr = 7,		/* 8 refresh commands per refresh cycle */
 };
 
 static struct mx6_ddr3_cfg cm_fx6_ddr3_cfg_s = {

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================