Skip to contentSkip to conversation

Patch "MIPS: Fix typo BIG_ENDIAN to CPU_BIG_ENDIAN" has been added to the 4.15-stable tree

PATCH [email protected] 2 participants 3 messages Feb 20, 2018

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

MIPS: Fix typo BIG_ENDIAN to CPU_BIG_ENDIAN

to the 4.15-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
mips-fix-typo-big_endian-to-cpu_big_endian.patch
and it can be found in the queue-4.15 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 2e6522c565522a2e18409c315c49d78c8b74807b Mon Sep 17 00:00:00 2001

From: Corentin Labbe <[email protected]>
Date: Wed, 17 Jan 2018 19:56:38 +0100
Subject: MIPS: Fix typo BIG_ENDIAN to CPU_BIG_ENDIAN

From: Corentin Labbe <[email protected]>

commit 2e6522c565522a2e18409c315c49d78c8b74807b upstream.

MIPS_GENERIC selects some options conditional on BIG_ENDIAN which does not exist.

Replace BIG_ENDIAN with CPU_BIG_ENDIAN which is the correct kconfig name. Note that BMIPS_GENERIC does the same which confirms that this patch is needed.

Fixes eed0eabd12ef0 ("MIPS: generic: Introduce generic DT-based board support")
Cc Ralf Baechle <[email protected]>
Cc <[email protected]> # 4.9+

Patchwork: https://patchwork.linux-mips.org/patch/18495/

---
 arch/mips/Kconfig |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
arch/mips/Kconfig +6 -6
@@ -119,12 +119,12 @@ config MIPS_GENERIC
 	select SYS_SUPPORTS_MULTITHREADING
 	select SYS_SUPPORTS_RELOCATABLE
 	select SYS_SUPPORTS_SMARTMIPS
-	select USB_EHCI_BIG_ENDIAN_DESC if BIG_ENDIAN
-	select USB_EHCI_BIG_ENDIAN_MMIO if BIG_ENDIAN
-	select USB_OHCI_BIG_ENDIAN_DESC if BIG_ENDIAN
-	select USB_OHCI_BIG_ENDIAN_MMIO if BIG_ENDIAN
-	select USB_UHCI_BIG_ENDIAN_DESC if BIG_ENDIAN
-	select USB_UHCI_BIG_ENDIAN_MMIO if BIG_ENDIAN
+	select USB_EHCI_BIG_ENDIAN_DESC if CPU_BIG_ENDIAN
+	select USB_EHCI_BIG_ENDIAN_MMIO if CPU_BIG_ENDIAN
+	select USB_OHCI_BIG_ENDIAN_DESC if CPU_BIG_ENDIAN
+	select USB_OHCI_BIG_ENDIAN_MMIO if CPU_BIG_ENDIAN
+	select USB_UHCI_BIG_ENDIAN_DESC if CPU_BIG_ENDIAN
+	select USB_UHCI_BIG_ENDIAN_MMIO if CPU_BIG_ENDIAN
 	select USE_OF
 	help
 	  Select this to build a kernel which aims to support multiple boards,

Patches currently in stable-queue which might be from [email protected] are

queue-4.15/mips-fix-typo-big_endian-to-cpu_big_endian.patch queue-4.15/crypto-sun4i_ss_prng-fix-return-value-of-sun4i_ss_prng_generate.patch

#1 lore raw

Hi Greg,

Quoted 8 lines · On Tue, Feb 20, 2018 at 12:10:06PM +0100, [email protected] wrote:

This is a note to let you know that I've just added the patch titled

MIPS: Fix typo BIG_ENDIAN to CPU_BIG_ENDIAN

to the 4.15-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

Quoted 6 lines

The filename of the patch is:
mips-fix-typo-big_endian-to-cpu_big_endian.patch
and it can be found in the queue-4.15 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

FYI this will introduce the following harmless kconfig warnings which are fixed by commit ec897569ad7d ("usb: Move USB_UHCI_BIG_ENDIAN_* out of USB_SUPPORT"):

warning: (MIPS_GENERIC) selects USB_UHCI_BIG_ENDIAN_MMIO which has unmet direct dependencies (USB_SUPPORT && USB)
warning: (MIPS_GENERIC) selects USB_UHCI_BIG_ENDIAN_DESC which has unmet direct dependencies (USB_SUPPORT && USB)

If anybody cares about such warnings, that patch could be applied also.

Thanks
James

Quoted 60 lines

From 2e6522c565522a2e18409c315c49d78c8b74807b Mon Sep 17 00:00:00 2001
From: Corentin Labbe <[email protected]>
Date: Wed, 17 Jan 2018 19:56:38 +0100
Subject: MIPS: Fix typo BIG_ENDIAN to CPU_BIG_ENDIAN

From: Corentin Labbe <[email protected]>

commit 2e6522c565522a2e18409c315c49d78c8b74807b upstream.

MIPS_GENERIC selects some options conditional on BIG_ENDIAN which does not exist.

Replace BIG_ENDIAN with CPU_BIG_ENDIAN which is the correct kconfig name. Note that BMIPS_GENERIC does the same which confirms that this patch is needed.

Fixes eed0eabd12ef0 ("MIPS: generic: Introduce generic DT-based board support")
Cc Ralf Baechle <[email protected]>
Cc <[email protected]> # 4.9+

Patchwork: https://patchwork.linux-mips.org/patch/18495/

---
 arch/mips/Kconfig |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
arch/mips/Kconfig +6 -6
@@ -119,12 +119,12 @@ config MIPS_GENERIC
 	select SYS_SUPPORTS_MULTITHREADING
 	select SYS_SUPPORTS_RELOCATABLE
 	select SYS_SUPPORTS_SMARTMIPS
-	select USB_EHCI_BIG_ENDIAN_DESC if BIG_ENDIAN
-	select USB_EHCI_BIG_ENDIAN_MMIO if BIG_ENDIAN
-	select USB_OHCI_BIG_ENDIAN_DESC if BIG_ENDIAN
-	select USB_OHCI_BIG_ENDIAN_MMIO if BIG_ENDIAN
-	select USB_UHCI_BIG_ENDIAN_DESC if BIG_ENDIAN
-	select USB_UHCI_BIG_ENDIAN_MMIO if BIG_ENDIAN
+	select USB_EHCI_BIG_ENDIAN_DESC if CPU_BIG_ENDIAN
+	select USB_EHCI_BIG_ENDIAN_MMIO if CPU_BIG_ENDIAN
+	select USB_OHCI_BIG_ENDIAN_DESC if CPU_BIG_ENDIAN
+	select USB_OHCI_BIG_ENDIAN_MMIO if CPU_BIG_ENDIAN
+	select USB_UHCI_BIG_ENDIAN_DESC if CPU_BIG_ENDIAN
+	select USB_UHCI_BIG_ENDIAN_MMIO if CPU_BIG_ENDIAN
 	select USE_OF
 	help
 	  Select this to build a kernel which aims to support multiple boards,

Patches currently in stable-queue which might be from [email protected] are

queue-4.15/mips-fix-typo-big_endian-to-cpu_big_endian.patch queue-4.15/crypto-sun4i_ss_prng-fix-return-value-of-sun4i_ss_prng_generate.patch

author maintainer
#2 lore raw
Quoted 18 lines · James Hogan

Hi Greg,

Quoted 8 lines · On Tue, Feb 20, 2018 at 12:10:06PM +0100, [email protected] wrote:

This is a note to let you know that I've just added the patch titled

MIPS: Fix typo BIG_ENDIAN to CPU_BIG_ENDIAN

to the 4.15-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

Quoted 6 lines

The filename of the patch is:
mips-fix-typo-big_endian-to-cpu_big_endian.patch
and it can be found in the queue-4.15 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 8 lines

FYI this will introduce the following harmless kconfig warnings which are fixed by commit ec897569ad7d ("usb: Move USB_UHCI_BIG_ENDIAN_* out of USB_SUPPORT"):

warning: (MIPS_GENERIC) selects USB_UHCI_BIG_ENDIAN_MMIO which has unmet direct dependencies (USB_SUPPORT && USB)
warning: (MIPS_GENERIC) selects USB_UHCI_BIG_ENDIAN_DESC which has unmet direct dependencies (USB_SUPPORT && USB)

If anybody cares about such warnings, that patch could be applied also.

I'll go queue that up too, thanks.

greg k-h