A "domain invalid" cgroup *can* sometimes have member tasks
Hello Tejun
According to Documentation/cgroup-v2.txt, a "domain invalid" cgroup can't have member tasks. And indeed this is generally not permitted.
However, someone recently showed me a scenario where a "domain invalid" cgroup can have member processes. See the following example:
# mkdir -p /sys/fs/cgroup/unified/grp0/grp1 # sleep 1000 & [1] 10549 # echo 10549 > /sys/fs/cgroup/unified/grp0/grp1/cgroup.procs # echo threaded > /sys/fs/cgroup/unified/grp0/cgroup.type # cat /sys/fs/cgroup/unified/grp0/cgroup.type threaded # cat /sys/fs/cgroup/unified/grp0/grp1/cgroup.type domain invalid # cat /sys/fs/cgroup/unified/grp0/grp1/cgroup.threads 10549
Quoted 1 line
From the above, we see that the cgroup grp0/grp1 is of type "domain
invalid" and has a member thread. This seems to be a violation of the documented rules, and is I assume a bug, since in the above scenario, we are denied from adding further tasks to the grp0/grp1 cgroup:
# sleep 2000 & [2] 10553 # echo 10553 > /sys/fs/cgroup/unified/grp0/grp1/cgroup.procs sh: echo: write error: Operation not supported
Could you comment please?
Thanks,
Michael
Signature · 3 lines
Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/
Tejun Heo
maintainerQuoted 25 lines · Michael Kerrisk (man-pages)
Hello Tejun
According to
Documentation/cgroup-v2.txt, a "domain invalid" cgroup can't have member tasks. And indeed this is generally not permitted.However, someone recently showed me a scenario where a "domain invalid" cgroup can have member processes. See the following example:
# mkdir -p /sys/fs/cgroup/unified/grp0/grp1 # sleep 1000 & [1] 10549 # echo 10549 > /sys/fs/cgroup/unified/grp0/grp1/cgroup.procs # echo threaded > /sys/fs/cgroup/unified/grp0/cgroup.type # cat /sys/fs/cgroup/unified/grp0/cgroup.type threaded # cat /sys/fs/cgroup/unified/grp0/grp1/cgroup.type domain invalid # cat /sys/fs/cgroup/unified/grp0/grp1/cgroup.threads 10549From the above, we see that the cgroup grp0/grp1 is of type "domain invalid" and has a member thread. This seems to be a violation of the documented rules, and is I assume a bug, since in the above scenario, we are denied from adding further tasks to the grp0/grp1 cgroup:
Quoted 6 lines
# sleep 2000 & [2] 10553 # echo 10553 > /sys/fs/cgroup/unified/grp0/grp1/cgroup.procs sh: echo: write error: Operation not supportedCould you comment please?
Hmm... nr_populated_domain_children check should have caught that condition and rejected it. Will look into what's going on.
Thanks.
Signature · 1 line
tejun
Tejun Heo
maintainerQuoted 2 lines · Tejun Heo
Hmm...
nr_populated_domain_childrencheck should have caught that condition and rejected it. Will look into what's going on.
Ah, okay, I was special-casing the first level children case too early. If you nest the test case by one more level, it fails as intended. I'll fix the checks.
Thanks.
Signature · 1 line
tejun
Hi Tehjun,
Quoted 7 lines · Tejun Heo
Quoted 2 lines · Tejun Heo
Hmm...
nr_populated_domain_childrencheck should have caught that condition and rejected it. Will look into what's going on.Ah, okay, I was special-casing the first level children case too early. If you nest the test case by one more level, it fails as intended. I'll fix the checks.
Thanks for looking into this so quickly! Please CC me on the patch.
Cheers,
Michael
Signature · 3 lines
Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/
Tejun Heo
maintainerPATCH 1/1 cgroup: fix rule checking for threaded mode switching
Quoted 1 line
From
d1897c9538edafd4ae6bbd03cc075962ddde2c21Mon Sep 17 00:00:00 2001
From: Tejun Heo <[email protected]>
Date: Wed, 21 Feb 2018 11:39:22 -0800
A domain cgroup isn't allowed to be turned threaded if its subtree is populated or domain controllers are enabled. cgroup_enable_threaded() depended on cgroup_can_be_thread_root() test to enforce this rule. A parent which has populated domain descendants or have domain controllers enabled can't become a thread root, so the above rules are enforced automatically.
However, for the root cgroup which can host mixed domain and threaded children, cgroup_can_be_thread_root() doesn't check any of those conditions and thus first level cgroups ends up escaping those rules.
This patch fixes the bug by adding explicit checks for those rules in cgroup_enable_threaded().
--- kernel/cgroup/cgroup.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
kernel/cgroup/cgroup.c +10 -0
@@ -3183,6 +3183,16 @@ static int cgroup_enable_threaded(struct cgroup *cgrp)if (cgroup_is_threaded (cgrp))return 0 ; +/* +* If @cgroup is populated or has domain controllers enabled, it +* can't be switched. While the below cgroup_can_be_thread_root() +* test can catch the same conditions, that's only when @parent is +* not mixable, so let's check it explicitly. +*/ +if (cgroup_is_populated (cgrp) || + cgrp->subtree_control & ~cgrp_dfl_threaded_ss_mask) +return -EOPNOTSUPP ; +/* we're joining the parent's domain, ensure its validity */ if (!cgroup_is_valid_domain (dom_cgrp) || !cgroup_can_be_thread_root (dom_cgrp))
Signature · 1 line
2.9.5