Skip to contentSkip to conversation

Add ARM system BMC device tree

PATCH In review Ken Chen 2 participants 2 messages Feb 21, 2018 – Feb 22, 2018

Subsystems (3)
lore
Share & tools
lore

Ken Chen

author
#0 lore raw

PATCH v6 1/1 Add ARM system BMC device tree

The Qualcomm Centriq 2400 REP (Reference Evaluation Platorm) is aarch64 Armv8 server platform with an ast2520 BMC.

---
v5->v6
- Modify commit text
- Fix Build fatel error
- Remove PCA9542 and and PAC9641 device
- Rebase to dev-4.13

v4->v5
- Removed strange whitespace
- Removed aspeed.c commit
- Modify commit content

v3->v4
- Modify Makefile for centriq2400-rep dts
- Fix typo label
- Removed unnecessary define of spi2 and centriq2400-spi-hwmon device
- Removed lpc device
- Fix coding style
- Removed ssif device
- Removed max31790 device
- Removed register control of GPIO and Watchdog

---
 arch/arm/boot/dts/Makefile                         |   1 +
 .../boot/dts/aspeed-bmc-arm-centriq2400-rep.dts    | 226 +++++++++++++++++++++
 2 files changed, 227 insertions(+)
 create mode 100644 arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dts
arch/arm/boot/dts/Makefile +1 -0
index 79b0218..5cfee25 100644
@@ -1055,6 +1055,7 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += \
 dtb-$(CONFIG_ARCH_ZX) += zx296702-ad1.dtb
 dtb-$(CONFIG_ARCH_ASPEED) += \
 	aspeed-ast2500-evb.dtb \
+	aspeed-bmc-arm-centriq2400-rep.dtb \
 	aspeed-bmc-intel-s2600wf.dtb \
 	aspeed-bmc-opp-palmetto.dtb \
 	aspeed-bmc-opp-romulus.dtb \
arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dts new file +226 -0

226 lines not on this page · raw message

Signature · 1 line
2.9.3
maintainer
#1 lore raw

Hi Ken,

arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dts line 176

Quoted 8 lines · Ken Chen

+&i2c8 {

arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dts new file +7 -0
+       status = "okay";
+
+       pca9641@70 {
+               compatible = "nxp,pca9641";
+               reg = <0x70>;
+               #address-cells = <1>;
+               #size-cells = <0>;

In order to build cleanly, I had to move the above two lines into the i2c-arb node.

It is important that you compile your patches before submitting them, and that they do not introduce any new warnings to the build.

I have fixed this for you in this case.

Quoted 16 lines
arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dts new file +16 -0
+               i2c-arb {
+                       tmp421@1d {
+                               compatible = "tmp421";
+                               reg = <0x1d>;
+                       };
+                       adm1278@12 {
+                               compatible = "adi,adm1278";
+                               reg = <0x12>;
+                               Rsense = <500>;
+                       };
+                       eeprom@50 {
+                               compatible = "atmel,24c02";
+                               reg = <0x50>;
+                       };
+                       ds1100@58 {
+                               compatible = "ds1100";

arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dts line 217

Quoted 10 lines
arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dts new file +9 -0
+                               reg = <0x58>;
+                       };
+               };
+       };
+};
+
 
+&wdt2 {
+       status = "okay";
+};

This is redundant in dev-4.13.

I've fixed up these minor errors and applied it to dev-4.13. Congratulations for your persistence :)

Cheers,

Joel