Skip to contentSkip to conversation

x86: make x86_init noop functions static

PATCH New Juergen Gross 2 participants 3 messages Feb 21, 2018 – Feb 26, 2018 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86: make x86_init noop functions static

Make the noop functions in x86_init.c static in case they are used locally only.

---
 arch/x86/kernel/x86_init.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
arch/x86/kernel/x86_init.c +5 -5
index 9e4e994a4836..b8cff22a8785 100644
@@ -26,11 +26,11 @@
 
 void x86_init_noop(void) { }
 void __init x86_init_uint_noop(unsigned int unused) { }
-int __init iommu_init_noop(void) { return 0; }
-void iommu_shutdown_noop(void) { }
-bool __init bool_x86_init_noop(void) { return false; }
-void x86_op_int_noop(int cpu) { }
-u64 u64_x86_init_noop(void) { return 0; }
+static int __init iommu_init_noop(void) { return 0; }
+static void iommu_shutdown_noop(void) { }
+static bool __init bool_x86_init_noop(void) { return false; }
+static void x86_op_int_noop(int cpu) { }
+static u64 u64_x86_init_noop(void) { return 0; }
 
 /*
  * The platform setup functions are preset with the default functions
Signature · 1 line
2.13.6
#1 lore raw

[tip:x86/boot] x86/boot: Make the x86_init noop functions static

x86/boot: Make the x86_init noop functions static
Commit-ID:  a504ab7384eea0361e9292681f4a7b9d5010ccf2
Gitweb:     https://git.kernel.org/tip/a504ab7384eea0361e9292681f4a7b9d5010ccf2
Author:     Juergen Gross <[email protected]>
AuthorDate: Wed, 21 Feb 2018 10:42:32 +0100
Committer:  Ingo Molnar <[email protected]>
CommitDate: Wed, 21 Feb 2018 11:22:37 +0100

x86/boot: Make the x86_init noop functions static

Make the noop functions in x86_init.c static in case they are used locally only.

---
 arch/x86/kernel/x86_init.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
arch/x86/kernel/x86_init.c +5 -5
index 9e4e994..b8cff22 100644
@@ -26,11 +26,11 @@
 
 void x86_init_noop(void) { }
 void __init x86_init_uint_noop(unsigned int unused) { }
-int __init iommu_init_noop(void) { return 0; }
-void iommu_shutdown_noop(void) { }
-bool __init bool_x86_init_noop(void) { return false; }
-void x86_op_int_noop(int cpu) { }
-u64 u64_x86_init_noop(void) { return 0; }
+static int __init iommu_init_noop(void) { return 0; }
+static void iommu_shutdown_noop(void) { }
+static bool __init bool_x86_init_noop(void) { return false; }
+static void x86_op_int_noop(int cpu) { }
+static u64 u64_x86_init_noop(void) { return 0; }
 
 /*
  * The platform setup functions are preset with the default functions
#2 lore raw

[tip:x86/mm] x86/boot: Make the x86_init noop functions static

In reply to Juergen Gross
x86/boot: Make the x86_init noop functions static
Commit-ID:  c46dacb75cd59a50a2380dcba5e7edf4fde86845
Gitweb:     https://git.kernel.org/tip/c46dacb75cd59a50a2380dcba5e7edf4fde86845
Author:     Juergen Gross <[email protected]>
AuthorDate: Wed, 21 Feb 2018 10:42:32 +0100
Committer:  Ingo Molnar <[email protected]>
CommitDate: Mon, 26 Feb 2018 08:43:21 +0100

x86/boot: Make the x86_init noop functions static

Make the noop functions in x86_init.c static in case they are used locally only.

---
 arch/x86/kernel/x86_init.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
arch/x86/kernel/x86_init.c +5 -5
index 9e4e994a4836..b8cff22a8785 100644
@@ -26,11 +26,11 @@
 
 void x86_init_noop(void) { }
 void __init x86_init_uint_noop(unsigned int unused) { }
-int __init iommu_init_noop(void) { return 0; }
-void iommu_shutdown_noop(void) { }
-bool __init bool_x86_init_noop(void) { return false; }
-void x86_op_int_noop(int cpu) { }
-u64 u64_x86_init_noop(void) { return 0; }
+static int __init iommu_init_noop(void) { return 0; }
+static void iommu_shutdown_noop(void) { }
+static bool __init bool_x86_init_noop(void) { return false; }
+static void x86_op_int_noop(int cpu) { }
+static u64 u64_x86_init_noop(void) { return 0; }
 
 /*
  * The platform setup functions are preset with the default functions