usb: dwc2: Reduce data buffer size to 16kB
PATCH 1/1 usb: dwc2: Reduce data buffer size to 16kB
If we use hardware with very small RAM (let's consider just a couple of hundreds of kB but not megabytes) it is not super convenient to lose 64kB for statically allocated bufer which most probably won't be used as big as it is. Typically we'll have much shorter data packages to excahnge and in the worst case longer packets will be split on separate transactions.
--- drivers/usb/host/dwc2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/host/dwc2.c +1 -1
@@ -25,7 +25,7 @@ DECLARE_GLOBAL_DATA_PTR;#define DWC2_HC_CHANNEL 0#define DWC2_STATUS_BUF_SIZE 64 -#define DWC2_DATA_BUF_SIZE (64 * 1024) +#define DWC2_DATA_BUF_SIZE (16 * 1024)#define MAX_DEVICE 16#define MAX_ENDPOINT 16
Signature · 1 line
2.14.3
PATCH 1/1 usb: dwc2: Reduce data buffer size to 16kB
Quoted 9 lines
-----Original Message-----
From: U-Boot [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Alexey Brodkin
Sent: Wednesday, February 21, 2018 3:18 PM
To: u-boot at lists.denx.de
Cc: Marek Vasut <[email protected]>; Alexey Brodkin <[email protected]>
Subject: [U-Boot] [PATCH] usb: dwc2: Reduce data buffer size to 16kB
Quoted 5 lines
If we use hardware with very small RAM (let's consider just a couple of hundreds of kB but not megabytes) it is not super convenient to lose 64kB for statically allocated bufer which most probably won't be used as big as it is. Typically we'll have much shorter data packages to excahnge and in the worst case longer packets will be split on separate
s/ excahnge /exchange
Regards
Calvin
PATCH 1/1 usb: dwc2: Reduce data buffer size to 16kB
In reply to Alexey BrodkinQuoted 9 lines · Alexey Brodkin
If we use hardware with very small RAM (let's consider just a couple of hundreds of kB but not megabytes) it is not super convenient to lose 64kB for statically allocated bufer which most probably won't be used as big as it is. Typically we'll have much shorter data packages to excahnge and in the worst case longer packets will be split on separate transactions.
Signed-off-by Alexey Brodkin <[email protected]>Cc Marek Vasut <[email protected]>
I think it does make sense to make this configurable with 64 kiB as default and tweak your platform to 16 kiB in it's defconfig.
Quoted 18 lines
--- drivers/usb/host/dwc2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/usb/host/dwc2.c +1
-1@@ -25,7 +25,7 @@ DECLARE_GLOBAL_DATA_PTR;#define DWC2_HC_CHANNEL 0#define DWC2_STATUS_BUF_SIZE 64 -#define DWC2_DATA_BUF_SIZE (64 * 1024) +#define DWC2_DATA_BUF_SIZE (16 * 1024)#define MAX_DEVICE 16#define MAX_ENDPOINT 16
Signature · 2 lines
Best regards, Marek Vasut