4.15.5-stable review
Subsystems (7)
Greg Kroah-Hartman
maintainercover 4.15.5-stable review
This is the start of the stable review cycle for the 4.15.5 release. There are 163 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Fri Feb 23 12:44:46 UTC 2018. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.15.5-rc1.gz
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.15.y
and the diffstat can be found below.
thanks,
greg k-h
-------------
Pseudo-Shortlog of commits:
Greg Kroah-Hartman <[email protected]>
Linux 4.15.5-rc1
yinbo.zhu <[email protected]>
mmc: sdhci-of-esdhc: fix the mmc error after sleep on ls1046ardb
yinbo.zhu <[email protected]>
mmc: sdhci-of-esdhc: fix eMMC couldn't work after kexec
Arnd Bergmann <[email protected]>
media: r820t: fix r820t_write_reg for KASAN
Linus Walleij <[email protected]>
ARM: dts: Delete bogus reference to the charlcd
Matthias Brugger <[email protected]>
arm: dts: mt2701: Add reset-cells
Matthias Brugger <[email protected]>
arm: dts: mt7623: Update ethsys binding
Arnd Bergmann <[email protected]>
ARM: dts: s5pv210: add interrupt-parent for ohci
Bjorn Andersson <[email protected]>
arm64: dts: msm8916: Add missing #phy-cells
Arnd Bergmann <[email protected]>
ARM: pxa/tosa-bt: add MODULE_LICENSE tag
Arnd Bergmann <[email protected]>
ARM: dts: exynos: fix RTC interrupt for exynos5410
Tony Luck <[email protected]>
x86/mm, mm/hwpoison: Don't unconditionally unmap kernel 1:1 pages
James Hogan <[email protected]>
usb: Move USB_UHCI_BIG_ENDIAN_* out of USB_SUPPORT
Mikulas Patocka <[email protected]>
mvpp2: fix multicast address filter
Takashi Iwai <[email protected]>
ALSA: seq: Fix racy pool initializations
Daniel Mack <[email protected]>
ALSA: usb: add more device quirks for USB DSD devices
Lassi Ylikojola <[email protected]>
ALSA: usb-audio: add implicit fb quirk for Behringer UFX1204
Jan-Marek Glogowski <[email protected]>
ALSA: hda/realtek: PCI quirk for Fujitsu U7x7
Kailang Yang <[email protected]>
ALSA: hda/realtek - Enable Thinkpad Dock device for ALC298 platform
Kailang Yang <[email protected]>
ALSA: hda/realtek - Add headset mode support for Dell laptop
Kirill Marinushkin <[email protected]>
ALSA: usb-audio: Fix UAC2 get_ctl request with a RANGE attribute
Hui Wang <[email protected]>
ALSA: hda - Fix headset mic detection problem for two Dell machines
Stefan Agner <[email protected]>
mtd: nand: vf610: set correct ooblayout
Greg Kurz <[email protected]>
9p/trans_virtio: discard zero-length reply
Liu Bo <[email protected]>
Btrfs: fix unexpected -EEXIST when creating new inode
Liu Bo <[email protected]>
Btrfs: fix use-after-free on root->orphan_block_rsv
Liu Bo <[email protected]>
Btrfs: fix btrfs_evict_inode to handle abnormal inodes correctly
Liu Bo <[email protected]>
Btrfs: fix extent state leak from tree log
Liu Bo <[email protected]>
Btrfs: fix crash due to not cleaning up tree log block's dirty bits
Liu Bo <[email protected]>
Btrfs: fix deadlock in run_delalloc_nocow
NeilBrown <[email protected]>
dm: correctly handle chained bios in dec_pending()
Florian Westphal <[email protected]>
iscsi-target: make sure to wake up sleeping login worker
David Disseldorp <[email protected]>
target/iscsi: avoid NULL dereference in CHAP auth error path
Jens Axboe <[email protected]>
blk-wbt: account flush requests correctly
Chuck Lever <[email protected]>
xprtrdma: Fix BUG after a device removal
Chuck Lever <[email protected]>
xprtrdma: Fix calculation of ri_max_send_sges
Will Deacon <[email protected]>
arm64: proc: Set PTE_NG for table entries to avoid traversing them twice
Larry Finger <[email protected]>
rtlwifi: rtl8821ae: Fix connection lost problem correctly
Dan Williams <[email protected]>
mpls, nospec: Sanitize array index in mpls_label_ok()
Steven Rostedt (VMware) <[email protected]>
tracing: Fix parsing of globs with a wildcard at the beginning
Miklos Szeredi <[email protected]>
seq_file: fix incomplete reset on read from zero offset
Joao Martins <[email protected]>
xenbus: track caller request id
Simon Gaiser <[email protected]>
xen: Fix {set,clear}_foreign_p2m_mapping on autotranslating guests
Ilya Dryomov <[email protected]>
rbd: whitelist RBD_FEATURE_OPERATIONS feature bit
Nicolas Pitre <[email protected]>
console/dummy: leave .con_font_get set to NULL
Johan Hovold <[email protected]>
video: fbdev: atmel_lcdfb: fix display-timings lookup
Johan Hovold <[email protected]>
PCI: keystone: Fix interrupt-controller-node lookup
Lukas Wunner <[email protected]>
PCI: pciehp: Assume NoCompl+ for Thunderbolt ports
Ray Jui <[email protected]>
PCI: iproc: Fix NULL pointer dereference for BCMA
Dongdong Liu <[email protected]>
PCI: Disable MSI for HiSilicon Hip06/Hip07 only in Root Port mode
Marcin Nowakowski <[email protected]>
MIPS: Fix incorrect mem=X@Y handling
James Hogan <[email protected]>
MIPS: CPS: Fix MIPS_ISA_LEVEL_RAW fallout
Corentin Labbe <[email protected]>
MIPS: Fix typo BIG_ENDIAN to CPU_BIG_ENDIAN
Jan H. Schönherr <[email protected]>
mm: Fix memory size alignment in devm_memremap_pages_release()
Arnd Bergmann <[email protected]>
mm: hide a #warning for COMPILE_TEST
Ernesto A. Fernández <[email protected]>
ext4: correct documentation for grpid mount option
Zhouyi Zhou <[email protected]>
ext4: save error to disk in __ext4_grp_locked_error()
Harshad Shirwadkar <[email protected]>
ext4: fix a race in the ext4 shutdown path
Tobin C. Harding <[email protected]>
jbd2: fix sphinx kernel-doc build warnings
Lukas Wunner <[email protected]>
Revert "apple-gmux: lock iGP IO to protect from vgaarb changes"
Sagi Grimberg <[email protected]>
mlx5: fix mlx5_get_vector_affinity to start from completion vector 0
Jerome Brunet <[email protected]>
Revert "mmc: meson-gx: include tx phase in the tuning process"
Phil Elwell <[email protected]>
mmc: bcm2835: Don't overwrite max frequency unconditionally
Linus Walleij <[email protected]>
mmc: sdhci: Implement an SDHCI-specific bounce buffer
Alexander Potapenko <[email protected]>
mbcache: initialize entry->e_referenced in mb_cache_entry_create()
Stewart Smith <[email protected]>
rtc-opal: Fix handling of firmware error codes, prevent busy loops
Masayoshi Mizuma <[email protected]>
x86/smpboot: Fix uncore_pci_remove() indexing bug when hot-removing a physical CPU
Julia Lawall <[email protected]>
drm/radeon: adjust tested variable
Alex Deucher <[email protected]>
drm/radeon: Add dpm quirk for Jet PRO (v2)
Shanker Donthineni <[email protected]>
arm64: Add missing Falkor part number for branch predictor hardening
Keith Packard <[email protected]>
drm: Check for lessee in DROP_MASTER ioctl
Daniel Vetter <[email protected]>
drm/ast: Load lut in crtc_commit
Andrey Grodzovsky <[email protected]>
drm/amd/powerplay: Fix smu_table_entry.handle type
Ray Strode <[email protected]>
drm/qxl: reapply cursor after resetting primary
Ray Strode <[email protected]>
drm/qxl: unref cursor bo when finished with it
Tom St Denis <[email protected]>
drm/ttm: Fix 'buf' pointer update in ttm_bo_vm_access_kmap() (v2)
Felix Kuehling <[email protected]>
drm/ttm: Don't add swapped BOs to swap-LRU list
Ingo Molnar <[email protected]>
x86/entry/64: Fix CR3 restore in paranoid_exit()
Gustavo A. R. Silva <[email protected]>
x86/cpu: Change type of x86_cache_size variable to unsigned int
Dan Carpenter <[email protected]>
x86/spectre: Fix an error message
Jia Zhang <[email protected]>
x86/cpu: Rename cpu_data.x86_mask to cpu_data.x86_stepping
Rui Wang <[email protected]>
selftests/x86/mpx: Fix incorrect bounds with old _sigfault
Andy Lutomirski <[email protected]>
x86/mm: Rename flush_tlb_single() and flush_tlb_one() to __flush_tlb_one_[user|kernel]()
Peter Zijlstra <[email protected]>
x86/speculation: Add <asm/msr-index.h> dependency
Will Deacon <[email protected]>
nospec: Move array_index_nospec() parameter checking into separate macro
Dan Williams <[email protected]>
x86/speculation: Fix up array_index_nospec_mask() asm constraint
Peter Zijlstra <[email protected]>
x86/debug: Use UD2 for WARN()
Josh Poimboeuf <[email protected]>
x86/debug, objtool: Annotate WARN()-related UD2 as reachable
Josh Poimboeuf <[email protected]>
objtool: Fix segfault in ignore_unreachable_insn()
Dominik Brodowski <[email protected]>
selftests/x86: Disable tests requiring 32-bit support on pure 64-bit systems
Dominik Brodowski <[email protected]>
selftests/x86: Do not rely on "int $0x80" in single_step_syscall.c
Andreas Gruenbacher <[email protected]>
gfs2: Fixes to "Implement iomap for block_map"
Dominik Brodowski <[email protected]>
selftests/x86: Do not rely on "int $0x80" in test_mremap_vdso.c
Dominik Brodowski <[email protected]>
selftests/x86: Fix build bug caused by the 5lvl test which has been moved to the VM directory
Ingo Molnar <[email protected]>
selftests/x86/pkeys: Remove unused functions
Dominik Brodowski <[email protected]>
selftests/x86: Clean up and document sscanf() usage
Dominik Brodowski <[email protected]>
selftests/x86: Fix vDSO selftest segfault for vsyscall=none
Borislav Petkov <[email protected]>
x86/entry/64: Remove the unused 'icebp' macro
Josh Poimboeuf <[email protected]>
x86/entry/64: Fix paranoid_entry() frame pointer warning
Dominik Brodowski <[email protected]>
x86/entry/64: Indent PUSH_AND_CLEAR_REGS and POP_REGS properly
Dominik Brodowski <[email protected]>
x86/entry/64: Get rid of the ALLOC_PT_GPREGS_ON_STACK and SAVE_AND_CLEAR_REGS macros
Dominik Brodowski <[email protected]>
x86/entry/64: Use PUSH_AND_CLEAN_REGS in more cases
Dominik Brodowski <[email protected]>
x86/entry/64: Introduce the PUSH_AND_CLEAN_REGS macro
Dominik Brodowski <[email protected]>
x86/entry/64: Interleave XOR register clearing with PUSH instructions
Dominik Brodowski <[email protected]>
x86/entry/64: Merge the POP_C_REGS and POP_EXTRA_REGS macros into a single POP_REGS macro
Dominik Brodowski <[email protected]>
x86/entry/64: Merge SAVE_C_REGS and SAVE_EXTRA_REGS, remove unused extensions
Dan Williams <[email protected]>
x86/entry/64: Clear registers for exceptions/interrupts, to reduce speculation attack surface
Andrey Ryabinin <[email protected]>
platform/x86: wmi: fix off-by-one write in wmi_dev_probe()
Rafael J. Wysocki <[email protected]>
PM: cpuidle: Fix cpuidle_poll_state_init() prototype
Lukas Wunner <[email protected]>
PM / runtime: Update links_count also if !CONFIG_SRCU
Ingo Molnar <[email protected]>
x86/speculation: Clean up various Spectre related details
KarimAllah Ahmed <[email protected]>
KVM/nVMX: Set the CPU_BASED_USE_MSR_BITMAPS if we have a valid L02 MSR bitmap
KarimAllah Ahmed <[email protected]>
X86/nVMX: Properly set spec_ctrl and pred_cmd before merging MSRs
David Woodhouse <[email protected]>
KVM/x86: Reduce retpoline performance impact in slot_handle_level_range(), by always inlining iterator helper methods
David Woodhouse <[email protected]>
Revert "x86/speculation: Simplify indirect_branch_prediction_barrier()"
David Woodhouse <[email protected]>
x86/speculation: Correct Speculation Control microcode blacklist again
David Woodhouse <[email protected]>
x86/speculation: Update Speculation Control microcode blacklist
Nadav Amit <[email protected]>
x86/mm/pti: Fix PTI comment in entry_SYSCALL_64()
Balbir Singh <[email protected]>
powerpc/mm/radix: Split linear mapping on hot-unplug
Artem Savkov <[email protected]>
crypto: sun4i_ss_prng - convert lock to _bh in sun4i_ss_prng_generate
Artem Savkov <[email protected]>
crypto: sun4i_ss_prng - fix return value of sun4i_ss_prng_generate
Geert Uytterhoeven <[email protected]>
compiler-gcc.h: __nostackprotector needs gcc-4.4 and up
Geert Uytterhoeven <[email protected]>
compiler-gcc.h: Introduce __optimize function attribute
Dan Williams <[email protected]>
x86/entry/64/compat: Clear registers for compat syscalls, to reduce speculation attack surface
Dan Williams <[email protected]>
x86/entry/64: Clear extra registers beyond syscall arguments, to reduce speculation attack surface
Michal Hocko <[email protected]>
mm, memory_hotplug: fix memmap initialization
Rafael J. Wysocki <[email protected]>
x86: PM: Make APM idle driver initialize polling state
Juergen Gross <[email protected]>
x86/xen: init %gs very early to avoid page faults with stack protector
Kirill A. Shutemov <[email protected]>
x86/kexec: Make kexec (mostly) work in 5-level paging mode
Lucas De Marchi <[email protected]>
x86/gpu: add CFL to early quirks
Viresh Kumar <[email protected]>
arm: spear13xx: Fix spics gpio controller's warning
Viresh Kumar <[email protected]>
arm: spear13xx: Fix dmas cells
Viresh Kumar <[email protected]>
arm: spear600: Add missing interrupt-parent of rtc
Sean Wang <[email protected]>
arm: dts: mt7623: fix card detection issue on bananapi-r2
Arnd Bergmann <[email protected]>
ARM: dts: nomadik: add interrupt-parent for clcd
Patrice Chotard <[email protected]>
ARM: dts: STi: Add gpio polarity for "hdmi,hpd-gpio" property
Arnd Bergmann <[email protected]>
ARM: lpc3250: fix uda1380 gpio numbers
Bjorn Andersson <[email protected]>
arm64: dts: msm8916: Correct ipc references for smsm
Eugene Syromiatnikov <[email protected]>
s390: fix handling of -1 in set{,fs}[gu]id16 syscalls
Christian König <[email protected]>
dma-buf: fix reservation_object_wait_timeout_rcu once more v2
Cédric Le Goater <[email protected]>
powerpc/xive: Use hw CPU ids when configuring the CPU queues
Alexey Kardashevskiy <[email protected]>
powerpc/mm: Flush radix process translations when setting MMU type
Nathan Fontenot <[email protected]>
powerpc/numa: Invalidate numa_cpu_lookup_table on cpu remove
Nicholas Piggin <[email protected]>
powerpc/vas: Don't set uses_vas for kernel windows
Sukadev Bhattiprolu <[email protected]>
powerpc/kernel: Block interrupts when updating TIDR
Mahesh Salgaonkar <[email protected]>
powerpc/radix: Remove trace_tlbie call from radix__flush_tlb_all
Ravi Bangoria <[email protected]>
trace_uprobe: Display correct offset in uprobe_events
Gang He <[email protected]>
ocfs2: try a blocking lock before return AOP_TRUNCATED_PAGE
Brian Norris <[email protected]>
mwifiex: resolve reset vs. remove()/shutdown() deadlocks
Bjorn Andersson <[email protected]>
PM / devfreq: Propagate error from devfreq_add_device()
Christian König <[email protected]>
swiotlb: suppress warning when __GFP_NOWARN is set
Shilpasri G Bhat <[email protected]>
cpufreq: powernv: Dont assume distinct pstate values for nominal and pmin
Bart Van Assche <[email protected]>
RDMA/rxe: Fix rxe_qp_cleanup()
Bart Van Assche <[email protected]>
RDMA/rxe: Fix a race condition in rxe_requester()
Bart Van Assche <[email protected]>
RDMA/rxe: Fix a race condition related to the QP error state
Arnd Bergmann <[email protected]>
kselftest: fix OOM in memory compaction test
Anders Roxell <[email protected]>
selftests: seccomp: fix compile error seccomp_bpf
Michael J. Ruhl <[email protected]>
IB/core: Avoid a potential OOPs for an unused optional parameter
Bodong Wang <[email protected]>
IB/core: Fix ib_wc structure size to remain in 64 bytes boundary
Bart Van Assche <[email protected]>
IB/core: Fix two kernel warnings triggered by rxe registration
Jack Morgenstein <[email protected]>
IB/mlx4: Fix incorrectly releasing steerable UD QPs when have only ETH ports
Mike Marciniszyn <[email protected]>
IB/qib: Fix comparison error with qperf compare/swap test
Jack Morgenstein <[email protected]>
IB/umad: Fix use of unprotected device pointer
Steffen Weber <[email protected]>
scsi: smartpqi: allow static build ("built-in")
-------------
Diffstat:
Documentation/devicetree/bindings/dma/snps-dma.txt | 2 +- Documentation/filesystems/ext4.txt | 2 +- Makefile | 4 +- arch/arm/boot/dts/arm-realview-eb-mp.dtsi | 5 - arch/arm/boot/dts/exynos5410.dtsi | 1 - arch/arm/boot/dts/lpc3250-ea3250.dts | 4 +- arch/arm/boot/dts/lpc3250-phy3250.dts | 4 +- arch/arm/boot/dts/mt2701.dtsi | 2 + arch/arm/boot/dts/mt7623.dtsi | 1 + arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 2 +- arch/arm/boot/dts/s5pv210.dtsi | 1 + arch/arm/boot/dts/spear1310-evb.dts | 2 +- arch/arm/boot/dts/spear1340.dtsi | 4 +- arch/arm/boot/dts/spear13xx.dtsi | 6 +- arch/arm/boot/dts/spear600.dtsi | 1 + arch/arm/boot/dts/ste-nomadik-stn8815.dtsi | 1 + arch/arm/boot/dts/stih407.dtsi | 3 +- arch/arm/boot/dts/stih410.dtsi | 3 +- arch/arm/mach-pxa/tosa-bt.c | 4 + arch/arm64/boot/dts/qcom/msm8916.dtsi | 5 +- arch/arm64/kernel/cpu_errata.c | 9 + arch/arm64/kvm/hyp/switch.c | 4 +- arch/arm64/mm/proc.S | 14 +- arch/mips/Kconfig | 12 +- arch/mips/kernel/cps-vec.S | 17 +- arch/mips/kernel/setup.c | 16 +- arch/powerpc/include/asm/topology.h | 5 + arch/powerpc/kernel/process.c | 15 +- arch/powerpc/mm/numa.c | 5 - arch/powerpc/mm/pgtable-radix.c | 95 ++++- arch/powerpc/mm/pgtable_64.c | 2 + arch/powerpc/mm/tlb-radix.c | 2 - arch/powerpc/platforms/powernv/vas-window.c | 16 +- arch/powerpc/platforms/pseries/hotplug-cpu.c | 2 + arch/powerpc/sysdev/xive/spapr.c | 16 +- arch/s390/kernel/compat_linux.c | 8 +- arch/x86/entry/calling.h | 107 +++-- arch/x86/entry/entry_64.S | 92 +---- arch/x86/entry/entry_64_compat.S | 30 ++ arch/x86/events/intel/core.c | 2 +- arch/x86/events/intel/lbr.c | 2 +- arch/x86/events/intel/p6.c | 2 +- arch/x86/include/asm/acpi.h | 2 +- arch/x86/include/asm/barrier.h | 2 +- arch/x86/include/asm/bug.h | 19 +- arch/x86/include/asm/nospec-branch.h | 14 +- arch/x86/include/asm/page_64.h | 4 - arch/x86/include/asm/paravirt.h | 4 +- arch/x86/include/asm/paravirt_types.h | 2 +- arch/x86/include/asm/pgtable_32.h | 2 +- arch/x86/include/asm/processor.h | 7 +- arch/x86/include/asm/tlbflush.h | 27 +- arch/x86/kernel/amd_nb.c | 2 +- arch/x86/kernel/apic/apic.c | 6 +- arch/x86/kernel/apm_32.c | 1 + arch/x86/kernel/asm-offsets_32.c | 2 +- arch/x86/kernel/cpu/amd.c | 28 +- arch/x86/kernel/cpu/bugs.c | 34 +- arch/x86/kernel/cpu/centaur.c | 4 +- arch/x86/kernel/cpu/common.c | 10 +- arch/x86/kernel/cpu/cyrix.c | 2 +- arch/x86/kernel/cpu/intel.c | 31 +- arch/x86/kernel/cpu/intel_rdt.c | 2 +- arch/x86/kernel/cpu/mcheck/mce-internal.h | 15 + arch/x86/kernel/cpu/mcheck/mce.c | 17 +- arch/x86/kernel/cpu/microcode/intel.c | 6 +- arch/x86/kernel/cpu/mtrr/generic.c | 2 +- arch/x86/kernel/cpu/mtrr/main.c | 4 +- arch/x86/kernel/cpu/proc.c | 8 +- arch/x86/kernel/early-quirks.c | 1 + arch/x86/kernel/head_32.S | 4 +- arch/x86/kernel/mpparse.c | 2 +- arch/x86/kernel/paravirt.c | 6 +- arch/x86/kernel/relocate_kernel_64.S | 8 + arch/x86/kernel/smpboot.c | 1 - arch/x86/kernel/traps.c | 2 +- arch/x86/kvm/mmu.c | 10 +- arch/x86/kvm/vmx.c | 7 +- arch/x86/lib/cpu.c | 2 +- arch/x86/mm/init_64.c | 2 +- arch/x86/mm/ioremap.c | 2 +- arch/x86/mm/kmmio.c | 2 +- arch/x86/mm/pgtable_32.c | 2 +- arch/x86/mm/tlb.c | 6 +- arch/x86/platform/uv/tlb_uv.c | 2 +- arch/x86/xen/mmu_pv.c | 6 +- arch/x86/xen/p2m.c | 6 + arch/x86/xen/xen-head.S | 16 + block/blk-wbt.c | 10 +- drivers/base/core.c | 3 + drivers/block/rbd.c | 4 +- drivers/char/hw_random/via-rng.c | 2 +- drivers/cpufreq/acpi-cpufreq.c | 2 +- drivers/cpufreq/longhaul.c | 6 +- drivers/cpufreq/p4-clockmod.c | 2 +- drivers/cpufreq/powernow-k7.c | 2 +- drivers/cpufreq/powernv-cpufreq.c | 4 +- drivers/cpufreq/speedstep-centrino.c | 4 +- drivers/cpufreq/speedstep-lib.c | 6 +- drivers/crypto/padlock-aes.c | 2 +- drivers/crypto/sunxi-ss/sun4i-ss-prng.c | 6 +- drivers/devfreq/devfreq.c | 2 +- drivers/dma-buf/reservation.c | 8 +- drivers/edac/amd64_edac.c | 2 +- drivers/gpu/drm/amd/powerplay/smumgr/rv_smumgr.h | 2 +- drivers/gpu/drm/ast/ast_mode.c | 1 + drivers/gpu/drm/drm_auth.c | 6 + drivers/gpu/drm/qxl/qxl_display.c | 63 ++- drivers/gpu/drm/qxl/qxl_drv.h | 2 + drivers/gpu/drm/radeon/radeon_uvd.c | 2 +- drivers/gpu/drm/radeon/si_dpm.c | 5 + drivers/gpu/drm/ttm/ttm_bo.c | 3 +- drivers/gpu/drm/ttm/ttm_bo_vm.c | 3 +- drivers/hwmon/coretemp.c | 6 +- drivers/hwmon/hwmon-vid.c | 2 +- drivers/hwmon/k10temp.c | 2 +- drivers/hwmon/k8temp.c | 2 +- drivers/infiniband/core/device.c | 20 +- drivers/infiniband/core/sysfs.c | 1 - drivers/infiniband/core/user_mad.c | 2 +- drivers/infiniband/core/uverbs_std_types.c | 2 +- drivers/infiniband/hw/mlx4/main.c | 13 +- drivers/infiniband/hw/qib/qib_rc.c | 6 +- drivers/infiniband/sw/rxe/rxe_loc.h | 1 - drivers/infiniband/sw/rxe/rxe_qp.c | 12 +- drivers/infiniband/sw/rxe/rxe_req.c | 9 +- drivers/infiniband/sw/rxe/rxe_resp.c | 2 +- drivers/infiniband/sw/rxe/rxe_verbs.c | 2 + drivers/infiniband/sw/rxe/rxe_verbs.h | 3 + drivers/md/dm.c | 3 +- drivers/media/tuners/r820t.c | 13 +- drivers/mmc/host/bcm2835.c | 3 +- drivers/mmc/host/meson-gx-mmc.c | 19 +- drivers/mmc/host/sdhci-of-esdhc.c | 8 + drivers/mmc/host/sdhci.c | 164 +++++++- drivers/mmc/host/sdhci.h | 3 + drivers/mtd/nand/vf610_nfc.c | 6 +- drivers/net/ethernet/marvell/mvpp2.c | 11 +- drivers/net/ethernet/mellanox/mlx4/qp.c | 3 + drivers/net/wireless/marvell/mwifiex/pcie.c | 5 +- .../net/wireless/realtek/rtlwifi/rtl8821ae/hw.c | 5 +- drivers/net/wireless/realtek/rtlwifi/wifi.h | 1 + drivers/pci/dwc/pci-keystone.c | 5 +- drivers/pci/host/pcie-iproc-platform.c | 7 + drivers/pci/host/pcie-iproc.c | 8 +- drivers/pci/host/pcie-iproc.h | 2 + drivers/pci/hotplug/pciehp_hpc.c | 7 + drivers/pci/quirks.c | 2 +- drivers/platform/x86/apple-gmux.c | 48 +-- drivers/platform/x86/wmi.c | 2 +- drivers/rtc/rtc-opal.c | 12 +- drivers/scsi/smartpqi/Makefile | 2 +- drivers/target/iscsi/iscsi_target_auth.c | 3 +- drivers/target/iscsi/iscsi_target_nego.c | 3 + drivers/usb/Kconfig | 8 + drivers/usb/host/Kconfig | 8 - drivers/video/console/dummycon.c | 1 - drivers/video/fbdev/atmel_lcdfb.c | 8 +- drivers/video/fbdev/geode/video_gx.c | 2 +- drivers/xen/xenbus/xenbus.h | 1 + drivers/xen/xenbus/xenbus_comms.c | 1 + drivers/xen/xenbus/xenbus_xs.c | 3 + fs/btrfs/inode.c | 41 +- fs/btrfs/tree-log.c | 32 +- fs/ext4/inode.c | 16 +- fs/ext4/super.c | 1 + fs/gfs2/bmap.c | 43 +- fs/jbd2/transaction.c | 5 +- fs/mbcache.c | 1 + fs/ocfs2/dlmglue.c | 9 + fs/seq_file.c | 5 +- include/drm/i915_pciids.h | 6 + include/linux/compiler-gcc.h | 7 +- include/linux/compiler.h | 4 + include/linux/cpuidle.h | 2 +- include/linux/jbd2.h | 431 +++++++++++++-------- include/linux/mlx5/driver.h | 2 +- include/linux/mm_inline.h | 6 - include/linux/nospec.h | 36 +- include/rdma/ib_verbs.h | 2 +- include/trace/events/xen.h | 2 +- kernel/memremap.c | 3 +- kernel/trace/trace_events_filter.c | 9 +- kernel/trace/trace_uprobe.c | 2 +- lib/swiotlb.c | 15 +- mm/memory-failure.c | 2 - mm/memory.c | 2 +- mm/page_alloc.c | 22 +- net/9p/trans_virtio.c | 3 +- net/mpls/af_mpls.c | 24 +- net/sunrpc/xprtrdma/rpc_rdma.c | 2 +- net/sunrpc/xprtrdma/verbs.c | 8 +- sound/core/seq/seq_clientmgr.c | 8 +- sound/pci/hda/patch_realtek.c | 72 ++++ sound/usb/mixer.c | 18 +- sound/usb/pcm.c | 9 + sound/usb/quirks.c | 7 +- tools/objtool/check.c | 12 +- tools/testing/selftests/seccomp/seccomp_bpf.c | 4 +- tools/testing/selftests/vm/compaction_test.c | 2 + tools/testing/selftests/x86/Makefile | 24 +- tools/testing/selftests/x86/mpx-mini-test.c | 32 +- tools/testing/selftests/x86/protection_keys.c | 28 -- tools/testing/selftests/x86/single_step_syscall.c | 5 +- tools/testing/selftests/x86/test_mremap_vdso.c | 4 + tools/testing/selftests/x86/test_vdso.c | 55 ++- tools/testing/selftests/x86/test_vsyscall.c | 11 +- 207 files changed, 1625 insertions(+), 897 deletions(-)
Greg Kroah-Hartman
maintainerPATCH 1/163 scsi: smartpqi: allow static build ("built-in")
4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Steffen Weber <[email protected]>
commit dc2db1dc5fb9ab3a43b305c2720fee5278dbee2a upstream.
If CONFIG_SCSI_SMARTPQI=y then don't build this driver as a module.
--- drivers/scsi/smartpqi/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/smartpqi/Makefile +1 -1
@@ -1,3 +1,3 @@ ccflags-y += -I. -obj-m += smartpqi.o +obj-$(CONFIG_SCSI_SMARTPQI) += smartpqi.o smartpqi-objs := smartpqi_init.o smartpqi_sis.o smartpqi_sas_transport.o
Greg Kroah-Hartman
maintainerPATCH 2/163 IB/umad: Fix use of unprotected device pointer
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Jack Morgenstein <[email protected]>
commit f23a5350e43c810ca36b26d4ed4ecd9a08686f47 upstream.
The ib_write_umad() is protected by taking the umad file mutex. However, it accesses file->port->ib_dev -- which is protected only by the port's mutex (field file_mutex).
The ib_umad_remove_one() calls ib_umad_kill_port() which sets port->ib_dev to NULL under the port mutex (NOT the file mutex). It then sets the mad agent to "dead" under the umad file mutex.
This is a race condition -- because there is a window where port->ib_dev is NULL, while the agent is not "dead".
As a result, we saw stack traces like:
[16490.678059] BUG: unable to handle kernel NULL pointer dereference at 00000000000000b0 [16490.678246] IP: ib_umad_write+0x29c/0xa3a [ib_umad] [16490.678333] PGD 0 P4D 0 [16490.678404] Oops: 0000 [#1] SMP PTI [16490.678466] Modules linked in: rdma_ucm(OE) ib_ucm(OE) rdma_cm(OE) iw_cm(OE) ib_ipoib(OE) ib_cm(OE) ib_uverbs(OE) ib_umad(OE) mlx4_en(OE) ptp pps_core mlx4_ib(OE-) ib_core(OE) mlx4_core(OE) mlx_compat (OE) memtrack(OE) devlink mst_pciconf(OE) mst_pci(OE) netconsole nfsv3 nfs_acl nfs lockd grace fscache cfg80211 rfkill esp6_offload esp6 esp4_offload esp4 sunrpc kvm_intel kvm ppdev parport_pc irqbypass parport joydev i2c_piix4 virtio_balloon cirrus drm_kms_helper ttm drm e1000 serio_raw virtio_pci virtio_ring virtio ata_generic pata_acpi qemu_fw_cfg [last unloaded: mlxfw] [16490.679202] CPU: 4 PID: 3115 Comm: sminfo Tainted: G OE 4.14.13-300.fc27.x86_64 #1 [16490.679339] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Ubuntu-1.8.2-1ubuntu2 04/01/2014 [16490.679477] task: ffff9cf753890000 task.stack: ffffaf70c26b0000 [16490.679571] RIP: 0010:ib_umad_write+0x29c/0xa3a [ib_umad] [16490.679664] RSP: 0018:ffffaf70c26b3d90 EFLAGS: 00010202 [16490.679747] RAX: 0000000000000010 RBX: ffff9cf75610fd80 RCX: 0000000000000000 [16490.679856] RDX: 0000000000000001 RSI: 00007ffdf2bfd714 RDI: ffff9cf6bb2a9c00
In the above trace, ib_umad_write is trying to dereference the NULL file->port->ib_dev pointer.
Fix this by using the agent's device pointer (the device field in struct ib_mad_agent) -- which IS protected by the umad file mutex.
--- drivers/infiniband/core/user_mad.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/infiniband/core/user_mad.c +1 -1
@@ -500,7 +500,7 @@ static ssize_t ib_umad_write(struct file }memset (&ah_attr,0 ,sizeof ah_attr); - ah_attr.type =rdma_ah_find_type (file->port->ib_dev, + ah_attr.type =rdma_ah_find_type (agent->device, file->port->port_num);rdma_ah_set_dlid (&ah_attr,be16_to_cpu (packet->mad.hdr.lid));rdma_ah_set_sl (&ah_attr, packet->mad.hdr.sl);
Greg Kroah-Hartman
maintainerPATCH 3/163 IB/qib: Fix comparison error with qperf compare/swap test
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Mike Marciniszyn <[email protected]>
commit 87b3524cb5058fdc7c2afdb92bdb2e079661ddc4 upstream.
This failure exists with qib:
ver_rc_compare_swap:
mismatch, sequence 2, expected 123456789abcdef, got 0
The request builder was using the incorrect inlines to build the request header resulting in incorrect data in the atomic header.
Fix by using the appropriate inlines to create the request.
--- drivers/infiniband/hw/qib/qib_rc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/infiniband/hw/qib/qib_rc.c +3 -3
@@ -434,13 +434,13 @@ no_flow_control: qp->s_state =OP (COMPARE_SWAP );put_ib_ateth_swap (wqe->atomic_wr.swap, &ohdr->u.atomic_eth); -put_ib_ateth_swap (wqe->atomic_wr.compare_add, - &ohdr->u.atomic_eth); +put_ib_ateth_compare (wqe->atomic_wr.compare_add, + &ohdr->u.atomic_eth); }else { qp->s_state =OP (FETCH_ADD );put_ib_ateth_swap (wqe->atomic_wr.compare_add, &ohdr->u.atomic_eth); -put_ib_ateth_swap (0 , &ohdr->u.atomic_eth); +put_ib_ateth_compare (0 , &ohdr->u.atomic_eth); }put_ib_ateth_vaddr (wqe->atomic_wr.remote_addr, &ohdr->u.atomic_eth);
Greg Kroah-Hartman
maintainerPATCH 4/163 IB/mlx4: Fix incorrectly releasing steerable UD QPs when have only ETH ports
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Jack Morgenstein <[email protected]>
commit 852f6927594d0d3e8632c889b2ab38cbc46476ad upstream.
Allocating steerable UD QPs depends on having at least one IB port, while releasing those QPs does not.
As a result, when there are only ETH ports, the IB (RoCE) driver requests releasing a qp range whose base qp is zero, with qp count zero.
When SR-IOV is enabled, and the VF driver is running on a VM over a hypervisor which treats such qp release calls as errors (rather than NOPs), we see lines in the VM message log like:
mlx4_core 0002:00:02.0: Failed to release qp range base:0 cnt:0
Fix this by adding a check for a zero count in mlx4_release_qp_range() (which thus treats releasing 0 qps as a nop), and eliminating the check for device managed flow steering when releasing steerable UD QPs. (Freeing ib_uc_qpns_bitmap unconditionally is also OK, since it remains NULL when steerable UD QPs are not allocated).
--- drivers/infiniband/hw/mlx4/main.c | 13 +++++-------- drivers/net/ethernet/mellanox/mlx4/qp.c | 3 +++ 2 files changed, 8 insertions(+), 8 deletions(-)
drivers/infiniband/hw/mlx4/main.c +5 -8
@@ -2995,9 +2995,8 @@ err_steer_free_bitmap:kfree (ibdev->ib_uc_qpns_bitmap); err_steer_qp_release: -if (ibdev->steering_support ==MLX4_STEERING_MODE_DEVICE_MANAGED ) -mlx4_qp_release_range (dev, ibdev->steer_qpn_base, - ibdev->steer_qpn_count); +mlx4_qp_release_range (dev, ibdev->steer_qpn_base, + ibdev->steer_qpn_count); err_counter:for (i =0 ; i < ibdev->num_ports; ++i)mlx4_ib_delete_counters_table (ibdev, &ibdev->counters_table[i]);
@@ -3102,11 +3101,9 @@ static void mlx4_ib_remove(struct mlx4_d ibdev->iboe.nb.notifier_call =NULL ; } -if (ibdev->steering_support ==MLX4_STEERING_MODE_DEVICE_MANAGED ) { -mlx4_qp_release_range (dev, ibdev->steer_qpn_base, - ibdev->steer_qpn_count); -kfree (ibdev->ib_uc_qpns_bitmap); - } +mlx4_qp_release_range (dev, ibdev->steer_qpn_base, + ibdev->steer_qpn_count); +kfree (ibdev->ib_uc_qpns_bitmap);iounmap (ibdev->uar_map);for (p =0 ; p < ibdev->num_ports; ++p)
drivers/net/ethernet/mellanox/mlx4/qp.c +3 -0
@@ -287,6 +287,9 @@ void mlx4_qp_release_range(struct mlx4_du64 in_param =0 ;int err; +if (!cnt) +return ; +if (mlx4_is_mfunc (dev)) {set_param_l (&in_param, base_qpn);set_param_h (&in_param, cnt);
Greg Kroah-Hartman
maintainerPATCH 5/163 IB/core: Fix two kernel warnings triggered by rxe registration
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Bart Van Assche <[email protected]>
commit 02ee9da347873699603d9ce0112a80b5dd69dea1 upstream.
Eliminate the WARN_ONs that create following two warnings when registering an rxe device:
WARNING: CPU: 2 PID: 1005 at drivers/infiniband/core/device.c:449 ib_register_device+0x591/0x640 [ib_core] CPU: 2 PID: 1005 Comm: run_tests Not tainted 4.15.0-rc4-dbg+ #2 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.0.0-prebuilt.qemu-project.org 04/01/2014 RIP: 0010:ib_register_device+0x591/0x640 [ib_core] Call Trace: rxe_register_device+0x3c6/0x470 [rdma_rxe] rxe_add+0x543/0x5e0 [rdma_rxe] rxe_net_add+0x37/0xb0 [rdma_rxe] rxe_param_set_add+0x5a/0x120 [rdma_rxe] param_attr_store+0x5e/0xc0 module_attr_store+0x19/0x30 sysfs_kf_write+0x3d/0x50 kernfs_fop_write+0x116/0x1a0 __vfs_write+0x23/0x120 vfs_write+0xbe/0x1b0 SyS_write+0x44/0xa0 entry_SYSCALL_64_fastpath+0x23/0x9a WARNING: CPU: 2 PID: 1005 at drivers/infiniband/core/sysfs.c:1279 ib_device_register_sysfs+0x11d/0x160 [ib_core] CPU: 2 PID: 1005 Comm: run_tests Tainted: G W 4.15.0-rc4-dbg+ #2 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.0.0-prebuilt.qemu-project.org 04/01/2014 RIP: 0010:ib_device_register_sysfs+0x11d/0x160 [ib_core] Call Trace: ib_register_device+0x3f7/0x640 [ib_core] rxe_register_device+0x3c6/0x470 [rdma_rxe] rxe_add+0x543/0x5e0 [rdma_rxe] rxe_net_add+0x37/0xb0 [rdma_rxe] rxe_param_set_add+0x5a/0x120 [rdma_rxe] param_attr_store+0x5e/0xc0 module_attr_store+0x19/0x30 sysfs_kf_write+0x3d/0x50 kernfs_fop_write+0x116/0x1a0 __vfs_write+0x23/0x120 vfs_write+0xbe/0x1b0 SyS_write+0x44/0xa0 entry_SYSCALL_64_fastpath+0x23/0x9a
The code should accept either a parent pointer or a fully specified DMA specification without producing warnings.
--- drivers/infiniband/core/device.c | 20 ++++++++++++++------ drivers/infiniband/core/sysfs.c | 1 - 2 files changed, 14 insertions(+), 7 deletions(-)
drivers/infiniband/core/device.c +14 -6
@@ -462,7 +462,6 @@ int ib_register_device(struct ib_devicestruct ib_udata uhw = {.outlen =0 , .inlen =0 };struct device *parent = device->dev.parent; -WARN_ON_ONCE (!parent);WARN_ON_ONCE (device->dma_device);if (device->dev.dma_ops) {/*
@@ -471,16 +470,25 @@ int ib_register_device(struct ib_device* into device->dev. */ device->dma_device = &device->dev; -if (!device->dev.dma_mask) - device->dev.dma_mask = parent->dma_mask; -if (!device->dev.coherent_dma_mask) - device->dev.coherent_dma_mask = - parent->coherent_dma_mask; +if (!device->dev.dma_mask) { +if (parent) + device->dev.dma_mask = parent->dma_mask; +else +WARN_ON_ONCE (true); + } +if (!device->dev.coherent_dma_mask) { +if (parent) + device->dev.coherent_dma_mask = + parent->coherent_dma_mask; +else +WARN_ON_ONCE (true); + } }else {/* * The caller did not provide custom DMA operations. Use the * DMA mapping operations of the parent device. */ +WARN_ON_ONCE (!parent); device->dma_device = parent; }
drivers/infiniband/core/sysfs.c +0 -1
@@ -1276,7 +1276,6 @@ int ib_device_register_sysfs(struct ib_dint ret;int i; -WARN_ON_ONCE (!device->dev.parent); ret =dev_set_name (class_dev,"%s" , device->name);if (ret)return ret;
Greg Kroah-Hartman
maintainerPATCH 6/163 IB/core: Fix ib_wc structure size to remain in 64 bytes boundary
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Bodong Wang <[email protected]>
commit cd2a6e7d384b043d5d029e39663061cebc949385 upstream.
The change of slid from u16 to u32 results in sizeof(struct ib_wc) cross 64B boundary, which causes more cache misses. This patch rearranges the fields and remain the size to 64B.
Pahole output before this change:
struct ib_wc {
union {
u64 wr_id; /* 8 */
struct ib_cqe * wr_cqe; /* 8 */
}; /* 0 8 */
enum ib_wc_status status; /* 8 4 */
enum ib_wc_opcode opcode; /* 12 4 */
u32 vendor_err; /* 16 4 */
u32 byte_len; /* 20 4 */
struct ib_qp * qp; /* 24 8 */
union {
__be32 imm_data; /* 4 */
u32 invalidate_rkey; /* 4 */
} ex; /* 32 4 */
u32 src_qp; /* 36 4 */
int wc_flags; /* 40 4 */
u16 pkey_index; /* 44 2 */
/* XXX 2 bytes hole, try to pack */
u32 slid; /* 48 4 */
u8 sl; /* 52 1 */
u8 dlid_path_bits; /* 53 1 */
u8 port_num; /* 54 1 */
u8 smac[6]; /* 55 6 */
/* XXX 1 byte hole, try to pack */
u16 vlan_id; /* 62 2 */
/* --- cacheline 1 boundary (64 bytes) --- */
u8 network_hdr_type; /* 64 1 */
/* size: 72, cachelines: 2, members: 17 */ /* sum members: 62, holes: 2, sum holes: 3 */ /* padding: 7 */
/* last cacheline: 8 bytes */
};
Pahole output after this change:
struct ib_wc {
union {
u64 wr_id; /* 8 */
struct ib_cqe * wr_cqe; /* 8 */
}; /* 0 8 */
enum ib_wc_status status; /* 8 4 */
enum ib_wc_opcode opcode; /* 12 4 */
u32 vendor_err; /* 16 4 */
u32 byte_len; /* 20 4 */
struct ib_qp * qp; /* 24 8 */
union {
__be32 imm_data; /* 4 */
u32 invalidate_rkey; /* 4 */
} ex; /* 32 4 */
u32 src_qp; /* 36 4 */
u32 slid; /* 40 4 */
int wc_flags; /* 44 4 */
u16 pkey_index; /* 48 2 */
u8 sl; /* 50 1 */
u8 dlid_path_bits; /* 51 1 */
u8 port_num; /* 52 1 */
u8 smac[6]; /* 53 6 */
/* XXX 1 byte hole, try to pack */
u16 vlan_id; /* 60 2 */
u8 network_hdr_type; /* 62 1 */
/* size: 64, cachelines: 1, members: 17 */ /* sum members: 62, holes: 1, sum holes: 1 */ /* padding: 1 */
};
--- include/rdma/ib_verbs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/rdma/ib_verbs.h +1 -1
@@ -983,9 +983,9 @@ struct ib_wc {u32 invalidate_rkey; } ex;u32 src_qp; +u32 slid;int wc_flags;u16 pkey_index; -u32 slid;u8 sl;u8 dlid_path_bits;u8 port_num;/* valid only for DR SMPs on switches */
Greg Kroah-Hartman
maintainerPATCH 7/163 IB/core: Avoid a potential OOPs for an unused optional parameter
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Michael J. Ruhl <[email protected]>
commit 2ff124d597c2df8696169ce0006fc974c49a4569 upstream.
The ev_file is an optional parameter for CQ creation. If the parameter is not passed, the ev_file pointer will be NULL. Using that pointer to set the cq_context will result in an OOPs.
Verify that ev_file is not NULL before using.
--- drivers/infiniband/core/uverbs_std_types.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/infiniband/core/uverbs_std_types.c +1 -1
@@ -315,7 +315,7 @@ static int uverbs_create_cq_handler(stru cq->uobject = &obj->uobject; cq->comp_handler = ib_uverbs_comp_handler; cq->event_handler = ib_uverbs_cq_event_handler; - cq->cq_context = &ev_file->ev_queue; + cq->cq_context = ev_file ? &ev_file->ev_queue :NULL ; obj->uobject.object = cq; obj->uobject.user_handle = user_handle;atomic_set (&cq->usecnt,0 );
Greg Kroah-Hartman
maintainerPATCH 8/163 selftests: seccomp: fix compile error seccomp_bpf
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Anders Roxell <[email protected]>
commit 912ec316686df352028afb6efec59e47a958a24d upstream.
aarch64-linux-gnu-gcc -Wl,-no-as-needed -Wall
-lpthread seccomp_bpf.c -o seccomp_bpfseccomp_bpf.c: In function 'tracer_ptrace':
seccomp_bpf.c:1720:12: error: '__NR_open' undeclared
(first use in this function)
if (nr == __NR_open)
^~~~~~~~~
seccomp_bpf.c:1720:12: note: each undeclared identifier is reported
only once for each function it appears in
In file included from seccomp_bpf.c:48:0:seccomp_bpf.c: In function 'TRACE_syscall_ptrace_syscall_dropped':
seccomp_bpf.c:1795:39: error: '__NR_open' undeclared
(first use in this function)
EXPECT_SYSCALL_RETURN(EPERM, syscall(__NR_open));
^open(2) is a legacy syscall, replaced with openat(2) since 2.6.16. Thus new architectures in the kernel, such as arm64, don't implement these legacy syscalls.
--- tools/testing/selftests/seccomp/seccomp_bpf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tools/testing/selftests/seccomp/seccomp_bpf.c +2 -2
@@ -1717,7 +1717,7 @@ void tracer_ptrace(struct __test_metadatif (nr == __NR_getpid)change_syscall (_metadata, tracee, __NR_getppid); -if (nr == __NR_open) +if (nr == __NR_openat)change_syscall (_metadata, tracee,-1 ); }
@@ -1792,7 +1792,7 @@ TEST_F(TRACE_syscall, ptrace_syscall_dro true);/* Tracer should skip the open syscall, resulting in EPERM. */ -EXPECT_SYSCALL_RETURN (EPERM ,syscall (__NR_open)); +EXPECT_SYSCALL_RETURN (EPERM ,syscall (__NR_openat)); }TEST_F (TRACE_syscall, syscall_allowed)
Greg Kroah-Hartman
maintainerPATCH 9/163 kselftest: fix OOM in memory compaction test
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Arnd Bergmann <[email protected]>
commit 4c1baad223906943b595a887305f2e8124821dad upstream.
Running the compaction_test sometimes results in out-of-memory failures. When I debugged this, it turned out that the code to reset the number of hugepages to the initial value is simply broken since we write into an open sysctl file descriptor multiple times without seeking back to the start.
Adding the lseek here fixes the problem.
--- tools/testing/selftests/vm/compaction_test.c | 2 ++ 1 file changed, 2 insertions(+)
tools/testing/selftests/vm/compaction_test.c +2 -0
@@ -137,6 +137,8 @@ int check_compaction(unsigned long mem_fprintf ("No of huge pages allocated = %d\n" , (atoi (nr_hugepages))); +lseek (fd,0 ,SEEK_SET ); +if (write (fd, initial_nr_hugepages,strlen (initial_nr_hugepages)) !=strlen (initial_nr_hugepages)) {perror ("Failed to write value to /proc/sys/vm/nr_hugepages\n" );
Greg Kroah-Hartman
maintainerPATCH 10/163 RDMA/rxe: Fix a race condition related to the QP error state
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Bart Van Assche <[email protected]>
commit 6f301e06de4cf9ab7303f5acd43e64fcd4aa04be upstream.
The following sequence:
* Change queue pair state into IB_QPS_ERR.
* Post a work request on the queue pair.
Triggers the following race condition in the rdma_rxe driver:
* rxe_qp_error() triggers an asynchronous call of rxe_completer(), the function that examines the QP send queue.
* rxe_post_send() posts a work request on the QP send queue.
If rxe_completer() runs prior to rxe_post_send(), it will drain the send queue and the driver will assume no further action is necessary. However, once we post the send to the send queue, because the queue is in error, no send completion will ever happen and the send will get stuck. In order to process the send, we need to make sure that rxe_completer() gets run after a send is posted to a queue pair in an error state. This patch ensures that happens.
--- drivers/infiniband/sw/rxe/rxe_verbs.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/infiniband/sw/rxe/rxe_verbs.c +2 -0
@@ -814,6 +814,8 @@ static int rxe_post_send_kernel(struct r (queue_count (qp->sq.queue) >1 );rxe_run_task (&qp->req.task, must_sched); +if (unlikely (qp->req.state ==QP_STATE_ERROR )) +rxe_run_task (&qp->comp.task,1 );return err; }
Greg Kroah-Hartman
maintainerPATCH 11/163 RDMA/rxe: Fix a race condition in rxe_requester()
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Bart Van Assche <[email protected]>
commit 65567e41219888feec72fee1de98ccf1efbbc16d upstream.
The rxe driver works as follows:
* The send queue, receive queue and completion queues are implemented as circular buffers.
* ib_post_send() and ib_post_recv() calls are serialized through a spinlock.
* Removing elements from various queues happens from tasklet context. Tasklets are guaranteed to run on at most one CPU. This serializes access to these queues. See also rxe_completer(), rxe_requester() and rxe_responder().
* rxe_completer() processes the skbs queued onto qp->resp_pkts.
* rxe_requester() handles the send queue (qp->sq.queue).
* rxe_responder() processes the skbs queued onto qp->req_pkts.
Since rxe_drain_req_pkts() processes qp->req_pkts, calling rxe_drain_req_pkts() from rxe_requester() is racy. Hence this patch.
--- drivers/infiniband/sw/rxe/rxe_loc.h | 1 - drivers/infiniband/sw/rxe/rxe_req.c | 9 +-------- drivers/infiniband/sw/rxe/rxe_resp.c | 2 +- 3 files changed, 2 insertions(+), 10 deletions(-)
drivers/infiniband/sw/rxe/rxe_loc.h +0 -1
@@ -237,7 +237,6 @@ int rxe_srq_from_attr(struct rxe_dev *rxvoid rxe_release (struct kref *kref); -void rxe_drain_req_pkts (struct rxe_qp *qp,bool notify);int rxe_completer (void *arg);int rxe_requester (void *arg);int rxe_responder (void *arg);
drivers/infiniband/sw/rxe/rxe_req.c +1 -8
@@ -594,15 +594,8 @@ int rxe_requester(void *arg)rxe_add_ref (qp); next_wqe: -if (unlikely (!qp->valid)) { -rxe_drain_req_pkts (qp, true); +if (unlikely (!qp->valid || qp->req.state ==QP_STATE_ERROR )) goto exit; - } - -if (unlikely (qp->req.state ==QP_STATE_ERROR )) { -rxe_drain_req_pkts (qp, true); - goto exit; - }if (unlikely (qp->req.state ==QP_STATE_RESET )) { qp->req.wqe_index =consumer_index (qp->sq.queue);
drivers/infiniband/sw/rxe/rxe_resp.c +1 -1
@@ -1210,7 +1210,7 @@ static enum resp_states do_class_d1e_err } } -void rxe_drain_req_pkts (struct rxe_qp *qp,bool notify) +static void rxe_drain_req_pkts (struct rxe_qp *qp,bool notify) {struct sk_buff *skb;
Greg Kroah-Hartman
maintainerPATCH 12/163 RDMA/rxe: Fix rxe_qp_cleanup()
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Bart Van Assche <[email protected]>
commit bb3ffb7ad48a21e98a5c64eb21103a74fd9f03f6 upstream.
rxe_qp_cleanup() can sleep so it must be run in thread context and not in atomic context. This patch avoids that the following bug is triggered:
Kernel BUG at 00000000560033f3 [verbose debug info unavailable] BUG: sleeping function called from invalid context at net/core/sock.c:2761 in_atomic(): 1, irqs_disabled(): 0, pid: 7, name: ksoftirqd/0 INFO: lockdep is turned off. Preemption disabled at: [<00000000b6e69628>] __do_softirq+0x4e/0x540 CPU: 0 PID: 7 Comm: ksoftirqd/0 Not tainted 4.15.0-rc7-dbg+ #4 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.0.0-prebuilt.qemu-project.org 04/01/2014 Call Trace: dump_stack+0x85/0xbf ___might_sleep+0x177/0x260 lock_sock_nested+0x1d/0x90 inet_shutdown+0x2e/0xd0 rxe_qp_cleanup+0x107/0x140 [rdma_rxe] rxe_elem_release+0x18/0x80 [rdma_rxe] rxe_requester+0x1cf/0x11b0 [rdma_rxe] rxe_do_task+0x78/0xf0 [rdma_rxe] tasklet_action+0x99/0x270 __do_softirq+0xc0/0x540 run_ksoftirqd+0x1c/0x70 smpboot_thread_fn+0x1be/0x270 kthread+0x117/0x130 ret_from_fork+0x24/0x30
--- drivers/infiniband/sw/rxe/rxe_qp.c | 12 ++++++++++-- drivers/infiniband/sw/rxe/rxe_verbs.h | 3 +++ 2 files changed, 13 insertions(+), 2 deletions(-)
drivers/infiniband/sw/rxe/rxe_qp.c +10 -2
@@ -824,9 +824,9 @@ void rxe_qp_destroy(struct rxe_qp *qp) }/* called when the last reference to the qp is dropped */ -void rxe_qp_cleanup (struct rxe_pool_entry *arg) +static void rxe_qp_do_cleanup (struct work_struct *work) { -struct rxe_qp *qp =container_of (arg,typeof (*qp), pelem); +struct rxe_qp *qp =container_of (work,typeof (*qp), cleanup_work.work);rxe_drop_all_mcast_groups (qp);
@@ -859,3 +859,11 @@ void rxe_qp_cleanup(struct rxe_pool_entrkernel_sock_shutdown (qp->sk,SHUT_RDWR );sock_release (qp->sk); } + +/* called when the last reference to the qp is dropped */ +void rxe_qp_cleanup (struct rxe_pool_entry *arg) +{ +struct rxe_qp *qp =container_of (arg,typeof (*qp), pelem); + +execute_in_process_context (rxe_qp_do_cleanup, &qp->cleanup_work); +}
drivers/infiniband/sw/rxe/rxe_verbs.h +3 -0
@@ -35,6 +35,7 @@#define RXE_VERBS_H #include <linux/interrupt.h> +#include <linux/workqueue.h> #include <rdma/rdma_user_rxe.h> #include "rxe_pool.h" #include "rxe_task.h"
@@ -281,6 +282,8 @@ struct rxe_qp {struct timer_list rnr_nak_timer;spinlock_t state_lock;/* guard requester and completer */ + +struct execute_work cleanup_work; };enum rxe_mem_state {
Greg Kroah-Hartman
maintainerPATCH 13/163 cpufreq: powernv: Dont assume distinct pstate values for nominal and pmin
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Shilpasri G Bhat <[email protected]>
commit 3fa4680b860bf48b437d6a2c039789c4abe202ae upstream.
Some OpenPOWER boxes can have same pstate values for nominal and pmin pstates. In these boxes the current code will not initialize 'powernv_pstate_info.min' variable and result in erroneous CPU frequency reporting. This patch fixes this problem.
--- drivers/cpufreq/powernv-cpufreq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/cpufreq/powernv-cpufreq.c +2 -2
@@ -288,9 +288,9 @@ next:if (id == pstate_max) powernv_pstate_info.max = i; -else if (id == pstate_nominal) +if (id == pstate_nominal) powernv_pstate_info.nominal = i; -else if (id == pstate_min) +if (id == pstate_min) powernv_pstate_info.min = i;if (powernv_pstate_info.wof_enabled && id == pstate_turbo) {
Greg Kroah-Hartman
maintainerPATCH 14/163 swiotlb: suppress warning when __GFP_NOWARN is set
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Christian König <[email protected]>
commit d0bc0c2a31c95002d37c3cc511ffdcab851b3256 upstream.
TTM tries to allocate coherent memory in chunks of 2MB first to improve TLB efficiency and falls back to allocating 4K pages if that fails.
Suppress the warning when the 2MB allocations fails since there is a valid fall back path.
--- lib/swiotlb.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-)
lib/swiotlb.c +9 -6
@@ -586,7 +586,7 @@ phys_addr_t swiotlb_tbl_map_single(struc not_found:spin_unlock_irqrestore (&io_tlb_lock, flags); -if (printk_ratelimit ()) +if (!(attrs &DMA_ATTR_NO_WARN ) &&printk_ratelimit ())dev_warn (hwdev,"swiotlb buffer is full (sz: %zd bytes)\n" , size);return SWIOTLB_MAP_ERROR ; found:
@@ -713,6 +713,7 @@ void * swiotlb_alloc_coherent(struct device *hwdev, size_t size, dma_addr_t *dma_handle, gfp_t flags) { + bool warn = !(flags & __GFP_NOWARN);dma_addr_t dev_addr;void *ret;int order =get_order (size);
@@ -738,8 +739,8 @@ swiotlb_alloc_coherent(struct device *hw* GFP_DMA memory; fall back on map_single(), which * will grab memory from the lowest available address range. */ -phys_addr_t paddr =map_single (hwdev,0 , size, -DMA_FROM_DEVICE ,0 ); +phys_addr_t paddr =map_single (hwdev,0 , size,DMA_FROM_DEVICE , + warn ?0 :DMA_ATTR_NO_WARN );if (paddr ==SWIOTLB_MAP_ERROR ) goto err_warn;
@@ -769,9 +770,11 @@ swiotlb_alloc_coherent(struct device *hwreturn ret; err_warn: -pr_warn ("swiotlb: coherent allocation failed for device %s size=%zu\n" , -dev_name (hwdev), size); -dump_stack (); +if (warn &&printk_ratelimit ()) { +pr_warn ("swiotlb: coherent allocation failed for device %s size=%zu\n" , +dev_name (hwdev), size); +dump_stack (); + }return NULL ; }
Greg Kroah-Hartman
maintainerPATCH 15/163 PM / devfreq: Propagate error from devfreq_add_device()
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Bjorn Andersson <[email protected]>
commit d1bf2d30728f310f72296b54f0651ecdb09cbb12 upstream.
Propagate the error of devfreq_add_device() in devm_devfreq_add_device() rather than statically returning ENOMEM. This makes it slightly faster to pinpoint the cause of a returned error.
--- drivers/devfreq/devfreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/devfreq/devfreq.c +1 -1
@@ -737,7 +737,7 @@ struct devfreq *devm_devfreq_add_device( devfreq =devfreq_add_device (dev, profile, governor_name, data);if (IS_ERR (devfreq)) {devres_free (ptr); -return ERR_PTR (-ENOMEM ); +return devfreq; } *ptr = devfreq;
Greg Kroah-Hartman
maintainerPATCH 16/163 mwifiex: resolve reset vs. remove()/shutdown() deadlocks
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Brian Norris <[email protected]>
commit a64e7a79dd6030479caad603c8d78e6c9c14904f upstream.
Commit b014e96d1abb ("PCI: Protect pci_error_handlers->reset_notify() usage with device_lock()") resolves races between driver reset and removal, but it introduces some new deadlock problems. If we see a timeout while we've already started suspending, removing, or shutting down the driver, we might see:
(a) a worker thread, running mwifiex_pcie_work() ->
mwifiex_pcie_card_reset_work() -> pci_reset_function()
(b) a removal thread, running mwifiex_pcie_remove() ->
mwifiex_free_adapter() -> mwifiex_unregister() ->
mwifiex_cleanup_pcie() -> cancel_work_sync(&card->work)Unfortunately, mwifiex_pcie_remove() already holds the device lock that pci_reset_function() is now requesting, and so we see a deadlock.
It's necessary to cancel and synchronize our outstanding work before tearing down the driver, so we can't have this work wait indefinitely for the lock.
It's reasonable to only "try" to reset here, since this will mostly happen for cases where it's already difficult to reset the firmware anyway (e.g., while we're suspending or powering off the system). And if reset *really* needs to happen, we can always try again later.
--- drivers/net/wireless/marvell/mwifiex/pcie.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/net/wireless/marvell/mwifiex/pcie.c +4 -1
@@ -2781,7 +2781,10 @@ static void mwifiex_pcie_card_reset_work {struct pcie_service_card *card = adapter->card; -pci_reset_function (card->dev); +/* We can't afford to wait here; remove() might be waiting on us. If we +* can't grab the device lock, maybe we'll get another chance later. +*/ +pci_try_reset_function (card->dev); }static void mwifiex_pcie_work (struct work_struct *work)
Greg Kroah-Hartman
maintainerPATCH 17/163 ocfs2: try a blocking lock before return AOP_TRUNCATED_PAGE
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Gang He <[email protected]>
commit ff26cc10aec128c3f86b5611fd5f59c71d49c0e3 upstream.
If we can't get inode lock immediately in the function ocfs2_inode_lock_with_page() when reading a page, we should not return directly here, since this will lead to a softlockup problem when the kernel is configured with CONFIG_PREEMPT is not set. The method is to get a blocking lock and immediately unlock before returning, this can avoid CPU resource waste due to lots of retries, and benefits fairness in getting lock among multiple nodes, increase efficiency in case modifying the same file frequently from multiple nodes.
The softlockup crash (when set /proc/sys/kernel/softlockup_panic to 1) looks like:
Kernel panic - not syncing: softlockup: hung tasks
CPU: 0 PID: 885 Comm: multi_mmap Tainted: G L 4.12.14-6.1-default #1
Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011
Call Trace:
<IRQ>
dump_stack+0x5c/0x82
panic+0xd5/0x21e
watchdog_timer_fn+0x208/0x210
__hrtimer_run_queues+0xcc/0x200
hrtimer_interrupt+0xa6/0x1f0
smp_apic_timer_interrupt+0x34/0x50
apic_timer_interrupt+0x96/0xa0
</IRQ>
RIP: 0010:unlock_page+0x17/0x30
RSP: 0000:ffffaf154080bc88 EFLAGS: 00000246 ORIG_RAX: ffffffffffffff10
RAX: dead000000000100 RBX: fffff21e009f5300 RCX: 0000000000000004
RDX: dead0000000000ff RSI: 0000000000000202 RDI: fffff21e009f5300
RBP: 0000000000000000 R08: 0000000000000000 R09: ffffaf154080bb00
R10: ffffaf154080bc30 R11: 0000000000000040 R12: ffff993749a39518
R13: 0000000000000000 R14: fffff21e009f5300 R15: fffff21e009f5300
ocfs2_inode_lock_with_page+0x25/0x30 [ocfs2]
ocfs2_readpage+0x41/0x2d0 [ocfs2]
filemap_fault+0x12b/0x5c0
ocfs2_fault+0x29/0xb0 [ocfs2]
__do_fault+0x1a/0xa0
__handle_mm_fault+0xbe8/0x1090
handle_mm_fault+0xaa/0x1f0
__do_page_fault+0x235/0x4b0
trace_do_page_fault+0x3c/0x110
async_page_fault+0x28/0x30
RIP: 0033:0x7fa75ded638e
RSP: 002b:00007ffd6657db18 EFLAGS: 00010287
RAX: 000055c7662fb700 RBX: 0000000000000001 RCX: 000055c7662fb700
RDX: 0000000000001770 RSI: 00007fa75e909000 RDI: 000055c7662fb700
RBP: 0000000000000003 R08: 000000000000000e R09: 0000000000000000
R10: 0000000000000483 R11: 00007fa75ded61b0 R12: 00007fa75e90a770
R13: 000000000000000e R14: 0000000000001770 R15: 0000000000000000About performance improvement, we can see the testing time is reduced, and CPU utilization decreases, the detailed data is as follows. I ran multi_mmap test case in ocfs2-test package in a three nodes cluster.
Before applying this patch:
PID USER PR NI VIRT RES SHR S %CPU %MEM TIME+ COMMAND
2754 ocfs2te+ 20 0 170248 6980 4856 D 80.73 0.341 0:18.71 multi_mmap
1505 root rt 0 222236 123060 97224 S 2.658 6.015 0:01.44 corosync
5 root 20 0 0 0 0 S 1.329 0.000 0:00.19 kworker/u8:0
95 root 20 0 0 0 0 S 1.329 0.000 0:00.25 kworker/u8:1
2728 root 20 0 0 0 0 S 0.997 0.000 0:00.24 jbd2/sda1-33
2721 root 20 0 0 0 0 S 0.664 0.000 0:00.07 ocfs2dc-3C8CFD4
2750 ocfs2te+ 20 0 142976 4652 3532 S 0.664 0.227 0:00.28 mpirun ocfs2test@tb-node2:~>multiple_run.sh -i ens3 -k ~/linux-4.4.21-69.tar.gz -o ~/ocfs2mullog -C hacluster -s pcmk -n tb-node2,tb-node1,tb-node3 -d /dev/sda1 -b 4096 -c 32768 -t multi_mmap /mnt/shared Tests with "-b 4096 -C 32768"
Thu Dec 28 14:44:52 CST 2017
multi_mmap..................................................Passed.
Runtime 783 seconds.
After apply this patch:
PID USER PR NI VIRT RES SHR S %CPU %MEM TIME+ COMMAND
2508 ocfs2te+ 20 0 170248 6804 4680 R 54.00 0.333 0:55.37 multi_mmap
155 root 20 0 0 0 0 S 2.667 0.000 0:01.20 kworker/u8:3
95 root 20 0 0 0 0 S 2.000 0.000 0:01.58 kworker/u8:1
2504 ocfs2te+ 20 0 142976 4604 3480 R 1.667 0.225 0:01.65 mpirun
5 root 20 0 0 0 0 S 1.000 0.000 0:01.36 kworker/u8:0
2482 root 20 0 0 0 0 S 1.000 0.000 0:00.86 jbd2/sda1-33
299 root 0 -20 0 0 0 S 0.333 0.000 0:00.13 kworker/2:1H
335 root 0 -20 0 0 0 S 0.333 0.000 0:00.17 kworker/1:1H
535 root 20 0 12140 7268 1456 S 0.333 0.355 0:00.34 haveged
1282 root rt 0 222284 123108 97224 S 0.333 6.017 0:01.33 corosync ocfs2test@tb-node2:~>multiple_run.sh -i ens3 -k ~/linux-4.4.21-69.tar.gz -o ~/ocfs2mullog -C hacluster -s pcmk -n tb-node2,tb-node1,tb-node3 -d /dev/sda1 -b 4096 -c 32768 -t multi_mmap /mnt/shared Tests with "-b 4096 -C 32768"
Thu Dec 28 15:04:12 CST 2017
multi_mmap..................................................Passed.
Runtime 487 seconds.
--- fs/ocfs2/dlmglue.c | 9 +++++++++ 1 file changed, 9 insertions(+)
fs/ocfs2/dlmglue.c +9 -0
@@ -2486,6 +2486,15 @@ int ocfs2_inode_lock_with_page(struct in ret =ocfs2_inode_lock_full (inode, ret_bh, ex,OCFS2_LOCK_NONBLOCK );if (ret == -EAGAIN ) {unlock_page (page); +/* +* If we can't get inode lock immediately, we should not return +* directly here, since this will lead to a softlockup problem. +* The method is to get a blocking lock and immediately unlock +* before returning, this can avoid CPU resource waste due to +* lots of retries, and benefits fairness in getting lock. +*/ +if (ocfs2_inode_lock (inode, ret_bh, ex) ==0 ) +ocfs2_inode_unlock (inode, ex); ret =AOP_TRUNCATED_PAGE ; }
Greg Kroah-Hartman
maintainerPATCH 18/163 trace_uprobe: Display correct offset in uprobe_events
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Ravi Bangoria <[email protected]>
commit 0e4d819d0893dc043ea7b7cb6baf4be1e310bd96 upstream.
Recently, how the pointers being printed with %p has been changed by commit ad67b74d2469 ("printk: hash addresses printed with %p"). This is causing a regression while showing offset in the uprobe_events file. Instead of %p, use %px to display offset.
Before patch:
# perf probe -vv -x /tmp/a.out main Opening /sys/kernel/debug/tracing//uprobe_events write=1 Writing event: p:probe_a/main /tmp/a.out:0x58c
# cat /sys/kernel/debug/tracing/uprobe_events p:probe_a/main /tmp/a.out:0x0000000049a0f352
After patch:
# cat /sys/kernel/debug/tracing/uprobe_events p:probe_a/main /tmp/a.out:0x000000000000058c
--- kernel/trace/trace_uprobe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/trace/trace_uprobe.c +1 -1
@@ -608,7 +608,7 @@ static int probes_seq_show(struct seq_fi/* Don't print "0x (null)" when offset is 0 */ if (tu->offset) { -seq_printf (m,"0x%p" , (void *)tu->offset); +seq_printf (m,"0x%px" , (void *)tu->offset); }else {switch (sizeof (void *)) {case 4 :
Greg Kroah-Hartman
maintainerPATCH 19/163 powerpc/radix: Remove trace_tlbie call from radix__flush_tlb_all
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Mahesh Salgaonkar <[email protected]>
commit 8d81296cfcce89013a714feb8d25004a156f8181 upstream.
radix__flush_tlb_all() is called only in kexec path in real mode and any tracepoints at this stage will make kexec to fail if enabled.
To verify enable tlbie trace before kexec.
$ echo 1 > /sys/kernel/debug/tracing/events/powerpc/tlbie/enable == kexec into new kernel and kexec fails.
Fix this by not calling trace_tlbie from radix__flush_tlb_all().
--- arch/powerpc/mm/tlb-radix.c | 2 -- 1 file changed, 2 deletions(-)
arch/powerpc/mm/tlb-radix.c +0 -2
@@ -600,14 +600,12 @@ void radix__flush_tlb_all(void)*/ asm volatile(PPC_TLBIE_5(%0, %4, %3, %2, %1) : : "r"(rb), "i"(r), "i"(1), "i"(ric), "r"(rs) : "memory"); - trace_tlbie(0 ,0 , rb, rs, ric, prs, r);/* * now flush host entires by passing PRS = 0 and LPID == 0 */ asm volatile(PPC_TLBIE_5(%0, %4, %3, %2, %1) : : "r"(rb), "i"(r), "i"(prs), "i"(ric), "r"(0) : "memory"); asmvolatile ("eieio; tlbsync; ptesync" : : :"memory" ); -trace_tlbie (0 ,0 , rb,0 , ric, prs, r); } void radix__flush_tlb_pte_p9_dd1(unsigned long old_pte, struct mm_struct *mm,
Greg Kroah-Hartman
maintainerPATCH 20/163 powerpc/kernel: Block interrupts when updating TIDR
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Sukadev Bhattiprolu <[email protected]>
commit 384dfd627f1ee67d028e6f14c6e9bf5a1e2a7a24 upstream.
clear_thread_tidr() is called in interrupt context as a part of delayed put of the task structure (i.e as a part of timer interrupt). To prevent a deadlock, block interrupts when holding vas_thread_id_lock to set/ clear TIDR for a task.
--- arch/powerpc/kernel/process.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-)
arch/powerpc/kernel/process.c +9 -6
@@ -1509,14 +1509,15 @@ static int assign_thread_tidr(void) {int index;int err; +unsigned long flags; again:if (!ida_pre_get (&vas_thread_ida,GFP_KERNEL ))return -ENOMEM ; -spin_lock (&vas_thread_id_lock); +spin_lock_irqsave (&vas_thread_id_lock, flags); err =ida_get_new_above (&vas_thread_ida,1 , &index); -spin_unlock (&vas_thread_id_lock); +spin_unlock_irqrestore (&vas_thread_id_lock, flags);if (err == -EAGAIN ) goto again;
@@ -1524,9 +1525,9 @@ again:return err;if (index >MAX_THREAD_CONTEXT ) { -spin_lock (&vas_thread_id_lock); +spin_lock_irqsave (&vas_thread_id_lock, flags);ida_remove (&vas_thread_ida, index); -spin_unlock (&vas_thread_id_lock); +spin_unlock_irqrestore (&vas_thread_id_lock, flags);return -ENOMEM ; }
@@ -1535,9 +1536,11 @@ again:static void free_thread_tidr (int id) { -spin_lock (&vas_thread_id_lock); +unsigned long flags; + +spin_lock_irqsave (&vas_thread_id_lock, flags);ida_remove (&vas_thread_ida, id); -spin_unlock (&vas_thread_id_lock); +spin_unlock_irqrestore (&vas_thread_id_lock, flags); }/*
Greg Kroah-Hartman
maintainerPATCH 21/163 powerpc/vas: Dont set uses_vas for kernel windows
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Nicholas Piggin <[email protected]>
commit b00b62898631b756c3e123542bbb0487aa343dd9 upstream.
cp_abort is only required for user windows, because kernel context must not be preempted between a copy/paste pair.
Without this patch, the init task gets used_vas set when it runs the nx842_powernv_init initcall, which opens windows for kernel usage.
used_vas is then never cleared anywhere, so it gets propagated into all other tasks. It's a property of the address space, so it should really be cleared when a new mm is created (or in dup_mmap if the mmaps are marked as VM_DONTCOPY). For now we seem to have no such driver, so leave that for another patch.
--- arch/powerpc/platforms/powernv/vas-window.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
arch/powerpc/platforms/powernv/vas-window.c +8 -8
@@ -1063,16 +1063,16 @@ struct vas_window *vas_tx_win_open(int v rc =PTR_ERR (txwin->paste_kaddr); goto free_window; } + }else { +/* +* A user mapping must ensure that context switch issues +* CP_ABORT for this thread. +*/ + rc =set_thread_uses_vas (); +if (rc) + goto free_window; } -/* -* Now that we have a send window, ensure context switch issues -* CP_ABORT for this thread. -*/ - rc = -EINVAL ; -if (set_thread_uses_vas () <0 ) - goto free_window; -set_vinst_win (vinst, txwin);return txwin;
Greg Kroah-Hartman
maintainerPATCH 22/163 powerpc/numa: Invalidate numa_cpu_lookup_table on cpu remove
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Nathan Fontenot <[email protected]>
commit 1d9a090783bef19fe8cdec878620d22f05191316 upstream.
When DLPAR removing a CPU, the unmapping of the cpu from a node in unmap_cpu_from_node() should also invalidate the CPUs entry in the numa_cpu_lookup_table. There is not a guarantee that on a subsequent DLPAR add of the CPU the associativity will be the same and thus could be in a different node. Invalidating the entry in the numa_cpu_lookup_table causes the associativity to be read from the device tree at the time of the add.
The current behavior of not invalidating the CPUs entry in the numa_cpu_lookup_table can result in scenarios where the the topology layout of CPUs in the partition does not match the device tree or the topology reported by the HMC.
This bug looks like it was introduced in 2004 in the commit titled "ppc64: cpu hotplug notifier for numa", which is 6b15e4e87e32 in the linux-fullhist tree. Hence tag it for all stable releases.
--- arch/powerpc/include/asm/topology.h | 5 +++++ arch/powerpc/mm/numa.c | 5 ----- arch/powerpc/platforms/pseries/hotplug-cpu.c | 2 ++ 3 files changed, 7 insertions(+), 5 deletions(-)
arch/powerpc/include/asm/topology.h +5 -0
@@ -44,6 +44,11 @@ extern int sysfs_add_device_to_node(struextern void sysfs_remove_device_from_node (struct device *dev,int nid);extern int numa_update_cpu_topology (bool cpus_locked); +static inline void update_numa_cpu_lookup_table (unsigned int cpu,int node) +{ + numa_cpu_lookup_table[cpu] = node; +} +static inline int early_cpu_to_node (int cpu) {int nid;
arch/powerpc/mm/numa.c +0 -5
@@ -142,11 +142,6 @@ static void reset_numa_cpu_lookup_table( numa_cpu_lookup_table[cpu] =-1 ; } -static void update_numa_cpu_lookup_table (unsigned int cpu,int node) -{ - numa_cpu_lookup_table[cpu] = node; -} -static void map_cpu_to_node (int cpu,int node) {update_numa_cpu_lookup_table (cpu, node);
arch/powerpc/platforms/pseries/hotplug-cpu.c +2 -0
@@ -36,6 +36,7 @@#include <asm/xics.h> #include <asm/xive.h> #include <asm/plpar_wrappers.h> +#include <asm/topology.h> #include "pseries.h" #include "offline_states.h"
@@ -331,6 +332,7 @@ static void pseries_remove_processor(strBUG_ON (cpu_online (cpu));set_cpu_present (cpu, false);set_hard_smp_processor_id (cpu,-1 ); +update_numa_cpu_lookup_table (cpu,-1 );break ; }if (cpu >= nr_cpu_ids)
Greg Kroah-Hartman
maintainerPATCH 23/163 powerpc/mm: Flush radix process translations when setting MMU type
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Alexey Kardashevskiy <[email protected]>
commit 62e984ddfd6b056d399e24113f5e6a7145e579d8 upstream.
Radix guests do normally invalidate process-scoped translations when a new pid is allocated but migrated guests do not invalidate these so migrated guests crash sometime, especially easy to reproduce with migration happening within first 10 seconds after the guest boot start on the same machine.
This adds the "Invalidate process-scoped translations" flush to fix radix guests migration.
--- arch/powerpc/mm/pgtable_64.c | 2 ++ 1 file changed, 2 insertions(+)
arch/powerpc/mm/pgtable_64.c +2 -0
@@ -483,6 +483,8 @@ void mmu_partition_table_set_entry(unsigif (old &PATB_HR ) { asm volatile(PPC_TLBIE_5(%0,%1,2,0,1) : : "r" (TLBIEL_INVAL_SET_LPID), "r" (lpid)); + asm volatile(PPC_TLBIE_5(%0,%1,2,1,1) : : + "r" (TLBIEL_INVAL_SET_LPID), "r" (lpid));trace_tlbie (lpid,0 ,TLBIEL_INVAL_SET_LPID , lpid,2 ,0 ,1 ); }else { asm volatile(PPC_TLBIE_5(%0,%1,2,0,0) : :
Greg Kroah-Hartman
maintainerPATCH 24/163 powerpc/xive: Use hw CPU ids when configuring the CPU queues
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Cédric Le Goater <[email protected]>
commit 8e036c8d30a2cd9d8fc7442fbf6824e0a3e986e7 upstream.
The CPU event notification queues on sPAPR should be configured using a hardware CPU identifier.
The problem did not show up on the Power Hypervisor because pHyp supports 8 threads per core which keeps CPU number contiguous. This is not the case on all sPAPR virtual machines, some use SMT=1.
Also improve error logging by adding the CPU number.
--- arch/powerpc/sysdev/xive/spapr.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-)
arch/powerpc/sysdev/xive/spapr.c +10 -6
@@ -356,7 +356,8 @@ static int xive_spapr_configure_queue(u3 rc =plpar_int_get_queue_info (0 , target, prio, &esn_page, &esn_size);if (rc) { -pr_err ("Error %lld getting queue info prio %d\n" , rc, prio); +pr_err ("Error %lld getting queue info CPU %d prio %d\n" , rc, + target, prio); rc = -EIO ; goto fail; }
@@ -370,7 +371,8 @@ static int xive_spapr_configure_queue(u3/* Configure and enable the queue in HW */ rc =plpar_int_set_queue_config (flags, target, prio, qpage_phys, order);if (rc) { -pr_err ("Error %lld setting queue for prio %d\n" , rc, prio); +pr_err ("Error %lld setting queue for CPU %d prio %d\n" , rc, + target, prio); rc = -EIO ; }else { q->qpage = qpage;
@@ -389,8 +391,8 @@ static int xive_spapr_setup_queue(unsignif (IS_ERR (qpage))return PTR_ERR (qpage); -return xive_spapr_configure_queue (cpu, q, prio, qpage, - xive_queue_shift); +return xive_spapr_configure_queue (get_hard_smp_processor_id (cpu), + q, prio, qpage, xive_queue_shift); } static void xive_spapr_cleanup_queue(unsigned int cpu, struct xive_cpu *xc,
@@ -399,10 +401,12 @@ static void xive_spapr_cleanup_queue(unsstruct xive_q *q = &xc->queue[prio];unsigned int alloc_order;long rc; +int hw_cpu =get_hard_smp_processor_id (cpu); - rc =plpar_int_set_queue_config (0 , cpu, prio,0 ,0 ); + rc =plpar_int_set_queue_config (0 , hw_cpu, prio,0 ,0 );if (rc) -pr_err ("Error %ld setting queue for prio %d\n" , rc, prio); +pr_err ("Error %ld setting queue for CPU %d prio %d\n" , rc, + hw_cpu, prio); alloc_order =xive_alloc_order (xive_queue_shift);free_pages ((unsigned long )q->qpage, alloc_order);
Greg Kroah-Hartman
maintainerPATCH 25/163 dma-buf: fix reservation_object_wait_timeout_rcu once more v2
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Christian König <[email protected]>
commit 5bffee867df7494ecd32c1e6ec4e8fc934c521b7 upstream.
We need to set shared_count even if we already have a fence to wait for.
v2: init i to -1 as well
--- drivers/dma-buf/reservation.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/dma-buf/reservation.c +5 -3
@@ -455,13 +455,15 @@ long reservation_object_wait_timeout_rcu unsigned long timeout) {struct dma_fence *fence; -unsigned seq, shared_count, i =0 ; +unsigned seq, shared_count;long ret = timeout ? timeout :1 ; +int i; retry: shared_count =0 ; seq =read_seqcount_begin (&obj->seq);rcu_read_lock (); + i =-1 ; fence =rcu_dereference (obj->fence_excl);if (fence && !test_bit (DMA_FENCE_FLAG_SIGNALED_BIT , &fence->flags)) {
@@ -477,14 +479,14 @@ retry: fence =NULL ; } -if (!fence && wait_all) { +if (wait_all) {struct reservation_object_list *fobj =rcu_dereference (obj->fence);if (fobj) shared_count = fobj->shared_count; -for (i =0 ; i < shared_count; ++i) { +for (i =0 ; !fence && i < shared_count; ++i) {struct dma_fence *lfence =rcu_dereference (fobj->shared[i]); if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT,
Greg Kroah-Hartman
maintainerPATCH 26/163 s390: fix handling of -1 in set{,fs}[gu]id16 syscalls
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Eugene Syromiatnikov <[email protected]>
commit 6dd0d2d22aa363fec075cb2577ba273ac8462e94 upstream.
For some reason, the implementation of some 16-bit ID system calls (namely, setuid16/setgid16 and setfsuid16/setfsgid16) used type cast instead of low2highgid/low2highuid macros for converting [GU]IDs, which led to incorrect handling of value of -1 (which ought to be considered invalid).
Discovered by strace test suite.
--- arch/s390/kernel/compat_linux.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
arch/s390/kernel/compat_linux.c +4 -4
@@ -110,7 +110,7 @@ COMPAT_SYSCALL_DEFINE2(s390_setregid16, COMPAT_SYSCALL_DEFINE1(s390_setgid16, u16, gid) { -return sys_setgid ((gid_t )gid); +return sys_setgid (low2highgid (gid)); }COMPAT_SYSCALL_DEFINE2 (s390_setreuid16, u16, ruid, u16, euid)
@@ -120,7 +120,7 @@ COMPAT_SYSCALL_DEFINE2(s390_setreuid16, COMPAT_SYSCALL_DEFINE1(s390_setuid16, u16, uid) { -return sys_setuid ((uid_t )uid); +return sys_setuid (low2highuid (uid)); }COMPAT_SYSCALL_DEFINE3 (s390_setresuid16, u16, ruid, u16, euid, u16, suid)
@@ -173,12 +173,12 @@ COMPAT_SYSCALL_DEFINE3(s390_getresgid16, COMPAT_SYSCALL_DEFINE1(s390_setfsuid16, u16, uid) { -return sys_setfsuid ((uid_t )uid); +return sys_setfsuid (low2highuid (uid)); } COMPAT_SYSCALL_DEFINE1(s390_setfsgid16, u16, gid) { -return sys_setfsgid ((gid_t )gid); +return sys_setfsgid (low2highgid (gid)); }static int groups16_to_user (u16 __user *grouplist,struct group_info *group_info)
Greg Kroah-Hartman
maintainerPATCH 27/163 arm64: dts: msm8916: Correct ipc references for smsm
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Bjorn Andersson <[email protected]>
commit 566bd8902e7fa20bd412ed753e09e89c1c96939c upstream.
SMSM is not symmetrical, the incoming bits from WCNSS are available at index 6, but the outgoing host id for WCNSS is 3. Further more, upstream references the base of APCS (in contrast to downstream), so the register offset of 8 must be included.
--- arch/arm64/boot/dts/qcom/msm8916.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/qcom/msm8916.dtsi +2 -2
@@ -1435,8 +1435,8 @@ #address-cells = <1>; #size-cells = <0>; - qcom,ipc-1 = <&apcs 0 13>; - qcom,ipc-6 = <&apcs 0 19>; + qcom,ipc-1 = <&apcs 8 13>; + qcom,ipc-3 = <&apcs 8 19>; apps_smsm: apps@0 { reg = <0>;
Greg Kroah-Hartman
maintainerPATCH 28/163 ARM: lpc3250: fix uda1380 gpio numbers
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Arnd Bergmann <[email protected]>
commit ca32e0c4bf9ca4b87089c5a5ce945e5f2ec890da upstream.
dtc warns about obviously incorrect GPIO numbers for the audio codec on both lpc32xx boards:
arch/arm/boot/dts/lpc3250-phy3250.dtb: Warning (gpios_property): reset-gpio property size (12) too small for cell size 3 in /ahb/apb/i2c@400A0000/uda1380@18 arch/arm/boot/dts/lpc3250-phy3250.dtb: Warning (gpios_property): power-gpio property size (12) too small for cell size 3 in /ahb/apb/i2c@400A0000/uda1380@18 arch/arm/boot/dts/lpc3250-ea3250.dtb: Warning (gpios_property): reset-gpio property size (12) too small for cell size 3 in /ahb/apb/i2c@400A0000/uda1380@18 arch/arm/boot/dts/lpc3250-ea3250.dtb: Warning (gpios_property): power-gpio property size (12) too small for cell size 3 in /ahb/apb/i2c@400A0000/uda1380@18
It looks like the nodes are written for a different binding that combines the GPIO number into a single number rather than a bank/number pair. I found the right numbers on stackexchange.com, so this patch fixes the warning and has a reasonable chance of getting things to actually work.
--- arch/arm/boot/dts/lpc3250-ea3250.dts | 4 ++-- arch/arm/boot/dts/lpc3250-phy3250.dts | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)
arch/arm/boot/dts/lpc3250-ea3250.dts +2 -2
@@ -156,8 +156,8 @@ uda1380: uda1380@18 { compatible = "nxp,uda1380"; reg = <0x18>; - power-gpio = <&gpio 0x59 0>; - reset-gpio = <&gpio 0x51 0>; + power-gpio = <&gpio 3 10 0>; + reset-gpio = <&gpio 3 2 0>; dac-clk = "wspll"; };
arch/arm/boot/dts/lpc3250-phy3250.dts +2 -2
@@ -81,8 +81,8 @@ uda1380: uda1380@18 { compatible = "nxp,uda1380"; reg = <0x18>; - power-gpio = <&gpio 0x59 0>; - reset-gpio = <&gpio 0x51 0>; + power-gpio = <&gpio 3 10 0>; + reset-gpio = <&gpio 3 2 0>; dac-clk = "wspll"; };
Greg Kroah-Hartman
maintainerPATCH 29/163 ARM: dts: STi: Add gpio polarity for "hdmi,hpd-gpio" property
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Patrice Chotard <[email protected]>
commit 7ac1f59c09a61e6af6622df6809e003b0af07f3d upstream.
The GPIO polarity is missing in the hdmi,hpd-gpio property, this fixes the following DT warnings:
arch/arm/boot/dts/stih410-b2120.dtb: Warning (gpios_property): hdmi,hpd-gpio property size (8) too small for cell size 2 in /soc/sti-display-subsystem/sti-hdmi@8d04000
arch/arm/boot/dts/stih407-b2120.dtb: Warning (gpios_property): hdmi,hpd-gpio property size (8) too small for cell size 2 in /soc/sti-display-subsystem/sti-hdmi@8d04000
arch/arm/boot/dts/stih410-b2260.dtb: Warning (gpios_property): hdmi,hpd-gpio property size (8) too small for cell size 2 in /soc/sti-display-subsystem/sti-hdmi@8d04000
[arnd: marked Cc:stable since this warning shows up with the latest dtc
by default, and is more likely to actually cause problems than the other patches from this series]
--- arch/arm/boot/dts/stih407.dtsi | 3 ++- arch/arm/boot/dts/stih410.dtsi | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-)
arch/arm/boot/dts/stih407.dtsi +2 -1
@@ -8,6 +8,7 @@ */ #include "stih407-clock.dtsi" #include "stih407-family.dtsi" +#include <dt-bindings/gpio/gpio.h> / { soc { sti-display-subsystem {
@@ -122,7 +123,7 @@ <&clk_s_d2_quadfs 0>, <&clk_s_d2_quadfs 1>; - hdmi,hpd-gpio = <&pio5 3>; + hdmi,hpd-gpio = <&pio5 3 GPIO_ACTIVE_LOW>; reset-names = "hdmi"; resets = <&softreset STIH407_HDMI_TX_PHY_SOFTRESET>; ddc = <&hdmiddc>;
arch/arm/boot/dts/stih410.dtsi +2 -1
@@ -9,6 +9,7 @@ #include "stih410-clock.dtsi" #include "stih407-family.dtsi" #include "stih410-pinctrl.dtsi" +#include <dt-bindings/gpio/gpio.h> / { aliases { bdisp0 = &bdisp0;
@@ -213,7 +214,7 @@ <&clk_s_d2_quadfs 0>, <&clk_s_d2_quadfs 1>; - hdmi,hpd-gpio = <&pio5 3>; + hdmi,hpd-gpio = <&pio5 3 GPIO_ACTIVE_LOW>; reset-names = "hdmi"; resets = <&softreset STIH407_HDMI_TX_PHY_SOFTRESET>; ddc = <&hdmiddc>;
Greg Kroah-Hartman
maintainerPATCH 30/163 ARM: dts: nomadik: add interrupt-parent for clcd
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Arnd Bergmann <[email protected]>
commit e8bfa0422469cdfc86be3f525f621b1d44d2481b upstream.
The clcd device is lacking an interrupt-parent property, which makes the interrupt unusable and shows up as a warning with the latest dtc version:
arch/arm/boot/dts/ste-nomadik-s8815.dtb: Warning (interrupts_property): Missing interrupt-parent for /amba/clcd@10120000 arch/arm/boot/dts/ste-nomadik-nhk15.dtb: Warning (interrupts_property): Missing interrupt-parent for /amba/clcd@10120000
I looked up the old board files and found that this interrupt has the same irqchip as all the other on-chip device, it just needs one extra line.
--- arch/arm/boot/dts/ste-nomadik-stn8815.dtsi | 1 + 1 file changed, 1 insertion(+)
arch/arm/boot/dts/ste-nomadik-stn8815.dtsi +1 -0
@@ -750,6 +750,7 @@ reg = <0x10120000 0x1000>; interrupt-names = "combined"; interrupts = <14>; + interrupt-parent = <&vica>; clocks = <&clcdclk>, <&hclkclcd>; clock-names = "clcdclk", "apb_pclk"; status = "disabled";
Greg Kroah-Hartman
maintainerPATCH 31/163 arm: dts: mt7623: fix card detection issue on bananapi-r2
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Sean Wang <[email protected]>
commit b96a696fb2a8dd1ee4e6cfee48dcac270fc53287 upstream.
Fix that bananapi-r2 booting from SD-card would fail since incorrect polarity is applied to the previous setup with GPIO_ACTIVE_HIGH.
--- arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts +1 -1
@@ -204,7 +204,7 @@ bus-width = <4>; max-frequency = <50000000>; cap-sd-highspeed; - cd-gpios = <&pio 261 0>; + cd-gpios = <&pio 261 GPIO_ACTIVE_LOW>; vmmc-supply = <&mt6323_vmch_reg>; vqmmc-supply = <&mt6323_vio18_reg>; };
Greg Kroah-Hartman
maintainerPATCH 32/163 arm: spear600: Add missing interrupt-parent of rtc
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Viresh Kumar <[email protected]>
commit 6ffb5b4f248fe53e0361b8cbc2a523b432566442 upstream.
The interrupt-parent of rtc was missing, add it.
--- arch/arm/boot/dts/spear600.dtsi | 1 + 1 file changed, 1 insertion(+)
arch/arm/boot/dts/spear600.dtsi +1 -0
@@ -194,6 +194,7 @@ rtc: rtc@fc900000 { compatible = "st,spear600-rtc"; reg = <0xfc900000 0x1000>; + interrupt-parent = <&vic0>; interrupts = <10>; status = "disabled"; };
Greg Kroah-Hartman
maintainerPATCH 33/163 arm: spear13xx: Fix dmas cells
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Viresh Kumar <[email protected]>
commit cdd10409914184c7eee5ae3e11beb890c9c16c61 upstream.
The "dmas" cells for the designware DMA controller need to have only 3 properties apart from the phandle: request line, src master and destination master. But the commit 6e8887f60f60 updated it incorrectly while moving from platform code to DT. Fix it.
--- Documentation/devicetree/bindings/dma/snps-dma.txt | 2 +- arch/arm/boot/dts/spear1340.dtsi | 4 ++-- arch/arm/boot/dts/spear13xx.dtsi | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-)
Documentation/devicetree/bindings/dma/snps-dma.txt +1 -1
@@ -64,6 +64,6 @@ Example: reg = <0xe0000000 0x1000>; interrupts = <0 35 0x4>; dmas = <&dmahost 12 0 1>, - <&dmahost 13 0 1 0>; + <&dmahost 13 1 0>; dma-names = "rx", "rx"; };
arch/arm/boot/dts/spear1340.dtsi +2 -2
@@ -142,8 +142,8 @@ reg = <0xb4100000 0x1000>; interrupts = <0 105 0x4>; status = "disabled"; - dmas = <&dwdma0 0x600 0 0 1>, /* 0xC << 11 */ - <&dwdma0 0x680 0 1 0>; /* 0xD << 7 */ + dmas = <&dwdma0 12 0 1>, + <&dwdma0 13 1 0>; dma-names = "tx", "rx"; };
arch/arm/boot/dts/spear13xx.dtsi +3 -3
@@ -100,7 +100,7 @@ reg = <0xb2800000 0x1000>; interrupts = <0 29 0x4>; status = "disabled"; - dmas = <&dwdma0 0 0 0 0>; + dmas = <&dwdma0 0 0 0>; dma-names = "data"; };
@@ -290,8 +290,8 @@ #size-cells = <0>; interrupts = <0 31 0x4>; status = "disabled"; - dmas = <&dwdma0 0x2000 0 0 0>, /* 0x4 << 11 */ - <&dwdma0 0x0280 0 0 0>; /* 0x5 << 7 */ + dmas = <&dwdma0 4 0 0>, + <&dwdma0 5 0 0>; dma-names = "tx", "rx"; };
Greg Kroah-Hartman
maintainerPATCH 34/163 arm: spear13xx: Fix spics gpio controllers warning
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Viresh Kumar <[email protected]>
commit f8975cb1b8a36d0839b6365235778dd9df1d04ca upstream.
This fixes the following warning by also sending the flags argument for gpio controllers:
Property 'cs-gpios', cell 6 is not a phandle reference in /ahb/apb/spi@e0100000
--- arch/arm/boot/dts/spear1310-evb.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/spear1310-evb.dts +1 -1
@@ -349,7 +349,7 @@ spi0: spi@e0100000 { status = "okay"; num-cs = <3>; - cs-gpios = <&gpio1 7 0>, <&spics 0>, <&spics 1>; + cs-gpios = <&gpio1 7 0>, <&spics 0 0>, <&spics 1 0>; stmpe610@0 { compatible = "st,stmpe610";
Greg Kroah-Hartman
maintainerPATCH 35/163 x86/gpu: add CFL to early quirks
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Lucas De Marchi <[email protected]>
commit 33aa69ed8aacd92dea12671e52eb3ca6ac2d7a49 upstream.
CFL was missing from intel_early_ids[]. The PCI ID needs to be there to allow the memory region to be stolen, otherwise we could have RAM being arbitrarily overwritten if for example we keep using the UEFI framebuffer, depending on how BIOS has set up the e820 map.
--- arch/x86/kernel/early-quirks.c | 1 + include/drm/i915_pciids.h | 6 ++++++ 2 files changed, 7 insertions(+)
arch/x86/kernel/early-quirks.c +1 -0
@@ -527,6 +527,7 @@ static const struct pci_device_id intel_INTEL_SKL_IDS (&gen9_early_ops),INTEL_BXT_IDS (&gen9_early_ops),INTEL_KBL_IDS (&gen9_early_ops), +INTEL_CFL_IDS (&gen9_early_ops),INTEL_GLK_IDS (&gen9_early_ops), INTEL_CNL_IDS(&gen9_early_ops), };
include/drm/i915_pciids.h +6 -0
@@ -392,6 +392,12 @@INTEL_VGA_DEVICE (0x3EA8 , info),/* ULT GT3 */ \ INTEL_VGA_DEVICE(0x3EA5, info) /* ULT GT3 */ +#define INTEL_CFL_IDS (info) \ + INTEL_CFL_S_GT1_IDS(info), \ + INTEL_CFL_S_GT2_IDS(info), \ + INTEL_CFL_H_GT2_IDS(info), \ + INTEL_CFL_U_GT3_IDS(info) +/* CNL U 2+2 */ #define INTEL_CNL_U_GT2_IDS (info) \ INTEL_VGA_DEVICE(0x5A52, info), \
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Greg Kroah-Hartman
maintainerPATCH 36/163 x86/kexec: Make kexec (mostly) work in 5-level paging mode
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Kirill A. Shutemov <[email protected]>
commit 5bf30316991d5bcda046343ee77d823cf16fdd03 upstream.
Currently kexec() will crash when switching into a 5-level paging enabled kernel.
I missed that we need to change relocate_kernel() to set CR4.LA57 flag if the kernel has 5-level paging enabled.
I avoided using #ifdef CONFIG_X86_5LEVEL here and inferred if we need to enable 5-level paging from previous CR4 value. This way the code is ready for boot-time switching between paging modes.
With this patch applied, in addition to kexec 4-to-4 which always worked, we can kexec 4-to-5 and 5-to-5 - while 5-to-4 will need more work.
--- arch/x86/kernel/relocate_kernel_64.S | 8 ++++++++ 1 file changed, 8 insertions(+)
arch/x86/kernel/relocate_kernel_64.S +8 -0
@@ -68,6 +68,9 @@ relocate_kernel: movq %cr4, %rax movq %rax, CR4(%r11) + /* Save CR4. Required to enable the right paging mode later. */ + movq %rax, %r13 + /* zero out flags, and disable interrupts */ pushq $0 popfq
@@ -126,8 +129,13 @@ identity_mapped: /* * Set cr4 to a known state: * - physical address extension enabled + * - 5-level paging, if it was enabled before */ movl $X86_CR4_PAE, %eax + testq $X86_CR4_LA57, %r13 + jz 1f + orl $X86_CR4_LA57, %eax +1: movq %rax, %cr4 jmp 1f
Greg Kroah-Hartman
maintainerPATCH 37/163 x86/xen: init %gs very early to avoid page faults with stack protector
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Juergen Gross <[email protected]>
commit 4f277295e54c5b7340e48efea3fc5cc21a2872b7 upstream.
When running as Xen pv guest %gs is initialized some time after C code is started. Depending on stack protector usage this might be too late, resulting in page faults.
So setup %gs and MSR_GS_BASE in assembly code already.
--- arch/x86/xen/xen-head.S | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)
arch/x86/xen/xen-head.S +16 -0
@@ -9,7 +9,9 @@ #include <asm/boot.h> #include <asm/asm.h> +#include <asm/msr.h> #include <asm/page_types.h> +#include <asm/percpu.h> #include <asm/unwind_hints.h> #include <xen/interface/elfnote.h>
@@ -35,6 +37,20 @@ ENTRY(startup_xen) mov %_ASM_SI, xen_start_info mov $init_thread_union+THREAD_SIZE, %_ASM_SP +#ifdef CONFIG_X86_64 + /* Set up %gs. + * + * The base of %gs always points to the bottom of the irqstack + * union. If the stack protector canary is enabled, it is + * located at %gs:40. Note that, on SMP, the boot cpu uses + * init data section till per cpu areas are set up. + */ + movl $MSR_GS_BASE,%ecx + movq $INIT_PER_CPU_VAR(irq_stack_union),%rax + cdq + wrmsr +#endif + jmp xen_start_kernel END(startup_xen) __FINIT
Greg Kroah-Hartman
maintainerPATCH 38/163 x86: PM: Make APM idle driver initialize polling state
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Rafael J. Wysocki <[email protected]>
commit f859422075165e32c00c8d75d63f300015cc07ae upstream.
Update the APM driver overlooked by commit 1b39e3f813b4 (cpuidle: Make drivers initialize polling state) to initialize the polling state like the other cpuidle drivers modified by that commit to prevent cpuidle from crashing.
--- arch/x86/kernel/apm_32.c | 1 + 1 file changed, 1 insertion(+)
arch/x86/kernel/apm_32.c +1 -0
@@ -2389,6 +2389,7 @@ static int __init apm_init(void)if (HZ !=100 ) idle_period = (idle_period *HZ ) /100 ;if (idle_threshold <100 ) { +cpuidle_poll_state_init (&apm_idle_driver);if (!cpuidle_register_driver (&apm_idle_driver))if (cpuidle_register_device (&apm_cpuidle_device))cpuidle_unregister_driver (&apm_idle_driver);
Greg Kroah-Hartman
maintainerPATCH 39/163 mm, memory_hotplug: fix memmap initialization
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Michal Hocko <[email protected]>
commit 9bb5a391f9a5707e04763cf14298fc4cc29bfecd upstream.
Bharata has noticed that onlining a newly added memory doesn't increase the total memory, pointing to commit f7f99100d8d9 ("mm: stop zeroing memory during allocation in vmemmap") as a culprit. This commit has changed the way how the memory for memmaps is initialized and moves it from the allocation time to the initialization time. This works properly for the early memmap init path.
It doesn't work for the memory hotplug though because we need to mark page as reserved when the sparsemem section is created and later initialize it completely during onlining. memmap_init_zone is called in the early stage of onlining. With the current code it calls __init_single_page and as such it clears up the whole stage and therefore online_pages_range skips those pages.
Fix this by skipping mm_zero_struct_page in __init_single_page for memory hotplug path. This is quite uggly but unifying both early init and memory hotplug init paths is a large project. Make sure we plug the regression at least.
--- mm/page_alloc.c | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-)
mm/page_alloc.c +14 -8
@@ -1177,9 +1177,10 @@ static void free_one_page(struct zone *z }static void __meminit __init_single_page (struct page *page,unsigned long pfn, -unsigned long zone,int nid) +unsigned long zone,int nid,bool zero) { -mm_zero_struct_page (page); +if (zero) +mm_zero_struct_page (page);set_page_links (page, zone, nid, pfn);init_page_count (page);page_mapcount_reset (page);
@@ -1194,9 +1195,9 @@ static void __meminit __init_single_page }static void __meminit __init_single_pfn (unsigned long pfn,unsigned long zone, -int nid) +int nid,bool zero) { -return __init_single_page (pfn_to_page (pfn), pfn, zone, nid); +return __init_single_page (pfn_to_page (pfn), pfn, zone, nid, zero); }#ifdef CONFIG_DEFERRED_STRUCT_PAGE_INIT
@@ -1217,7 +1218,7 @@ static void __meminit init_reserved_pageif (pfn >= zone->zone_start_pfn && pfn <zone_end_pfn (zone)) break; } -__init_single_pfn (pfn, zid, nid); +__init_single_pfn (pfn, zid, nid, true); }#else static inline void init_reserved_page (unsigned long pfn)
@@ -1514,7 +1515,7 @@ static unsigned long __init deferred_ini page++; else page =pfn_to_page (pfn); -__init_single_page (page, pfn, zid, nid); +__init_single_page (page, pfn, zid, nid, true);cond_resched (); } }
@@ -5393,15 +5394,20 @@ not_early:* can be created for invalid pages (for alignment) * check here not to call set_pageblock_migratetype() against * pfn out of zone. +* +* Please note that MEMMAP_HOTPLUG path doesn't clear memmap +* because this is done early in sparse_add_one_section */ if (!(pfn & (pageblock_nr_pages -1 ))) {struct page *page =pfn_to_page (pfn); -__init_single_page (page, pfn, zone, nid); +__init_single_page (page, pfn, zone, nid, + context !=MEMMAP_HOTPLUG );set_pageblock_migratetype (page,MIGRATE_MOVABLE );cond_resched (); }else { -__init_single_pfn (pfn, zone, nid); +__init_single_pfn (pfn, zone, nid, + context !=MEMMAP_HOTPLUG ); } } }
Greg Kroah-Hartman
maintainerPATCH 40/163 x86/entry/64: Clear extra registers beyond syscall arguments, to reduce speculation attack surface
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Dan Williams <[email protected]>
commit 8e1eb3fa009aa7c0b944b3c8b26b07de0efb3200 upstream.
At entry userspace may have (maliciously) populated the extra registers outside the syscall calling convention with arbitrary values that could be useful in a speculative execution (Spectre style) attack.
Clear these registers to minimize the kernel's attack surface.
Note, this only clears the extra registers and not the unused registers for syscalls less than 6 arguments, since those registers are likely to be clobbered well before their values could be put to use under speculation.
Note, Linus found that the XOR instructions can be executed with minimized cost if interleaved with the PUSH instructions, and Ingo's analysis found that R10 and R11 should be included in the register clearing beyond the typical 'extra' syscall calling convention registers.
--- arch/x86/entry/entry_64.S | 13 +++++++++++++ 1 file changed, 13 insertions(+)
arch/x86/entry/entry_64.S +13 -0
@@ -235,13 +235,26 @@ GLOBAL(entry_SYSCALL_64_after_hwframe) pushq %r8 /* pt_regs->r8 */ pushq %r9 /* pt_regs->r9 */ pushq %r10 /* pt_regs->r10 */ + /* + * Clear extra registers that a speculation attack might + * otherwise want to exploit. Interleave XOR with PUSH + * for better uop scheduling: + */ + xorq %r10, %r10 /* nospec r10 */ pushq %r11 /* pt_regs->r11 */ + xorq %r11, %r11 /* nospec r11 */ pushq %rbx /* pt_regs->rbx */ + xorl %ebx, %ebx /* nospec rbx */ pushq %rbp /* pt_regs->rbp */ + xorl %ebp, %ebp /* nospec rbp */ pushq %r12 /* pt_regs->r12 */ + xorq %r12, %r12 /* nospec r12 */ pushq %r13 /* pt_regs->r13 */ + xorq %r13, %r13 /* nospec r13 */ pushq %r14 /* pt_regs->r14 */ + xorq %r14, %r14 /* nospec r14 */ pushq %r15 /* pt_regs->r15 */ + xorq %r15, %r15 /* nospec r15 */ UNWIND_HINT_REGS TRACE_IRQS_OFF
Greg Kroah-Hartman
maintainerPATCH 41/163 x86/entry/64/compat: Clear registers for compat syscalls, to reduce speculation attack surface
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Dan Williams <[email protected]>
commit 6b8cf5cc9965673951f1ab3f0e3cf23d06e3e2ee upstream.
At entry userspace may have populated registers with values that could otherwise be useful in a speculative execution attack. Clear them to minimize the kernel's attack surface.
Originally-From: Andi Kleen <[email protected]>
--- arch/x86/entry/entry_64_compat.S | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+)
arch/x86/entry/entry_64_compat.S +30 -0
@@ -85,15 +85,25 @@ ENTRY(entry_SYSENTER_compat) pushq %rcx /* pt_regs->cx */ pushq $-ENOSYS /* pt_regs->ax */ pushq $0 /* pt_regs->r8 = 0 */ + xorq %r8, %r8 /* nospec r8 */ pushq $0 /* pt_regs->r9 = 0 */ + xorq %r9, %r9 /* nospec r9 */ pushq $0 /* pt_regs->r10 = 0 */ + xorq %r10, %r10 /* nospec r10 */ pushq $0 /* pt_regs->r11 = 0 */ + xorq %r11, %r11 /* nospec r11 */ pushq %rbx /* pt_regs->rbx */ + xorl %ebx, %ebx /* nospec rbx */ pushq %rbp /* pt_regs->rbp (will be overwritten) */ + xorl %ebp, %ebp /* nospec rbp */ pushq $0 /* pt_regs->r12 = 0 */ + xorq %r12, %r12 /* nospec r12 */ pushq $0 /* pt_regs->r13 = 0 */ + xorq %r13, %r13 /* nospec r13 */ pushq $0 /* pt_regs->r14 = 0 */ + xorq %r14, %r14 /* nospec r14 */ pushq $0 /* pt_regs->r15 = 0 */ + xorq %r15, %r15 /* nospec r15 */ cld /*
@@ -214,15 +224,25 @@ GLOBAL(entry_SYSCALL_compat_after_hwfram pushq %rbp /* pt_regs->cx (stashed in bp) */ pushq $-ENOSYS /* pt_regs->ax */ pushq $0 /* pt_regs->r8 = 0 */ + xorq %r8, %r8 /* nospec r8 */ pushq $0 /* pt_regs->r9 = 0 */ + xorq %r9, %r9 /* nospec r9 */ pushq $0 /* pt_regs->r10 = 0 */ + xorq %r10, %r10 /* nospec r10 */ pushq $0 /* pt_regs->r11 = 0 */ + xorq %r11, %r11 /* nospec r11 */ pushq %rbx /* pt_regs->rbx */ + xorl %ebx, %ebx /* nospec rbx */ pushq %rbp /* pt_regs->rbp (will be overwritten) */ + xorl %ebp, %ebp /* nospec rbp */ pushq $0 /* pt_regs->r12 = 0 */ + xorq %r12, %r12 /* nospec r12 */ pushq $0 /* pt_regs->r13 = 0 */ + xorq %r13, %r13 /* nospec r13 */ pushq $0 /* pt_regs->r14 = 0 */ + xorq %r14, %r14 /* nospec r14 */ pushq $0 /* pt_regs->r15 = 0 */ + xorq %r15, %r15 /* nospec r15 */ /* * User mode is traced as though IRQs are on, and SYSENTER
@@ -338,15 +358,25 @@ ENTRY(entry_INT80_compat) pushq %rcx /* pt_regs->cx */ pushq $-ENOSYS /* pt_regs->ax */ pushq $0 /* pt_regs->r8 = 0 */ + xorq %r8, %r8 /* nospec r8 */ pushq $0 /* pt_regs->r9 = 0 */ + xorq %r9, %r9 /* nospec r9 */ pushq $0 /* pt_regs->r10 = 0 */ + xorq %r10, %r10 /* nospec r10 */ pushq $0 /* pt_regs->r11 = 0 */ + xorq %r11, %r11 /* nospec r11 */ pushq %rbx /* pt_regs->rbx */ + xorl %ebx, %ebx /* nospec rbx */ pushq %rbp /* pt_regs->rbp */ + xorl %ebp, %ebp /* nospec rbp */ pushq %r12 /* pt_regs->r12 */ + xorq %r12, %r12 /* nospec r12 */ pushq %r13 /* pt_regs->r13 */ + xorq %r13, %r13 /* nospec r13 */ pushq %r14 /* pt_regs->r14 */ + xorq %r14, %r14 /* nospec r14 */ pushq %r15 /* pt_regs->r15 */ + xorq %r15, %r15 /* nospec r15 */ cld /*
Greg Kroah-Hartman
maintainerPATCH 42/163 compiler-gcc.h: Introduce __optimize function attribute
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Geert Uytterhoeven <[email protected]>
commit df5d45aa08f848b79caf395211b222790534ccc7 upstream.
Create a new function attribute __optimize, which allows to specify an optimization level on a per-function basis.
--- include/linux/compiler-gcc.h | 4 ++++ include/linux/compiler.h | 4 ++++ 2 files changed, 8 insertions(+)
include/linux/compiler-gcc.h +4 -0
@@ -196,6 +196,10 @@#endif /* __CHECKER__ */ #endif /* GCC_VERSION >= 40300 */ +#if GCC_VERSION >=40400 +#define __optimize (level) __attribute__((__optimize__(level))) +#endif /* GCC_VERSION >= 40400 */ +#if GCC_VERSION >=40500 #ifndef __CHECKER__
include/linux/compiler.h +4 -0
@@ -271,6 +271,10 @@ static __always_inline void __write_once#endif /* __ASSEMBLY__ */ +#ifndef __optimize +# define __optimize (level) +#endif +/* Compile time object size, -1 for unknown */ #ifndef __compiletime_object_size# define __compiletime_object_size (obj) -1
Greg Kroah-Hartman
maintainerPATCH 43/163 compiler-gcc.h: __nostackprotector needs gcc-4.4 and up
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Geert Uytterhoeven <[email protected]>
commit d9afaaa4ff7af8b87d4a205e48cb8a6f666d7f01 upstream.
Gcc versions before 4.4 do not recognize the __optimize__ compiler attribute:
warning: ‘__optimize__’ attribute directive ignored
--- include/linux/compiler-gcc.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
include/linux/compiler-gcc.h +1 -2
@@ -167,8 +167,6 @@#if GCC_VERSION >=40100 # define __compiletime_object_size (obj) __builtin_object_size(obj, 0) - -#define __nostackprotector __attribute__((__optimize__("no-stack-protector")))#endif #if GCC_VERSION >=40300
@@ -198,6 +196,7 @@#if GCC_VERSION >=40400 #define __optimize (level) __attribute__((__optimize__(level))) +#define __nostackprotector __optimize("no-stack-protector")#endif /* GCC_VERSION >= 40400 */ #if GCC_VERSION >=40500
Greg Kroah-Hartman
maintainerPATCH 44/163 crypto: sun4i_ss_prng - fix return value of sun4i_ss_prng_generate
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Artem Savkov <[email protected]>
commit dd78c832ffaf86eb6434e56de4bc3bc31f03f771 upstream.
According to crypto/rng.h generate function should return 0 on success and < 0 on error.
--- drivers/crypto/sunxi-ss/sun4i-ss-prng.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/crypto/sunxi-ss/sun4i-ss-prng.c +1 -1
@@ -52,5 +52,5 @@ int sun4i_ss_prng_generate(struct cryptowritel (0 , ss->base +SS_CTL );spin_unlock (&ss->slock); -return dlen; +return 0 ; }
Greg Kroah-Hartman
maintainerPATCH 45/163 crypto: sun4i_ss_prng - convert lock to _bh in sun4i_ss_prng_generate
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Artem Savkov <[email protected]>
commit 2e7d1d61ea6c0f1c4da5eb82cafac750d55637a7 upstream.
Lockdep detects a possible deadlock in sun4i_ss_prng_generate() and throws an "inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage" warning. Disabling softirqs to fix this.
--- drivers/crypto/sunxi-ss/sun4i-ss-prng.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/crypto/sunxi-ss/sun4i-ss-prng.c +2 -2
@@ -28,7 +28,7 @@ int sun4i_ss_prng_generate(struct crypto algt = container_of(alg, struct sun4i_ss_alg_template, alg.rng); ss = algt->ss; -spin_lock (&ss->slock); +spin_lock_bh (&ss->slock);writel (mode, ss->base +SS_CTL );
@@ -51,6 +51,6 @@ int sun4i_ss_prng_generate(struct crypto }writel (0 , ss->base +SS_CTL ); -spin_unlock (&ss->slock); +spin_unlock_bh (&ss->slock);return 0 ; }
Greg Kroah-Hartman
maintainerPATCH 46/163 powerpc/mm/radix: Split linear mapping on hot-unplug
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Balbir Singh <[email protected]>
commit 4dd5f8a99e791a8c6500e3592f3ce81ae7edcde1 upstream.
This patch splits the linear mapping if the hot-unplug range is smaller than the mapping size. The code detects if the mapping needs to be split into a smaller size and if so, uses the stop machine infrastructure to clear the existing mapping and then remap the remaining range using a smaller page size.
The code will skip any region of the mapping that overlaps with kernel text and warn about it once. We don't want to remove a mapping where the kernel text and the LMB we intend to remove overlap in the same TLB mapping as it may affect the currently executing code.
I've tested these changes under a kvm guest with 2 vcpus, from a split mapping point of view, some of the caveats mentioned above applied to the testing I did.
--- arch/powerpc/mm/pgtable-radix.c | 95 +++++++++++++++++++++++++++++++--------- 1 file changed, 74 insertions(+), 21 deletions(-)
arch/powerpc/mm/pgtable-radix.c +74 -21
@@ -17,6 +17,7 @@#include <linux/of_fdt.h> #include <linux/mm.h> #include <linux/string_helpers.h> +#include <linux/stop_machine.h> #include <asm/pgtable.h> #include <asm/pgalloc.h>
@@ -671,6 +672,30 @@ static void free_pmd_table(pmd_t *pmd_stpud_clear (pud); } +struct change_mapping_params { +pte_t *pte; +unsigned long start; +unsigned long end; +unsigned long aligned_start; +unsigned long aligned_end; +}; + +static int stop_machine_change_mapping (void *data) +{ +struct change_mapping_params *params = + (struct change_mapping_params *)data; + +if (!data) +return -1 ; + +spin_unlock (&init_mm.page_table_lock); +pte_clear (&init_mm, params->aligned_start, params->pte); +create_physical_mapping (params->aligned_start, params->start); +create_physical_mapping (params->end, params->aligned_end); +spin_lock (&init_mm.page_table_lock); +return 0 ; +} +static void remove_pte_table (pte_t *pte_start,unsigned long addr,unsigned long end) {
@@ -699,6 +724,52 @@ static void remove_pte_table(pte_t *pte_ } } +/* +* clear the pte and potentially split the mapping helper +*/ +static void split_kernel_mapping (unsigned long addr,unsigned long end, +unsigned long size,pte_t *pte) +{ +unsigned long mask = ~(size -1 ); +unsigned long aligned_start = addr & mask; +unsigned long aligned_end = addr + size; +struct change_mapping_params params; +bool split_region = false; + +if ((end - addr) < size) { +/* +* We're going to clear the PTE, but not flushed +* the mapping, time to remap and flush. The +* effects if visible outside the processor or +* if we are running in code close to the +* mapping we cleared, we are in trouble. +*/ +if (overlaps_kernel_text (aligned_start, addr) || +overlaps_kernel_text (end, aligned_end)) { +/* +* Hack, just return, don't pte_clear +*/ +WARN_ONCE (1 ,"Linear mapping %lx->%lx overlaps kernel " +"text, not splitting\n" , addr, end); +return ; + } + split_region = true; + } + +if (split_region) { + params.pte = pte; + params.start = addr; + params.end = end; + params.aligned_start = addr & ~(size -1 ); + params.aligned_end = min_t(unsigned long, aligned_end, + (unsigned long )__va (memblock_end_of_DRAM ())); +stop_machine (stop_machine_change_mapping, ¶ms,NULL ); +return ; + } + +pte_clear (&init_mm, addr, pte); +} +static void remove_pmd_table (pmd_t *pmd_start,unsigned long addr,unsigned long end) {
@@ -714,13 +785,7 @@ static void remove_pmd_table(pmd_t *pmd_continue ;if (pmd_huge (*pmd)) { -if (!IS_ALIGNED (addr,PMD_SIZE ) || - !IS_ALIGNED (next,PMD_SIZE )) { -WARN_ONCE (1 ,"%s: unaligned range\n" , __func__); -continue ; - } - -pte_clear (&init_mm, addr, (pte_t *)pmd); +split_kernel_mapping (addr, end,PMD_SIZE , (pte_t *)pmd);continue ; }
@@ -745,13 +810,7 @@ static void remove_pud_table(pud_t *pud_continue ;if (pud_huge (*pud)) { -if (!IS_ALIGNED (addr,PUD_SIZE ) || - !IS_ALIGNED (next,PUD_SIZE )) { -WARN_ONCE (1 ,"%s: unaligned range\n" , __func__); -continue ; - } - -pte_clear (&init_mm, addr, (pte_t *)pud); +split_kernel_mapping (addr, end,PUD_SIZE , (pte_t *)pud);continue ; }
@@ -777,13 +836,7 @@ static void remove_pagetable(unsigned locontinue ;if (pgd_huge (*pgd)) { -if (!IS_ALIGNED (addr,PGDIR_SIZE ) || - !IS_ALIGNED (next,PGDIR_SIZE )) { -WARN_ONCE (1 ,"%s: unaligned range\n" , __func__); -continue ; - } - -pte_clear (&init_mm, addr, (pte_t *)pgd); +split_kernel_mapping (addr, end,PGDIR_SIZE , (pte_t *)pgd);continue ; }
Greg Kroah-Hartman
maintainerPATCH 47/163 x86/mm/pti: Fix PTI comment in entry_SYSCALL_64()
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Nadav Amit <[email protected]>
commit 14b1fcc62043729d12e8ae00f8297ab2ffe9fa91 upstream.
The comment is confusing since the path is taken when CONFIG_PAGE_TABLE_ISOLATION=y is disabled (while the comment says it is not taken).
--- arch/x86/entry/entry_64.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/entry/entry_64.S +1 -1
@@ -213,7 +213,7 @@ ENTRY(entry_SYSCALL_64) swapgs /* - * This path is not taken when PAGE_TABLE_ISOLATION is disabled so it + * This path is only taken when PAGE_TABLE_ISOLATION is disabled so it * is not required to switch CR3. */ movq %rsp, PER_CPU_VAR(rsp_scratch)
Greg Kroah-Hartman
maintainerPATCH 48/163 x86/speculation: Update Speculation Control microcode blacklist
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: David Woodhouse <[email protected]>
commit 1751342095f0d2b36fa8114d8e12c5688c455ac4 upstream.
Intel have retroactively blessed the 0xc2 microcode on Skylake mobile and desktop parts, and the Gemini Lake 0x22 microcode is apparently fine too. We blacklisted the latter purely because it was present with all the other problematic ones in the 2018-01-08 release, but now it's explicitly listed as OK.
We still list 0x84 for the various Kaby Lake / Coffee Lake parts, as that appeared in one version of the blacklist and then reverted to 0x80 again. We can change it if 0x84 is actually announced to be safe.
--- arch/x86/kernel/cpu/intel.c | 4 ---- 1 file changed, 4 deletions(-)
arch/x86/kernel/cpu/intel.c +0 -4
@@ -123,8 +123,6 @@ static const struct sku_microcode spectr { INTEL_FAM6_KABYLAKE_MOBILE, 0x09, 0x84 }, { INTEL_FAM6_SKYLAKE_X, 0x03, 0x0100013e }, { INTEL_FAM6_SKYLAKE_X, 0x04, 0x0200003c }, - { INTEL_FAM6_SKYLAKE_MOBILE, 0x03, 0xc2 }, - { INTEL_FAM6_SKYLAKE_DESKTOP, 0x03, 0xc2 }, { INTEL_FAM6_BROADWELL_CORE, 0x04, 0x28 }, { INTEL_FAM6_BROADWELL_GT3E, 0x01, 0x1b }, { INTEL_FAM6_BROADWELL_XEON_D, 0x02, 0x14 },
@@ -136,8 +134,6 @@ static const struct sku_microcode spectr { INTEL_FAM6_HASWELL_X, 0x02, 0x3b }, { INTEL_FAM6_HASWELL_X, 0x04, 0x10 }, { INTEL_FAM6_IVYBRIDGE_X, 0x04, 0x42a }, -/* Updated in the 20180108 release; blacklist until we know otherwise */ - { INTEL_FAM6_ATOM_GEMINI_LAKE, 0x01, 0x22 },/* Observed in the wild */ { INTEL_FAM6_SANDYBRIDGE_X, 0x06, 0x61b }, { INTEL_FAM6_SANDYBRIDGE_X, 0x07, 0x712 },
Greg Kroah-Hartman
maintainerPATCH 49/163 x86/speculation: Correct Speculation Control microcode blacklist again
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: David Woodhouse <[email protected]>
commit d37fc6d360a404b208547ba112e7dabb6533c7fc upstream.
Arjan points out that the Intel document only clears the 0xc2 microcode on *some* parts with CPUID 506E3 (INTEL_FAM6_SKYLAKE_DESKTOP stepping 3). For the Skylake H/S platform it's OK but for Skylake E3 which has the same CPUID it isn't (yet) cleared.
So removing it from the blacklist was premature. Put it back for now.
Also, Arjan assures me that the 0x84 microcode for Kaby Lake which was featured in one of the early revisions of the Intel document was never released to the public, and won't be until/unless it is also validated as safe. So those can change to 0x80 which is what all *other* versions of the doc have identified.
Once the retrospective testing of existing public microcodes is done, we should be back into a mode where new microcodes are only released in batches and we shouldn't even need to update the blacklist for those anyway, so this tweaking of the list isn't expected to be a thing which keeps happening.
--- arch/x86/kernel/cpu/intel.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
arch/x86/kernel/cpu/intel.c +6 -5
@@ -116,13 +116,14 @@ struct sku_microcode {u32 microcode; };static const struct sku_microcode spectre_bad_microcodes[] = { - {INTEL_FAM6_KABYLAKE_DESKTOP ,0x0B ,0x84 }, - {INTEL_FAM6_KABYLAKE_DESKTOP ,0x0A ,0x84 }, - {INTEL_FAM6_KABYLAKE_DESKTOP ,0x09 ,0x84 }, - {INTEL_FAM6_KABYLAKE_MOBILE ,0x0A ,0x84 }, - {INTEL_FAM6_KABYLAKE_MOBILE ,0x09 ,0x84 }, + {INTEL_FAM6_KABYLAKE_DESKTOP ,0x0B ,0x80 }, + {INTEL_FAM6_KABYLAKE_DESKTOP ,0x0A ,0x80 }, + {INTEL_FAM6_KABYLAKE_DESKTOP ,0x09 ,0x80 }, + {INTEL_FAM6_KABYLAKE_MOBILE ,0x0A ,0x80 }, + {INTEL_FAM6_KABYLAKE_MOBILE ,0x09 ,0x80 }, {INTEL_FAM6_SKYLAKE_X ,0x03 ,0x0100013e }, {INTEL_FAM6_SKYLAKE_X ,0x04 ,0x0200003c }, + {INTEL_FAM6_SKYLAKE_DESKTOP ,0x03 ,0xc2 }, {INTEL_FAM6_BROADWELL_CORE ,0x04 ,0x28 }, {INTEL_FAM6_BROADWELL_GT3E ,0x01 ,0x1b }, {INTEL_FAM6_BROADWELL_XEON_D ,0x02 ,0x14 },
Greg Kroah-Hartman
maintainerPATCH 50/163 Revert "x86/speculation: Simplify indirect_branch_prediction_barrier()"
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: David Woodhouse <[email protected]>
commit f208820a321f9b23d77d7eed89945d862d62a3ed upstream.
This reverts commit 64e16720ea0879f8ab4547e3b9758936d483909b.
We cannot call C functions like that, without marking all the call-clobbered registers as, well, clobbered. We might have got away with it for now because the __ibp_barrier() function was *fairly* unlikely to actually use any other registers. But no. Just no.
--- arch/x86/include/asm/nospec-branch.h | 13 +++++++++---- arch/x86/include/asm/processor.h | 3 --- arch/x86/kernel/cpu/bugs.c | 6 ------ 3 files changed, 9 insertions(+), 13 deletions(-)
arch/x86/include/asm/nospec-branch.h +9 -4
@@ -164,10 +164,15 @@ static inline void vmexit_fill_RSB(void)static inline void indirect_branch_prediction_barrier (void ) { -alternative_input ("" , -"call __ibp_barrier" , -X86_FEATURE_USE_IBPB , -ASM_NO_INPUT_CLOBBER ("eax" ,"ecx" ,"edx" ,"memory" )); + asm volatile(ALTERNATIVE("", + "movl %[msr], %%ecx\n\t" + "movl %[val], %%eax\n\t" + "movl $0, %%edx\n\t" + "wrmsr", + X86_FEATURE_USE_IBPB) + : : [msr] "i" (MSR_IA32_PRED_CMD), + [val] "i" (PRED_CMD_IBPB) + : "eax", "ecx", "edx", "memory"); }#endif /* __ASSEMBLY__ */
arch/x86/include/asm/processor.h +0 -3
@@ -969,7 +969,4 @@ bool xen_set_default_idle(void);void stop_this_cpu (void *dummy);void df_debug (struct pt_regs *regs,long error_code); - -void __ibp_barrier (void ); -#endif /* _ASM_X86_PROCESSOR_H */
arch/x86/kernel/cpu/bugs.c +0 -6
@@ -337,9 +337,3 @@ ssize_t cpu_show_spectre_v2(struct devic spectre_v2_module_string()); }#endif - -void __ibp_barrier (void ) -{ -__wrmsr (MSR_IA32_PRED_CMD ,PRED_CMD_IBPB ,0 ); -} -EXPORT_SYMBOL_GPL (__ibp_barrier);
Greg Kroah-Hartman
maintainerPATCH 51/163 KVM/x86: Reduce retpoline performance impact in slot_handle_level_range(), by always inlining iterator helper methods
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: David Woodhouse <[email protected]>
commit 928a4c39484281f8ca366f53a1db79330d058401 upstream.
With retpoline, tight loops of "call this function for every XXX" are very much pessimised by taking a prediction miss *every* time. This one is by far the biggest contributor to the guest launch time with retpoline.
By marking the iterator slot_handle_…() functions always_inline, we can ensure that the indirect function call can be optimised away into a direct call and it actually generates slightly smaller code because some of the other conditionals can get optimised away too.
Performance is now pretty close to what we see with nospectre_v2 on the command line.
--- arch/x86/kvm/mmu.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
arch/x86/kvm/mmu.c +5 -5
@@ -5058,7 +5058,7 @@ void kvm_mmu_uninit_vm(struct kvm *kvm)typedef bool (*slot_level_handler ) (struct kvm *kvm,struct kvm_rmap_head *rmap_head);/* The caller should hold mmu-lock before calling this function. */ -static bool +static __always_inline boolslot_handle_level_range (struct kvm *kvm,struct kvm_memory_slot *memslot,slot_level_handler fn,int start_level,int end_level,gfn_t start_gfn,gfn_t end_gfn,bool lock_flush_tlb)
@@ -5088,7 +5088,7 @@ slot_handle_level_range(struct kvm *kvm,return flush; } -static bool +static __always_inline boolslot_handle_level (struct kvm *kvm,struct kvm_memory_slot *memslot,slot_level_handler fn,int start_level,int end_level,bool lock_flush_tlb)
@@ -5099,7 +5099,7 @@ slot_handle_level(struct kvm *kvm, struc lock_flush_tlb); } -static bool +static __always_inline boolslot_handle_all_level (struct kvm *kvm,struct kvm_memory_slot *memslot,slot_level_handler fn,bool lock_flush_tlb) {
@@ -5107,7 +5107,7 @@ slot_handle_all_level(struct kvm *kvm, s PT_MAX_HUGEPAGE_LEVEL, lock_flush_tlb); } -static bool +static __always_inline boolslot_handle_large_level (struct kvm *kvm,struct kvm_memory_slot *memslot,slot_level_handler fn,bool lock_flush_tlb) {
@@ -5115,7 +5115,7 @@ slot_handle_large_level(struct kvm *kvm, PT_MAX_HUGEPAGE_LEVEL, lock_flush_tlb); } -static bool +static __always_inline boolslot_handle_leaf (struct kvm *kvm,struct kvm_memory_slot *memslot,slot_level_handler fn,bool lock_flush_tlb) {
Greg Kroah-Hartman
maintainerPATCH 52/163 X86/nVMX: Properly set spec_ctrl and pred_cmd before merging MSRs
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: KarimAllah Ahmed <[email protected]>
commit 206587a9fb764d71f035dc7f6d3b6488f5d5b304 upstream.
These two variables should check whether SPEC_CTRL and PRED_CMD are supposed to be passed through to L2 guests or not. While msr_write_intercepted_l01 would return 'true' if it is not passed through.
So just invert the result of msr_write_intercepted_l01 to implement the correct semantics.
--- arch/x86/kvm/vmx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/x86/kvm/vmx.c +2 -2
@@ -10220,8 +10220,8 @@ static inline bool nested_vmx_merge_msr_* updated to reflect this when L1 (or its L2s) actually write to * the MSR. */ -bool pred_cmd =msr_write_intercepted_l01 (vcpu,MSR_IA32_PRED_CMD ); -bool spec_ctrl =msr_write_intercepted_l01 (vcpu,MSR_IA32_SPEC_CTRL ); +bool pred_cmd = !msr_write_intercepted_l01 (vcpu,MSR_IA32_PRED_CMD ); +bool spec_ctrl = !msr_write_intercepted_l01 (vcpu,MSR_IA32_SPEC_CTRL );if (!nested_cpu_has_virt_x2apic_mode (vmcs12) && !pred_cmd && !spec_ctrl)
Greg Kroah-Hartman
maintainerPATCH 53/163 KVM/nVMX: Set the CPU_BASED_USE_MSR_BITMAPS if we have a valid L02 MSR bitmap
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: KarimAllah Ahmed <[email protected]>
commit 3712caeb14dcb33fb4d5114f14c0beef10aca101 upstream.
We either clear the CPU_BASED_USE_MSR_BITMAPS and end up intercepting all MSR accesses or create a valid L02 MSR bitmap and use that. This decision has to be made every time we evaluate whether we are going to generate the L02 MSR bitmap.
Before commit:
d28b387fb74d ("KVM/VMX: Allow direct access to MSR_IA32_SPEC_CTRL")
... this was probably OK since the decision was always identical.
This is no longer the case now since the MSR bitmap might actually change once we decide to not intercept SPEC_CTRL and PRED_CMD.
--- arch/x86/kvm/vmx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
arch/x86/kvm/vmx.c +2 -1
@@ -10131,7 +10131,8 @@ static void nested_get_vmcs12_pages(struif (cpu_has_vmx_msr_bitmap () &&nested_cpu_has (vmcs12,CPU_BASED_USE_MSR_BITMAPS ) &&nested_vmx_merge_msr_bitmap (vcpu, vmcs12)) - ; +vmcs_set_bits (CPU_BASED_VM_EXEC_CONTROL , +CPU_BASED_USE_MSR_BITMAPS );else vmcs_clear_bits (CPU_BASED_VM_EXEC_CONTROL ,CPU_BASED_USE_MSR_BITMAPS );
Greg Kroah-Hartman
maintainerPATCH 54/163 x86/speculation: Clean up various Spectre related details
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Ingo Molnar <[email protected]>
commit 21e433bdb95bdf3aa48226fd3d33af608437f293 upstream.
Harmonize all the Spectre messages so that a:
dmesg | grep -i spectre
... gives us most Spectre related kernel boot messages.
Also fix a few other details:
- clarify a comment about firmware speculation control
- s/KPTI/PTI
- remove various line-breaks that made the code uglier
--- arch/x86/kernel/cpu/bugs.c | 28 +++++++++++----------------- 1 file changed, 11 insertions(+), 17 deletions(-)
arch/x86/kernel/cpu/bugs.c +11 -17
@@ -162,8 +162,7 @@ static enum spectre_v2_mitigation_cmd __if (cmdline_find_option_bool (boot_command_line,"nospectre_v2" ))return SPECTRE_V2_CMD_NONE ;else { - ret =cmdline_find_option (boot_command_line,"spectre_v2" , arg, -sizeof (arg)); + ret =cmdline_find_option (boot_command_line,"spectre_v2" , arg,sizeof (arg));if (ret <0 )return SPECTRE_V2_CMD_AUTO ;
@@ -175,8 +174,7 @@ static enum spectre_v2_mitigation_cmd __ }if (i >=ARRAY_SIZE (mitigation_options)) { -pr_err ("unknown option (%s). Switching to AUTO select\n" , - mitigation_options[i].option); +pr_err ("unknown option (%s). Switching to AUTO select\n" , mitigation_options[i].option);return SPECTRE_V2_CMD_AUTO ; } }
@@ -185,8 +183,7 @@ static enum spectre_v2_mitigation_cmd __ cmd == SPECTRE_V2_CMD_RETPOLINE_AMD || cmd == SPECTRE_V2_CMD_RETPOLINE_GENERIC) && !IS_ENABLED(CONFIG_RETPOLINE)) { -pr_err ("%s selected but not compiled in. Switching to AUTO select\n" , - mitigation_options[i].option); +pr_err ("%s selected but not compiled in. Switching to AUTO select\n" , mitigation_options[i].option);return SPECTRE_V2_CMD_AUTO ; }
@@ -256,14 +253,14 @@ static void __init spectre_v2_select_mit goto retpoline_auto;break ; } -pr_err ("kernel not compiled with retpoline; no mitigation available!" ); +pr_err ("Spectre mitigation: kernel not compiled with retpoline; no mitigation available!" );return ; retpoline_auto:if (boot_cpu_data.x86_vendor ==X86_VENDOR_AMD ) { retpoline_amd:if (!boot_cpu_has (X86_FEATURE_LFENCE_RDTSC )) { -pr_err ("LFENCE not serializing. Switching to generic retpoline\n" ); +pr_err ("Spectre mitigation: LFENCE not serializing, switching to generic retpoline\n" ); goto retpoline_generic; } mode = retp_compiler() ? SPECTRE_V2_RETPOLINE_AMD :
@@ -281,7 +278,7 @@ retpoline_auto:pr_info ("%s\n" , spectre_v2_strings[mode]);/* -* If neither SMEP or KPTI are available, there is a risk of +* If neither SMEP nor PTI are available, there is a risk of * hitting userspace addresses in the RSB after a context switch * from a shallow call stack to a deeper one. To prevent this fill * the entire RSB, even when using IBRS.
@@ -295,21 +292,20 @@ retpoline_auto:if ((!boot_cpu_has (X86_FEATURE_PTI ) && !boot_cpu_has (X86_FEATURE_SMEP )) ||is_skylake_era ()) {setup_force_cpu_cap (X86_FEATURE_RSB_CTXSW ); -pr_info ("Filling RSB on context switch\n" ); +pr_info ("Spectre v2 mitigation: Filling RSB on context switch\n" ); }/* Initialize Indirect Branch Prediction Barrier if supported */ if (boot_cpu_has (X86_FEATURE_IBPB )) {setup_force_cpu_cap (X86_FEATURE_USE_IBPB ); -pr_info ("Enabling Indirect Branch Prediction Barrier\n" ); +pr_info ("Spectre v2 mitigation: Enabling Indirect Branch Prediction Barrier\n" ); } }#undef pr_fmt#ifdef CONFIG_SYSFS -ssize_t cpu_show_meltdown (struct device *dev, -struct device_attribute *attr,char *buf) +ssize_t cpu_show_meltdown (struct device *dev,struct device_attribute *attr,char *buf) {if (!boot_cpu_has_bug (X86_BUG_CPU_MELTDOWN ))return sprintf (buf,"Not affected\n" );
@@ -318,16 +314,14 @@ ssize_t cpu_show_meltdown(struct devicereturn sprintf (buf,"Vulnerable\n" ); } -ssize_t cpu_show_spectre_v1 (struct device *dev, -struct device_attribute *attr,char *buf) +ssize_t cpu_show_spectre_v1 (struct device *dev,struct device_attribute *attr,char *buf) {if (!boot_cpu_has_bug (X86_BUG_SPECTRE_V1 ))return sprintf (buf,"Not affected\n" );return sprintf (buf,"Mitigation: __user pointer sanitization\n" ); } -ssize_t cpu_show_spectre_v2 (struct device *dev, -struct device_attribute *attr,char *buf) +ssize_t cpu_show_spectre_v2 (struct device *dev,struct device_attribute *attr,char *buf) {if (!boot_cpu_has_bug (X86_BUG_SPECTRE_V2 ))return sprintf (buf,"Not affected\n" );
Greg Kroah-Hartman
maintainerPATCH 55/163 PM / runtime: Update links_count also if !CONFIG_SRCU
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Lukas Wunner <[email protected]>
commit 433986c2c265d106d6a8e88006e0131fefc92b7b upstream.
Commit baa8809f6097 (PM / runtime: Optimize the use of device links) added an invocation of pm_runtime_drop_link() to __device_link_del(). However there are two variants of that function, one for CONFIG_SRCU and another for !CONFIG_SRCU, and the commit only modified the former.
--- drivers/base/core.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/base/core.c +3 -0
@@ -313,6 +313,9 @@ static void __device_link_del(struct devdev_info (link->consumer,"Dropping the link to %s\n" ,dev_name (link->supplier)); +if (link->flags &DL_FLAG_PM_RUNTIME ) +pm_runtime_drop_link (link->consumer); +list_del (&link->s_node);list_del (&link->c_node);device_link_free (link);
Greg Kroah-Hartman
maintainerPATCH 56/163 PM: cpuidle: Fix cpuidle_poll_state_init() prototype
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Rafael J. Wysocki <[email protected]>
commit d7212cfb05ba802bea4dd6c90d61cfe6366ea224 upstream.
Commit f85942207516 (x86: PM: Make APM idle driver initialize polling state) made apm_init() call cpuidle_poll_state_init(), but that only is defined for CONFIG_CPU_IDLE set, so make the empty stub of it available for CONFIG_CPU_IDLE unset too to fix the resulting build issue.
--- include/linux/cpuidle.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/cpuidle.h +1 -1
@@ -225,7 +225,7 @@ static inline void cpuidle_coupled_paral }#endif -#ifdef CONFIG_ARCH_HAS_CPU_RELAX +#if defined(CONFIG_CPU_IDLE ) && defined(CONFIG_ARCH_HAS_CPU_RELAX )void cpuidle_poll_state_init (struct cpuidle_driver *drv);#else static inline void cpuidle_poll_state_init (struct cpuidle_driver *drv) {}
Greg Kroah-Hartman
maintainerPATCH 57/163 platform/x86: wmi: fix off-by-one write in wmi_dev_probe()
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Andrey Ryabinin <[email protected]>
commit 6e1d8ea90932f77843730ada0bfea63093b7212a upstream.
wmi_dev_probe() allocates one byte less than necessary, thus subsequent sprintf() call writes trailing zero past the end of the 'buf':
BUG: KASAN: slab-out-of-bounds in vsnprintf+0xda4/0x1240
Write of size 1 at addr ffff880423529caf by task kworker/1:1/32
Call Trace:
dump_stack+0xb3/0x14d
print_address_description+0xd7/0x380
kasan_report+0x166/0x2b0
vsnprintf+0xda4/0x1240
sprintf+0x9b/0xd0
wmi_dev_probe+0x1c3/0x400
driver_probe_device+0x5d1/0x990
bus_for_each_drv+0x109/0x190
__device_attach+0x217/0x360
bus_probe_device+0x1ad/0x260
deferred_probe_work_func+0x10f/0x5d0
process_one_work+0xa8b/0x1dc0
worker_thread+0x20d/0x17d0
kthread+0x311/0x3d0
ret_from_fork+0x3a/0x50
Allocated by task 32:
kasan_kmalloc+0xa0/0xd0
__kmalloc+0x14f/0x3e0
wmi_dev_probe+0x182/0x400
driver_probe_device+0x5d1/0x990
bus_for_each_drv+0x109/0x190
__device_attach+0x217/0x360
bus_probe_device+0x1ad/0x260
deferred_probe_work_func+0x10f/0x5d0
process_one_work+0xa8b/0x1dc0
worker_thread+0x20d/0x17d0
kthread+0x311/0x3d0
ret_from_fork+0x3a/0x50Increment allocation size to fix this.
--- drivers/platform/x86/wmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/wmi.c +1 -1
@@ -933,7 +933,7 @@ static int wmi_dev_probe(struct device * goto probe_failure; } - buf =kmalloc (strlen (wdriver->driver.name) +4 ,GFP_KERNEL ); + buf =kmalloc (strlen (wdriver->driver.name) +5 ,GFP_KERNEL );if (!buf) { ret = -ENOMEM ; goto probe_string_failure;
Greg Kroah-Hartman
maintainerPATCH 58/163 x86/entry/64: Clear registers for exceptions/interrupts, to reduce speculation attack surface
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Dan Williams <[email protected]>
commit 3ac6d8c787b835b997eb23e43e09aa0895ef7d58 upstream.
Clear the 'extra' registers on entering the 64-bit kernel for exceptions and interrupts. The common registers are not cleared since they are likely clobbered well before they can be exploited in a speculative execution attack.
Originally-From: Andi Kleen <[email protected]>
--- arch/x86/entry/calling.h | 19 +++++++++++++++++++ arch/x86/entry/entry_64.S | 6 +++++- 2 files changed, 24 insertions(+), 1 deletion(-)
arch/x86/entry/calling.h +19 -0
@@ -147,6 +147,25 @@ For 32-bit we have the following convent UNWIND_HINT_REGS offset=\offset .endm + /* + * Sanitize registers of values that a speculation attack + * might otherwise want to exploit. The lower registers are + * likely clobbered well before they could be put to use in + * a speculative execution gadget: + */ + .macro CLEAR_REGS_NOSPEC + xorl %ebp, %ebp + xorl %ebx, %ebx + xorq %r8, %r8 + xorq %r9, %r9 + xorq %r10, %r10 + xorq %r11, %r11 + xorq %r12, %r12 + xorq %r13, %r13 + xorq %r14, %r14 + xorq %r15, %r15 + .endm + .macro POP_EXTRA_REGS popq %r15 popq %r14
arch/x86/entry/entry_64.S +5 -1
@@ -575,6 +575,7 @@ END(irq_entries_start) ALLOC_PT_GPREGS_ON_STACK SAVE_C_REGS SAVE_EXTRA_REGS + CLEAR_REGS_NOSPEC ENCODE_FRAME_POINTER testb $3, CS(%rsp)
@@ -1133,6 +1134,7 @@ ENTRY(xen_failsafe_callback) ALLOC_PT_GPREGS_ON_STACK SAVE_C_REGS SAVE_EXTRA_REGS + CLEAR_REGS_NOSPEC ENCODE_FRAME_POINTER jmp error_exit END(xen_failsafe_callback)
@@ -1178,6 +1180,7 @@ ENTRY(paranoid_entry) cld SAVE_C_REGS 8 SAVE_EXTRA_REGS 8 + CLEAR_REGS_NOSPEC ENCODE_FRAME_POINTER 8 movl $1, %ebx movl $MSR_GS_BASE, %ecx
@@ -1230,8 +1233,8 @@ ENTRY(error_entry) cld SAVE_C_REGS 8 SAVE_EXTRA_REGS 8 + CLEAR_REGS_NOSPEC ENCODE_FRAME_POINTER 8 - xorl %ebx, %ebx testb $3, CS+8(%rsp) jz .Lerror_kernelspace
@@ -1428,6 +1431,7 @@ ENTRY(nmi) pushq %r14 /* pt_regs->r14 */ pushq %r15 /* pt_regs->r15 */ UNWIND_HINT_REGS + CLEAR_REGS_NOSPEC ENCODE_FRAME_POINTER /*
Greg Kroah-Hartman
maintainerPATCH 59/163 x86/entry/64: Merge SAVE_C_REGS and SAVE_EXTRA_REGS, remove unused extensions
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Dominik Brodowski <[email protected]>
commit 2e3f0098bc45f710a2f4cbcc94b80a1fae7a99a1 upstream.
All current code paths call SAVE_C_REGS and then immediately SAVE_EXTRA_REGS. Therefore, merge these two macros and order the MOV sequeneces properly.
While at it, remove the macros to save all except specific registers, as these macros have been unused for a long time.
--- arch/x86/entry/calling.h | 57 ++++++++++++---------------------------------- arch/x86/entry/entry_64.S | 12 +++------ 2 files changed, 19 insertions(+), 50 deletions(-)
arch/x86/entry/calling.h +15 -42
@@ -101,49 +101,22 @@ For 32-bit we have the following convent addq $-(15*8), %rsp .endm - .macro SAVE_C_REGS_HELPER offset=0 rax=1 rcx=1 r8910=1 r11=1 - .if \r11 - movq %r11, 6*8+\offset(%rsp) - .endif - .if \r8910 - movq %r10, 7*8+\offset(%rsp) - movq %r9, 8*8+\offset(%rsp) - movq %r8, 9*8+\offset(%rsp) - .endif - .if \rax - movq %rax, 10*8+\offset(%rsp) - .endif - .if \rcx - movq %rcx, 11*8+\offset(%rsp) - .endif - movq %rdx, 12*8+\offset(%rsp) - movq %rsi, 13*8+\offset(%rsp) + .macro SAVE_REGS offset=0 movq %rdi, 14*8+\offset(%rsp) - UNWIND_HINT_REGS offset=\offset extra=0 - .endm - .macro SAVE_C_REGS offset=0 - SAVE_C_REGS_HELPER \offset, 1, 1, 1, 1 - .endm - .macro SAVE_C_REGS_EXCEPT_RAX_RCX offset=0 - SAVE_C_REGS_HELPER \offset, 0, 0, 1, 1 - .endm - .macro SAVE_C_REGS_EXCEPT_R891011 - SAVE_C_REGS_HELPER 0, 1, 1, 0, 0 - .endm - .macro SAVE_C_REGS_EXCEPT_RCX_R891011 - SAVE_C_REGS_HELPER 0, 1, 0, 0, 0 - .endm - .macro SAVE_C_REGS_EXCEPT_RAX_RCX_R11 - SAVE_C_REGS_HELPER 0, 0, 0, 1, 0 - .endm - - .macro SAVE_EXTRA_REGS offset=0 - movq %r15, 0*8+\offset(%rsp) - movq %r14, 1*8+\offset(%rsp) - movq %r13, 2*8+\offset(%rsp) - movq %r12, 3*8+\offset(%rsp) - movq %rbp, 4*8+\offset(%rsp) + movq %rsi, 13*8+\offset(%rsp) + movq %rdx, 12*8+\offset(%rsp) + movq %rcx, 11*8+\offset(%rsp) + movq %rax, 10*8+\offset(%rsp) + movq %r8, 9*8+\offset(%rsp) + movq %r9, 8*8+\offset(%rsp) + movq %r10, 7*8+\offset(%rsp) + movq %r11, 6*8+\offset(%rsp) movq %rbx, 5*8+\offset(%rsp) + movq %rbp, 4*8+\offset(%rsp) + movq %r12, 3*8+\offset(%rsp) + movq %r13, 2*8+\offset(%rsp) + movq %r14, 1*8+\offset(%rsp) + movq %r15, 0*8+\offset(%rsp) UNWIND_HINT_REGS offset=\offset .endm
@@ -197,7 +170,7 @@ For 32-bit we have the following convent* is just setting the LSB, which makes it an invalid stack address and is also * a signal to the unwinder that it's a pt_regs pointer in disguise. * -* NOTE: This macro must be used *after* SAVE_EXTRA_REGS because it corrupts +* NOTE: This macro must be used *after* SAVE_REGS because it corrupts * the original rbp. */ .macro ENCODE_FRAME_POINTER ptregs_offset=0
arch/x86/entry/entry_64.S +4 -8
@@ -573,8 +573,7 @@ END(irq_entries_start) 1: ALLOC_PT_GPREGS_ON_STACK - SAVE_C_REGS - SAVE_EXTRA_REGS + SAVE_REGS CLEAR_REGS_NOSPEC ENCODE_FRAME_POINTER
@@ -1132,8 +1131,7 @@ ENTRY(xen_failsafe_callback) UNWIND_HINT_IRET_REGS pushq $-1 /* orig_ax = -1 => not a system call */ ALLOC_PT_GPREGS_ON_STACK - SAVE_C_REGS - SAVE_EXTRA_REGS + SAVE_REGS CLEAR_REGS_NOSPEC ENCODE_FRAME_POINTER jmp error_exit
@@ -1178,8 +1176,7 @@ idtentry machine_check do_mce has_err ENTRY(paranoid_entry) UNWIND_HINT_FUNC cld - SAVE_C_REGS 8 - SAVE_EXTRA_REGS 8 + SAVE_REGS 8 CLEAR_REGS_NOSPEC ENCODE_FRAME_POINTER 8 movl $1, %ebx
@@ -1231,8 +1228,7 @@ END(paranoid_exit) ENTRY(error_entry) UNWIND_HINT_FUNC cld - SAVE_C_REGS 8 - SAVE_EXTRA_REGS 8 + SAVE_REGS 8 CLEAR_REGS_NOSPEC ENCODE_FRAME_POINTER 8 testb $3, CS+8(%rsp)
Greg Kroah-Hartman
maintainerPATCH 60/163 x86/entry/64: Merge the POP_C_REGS and POP_EXTRA_REGS macros into a single POP_REGS macro
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Dominik Brodowski <[email protected]>
commit 502af0d70843c2a9405d7ba1f79b4b0305aaf5f5 upstream.
The two special, opencoded cases for POP_C_REGS can be handled by ASM macros.
--- arch/x86/entry/calling.h | 15 +++++++++++---- arch/x86/entry/entry_64.S | 26 ++++---------------------- 2 files changed, 15 insertions(+), 26 deletions(-)
arch/x86/entry/calling.h +11 -4
@@ -139,25 +139,32 @@ For 32-bit we have the following convent xorq %r15, %r15 .endm - .macro POP_EXTRA_REGS + .macro POP_REGS pop_rdi=1 skip_r11rcx=0 popq %r15 popq %r14 popq %r13 popq %r12 popq %rbp popq %rbx - .endm - - .macro POP_C_REGS + .if \skip_r11rcx + popq %rsi + .else popq %r11 + .endif popq %r10 popq %r9 popq %r8 popq %rax + .if \skip_r11rcx + popq %rsi + .else popq %rcx + .endif popq %rdx popq %rsi + .if \pop_rdi popq %rdi + .endif .endm .macro icebp
arch/x86/entry/entry_64.S +4 -22
@@ -334,15 +334,7 @@ GLOBAL(entry_SYSCALL_64_after_hwframe) syscall_return_via_sysret: /* rcx and r11 are already restored (see code above) */ UNWIND_HINT_EMPTY - POP_EXTRA_REGS - popq %rsi /* skip r11 */ - popq %r10 - popq %r9 - popq %r8 - popq %rax - popq %rsi /* skip rcx */ - popq %rdx - popq %rsi + POP_REGS pop_rdi=0 skip_r11rcx=1 /* * Now all regs are restored except RSP and RDI.
@@ -635,15 +627,7 @@ GLOBAL(swapgs_restore_regs_and_return_to ud2 1: #endif - POP_EXTRA_REGS - popq %r11 - popq %r10 - popq %r9 - popq %r8 - popq %rax - popq %rcx - popq %rdx - popq %rsi + POP_REGS pop_rdi=0 /* * The stack is now user RDI, orig_ax, RIP, CS, EFLAGS, RSP, SS.
@@ -701,8 +685,7 @@ GLOBAL(restore_regs_and_return_to_kernel ud2 1: #endif - POP_EXTRA_REGS - POP_C_REGS + POP_REGS addq $8, %rsp /* skip regs->orig_ax */ INTERRUPT_RETURN
@@ -1661,8 +1644,7 @@ end_repeat_nmi: nmi_swapgs: SWAPGS_UNSAFE_STACK nmi_restore: - POP_EXTRA_REGS - POP_C_REGS + POP_REGS /* * Skip orig_ax and the "outermost" frame to point RSP at the "iret"
Greg Kroah-Hartman
maintainerPATCH 61/163 x86/entry/64: Interleave XOR register clearing with PUSH instructions
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Dominik Brodowski <[email protected]>
commit f7bafa2b05ef25eda1d9179fd930b0330cf2b7d1 upstream.
Same as is done for syscalls, interleave XOR with PUSH instructions for exceptions/interrupts, in order to minimize the cost of the additional instructions required for register clearing.
--- arch/x86/entry/calling.h | 40 +++++++++++++++++++--------------------- arch/x86/entry/entry_64.S | 30 +++++++++++++++++++++--------- 2 files changed, 40 insertions(+), 30 deletions(-)
arch/x86/entry/calling.h +19 -21
@@ -101,44 +101,42 @@ For 32-bit we have the following convent addq $-(15*8), %rsp .endm - .macro SAVE_REGS offset=0 + .macro SAVE_AND_CLEAR_REGS offset=0 +/* +* Save registers and sanitize registers of values that a +* speculation attack might otherwise want to exploit. The +* lower registers are likely clobbered well before they +* could be put to use in a speculative execution gadget. +* Interleave XOR with PUSH for better uop scheduling: + */ movq %rdi, 14*8+\offset(%rsp) movq %rsi, 13*8+\offset(%rsp) movq %rdx, 12*8+\offset(%rsp) movq %rcx, 11*8+\offset(%rsp) movq %rax, 10*8+\offset(%rsp) movq %r8, 9*8+\offset(%rsp) + xorq %r8, %r8 /* nospec r8 */ movq %r9, 8*8+\offset(%rsp) + xorq %r9, %r9 /* nospec r9 */ movq %r10, 7*8+\offset(%rsp) + xorq %r10, %r10 /* nospec r10 */ movq %r11, 6*8+\offset(%rsp) + xorq %r11, %r11 /* nospec r11 */ movq %rbx, 5*8+\offset(%rsp) + xorl %ebx, %ebx /* nospec rbx */ movq %rbp, 4*8+\offset(%rsp) + xorl %ebp, %ebp /* nospec rbp */ movq %r12, 3*8+\offset(%rsp) + xorq %r12, %r12 /* nospec r12 */ movq %r13, 2*8+\offset(%rsp) + xorq %r13, %r13 /* nospec r13 */ movq %r14, 1*8+\offset(%rsp) + xorq %r14, %r14 /* nospec r14 */ movq %r15, 0*8+\offset(%rsp) + xorq %r15, %r15 /* nospec r15 */ UNWIND_HINT_REGS offset=\offset .endm - /* - * Sanitize registers of values that a speculation attack - * might otherwise want to exploit. The lower registers are - * likely clobbered well before they could be put to use in - * a speculative execution gadget: - */ - .macro CLEAR_REGS_NOSPEC - xorl %ebp, %ebp - xorl %ebx, %ebx - xorq %r8, %r8 - xorq %r9, %r9 - xorq %r10, %r10 - xorq %r11, %r11 - xorq %r12, %r12 - xorq %r13, %r13 - xorq %r14, %r14 - xorq %r15, %r15 - .endm - .macro POP_REGS pop_rdi=1 skip_r11rcx=0 popq %r15 popq %r14
@@ -177,7 +175,7 @@ For 32-bit we have the following convent* is just setting the LSB, which makes it an invalid stack address and is also * a signal to the unwinder that it's a pt_regs pointer in disguise. * -* NOTE: This macro must be used *after* SAVE_REGS because it corrupts +* NOTE: This macro must be used *after* SAVE_AND_CLEAR_REGS because it corrupts * the original rbp. */ .macro ENCODE_FRAME_POINTER ptregs_offset=0
arch/x86/entry/entry_64.S +21 -9
@@ -565,8 +565,7 @@ END(irq_entries_start) 1: ALLOC_PT_GPREGS_ON_STACK - SAVE_REGS - CLEAR_REGS_NOSPEC + SAVE_AND_CLEAR_REGS ENCODE_FRAME_POINTER testb $3, CS(%rsp)
@@ -1114,8 +1113,7 @@ ENTRY(xen_failsafe_callback) UNWIND_HINT_IRET_REGS pushq $-1 /* orig_ax = -1 => not a system call */ ALLOC_PT_GPREGS_ON_STACK - SAVE_REGS - CLEAR_REGS_NOSPEC + SAVE_AND_CLEAR_REGS ENCODE_FRAME_POINTER jmp error_exit END(xen_failsafe_callback)
@@ -1159,8 +1157,7 @@ idtentry machine_check do_mce has_err ENTRY(paranoid_entry) UNWIND_HINT_FUNC cld - SAVE_REGS 8 - CLEAR_REGS_NOSPEC + SAVE_AND_CLEAR_REGS 8 ENCODE_FRAME_POINTER 8 movl $1, %ebx movl $MSR_GS_BASE, %ecx
@@ -1211,8 +1208,7 @@ END(paranoid_exit) ENTRY(error_entry) UNWIND_HINT_FUNC cld - SAVE_REGS 8 - CLEAR_REGS_NOSPEC + SAVE_AND_CLEAR_REGS 8 ENCODE_FRAME_POINTER 8 testb $3, CS+8(%rsp) jz .Lerror_kernelspace
@@ -1399,18 +1395,34 @@ ENTRY(nmi) pushq (%rdx) /* pt_regs->dx */ pushq %rcx /* pt_regs->cx */ pushq %rax /* pt_regs->ax */ + /* + * Sanitize registers of values that a speculation attack + * might otherwise want to exploit. The lower registers are + * likely clobbered well before they could be put to use in + * a speculative execution gadget. Interleave XOR with PUSH + * for better uop scheduling: + */ pushq %r8 /* pt_regs->r8 */ + xorq %r8, %r8 /* nospec r8 */ pushq %r9 /* pt_regs->r9 */ + xorq %r9, %r9 /* nospec r9 */ pushq %r10 /* pt_regs->r10 */ + xorq %r10, %r10 /* nospec r10 */ pushq %r11 /* pt_regs->r11 */ + xorq %r11, %r11 /* nospec r11*/ pushq %rbx /* pt_regs->rbx */ + xorl %ebx, %ebx /* nospec rbx*/ pushq %rbp /* pt_regs->rbp */ + xorl %ebp, %ebp /* nospec rbp*/ pushq %r12 /* pt_regs->r12 */ + xorq %r12, %r12 /* nospec r12*/ pushq %r13 /* pt_regs->r13 */ + xorq %r13, %r13 /* nospec r13*/ pushq %r14 /* pt_regs->r14 */ + xorq %r14, %r14 /* nospec r14*/ pushq %r15 /* pt_regs->r15 */ + xorq %r15, %r15 /* nospec r15*/ UNWIND_HINT_REGS - CLEAR_REGS_NOSPEC ENCODE_FRAME_POINTER /*
Greg Kroah-Hartman
maintainerPATCH 62/163 x86/entry/64: Introduce the PUSH_AND_CLEAN_REGS macro
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Dominik Brodowski <[email protected]>
commit 3f01daecd545e818098d84fd1ad43e19a508d705 upstream.
Those instances where ALLOC_PT_GPREGS_ON_STACK is called just before SAVE_AND_CLEAR_REGS can trivially be replaced by PUSH_AND_CLEAN_REGS. This macro uses PUSH instead of MOV and should therefore be faster, at least on newer CPUs.
--- arch/x86/entry/calling.h | 36 ++++++++++++++++++++++++++++++++++++ arch/x86/entry/entry_64.S | 6 ++---- 2 files changed, 38 insertions(+), 4 deletions(-)
arch/x86/entry/calling.h +36 -0
@@ -137,6 +137,42 @@ For 32-bit we have the following convent UNWIND_HINT_REGS offset=\offset .endm + .macro PUSH_AND_CLEAR_REGS +/* +* Push registers and sanitize registers of values that a +* speculation attack might otherwise want to exploit. The +* lower registers are likely clobbered well before they +* could be put to use in a speculative execution gadget. +* Interleave XOR with PUSH for better uop scheduling: +*/ + pushq %rdi /* pt_regs->di */ + pushq %rsi /* pt_regs->si */ + pushq %rdx /* pt_regs->dx */ + pushq %rcx /* pt_regs->cx */ + pushq %rax /* pt_regs->ax */ + pushq %r8 /* pt_regs->r8 */ + xorq %r8, %r8 /* nospec r8 */ + pushq %r9 /* pt_regs->r9 */ + xorq %r9, %r9 /* nospec r9 */ + pushq %r10 /* pt_regs->r10 */ + xorq %r10, %r10 /* nospec r10 */ + pushq %r11 /* pt_regs->r11 */ + xorq %r11, %r11 /* nospec r11*/ + pushq %rbx /* pt_regs->rbx */ + xorl %ebx, %ebx /* nospec rbx*/ + pushq %rbp /* pt_regs->rbp */ + xorl %ebp, %ebp /* nospec rbp*/ + pushq %r12 /* pt_regs->r12 */ + xorq %r12, %r12 /* nospec r12*/ + pushq %r13 /* pt_regs->r13 */ + xorq %r13, %r13 /* nospec r13*/ + pushq %r14 /* pt_regs->r14 */ + xorq %r14, %r14 /* nospec r14*/ + pushq %r15 /* pt_regs->r15 */ + xorq %r15, %r15 /* nospec r15*/ +UNWIND_HINT_REGS + .endm + .macro POP_REGS pop_rdi=1 skip_r11rcx=0 popq %r15 popq %r14
arch/x86/entry/entry_64.S +2 -4
@@ -564,8 +564,7 @@ END(irq_entries_start) call switch_to_thread_stack 1: - ALLOC_PT_GPREGS_ON_STACK - SAVE_AND_CLEAR_REGS + PUSH_AND_CLEAR_REGS ENCODE_FRAME_POINTER testb $3, CS(%rsp)
@@ -1112,8 +1111,7 @@ ENTRY(xen_failsafe_callback) addq $0x30, %rsp UNWIND_HINT_IRET_REGS pushq $-1 /* orig_ax = -1 => not a system call */ - ALLOC_PT_GPREGS_ON_STACK - SAVE_AND_CLEAR_REGS + PUSH_AND_CLEAR_REGS ENCODE_FRAME_POINTER jmp error_exit END(xen_failsafe_callback)
Greg Kroah-Hartman
maintainerPATCH 63/163 x86/entry/64: Use PUSH_AND_CLEAN_REGS in more cases
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Dominik Brodowski <[email protected]>
commit 30907fd13bb593202574bb20af58d67c70a1ee14 upstream.
entry_SYSCALL_64_after_hwframe() and nmi() can be converted to use PUSH_AND_CLEAN_REGS instead of opencoded variants thereof. Due to the interleaving, the additional XOR-based clearing of R8 and R9 in entry_SYSCALL_64_after_hwframe() should not have any noticeable negative implications.
--- arch/x86/entry/calling.h | 6 ++-- arch/x86/entry/entry_64.S | 65 ++-------------------------------------------- 2 files changed, 6 insertions(+), 65 deletions(-)
arch/x86/entry/calling.h +3 -3
@@ -137,7 +137,7 @@ For 32-bit we have the following convent UNWIND_HINT_REGS offset=\offset .endm - .macro PUSH_AND_CLEAR_REGS + .macro PUSH_AND_CLEAR_REGS rdx=%rdx rax=%rax/* * Push registers and sanitize registers of values that a * speculation attack might otherwise want to exploit. The
@@ -147,9 +147,9 @@ For 32-bit we have the following convent*/ pushq %rdi /* pt_regs->di */ pushq %rsi/* pt_regs->si */ - pushq %rdx /* pt_regs->dx */ + pushq \rdx /* pt_regs->dx */ pushq %rcx /* pt_regs->cx */ - pushq %rax /* pt_regs->ax */ + pushq \rax /* pt_regs->ax */ pushq %r8 /* pt_regs->r8 */ xorq %r8, %r8 /* nospec r8 */ pushq %r9/* pt_regs->r9 */
arch/x86/entry/entry_64.S +3 -62
77 lines not on this page · raw message
Greg Kroah-Hartman
maintainerPATCH 64/163 x86/entry/64: Get rid of the ALLOC_PT_GPREGS_ON_STACK and SAVE_AND_CLEAR_REGS macros
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Dominik Brodowski <[email protected]>
commit dde3036d62ba3375840b10ab9ec0d568fd773b07 upstream.
Previously, error_entry() and paranoid_entry() saved the GP registers onto stack space previously allocated by its callers. Combine these two steps in the callers, and use the generic PUSH_AND_CLEAR_REGS macro for that.
This adds a significant amount ot text size. However, Ingo Molnar points out that:
"these numbers also _very_ significantly over-represent the extra footprint. The assumptions that resulted in us compressing the IRQ entry code have changed very significantly with the new x86 IRQ allocation code we introduced in the last year:
- IRQ vectors are usually populated in tightly clustered groups.
With our new vector allocator code the typical per CPU allocation percentage on x86 systems is ~3 device vectors and ~10 fixed vectors out of ~220 vectors - i.e. a very low ~6% utilization (!). [...]
The days where we allocated a lot of vectors on every CPU and the compression of the IRQ entry code text mattered are over.
- Another issue is that only a small minority of vectors is frequent enough to actually matter to cache utilization in practice: 3-4 key IPIs and 1-2 device IRQs at most - and those vectors tend to be tightly clustered as well into about two groups, and are probably already on 2-3 cache lines in practice.
For the common case of 'cache cold' IRQs it's the depth of the call chain and the fragmentation of the resulting I$ that should be the main performance limit - not the overall size of it.
- The CPU side cost of IRQ delivery is still very expensive even in the best, most cached case, as in 'over a thousand cycles'. So much stuff is done that maybe contemporary x86 IRQ entry microcode already prefetches the IDT entry and its expected call target address."[*]
[*] http://lkml.kernel.org/r/[email protected]
The "testb $3, CS(%rsp)" instruction in the idtentry macro does not need modification. Previously, %rsp was manually decreased by 15*8; with this patch, %rsp is decreased by 15 pushq instructions.
[[email protected]: unwind hint improvements]
--- arch/x86/entry/calling.h | 42 +----------------------------------------- arch/x86/entry/entry_64.S | 20 +++++++++----------- 2 files changed, 10 insertions(+), 52 deletions(-)
arch/x86/entry/calling.h +1 -41
@@ -97,46 +97,6 @@ For 32-bit we have the following convent#define SIZEOF_PTREGS 21*8 - .macro ALLOC_PT_GPREGS_ON_STACK - addq $-(15*8), %rsp - .endm - - .macro SAVE_AND_CLEAR_REGS offset=0 -/* -* Save registers and sanitize registers of values that a -* speculation attack might otherwise want to exploit. The -* lower registers are likely clobbered well before they -* could be put to use in a speculative execution gadget. -* Interleave XOR with PUSH for better uop scheduling: -*/ - movq %rdi, 14*8+\offset(%rsp) - movq %rsi, 13*8+\offset(%rsp) - movq %rdx, 12*8+\offset(%rsp) - movq %rcx, 11*8+\offset(%rsp) - movq %rax, 10*8+\offset(%rsp) - movq %r8, 9*8+\offset(%rsp) - xorq %r8, %r8 /* nospec r8 */ - movq %r9, 8*8+\offset(%rsp) - xorq %r9, %r9 /* nospec r9 */ - movq %r10, 7*8+\offset(%rsp) - xorq %r10, %r10 /* nospec r10 */ - movq %r11, 6*8+\offset(%rsp) - xorq %r11, %r11 /* nospec r11 */ - movq %rbx, 5*8+\offset(%rsp) - xorl %ebx, %ebx /* nospec rbx */ - movq %rbp, 4*8+\offset(%rsp) - xorl %ebp, %ebp /* nospec rbp */ - movq %r12, 3*8+\offset(%rsp) - xorq %r12, %r12 /* nospec r12 */ - movq %r13, 2*8+\offset(%rsp) - xorq %r13, %r13 /* nospec r13 */ - movq %r14, 1*8+\offset(%rsp) - xorq %r14, %r14 /* nospec r14 */ - movq %r15, 0*8+\offset(%rsp) - xorq %r15, %r15 /* nospec r15 */ - UNWIND_HINT_REGS offset=\offset - .endm - .macro PUSH_AND_CLEAR_REGS rdx=%rdx rax=%rax/* * Push registers and sanitize registers of values that a
@@ -211,7 +171,7 @@ For 32-bit we have the following convent* is just setting the LSB, which makes it an invalid stack address and is also * a signal to the unwinder that it's a pt_regs pointer in disguise. * -* NOTE: This macro must be used *after* SAVE_AND_CLEAR_REGS because it corrupts +* NOTE: This macro must be used *after* PUSH_AND_CLEAR_REGS because it corrupts * the original rbp. */ .macro ENCODE_FRAME_POINTER ptregs_offset=0
arch/x86/entry/entry_64.S +9 -11
@@ -871,7 +871,9 @@ ENTRY(\sym) pushq $-1 /* ORIG_RAX: no syscall to restart */ .endif - ALLOC_PT_GPREGS_ON_STACK + /* Save all registers in pt_regs */ + PUSH_AND_CLEAR_REGS + ENCODE_FRAME_POINTER .if \paranoid < 2 testb $3, CS(%rsp) /* If coming from userspace, switch stacks */
@@ -1121,15 +1123,12 @@ idtentry machine_check do_mce has_err #endif /* - * Save all registers in pt_regs, and switch gs if needed. + * Switch gs if needed. * Use slow, but surefire "are we in kernel?" check. * Return: ebx=0: need swapgs on exit, ebx=1: otherwise */ ENTRY(paranoid_entry) - UNWIND_HINT_FUNC cld - SAVE_AND_CLEAR_REGS 8 - ENCODE_FRAME_POINTER 8 movl $1, %ebx movl $MSR_GS_BASE, %ecx rdmsr
@@ -1142,7 +1141,7 @@ ENTRY(paranoid_entry) SAVE_AND_SWITCH_TO_KERNEL_CR3 scratch_reg=%rax save_reg=%r14 ret -END(paranoid_entry) +ENDPROC(paranoid_entry) /* * "Paranoid" exit path from exception stack. This is invoked
@@ -1173,14 +1172,12 @@ ENTRY(paranoid_exit) END(paranoid_exit) /* - * Save all registers in pt_regs, and switch gs if needed. + * Switch gs if needed. * Return: EBX=0: came from user mode; EBX=1: otherwise */ ENTRY(error_entry) - UNWIND_HINT_FUNC + UNWIND_HINT_REGS offset=8 cld - SAVE_AND_CLEAR_REGS 8 - ENCODE_FRAME_POINTER 8 testb $3, CS+8(%rsp) jz .Lerror_kernelspace
@@ -1571,7 +1568,8 @@ end_repeat_nmi: * frame to point back to repeat_nmi. */ pushq $-1 /* ORIG_RAX: no syscall to restart */ - ALLOC_PT_GPREGS_ON_STACK + PUSH_AND_CLEAR_REGS + ENCODE_FRAME_POINTER /* * Use paranoid_entry to handle SWAPGS, but no need to use paranoid_exit
Greg Kroah-Hartman
maintainerPATCH 65/163 x86/entry/64: Indent PUSH_AND_CLEAR_REGS and POP_REGS properly
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Dominik Brodowski <[email protected]>
commit 92816f571af81e9a71cc6f3dc8ce1e2fcdf7b6b8 upstream.
... same as the other macros in arch/x86/entry/calling.h
--- arch/x86/entry/calling.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
arch/x86/entry/calling.h +4 -4
@@ -97,7 +97,7 @@ For 32-bit we have the following convent#define SIZEOF_PTREGS 21*8 - .macro PUSH_AND_CLEAR_REGS rdx=%rdx rax=%rax +.macro PUSH_AND_CLEAR_REGS rdx=%rdx rax=%rax/* * Push registers and sanitize registers of values that a * speculation attack might otherwise want to exploit. The
@@ -131,9 +131,9 @@ For 32-bit we have the following convent pushq %r15 /* pt_regs->r15 */ xorq %r15, %r15 /* nospec r15*/UNWIND_HINT_REGS - .endm +.endm - .macro POP_REGS pop_rdi=1 skip_r11rcx=0 +.macro POP_REGS pop_rdi=1 skip_r11rcx=0 popq %r15 popq %r14 popq %r13
@@ -163,7 +163,7 @@ For 32-bit we have the following convent .macro icebp .byte 0xf1 - .endm +.endm/* * This is a sneaky trick to help the unwinder find pt_regs on the stack. The
Greg Kroah-Hartman
maintainerPATCH 66/163 x86/entry/64: Fix paranoid_entry() frame pointer warning
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Josh Poimboeuf <[email protected]>
commit b3ccefaed922529e6a67de7b30af5aa38c76ace9 upstream.
With the following commit:
f09d160992d1 ("x86/entry/64: Get rid of the ALLOC_PT_GPREGS_ON_STACK and SAVE_AND_CLEAR_REGS macros")
... one of my suggested improvements triggered a frame pointer warning:
arch/x86/entry/entry_64.o: warning: objtool: paranoid_entry()+0x11: call without frame pointer save/setup
The warning is correct for the build-time code, but it's actually not relevant at runtime because of paravirt patching. The paravirt swapgs call gets replaced with either a SWAPGS instruction or NOPs at runtime.
Go back to the previous behavior by removing the ELF function annotation for paranoid_entry() and adding an unwind hint, which effectively silences the warning.
--- arch/x86/entry/entry_64.S | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
arch/x86/entry/entry_64.S +2 -1
@@ -1128,6 +1128,7 @@ idtentry machine_check do_mce has_err * Return: ebx=0: need swapgs on exit, ebx=1: otherwise */ ENTRY(paranoid_entry) + UNWIND_HINT_FUNC cld movl $1, %ebx movl $MSR_GS_BASE, %ecx
@@ -1141,7 +1142,7 @@ ENTRY(paranoid_entry) SAVE_AND_SWITCH_TO_KERNEL_CR3 scratch_reg=%rax save_reg=%r14 ret -ENDPROC(paranoid_entry) +END(paranoid_entry) /* * "Paranoid" exit path from exception stack. This is invoked
Greg Kroah-Hartman
maintainerPATCH 67/163 x86/entry/64: Remove the unused icebp macro
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Borislav Petkov <[email protected]>
commit b498c261107461d5c42140dfddd05df83d8ca078 upstream.
That macro was touched around 2.5.8 times, judging by the full history linux repo, but it was unused even then. Get rid of it already.
--- arch/x86/entry/calling.h | 4 ---- 1 file changed, 4 deletions(-)
arch/x86/entry/calling.h +0 -4
@@ -159,10 +159,6 @@ For 32-bit we have the following convent .if \pop_rdi popq %rdi .endif - .endm - - .macro icebp - .byte 0xf1 .endm/*
Greg Kroah-Hartman
maintainerPATCH 68/163 selftests/x86: Fix vDSO selftest segfault for vsyscall=none
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Dominik Brodowski <[email protected]>
commit 198ee8e17502da2634f7366395db1d77630e0219 upstream.
The vDSO selftest tries to execute a vsyscall unconditionally, even if it is not present on the test system (e.g. if booted with vsyscall=none or with CONFIG_LEGACY_VSYSCALL_NONE=y set. Fix this by copying (and tweaking) the vsyscall check from test_vsyscall.c
--- tools/testing/selftests/x86/test_vdso.c | 50 +++++++++++++++++++++++++++----- 1 file changed, 43 insertions(+), 7 deletions(-)
tools/testing/selftests/x86/test_vdso.c +43 -7
@@ -28,18 +28,52 @@int nerrs =0 ; +typedef long (*getcpu_t )(unsigned *,unsigned *,void *); + +getcpu_t vgetcpu; +getcpu_t vdso_getcpu; + +static void *vsyscall_getcpu (void ) +{#ifdef __x86_64__ -# define VSYS (x) (x) +FILE *maps; +char line[128 ]; +bool found = false; + + maps =fopen ("/proc/self/maps" ,"r" ); +if (!maps)/* might still be present, but ignore it here, as we test vDSO not vsyscall */ +return NULL ; + +while (fgets (line,sizeof (line), maps)) { +char r, x; +void *start, *end; +char name[128 ]; +if (sscanf (line,"%p-%p %c-%cp %*x %*x:%*x %*u %s" , + &start, &end, &r, &x, name) !=5 ) +continue ; + +if (strcmp (name,"[vsyscall]" )) +continue ; + +/* assume entries are OK, as we test vDSO here not vsyscall */ + found = true; +break ; + } + +fclose (maps); + +if (!found) { +printf ("Warning: failed to find vsyscall getcpu\n" ); +return NULL ; + } +return (void *) (0xffffffffff600800 );#else -# define VSYS (x) 0 +return NULL ;#endif +} -typedef long (*getcpu_t )(unsigned *,unsigned *,void *); - -const getcpu_t vgetcpu = (getcpu_t )VSYS (0xffffffffff600800 ); -getcpu_t vdso_getcpu; -void fill_function_pointers () +static void fill_function_pointers () {void *vdso =dlopen ("linux-vdso.so.1" ,RTLD_LAZY |RTLD_LOCAL |RTLD_NOLOAD );
@@ -54,6 +88,8 @@ void fill_function_pointers() vdso_getcpu = (getcpu_t )dlsym (vdso,"__vdso_getcpu" );if (!vdso_getcpu)printf ("Warning: failed to find getcpu in vDSO\n" ); + + vgetcpu = (getcpu_t )vsyscall_getcpu (); } static long sys_getcpu(unsigned * cpu, unsigned * node,
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Greg Kroah-Hartman
maintainerPATCH 69/163 selftests/x86: Clean up and document sscanf() usage
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Dominik Brodowski <[email protected]>
commit d8e92de8ef952bed88c56c7a44c02d8dcae0984e upstream.
Replace a couple of magically connected buffer length literal constants with a common definition that makes their relationship obvious. Also document why our sscanf() usage is safe.
No intended functional changes.
--- tools/testing/selftests/x86/test_vdso.c | 11 ++++++++--- tools/testing/selftests/x86/test_vsyscall.c | 11 ++++++++--- 2 files changed, 16 insertions(+), 6 deletions(-)
tools/testing/selftests/x86/test_vdso.c +8 -3
@@ -26,6 +26,9 @@# endif #endif +/* max length of lines in /proc/self/maps - anything longer is skipped here */ +#define MAPS_LINE_LEN 128 +int nerrs =0 ;typedef long (*getcpu_t )(unsigned *,unsigned *,void *);
@@ -37,17 +40,19 @@ static void *vsyscall_getcpu(void) {#ifdef __x86_64__FILE *maps; -char line[128 ]; +char line[MAPS_LINE_LEN ];bool found = false; maps =fopen ("/proc/self/maps" ,"r" );if (!maps)/* might still be present, but ignore it here, as we test vDSO not vsyscall */ return NULL ; -while (fgets (line,sizeof (line), maps)) { +while (fgets (line,MAPS_LINE_LEN , maps)) {char r, x;void *start, *end; -char name[128 ]; +char name[MAPS_LINE_LEN ]; + +/* sscanf() is safe here as strlen(name) >= strlen(line) */ if (sscanf (line,"%p-%p %c-%cp %*x %*x:%*x %*u %s" , &start, &end, &r, &x, name) !=5 )continue ;
tools/testing/selftests/x86/test_vsyscall.c +8 -3
@@ -33,6 +33,9 @@# endif #endif +/* max length of lines in /proc/self/maps - anything longer is skipped here */ +#define MAPS_LINE_LEN 128 +static void sethandler (int sig,void (*handler)(int ,siginfo_t *,void *),int flags) {
@@ -98,7 +101,7 @@ static int init_vsys(void)#ifdef __x86_64__int nerrs =0 ;FILE *maps; -char line[128 ]; +char line[MAPS_LINE_LEN ];bool found = false; maps =fopen ("/proc/self/maps" ,"r" );
@@ -108,10 +111,12 @@ static int init_vsys(void)return 0 ; } -while (fgets (line,sizeof (line), maps)) { +while (fgets (line,MAPS_LINE_LEN , maps)) {char r, x;void *start, *end; -char name[128 ]; +char name[MAPS_LINE_LEN ]; + +/* sscanf() is safe here as strlen(name) >= strlen(line) */ if (sscanf (line,"%p-%p %c-%cp %*x %*x:%*x %*u %s" , &start, &end, &r, &x, name) !=5 )continue ;
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Greg Kroah-Hartman
maintainerPATCH 70/163 selftests/x86/pkeys: Remove unused functions
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Ingo Molnar <[email protected]>
commit ce676638fe7b284132a7d7d5e7e7ad81bab9947e upstream.
This also gets rid of two build warnings:
protection_keys.c: In function ‘dumpit’:
protection_keys.c:419:3: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result [-Wunused-result]
write(1, buf, nr_read);
^~~~~~~~~~~~~~~~~~~~~~--- tools/testing/selftests/x86/protection_keys.c | 28 -------------------------- 1 file changed, 28 deletions(-)
tools/testing/selftests/x86/protection_keys.c +0 -28
@@ -393,34 +393,6 @@ pid_t fork_lazy_child(void)return forkret; } -void davecmp (void *_a,void *_b,int len) -{ -int i; -unsigned long *a = _a; -unsigned long *b = _b; - -for (i =0 ; i < len /sizeof (*a); i++) { -if (a[i] == b[i]) -continue ; - -dprintf3 ("[%3d]: a: %016lx b: %016lx\n" , i, a[i], b[i]); - } -} - -void dumpit (char *f) -{ -int fd =open (f,O_RDONLY ); -char buf[100 ]; -int nr_read; - -dprintf2 ("maps fd: %d\n" , fd); -do { - nr_read =read (fd, &buf[0 ],sizeof (buf)); -write (1 , buf, nr_read); - }while (nr_read >0 ); -close (fd); -} -#define PKEY_DISABLE_ACCESS 0x1#define PKEY_DISABLE_WRITE 0x2
Greg Kroah-Hartman
maintainerPATCH 71/163 selftests/x86: Fix build bug caused by the 5lvl test which has been moved to the VM directory
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Dominik Brodowski <linux at dominikbrodowski.net>
commit 7f95122067ab26fb8344b2a9de64ffbd0fea0010 upstream.
--- tools/testing/selftests/x86/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/x86/Makefile +1 -1
@@ -11,7 +11,7 @@ TARGETS_C_BOTHBITS := single_step_syscal TARGETS_C_32BIT_ONLY := entry_from_vm86 syscall_arg_fault test_syscall_vdso unwind_vdso \ test_FCMOV test_FCOMI test_FISTTP \ vdso_restorer -TARGETS_C_64BIT_ONLY := fsgsbase sysret_rip 5lvl +TARGETS_C_64BIT_ONLY := fsgsbase sysret_rip TARGETS_C_32BIT_ALL := $(TARGETS_C_BOTHBITS) $(TARGETS_C_32BIT_ONLY) TARGETS_C_64BIT_ALL := $(TARGETS_C_BOTHBITS) $(TARGETS_C_64BIT_ONLY)
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Greg Kroah-Hartman
maintainerPATCH 72/163 selftests/x86: Do not rely on "int $0x80" in test_mremap_vdso.c
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Dominik Brodowski <linux at dominikbrodowski.net>
commit 2cbc0d66de0480449c75636f55697c7ff3af61fc upstream.
On 64-bit builds, we should not rely on "int $0x80" working (it only does if CONFIG_IA32_EMULATION=y is enabled).
Without this patch, the move test may succeed, but the "int $0x80" causes a segfault, resulting in a false negative output of this self-test.
--- tools/testing/selftests/x86/test_mremap_vdso.c | 4 ++++ 1 file changed, 4 insertions(+)
tools/testing/selftests/x86/test_mremap_vdso.c +4 -0
@@ -90,8 +90,12 @@ int main(int argc, char **argv, char **e vdso_size +=PAGE_SIZE ; } +#ifdef __i386__/* Glibc is likely to explode now - exit with raw syscall */ asmvolatile ("int $0x80" : :"a" (__NR_exit),"b" (!!ret)); +#else /* __x86_64__ */ +syscall (SYS_exit, ret); +#endif }else {int status;
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Greg Kroah-Hartman
maintainerPATCH 73/163 gfs2: Fixes to "Implement iomap for block_map"
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Andreas Gruenbacher <[email protected]>
commit 49edd5bf429c405b3a7f75503845d9f66a47dd4b upstream.
It turns out that commit 3974320ca6 "Implement iomap for block_map" introduced a few bugs that trigger occasional failures with xfstest generic/476:
In gfs2_iomap_begin, we jump to do_alloc when we determine that we are beyond the end of the allocated metadata (height > ip->i_height). There, we can end up calling hole_size with a metapath that doesn't match the current metadata tree, which doesn't make sense. After untangling the code at do_alloc, fix this by checking if the block we are looking for is within the range of allocated metadata.
In addition, add a BUG() in case gfs2_iomap_begin is accidentally called for reading stuffed files: this is handled separately. Make sure we don't truncate iomap->length for reads beyond the end of the file; in that case, the entire range counts as a hole.
Finally, revert to taking a bitmap write lock when doing allocations. It's unclear why that change didn't lead to any failures during testing.
--- fs/gfs2/bmap.c | 43 +++++++++++++++++++++++-------------------- 1 file changed, 23 insertions(+), 20 deletions(-)
fs/gfs2/bmap.c +23 -20
@@ -736,7 +736,7 @@ int gfs2_iomap_begin(struct inode *inode__be64 *ptr;sector_t lblock;sector_t lend; -int ret; +int ret =0 ;int eob;unsigned int len;struct buffer_head *bh;
@@ -748,12 +748,14 @@ int gfs2_iomap_begin(struct inode *inode goto out; } -if ((flags &IOMAP_REPORT ) &&gfs2_is_stuffed (ip)) { -gfs2_stuffed_iomap (inode, iomap); -if (pos >= iomap->length) -return -ENOENT ; - ret =0 ; - goto out; +if (gfs2_is_stuffed (ip)) { +if (flags &IOMAP_REPORT ) { +gfs2_stuffed_iomap (inode, iomap); +if (pos >= iomap->length) + ret = -ENOENT ; + goto out; + } +BUG_ON (!(flags &IOMAP_WRITE )); } lblock = pos >> inode->i_blkbits;
@@ -764,7 +766,7 @@ int gfs2_iomap_begin(struct inode *inode iomap->type =IOMAP_HOLE ; iomap->length = (u64)(lend - lblock) << inode->i_blkbits; iomap->flags =IOMAP_F_MERGED ; -bmap_lock (ip,0 ); +bmap_lock (ip, flags &IOMAP_WRITE );/* * Directory data blocks have a struct gfs2_meta_header header, so the
@@ -807,27 +809,28 @@ int gfs2_iomap_begin(struct inode *inode iomap->flags |=IOMAP_F_BOUNDARY ; iomap->length = (u64 )len << inode->i_blkbits; - ret =0 ; - out_release:release_metapath (&mp); -bmap_unlock (ip,0 ); +bmap_unlock (ip, flags &IOMAP_WRITE ); out:trace_gfs2_iomap_end (ip, iomap, ret);return ret; do_alloc: -if (!(flags &IOMAP_WRITE )) { -if (pos >=i_size_read (inode)) { +if (flags &IOMAP_WRITE ) { + ret =gfs2_iomap_alloc (inode, iomap, flags, &mp); + }else if (flags &IOMAP_REPORT ) { +loff_t size =i_size_read (inode); +if (pos >= size) ret = -ENOENT ; - goto out_release; - } - ret =0 ; - iomap->length =hole_size (inode, lblock, &mp); - goto out_release; +else if (height <= ip->i_height) + iomap->length =hole_size (inode, lblock, &mp); +else + iomap->length = size - pos; + }else { +if (height <= ip->i_height) + iomap->length =hole_size (inode, lblock, &mp); } - - ret =gfs2_iomap_alloc (inode, iomap, flags, &mp); goto out_release; }
Greg Kroah-Hartman
maintainerPATCH 74/163 selftests/x86: Do not rely on "int $0x80" in single_step_syscall.c
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Dominik Brodowski <linux at dominikbrodowski.net>
commit 4105c69703cdeba76f384b901712c9397b04e9c2 upstream.
On 64-bit builds, we should not rely on "int $0x80" working (it only does if CONFIG_IA32_EMULATION=y is enabled). To keep the "Set TF and check int80" test running on 64-bit installs with CONFIG_IA32_EMULATION=y enabled, build this test only if we can also build 32-bit binaries (which should be a good approximation for that).
--- tools/testing/selftests/x86/Makefile | 2 ++ tools/testing/selftests/x86/single_step_syscall.c | 5 ++++- 2 files changed, 6 insertions(+), 1 deletion(-)
tools/testing/selftests/x86/Makefile +2 -0
@@ -30,11 +30,13 @@ CAN_BUILD_X86_64 := $(shell ./check_cc.s ifeq ($(CAN_BUILD_I386),1) all: all_32 TEST_PROGS += $(BINARIES_32) +EXTRA_CFLAGS += -DCAN_BUILD_32 endif ifeq ($(CAN_BUILD_X86_64),1) all: all_64 TEST_PROGS += $(BINARIES_64) +EXTRA_CFLAGS += -DCAN_BUILD_64 endif all_32: $(BINARIES_32)
tools/testing/selftests/x86/single_step_syscall.c +4 -1
@@ -119,7 +119,9 @@ static void check_result(void)int main () { +#ifdef CAN_BUILD_32 int tmp; +#endif sethandler (SIGTRAP , sigtrap,0 );
@@ -139,12 +141,13 @@ int main() : : "c" (post_nop) : "r11");check_result ();#endif - +#ifdef CAN_BUILD_32 printf ("[RUN]\tSet TF and check int80\n" );set_eflags (get_eflags () |X86_EFLAGS_TF ); asmvolatile ("int $0x80" :"=a" (tmp) :"a" (SYS_getpid) : INT80_CLOBBERS);check_result (); +#endif /* * This test is particularly interesting if fast syscalls use
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Greg Kroah-Hartman
maintainerPATCH 75/163 selftests/x86: Disable tests requiring 32-bit support on pure 64-bit systems
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Dominik Brodowski <[email protected]>
commit 9279ddf23ce78ff2676e8e8e19fec0f022c26d04 upstream.
The ldt_gdt and ptrace_syscall selftests, even in their 64-bit variant, use hard-coded 32-bit syscall numbers and call "int $0x80".
This will fail on 64-bit systems with CONFIG_IA32_EMULATION=y disabled.
Therefore, do not build these tests if we cannot build 32-bit binaries (which should be a good approximation for CONFIG_IA32_EMULATION=y being enabled).
--- tools/testing/selftests/x86/Makefile | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-)
tools/testing/selftests/x86/Makefile +13 -7
@@ -5,16 +5,26 @@ include ../lib.mk .PHONY: all all_32 all_64 warn_32bit_failure clean -TARGETS_C_BOTHBITS := single_step_syscall sysret_ss_attrs syscall_nt ptrace_syscall test_mremap_vdso \ - check_initial_reg_state sigreturn ldt_gdt iopl mpx-mini-test ioperm \ +UNAME_M := $(shell uname -m) +CAN_BUILD_I386 := $(shell ./check_cc.sh $(CC) trivial_32bit_program.c -m32) +CAN_BUILD_X86_64 := $(shell ./check_cc.sh $(CC) trivial_64bit_program.c) + +TARGETS_C_BOTHBITS := single_step_syscall sysret_ss_attrs syscall_nt test_mremap_vdso \ + check_initial_reg_state sigreturn iopl mpx-mini-test ioperm \ protection_keys test_vdso test_vsyscall TARGETS_C_32BIT_ONLY := entry_from_vm86 syscall_arg_fault test_syscall_vdso unwind_vdso \ test_FCMOV test_FCOMI test_FISTTP \ vdso_restorer TARGETS_C_64BIT_ONLY := fsgsbase sysret_rip +# Some selftests require 32bit support enabled also on 64bit systems +TARGETS_C_32BIT_NEEDED := ldt_gdt ptrace_syscall -TARGETS_C_32BIT_ALL := $(TARGETS_C_BOTHBITS) $(TARGETS_C_32BIT_ONLY) +TARGETS_C_32BIT_ALL := $(TARGETS_C_BOTHBITS) $(TARGETS_C_32BIT_ONLY) $(TARGETS_C_32BIT_NEEDED) TARGETS_C_64BIT_ALL := $(TARGETS_C_BOTHBITS) $(TARGETS_C_64BIT_ONLY) +ifeq ($(CAN_BUILD_I386)$(CAN_BUILD_X86_64),11) +TARGETS_C_64BIT_ALL += $(TARGETS_C_32BIT_NEEDED) +endif + BINARIES_32 := $(TARGETS_C_32BIT_ALL:%=%_32) BINARIES_64 := $(TARGETS_C_64BIT_ALL:%=%_64)
@@ -23,10 +33,6 @@ BINARIES_64 := $(patsubst %,$(OUTPUT)/%, CFLAGS := -O2 -g -std=gnu99 -pthread -Wall -no-pie -UNAME_M := $(shell uname -m) -CAN_BUILD_I386 := $(shell ./check_cc.sh $(CC) trivial_32bit_program.c -m32) -CAN_BUILD_X86_64 := $(shell ./check_cc.sh $(CC) trivial_64bit_program.c) - ifeq ($(CAN_BUILD_I386),1) all: all_32 TEST_PROGS += $(BINARIES_32)
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Greg Kroah-Hartman
maintainerPATCH 76/163 objtool: Fix segfault in ignore_unreachable_insn()
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Josh Poimboeuf <[email protected]>
commit fe24e27128252c230a34a6c628da2bf1676781ea upstream.
Peter Zijlstra's patch for converting WARN() to use UD2 triggered a bunch of false "unreachable instruction" warnings, which then triggered a seg fault in ignore_unreachable_insn().
The seg fault happened when it tried to dereference a NULL 'insn->func' pointer. Thanks to static_cpu_has(), some functions can jump to a non-function area in the .altinstr_aux section. That breaks ignore_unreachable_insn()'s assumption that it's always inside the original function.
Make sure ignore_unreachable_insn() only follows jumps within the current function.
--- tools/objtool/check.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-)
tools/objtool/check.c +9 -3
@@ -1935,13 +1935,19 @@ static bool ignore_unreachable_insn(struif (is_kasan_insn (insn) ||is_ubsan_insn (insn))return true; -if (insn->type ==INSN_JUMP_UNCONDITIONAL && insn->jump_dest) { - insn = insn->jump_dest; -continue ; +if (insn->type ==INSN_JUMP_UNCONDITIONAL ) { +if (insn->jump_dest && + insn->jump_dest->func == insn->func) { + insn = insn->jump_dest; +continue ; + } + +break ; }if (insn->offset + insn->len >= insn->func->offset + insn->func->len)break ; + insn =list_next_entry (insn, list); }
Greg Kroah-Hartman
maintainerPATCH 77/163 x86/debug, objtool: Annotate WARN()-related UD2 as reachable
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Josh Poimboeuf <[email protected]>
commit 2b5db66862b95532cb6cca8165ae6eb73633cf85 upstream.
By default, objtool assumes that a UD2 is a dead end. This is mainly because GCC 7+ sometimes inserts a UD2 when it detects a divide-by-zero condition.
Now that WARN() is moving back to UD2, annotate the code after it as reachable so objtool can follow the code flow.
--- arch/x86/include/asm/bug.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
arch/x86/include/asm/bug.h +5 -1
@@ -77,7 +77,11 @@ do { \unreachable (); \ } while (0) -#define __WARN_FLAGS (flags) _BUG_FLAGS(ASM_UD0, BUGFLAG_WARNING|(flags)) +#define __WARN_FLAGS (flags) \ +do { \ + _BUG_FLAGS(ASM_UD0, BUGFLAG_WARNING|(flags)); \ + annotate_reachable(); \ +} while (0)#include <asm-generic/bug.h>
Greg Kroah-Hartman
maintainerPATCH 78/163 x86/debug: Use UD2 for WARN()
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Peter Zijlstra <[email protected]>
commit 3b3a371cc9bc980429baabe0a8e5f307f3d1f463 upstream.
Since the Intel SDM added an ModR/M byte to UD0 and binutils followed that specification, we now cannot disassemble our kernel anymore.
This now means Intel and AMD disagree on the encoding of UD0. And instead of playing games with additional bytes that are valid ModR/M and single byte instructions (0xd6 for instance), simply use UD2 for both WARN() and BUG().
--- arch/x86/include/asm/bug.h | 15 ++++++--------- arch/x86/kernel/traps.c | 2 +- 2 files changed, 7 insertions(+), 10 deletions(-)
arch/x86/include/asm/bug.h +6 -9
@@ -5,23 +5,20 @@#include <linux/stringify.h> /* -* Since some emulators terminate on UD2, we cannot use it for WARN. -* Since various instruction decoders disagree on the length of UD1, -* we cannot use it either. So use UD0 for WARN. +* Despite that some emulators terminate on UD2, we use it for WARN(). * -* (binutils knows about "ud1" but {en,de}codes it as 2 bytes, whereas -* our kernel decoder thinks it takes a ModRM byte, which seems consistent -* with various things like the Intel SDM instruction encoding rules) +* Since various instruction decoders/specs disagree on the encoding of +* UD0/UD1. */ -#define ASM_UD0 ".byte 0x0f, 0xff" +#define ASM_UD0 ".byte 0x0f, 0xff"/* + ModRM (for Intel) */ #define ASM_UD1 ".byte 0x0f, 0xb9"/* + ModRM */ #define ASM_UD2 ".byte 0x0f, 0x0b"#define INSN_UD0 0xff0f#define INSN_UD2 0x0b0f -#define LEN_UD0 2 +#define LEN_UD2 2#ifdef CONFIG_GENERIC_BUG
@@ -79,7 +76,7 @@ do { \#define __WARN_FLAGS (flags) \ do { \ - _BUG_FLAGS(ASM_UD0, BUGFLAG_WARNING|(flags)); \ + _BUG_FLAGS(ASM_UD2, BUGFLAG_WARNING|(flags)); \ annotate_reachable(); \ } while (0)
arch/x86/kernel/traps.c +1 -1
@@ -181,7 +181,7 @@ int fixup_bug(struct pt_regs *regs, intbreak ;case BUG_TRAP_TYPE_WARN : - regs->ip +=LEN_UD0 ; + regs->ip +=LEN_UD2 ;return 1 ; }
Greg Kroah-Hartman
maintainerPATCH 79/163 x86/speculation: Fix up array_index_nospec_mask() asm constraint
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Dan Williams <[email protected]>
commit be3233fbfcb8f5acb6e3bcd0895c3ef9e100d470 upstream.
Allow the compiler to handle @size as an immediate value or memory directly rather than allocating a register.
--- arch/x86/include/asm/barrier.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/include/asm/barrier.h +1 -1
@@ -40,7 +40,7 @@ static inline unsigned long array_index_ asm ("cmp %1,%2; sbb %0,%0;" :"=r" (mask) - :"r" (size),"r" (index) + :"g" (size),"r" (index) :"cc" );return mask; }
Greg Kroah-Hartman
maintainerPATCH 80/163 nospec: Move array_index_nospec() parameter checking into separate macro
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Will Deacon <[email protected]>
commit 8fa80c503b484ddc1abbd10c7cb2ab81f3824a50 upstream.
For architectures providing their own implementation of array_index_mask_nospec() in asm/barrier.h, attempting to use WARN_ONCE() to complain about out-of-range parameters using WARN_ON() results in a mess of mutually-dependent include files.
Rather than unpick the dependencies, simply have the core code in nospec.h perform the checking for us.
--- include/linux/nospec.h | 36 +++++++++++++++++++++--------------- 1 file changed, 21 insertions(+), 15 deletions(-)
include/linux/nospec.h +21 -15
@@ -20,20 +20,6 @@ static inline unsigned long array_index_ unsigned long size) {/* -* Warn developers about inappropriate array_index_nospec() usage. -* -* Even if the CPU speculates past the WARN_ONCE branch, the -* sign bit of @index is taken into account when generating the -* mask. -* -* This warning is compiled out when the compiler can infer that -* @index and @size are less than LONG_MAX. -*/ -if (WARN_ONCE (index >LONG_MAX || size >LONG_MAX , -"array_index_nospec() limited to range of [0, LONG_MAX]\n" )) -return 0 ; - -/* * Always calculate and emit the mask even if the compiler * thinks the mask is not needed. The compiler does not take * into account the value of @index under speculation.
@@ -44,6 +30,26 @@ static inline unsigned long array_index_#endif /* +* Warn developers about inappropriate array_index_nospec() usage. +* +* Even if the CPU speculates past the WARN_ONCE branch, the +* sign bit of @index is taken into account when generating the +* mask. +* +* This warning is compiled out when the compiler can infer that +* @index and @size are less than LONG_MAX. +*/ +#define array_index_mask_nospec_check (index, size) \ +({ \ + if (WARN_ONCE(index > LONG_MAX || size > LONG_MAX, \ + "array_index_nospec() limited to range of [0, LONG_MAX]\n")) \ + _mask = 0; \ + else \ + _mask = array_index_mask_nospec(index, size); \ + _mask; \ +}) + +/* * array_index_nospec - sanitize an array index after a bounds check * * For a code sequence like:
@@ -61,7 +67,7 @@ static inline unsigned long array_index_ ({ \ typeof(index) _i = (index); \ typeof(size) _s = (size); \ - unsigned long _mask = array_index_mask_nospec(_i, _s); \ + unsigned long _mask = array_index_mask_nospec_check(_i, _s); \ \ BUILD_BUG_ON(sizeof(_i) > sizeof(long)); \ BUILD_BUG_ON(sizeof(_s) > sizeof(long)); \
Greg Kroah-Hartman
maintainerPATCH 81/163 x86/speculation: Add <asm/msr-index.h> dependency
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Peter Zijlstra <[email protected]>
commit ea00f301285ea2f07393678cd2b6057878320c9d upstream.
Joe Konno reported a compile failure resulting from using an MSR without inclusion of <asm/msr-index.h>, and while the current code builds fine (by accident) this needs fixing for future patches.
--- arch/x86/include/asm/nospec-branch.h | 1 + 1 file changed, 1 insertion(+)
arch/x86/include/asm/nospec-branch.h +1 -0
@@ -6,6 +6,7 @@#include <asm/alternative.h> #include <asm/alternative-asm.h> #include <asm/cpufeatures.h> +#include <asm/msr-index.h> #ifdef __ASSEMBLY__
Greg Kroah-Hartman
maintainerPATCH 82/163 x86/mm: Rename flush_tlb_single() and flush_tlb_one() to __flush_tlb_one_[user|kernel]()
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Andy Lutomirski <[email protected]>
commit 1299ef1d8870d2d9f09a5aadf2f8b2c887c2d033 upstream.
flush_tlb_single() and flush_tlb_one() sound almost identical, but they really mean "flush one user translation" and "flush one kernel translation". Rename them to flush_tlb_one_user() and flush_tlb_one_kernel() to make the semantics more obvious.
[ I was looking at some PTI-related code, and the flush-one-address code
is unnecessarily hard to understand because the names of the helpers are uninformative. This came up during PTI review, but no one got around to doing it. ]
--- arch/x86/include/asm/paravirt.h | 4 ++-- arch/x86/include/asm/paravirt_types.h | 2 +- arch/x86/include/asm/pgtable_32.h | 2 +- arch/x86/include/asm/tlbflush.h | 27 ++++++++++++++++++++------- arch/x86/kernel/paravirt.c | 6 +++--- arch/x86/mm/init_64.c | 2 +- arch/x86/mm/ioremap.c | 2 +- arch/x86/mm/kmmio.c | 2 +- arch/x86/mm/pgtable_32.c | 2 +- arch/x86/mm/tlb.c | 6 +++--- arch/x86/platform/uv/tlb_uv.c | 2 +- arch/x86/xen/mmu_pv.c | 6 +++--- include/trace/events/xen.h | 2 +- 13 files changed, 39 insertions(+), 26 deletions(-)
arch/x86/include/asm/paravirt.h +2 -2
@@ -297,9 +297,9 @@ static inline void __flush_tlb_global(vo {PVOP_VCALL0 (pv_mmu_ops.flush_tlb_kernel); } -static inline void __flush_tlb_single (unsigned long addr) +static inline void __flush_tlb_one_user (unsigned long addr) { -PVOP_VCALL1 (pv_mmu_ops.flush_tlb_single, addr); +PVOP_VCALL1 (pv_mmu_ops.flush_tlb_one_user, addr); } static inline void flush_tlb_others(const struct cpumask *cpumask,
arch/x86/include/asm/paravirt_types.h +1 -1
@@ -217,7 +217,7 @@ struct pv_mmu_ops {/* TLB operations */ void (*flush_tlb_user)(void );void (*flush_tlb_kernel)(void ); -void (*flush_tlb_single)(unsigned long addr); +void (*flush_tlb_one_user)(unsigned long addr);void (*flush_tlb_others)(const struct cpumask *cpus,const struct flush_tlb_info *info);
arch/x86/include/asm/pgtable_32.h +1 -1
@@ -61,7 +61,7 @@ void paging_init(void);#define kpte_clear_flush (ptep, vaddr) \ do { \ pte_clear(&init_mm, (vaddr), (ptep)); \ - __flush_tlb_one((vaddr)); \ + __flush_tlb_one_kernel((vaddr)); \ } while (0)#endif /* !__ASSEMBLY__ */
arch/x86/include/asm/tlbflush.h +20 -7
@@ -140,7 +140,7 @@ static inline unsigned long build_cr3_no#else #define __flush_tlb () __native_flush_tlb()#define __flush_tlb_global () __native_flush_tlb_global() -#define __flush_tlb_single (addr) __native_flush_tlb_single(addr) +#define __flush_tlb_one_user (addr) __native_flush_tlb_one_user(addr)#endif static inline bool tlb_defer_switch_to_init_mm (void )
@@ -400,7 +400,7 @@ static inline void __native_flush_tlb_gl/* * flush one page in the user mapping */ -static inline void __native_flush_tlb_single (unsigned long addr) +static inline void __native_flush_tlb_one_user (unsigned long addr) {u32 loaded_mm_asid =this_cpu_read (cpu_tlbstate.loaded_mm_asid);
@@ -437,18 +437,31 @@ static inline void __flush_tlb_all(void)/* * flush one page in the kernel mapping */ -static inline void __flush_tlb_one (unsigned long addr) +static inline void __flush_tlb_one_kernel (unsigned long addr) {count_vm_tlb_event (NR_TLB_LOCAL_FLUSH_ONE ); -__flush_tlb_single (addr); + +/* +* If PTI is off, then __flush_tlb_one_user() is just INVLPG or its +* paravirt equivalent. Even with PCID, this is sufficient: we only +* use PCID if we also use global PTEs for the kernel mapping, and +* INVLPG flushes global translations across all address spaces. +* +* If PTI is on, then the kernel is mapped with non-global PTEs, and +* __flush_tlb_one_user() will flush the given address for the current +* kernel address space and for its usermode counterpart, but it does +* not flush it for other address spaces. +*/ +__flush_tlb_one_user (addr);if (!static_cpu_has (X86_FEATURE_PTI ))return ;/* -* __flush_tlb_single() will have cleared the TLB entry for this ASID, -* but since kernel space is replicated across all, we must also -* invalidate all others. +* See above. We need to propagate the flush to all other address +* spaces. In principle, we only need to propagate it to kernelmode +* address spaces, but the extra bookkeeping we would need is not +* worth it. */ invalidate_other_asid (); }
arch/x86/kernel/paravirt.c +3 -3
@@ -200,9 +200,9 @@ static void native_flush_tlb_global(void__native_flush_tlb_global (); } -static void native_flush_tlb_single (unsigned long addr) +static void native_flush_tlb_one_user (unsigned long addr) { -__native_flush_tlb_single (addr); +__native_flush_tlb_one_user (addr); }struct static_key paravirt_steal_enabled;
@@ -401,7 +401,7 @@ struct pv_mmu_ops pv_mmu_ops __ro_after_ .flush_tlb_user = native_flush_tlb, .flush_tlb_kernel = native_flush_tlb_global, - .flush_tlb_single = native_flush_tlb_single, + .flush_tlb_one_user = native_flush_tlb_one_user, .flush_tlb_others = native_flush_tlb_others, .pgd_alloc = __paravirt_pgd_alloc,
arch/x86/mm/init_64.c +1 -1
@@ -256,7 +256,7 @@ static void __set_pte_vaddr(pud_t *pud,* It's enough to flush this one mapping. * (PGE mappings get flushed as well) */ -__flush_tlb_one (vaddr); +__flush_tlb_one_kernel (vaddr); }void set_pte_vaddr_p4d (p4d_t *p4d_page,unsigned long vaddr,pte_t new_pte)
arch/x86/mm/ioremap.c +1 -1
@@ -820,5 +820,5 @@ void __init __early_set_fixmap(enum fixeset_pte (pte,pfn_pte (phys >>PAGE_SHIFT , flags)); else pte_clear(&init_mm, addr, pte); -__flush_tlb_one (addr); +__flush_tlb_one_kernel (addr); }
arch/x86/mm/kmmio.c +1 -1
@@ -168,7 +168,7 @@ static int clear_page_presence(struct kmreturn -1 ; } -__flush_tlb_one (f->addr); +__flush_tlb_one_kernel (f->addr);return 0 ; }
arch/x86/mm/pgtable_32.c +1 -1
@@ -63,7 +63,7 @@ void set_pte_vaddr(unsigned long vaddr,* It's enough to flush this one mapping. * (PGE mappings get flushed as well) */ -__flush_tlb_one (vaddr); +__flush_tlb_one_kernel (vaddr); }unsigned long __FIXADDR_TOP =0xfffff000 ;
arch/x86/mm/tlb.c +3 -3
@@ -492,7 +492,7 @@ static void flush_tlb_func_common(const* flush that changes context.tlb_gen from 2 to 3. If they get * processed on this CPU in reverse order, we'll see * local_tlb_gen == 1, mm_tlb_gen == 3, and end != TLB_FLUSH_ALL. -* If we were to use __flush_tlb_single() and set local_tlb_gen to +* If we were to use __flush_tlb_one_user() and set local_tlb_gen to * 3, we'd be break the invariant: we'd update local_tlb_gen above * 1 without the full flush that's needed for tlb_gen 2. *
@@ -513,7 +513,7 @@ static void flush_tlb_func_common(const addr = f->start;while (addr < f->end) { -__flush_tlb_single (addr); +__flush_tlb_one_user (addr); addr +=PAGE_SIZE ; }if (local)
@@ -660,7 +660,7 @@ static void do_kernel_range_flush(void */* flush range by one by one 'invlpg' */ for (addr = f->start; addr < f->end; addr +=PAGE_SIZE ) -__flush_tlb_one (addr); +__flush_tlb_one_kernel (addr); }void flush_tlb_kernel_range (unsigned long start,unsigned long end)
arch/x86/platform/uv/tlb_uv.c +1 -1
@@ -299,7 +299,7 @@ static void bau_process_message(struct mlocal_flush_tlb (); stat->d_alltlb++; }else { -__flush_tlb_single (msg->address); +__flush_tlb_one_user (msg->address); stat->d_onetlb++; } stat->d_requestee++;
arch/x86/xen/mmu_pv.c +3 -3
@@ -1300,12 +1300,12 @@ static void xen_flush_tlb(void)preempt_enable (); } -static void xen_flush_tlb_single (unsigned long addr) +static void xen_flush_tlb_one_user (unsigned long addr) {struct mmuext_op *op;struct multicall_space mcs; -trace_xen_mmu_flush_tlb_single (addr); +trace_xen_mmu_flush_tlb_one_user (addr);preempt_disable ();
@@ -2370,7 +2370,7 @@ static const struct pv_mmu_ops xen_mmu_o .flush_tlb_user = xen_flush_tlb, .flush_tlb_kernel = xen_flush_tlb, - .flush_tlb_single = xen_flush_tlb_single, + .flush_tlb_one_user = xen_flush_tlb_one_user, .flush_tlb_others = xen_flush_tlb_others, .pgd_alloc = xen_pgd_alloc,
include/trace/events/xen.h +1 -1
@@ -368,7 +368,7 @@ TRACE_EVENT(xen_mmu_flush_tlb,TP_printk ("%s" ,"" ) ); -TRACE_EVENT(xen_mmu_flush_tlb_single, +TRACE_EVENT(xen_mmu_flush_tlb_one_user, TP_PROTO(unsigned long addr), TP_ARGS(addr), TP_STRUCT__entry(
Greg Kroah-Hartman
maintainerPATCH 83/163 selftests/x86/mpx: Fix incorrect bounds with old _sigfault
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Rui Wang <[email protected]>
commit 961888b1d76d84efc66a8f5604b06ac12ac2f978 upstream.
For distributions with old userspace header files, the _sigfault structure is different. mpx-mini-test fails with the following error:
[root@Purley]# mpx-mini-test_64 tabletest
XSAVE is supported by HW & OS
XSAVE processor supported state mask: 0x2ff
XSAVE OS supported state mask: 0x2ff
BNDREGS: size: 64 user: 1 supervisor: 0 aligned: 0
BNDCSR: size: 64 user: 1 supervisor: 0 aligned: 0
starting mpx bounds table test
ERROR: siginfo bounds do not match shadow bounds for register 0Fix it by using the correct offset of _lower/_upper in _sigfault. RHEL needs this patch to work.
--- tools/testing/selftests/x86/mpx-mini-test.c | 32 ++++++++++++++++++++++++++-- 1 file changed, 30 insertions(+), 2 deletions(-)
tools/testing/selftests/x86/mpx-mini-test.c +30 -2
@@ -315,11 +315,39 @@ static inline void *__si_bounds_upper(si return si->si_upper; }#else + +/* +* This deals with old version of _sigfault in some distros: +* + +old _sigfault: +struct { +void *si_addr; +} _sigfault; + +new _sigfault: +struct { +void __user *_addr; +int _trapno; +short _addr_lsb; +union { +struct { +void __user *_lower; +void __user *_upper; +} _addr_bnd; +__u32 _pkey; +}; +} _sigfault; +* +*/ +static inline void **__si_bounds_hack (siginfo_t *si) {void *sigfault = &si->_sifields._sigfault;void *end_sigfault = sigfault +sizeof (si->_sifields._sigfault); -void **__si_lower = end_sigfault; +int *trapno = (int *)end_sigfault; +/* skip _trapno and _addr_lsb */ +void **__si_lower = (void **)(trapno +2 );return __si_lower; }
@@ -331,7 +359,7 @@ static inline void *__si_bounds_lower(sistatic inline void *__si_bounds_upper (siginfo_t *si) { -return (*__si_bounds_hack (si)) +sizeof (void *); +return *(__si_bounds_hack (si) +1 ); }#endif
Greg Kroah-Hartman
maintainerPATCH 84/163 x86/cpu: Rename cpu_data.x86_mask to cpu_data.x86_stepping
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Jia Zhang <[email protected]>
commit b399151cb48db30ad1e0e93dd40d68c6d007b637 upstream.
x86_mask is a confusing name which is hard to associate with the processor's stepping.
Additionally, correct an indent issue in lib/cpu.c.
--- arch/x86/events/intel/core.c | 2 +- arch/x86/events/intel/lbr.c | 2 +- arch/x86/events/intel/p6.c | 2 +- arch/x86/include/asm/acpi.h | 2 +- arch/x86/include/asm/processor.h | 2 +- arch/x86/kernel/amd_nb.c | 2 +- arch/x86/kernel/apic/apic.c | 6 +++--- arch/x86/kernel/asm-offsets_32.c | 2 +- arch/x86/kernel/cpu/amd.c | 28 ++++++++++++++-------------- arch/x86/kernel/cpu/centaur.c | 4 ++-- arch/x86/kernel/cpu/common.c | 8 ++++---- arch/x86/kernel/cpu/cyrix.c | 2 +- arch/x86/kernel/cpu/intel.c | 18 +++++++++--------- arch/x86/kernel/cpu/intel_rdt.c | 2 +- arch/x86/kernel/cpu/microcode/intel.c | 4 ++-- arch/x86/kernel/cpu/mtrr/generic.c | 2 +- arch/x86/kernel/cpu/mtrr/main.c | 4 ++-- arch/x86/kernel/cpu/proc.c | 4 ++-- arch/x86/kernel/head_32.S | 4 ++-- arch/x86/kernel/mpparse.c | 2 +- arch/x86/lib/cpu.c | 2 +- drivers/char/hw_random/via-rng.c | 2 +- drivers/cpufreq/acpi-cpufreq.c | 2 +- drivers/cpufreq/longhaul.c | 6 +++--- drivers/cpufreq/p4-clockmod.c | 2 +- drivers/cpufreq/powernow-k7.c | 2 +- drivers/cpufreq/speedstep-centrino.c | 4 ++-- drivers/cpufreq/speedstep-lib.c | 6 +++--- drivers/crypto/padlock-aes.c | 2 +- drivers/edac/amd64_edac.c | 2 +- drivers/hwmon/coretemp.c | 6 +++--- drivers/hwmon/hwmon-vid.c | 2 +- drivers/hwmon/k10temp.c | 2 +- drivers/hwmon/k8temp.c | 2 +- drivers/video/fbdev/geode/video_gx.c | 2 +- 35 files changed, 73 insertions(+), 73 deletions(-)
arch/x86/events/intel/core.c +1 -1
@@ -3559,7 +3559,7 @@ static int intel_snb_pebs_broken(int cpubreak ;case INTEL_FAM6_SANDYBRIDGE_X : -switch (cpu_data (cpu).x86_mask) { +switch (cpu_data (cpu).x86_stepping) {case 6 : rev =0x618 ;break ;case 7 : rev =0x70c ;break ; }
arch/x86/events/intel/lbr.c +1 -1
@@ -1186,7 +1186,7 @@ void __init intel_pmu_lbr_init_atom(void* on PMU interrupt */ if (boot_cpu_data.x86_model ==28 - && boot_cpu_data.x86_mask <10 ) { + && boot_cpu_data.x86_stepping <10 ) {pr_cont ("LBR disabled due to erratum" );return ; }
arch/x86/events/intel/p6.c +1 -1
@@ -234,7 +234,7 @@ static __initconst const struct x86_pmustatic __init void p6_pmu_rdpmc_quirk (void ) { -if (boot_cpu_data.x86_mask <9 ) { +if (boot_cpu_data.x86_stepping <9 ) {/* * PPro erratum 26; fixed in stepping 9 and above. */
arch/x86/include/asm/acpi.h +1 -1
@@ -94,7 +94,7 @@ static inline unsigned int acpi_processoif (boot_cpu_data.x86 ==0x0F && boot_cpu_data.x86_vendor ==X86_VENDOR_AMD && boot_cpu_data.x86_model <=0x05 && - boot_cpu_data.x86_mask <0x0A ) + boot_cpu_data.x86_stepping <0x0A )return 1 ;else if (boot_cpu_has (X86_BUG_AMD_APIC_C1E ))return 1 ;
arch/x86/include/asm/processor.h +1 -1
@@ -91,7 +91,7 @@ struct cpuinfo_x86 {__u8 x86;/* CPU family */ __u8 x86_vendor;/* CPU vendor */ __u8 x86_model; -__u8 x86_mask; +__u8 x86_stepping;#ifdef CONFIG_X86_64 /* Number of 4K pages in DTLB/ITLB combined(in pages): */ int x86_tlbsize;
arch/x86/kernel/amd_nb.c +1 -1
@@ -235,7 +235,7 @@ int amd_cache_northbridges(void)if (boot_cpu_data.x86 ==0x10 && boot_cpu_data.x86_model >=0x8 && (boot_cpu_data.x86_model >0x9 || - boot_cpu_data.x86_mask >=0x1 )) + boot_cpu_data.x86_stepping >=0x1 )) amd_northbridges.flags |=AMD_NB_L3_INDEX_DISABLE ;if (boot_cpu_data.x86 ==0x15 )
arch/x86/kernel/apic/apic.c +3 -3
@@ -546,7 +546,7 @@ static DEFINE_PER_CPU(struct clock_eventstatic u32 hsx_deadline_rev (void ) { -switch (boot_cpu_data.x86_mask) { +switch (boot_cpu_data.x86_stepping) {case 0x02 :return 0x3a ;/* EP */ case 0x04 :return 0x0f ;/* EX */ }
@@ -556,7 +556,7 @@ static u32 hsx_deadline_rev(void)static u32 bdx_deadline_rev (void ) { -switch (boot_cpu_data.x86_mask) { +switch (boot_cpu_data.x86_stepping) {case 0x02 :return 0x00000011 ;case 0x03 :return 0x0700000e ;case 0x04 :return 0x0f00000c ;
@@ -568,7 +568,7 @@ static u32 bdx_deadline_rev(void)static u32 skx_deadline_rev (void ) { -switch (boot_cpu_data.x86_mask) { +switch (boot_cpu_data.x86_stepping) {case 0x03 :return 0x01000136 ;case 0x04 :return 0x02000014 ; }
arch/x86/kernel/asm-offsets_32.c +1 -1
@@ -18,7 +18,7 @@ void foo(void)OFFSET (CPUINFO_x86, cpuinfo_x86, x86);OFFSET (CPUINFO_x86_vendor, cpuinfo_x86, x86_vendor);OFFSET (CPUINFO_x86_model, cpuinfo_x86, x86_model); -OFFSET (CPUINFO_x86_mask, cpuinfo_x86, x86_mask); +OFFSET (CPUINFO_x86_stepping, cpuinfo_x86, x86_stepping);OFFSET (CPUINFO_cpuid_level, cpuinfo_x86, cpuid_level);OFFSET (CPUINFO_x86_capability, cpuinfo_x86, x86_capability);OFFSET (CPUINFO_x86_vendor_id, cpuinfo_x86, x86_vendor_id);
arch/x86/kernel/cpu/amd.c +14 -14
@@ -119,7 +119,7 @@ static void init_amd_k6(struct cpuinfo_xreturn ; } -if (c->x86_model ==6 && c->x86_mask ==1 ) { +if (c->x86_model ==6 && c->x86_stepping ==1 ) {const int K6_BUG_LOOP =1000000 ;int n;void (*f_vide)(void );
@@ -149,7 +149,7 @@ static void init_amd_k6(struct cpuinfo_x/* K6 with old style WHCR */ if (c->x86_model <8 || - (c->x86_model ==8 && c->x86_mask <8 )) { + (c->x86_model ==8 && c->x86_stepping <8 )) {/* We can only write allocate on the low 508Mb */ if (mbytes >508 ) mbytes =508 ;
@@ -168,7 +168,7 @@ static void init_amd_k6(struct cpuinfo_xreturn ; } -if ((c->x86_model ==8 && c->x86_mask >7 ) || +if ((c->x86_model ==8 && c->x86_stepping >7 ) || c->x86_model ==9 || c->x86_model ==13 ) {/* The more serious chips .. */
@@ -221,7 +221,7 @@ static void init_amd_k7(struct cpuinfo_x* are more robust with CLK_CTL set to 200xxxxx instead of 600xxxxx * As per AMD technical note 27212 0.2 */ -if ((c->x86_model ==8 && c->x86_mask >=1 ) || (c->x86_model >8 )) { +if ((c->x86_model ==8 && c->x86_stepping >=1 ) || (c->x86_model >8 )) {rdmsr (MSR_K7_CLK_CTL , l, h);if ((l &0xfff00000 ) !=0x20000000 ) { pr_info("CPU: CLK_CTL MSR was %x. Reprogramming to %x\n",
@@ -241,12 +241,12 @@ static void init_amd_k7(struct cpuinfo_x* but they are not certified as MP capable. */ /* Athlon 660/661 is valid. */ -if ((c->x86_model ==6 ) && ((c->x86_mask ==0 ) || - (c->x86_mask ==1 ))) +if ((c->x86_model ==6 ) && ((c->x86_stepping ==0 ) || + (c->x86_stepping ==1 )))return ;/* Duron 670 is valid */ -if ((c->x86_model ==7 ) && (c->x86_mask ==0 )) +if ((c->x86_model ==7 ) && (c->x86_stepping ==0 ))return ;/*
@@ -256,8 +256,8 @@ static void init_amd_k7(struct cpuinfo_x* See http://www.heise.de/newsticker/data/jow-18.10.01-000 for * more. */ -if (((c->x86_model ==6 ) && (c->x86_mask >=2 )) || - ((c->x86_model ==7 ) && (c->x86_mask >=1 )) || +if (((c->x86_model ==6 ) && (c->x86_stepping >=2 )) || + ((c->x86_model ==7 ) && (c->x86_stepping >=1 )) || (c->x86_model >7 ))if (cpu_has (c,X86_FEATURE_MP ))return ;
@@ -583,7 +583,7 @@ static void early_init_amd(struct cpuinf/* Set MTRR capability flag if appropriate */ if (c->x86 ==5 )if (c->x86_model ==13 || c->x86_model ==9 || - (c->x86_model ==8 && c->x86_mask >=8 )) + (c->x86_model ==8 && c->x86_stepping >=8 ))set_cpu_cap (c,X86_FEATURE_K6_MTRR );#endif #if defined(CONFIG_X86_LOCAL_APIC ) && defined(CONFIG_PCI )
@@ -769,7 +769,7 @@ static void init_amd_zn(struct cpuinfo_x* Fix erratum 1076: CPB feature bit not being set in CPUID. It affects * all up to and including B1. */ -if (c->x86_model <=1 && c->x86_mask <=1 ) +if (c->x86_model <=1 && c->x86_stepping <=1 )set_cpu_cap (c,X86_FEATURE_CPB ); }
@@ -880,11 +880,11 @@ static unsigned int amd_size_cache(struc/* AMD errata T13 (order #21922) */ if ((c->x86 ==6 )) {/* Duron Rev A0 */ -if (c->x86_model ==3 && c->x86_mask ==0 ) +if (c->x86_model ==3 && c->x86_stepping ==0 ) size =64 ;/* Tbird rev A1/A2 */ if (c->x86_model ==4 && - (c->x86_mask ==0 || c->x86_mask ==1 )) + (c->x86_stepping ==0 || c->x86_stepping ==1 )) size =256 ; }return size;
@@ -1021,7 +1021,7 @@ static bool cpu_has_amd_erratum(struct c }/* OSVW unavailable or ID unknown, match family-model-stepping range */ - ms = (cpu->x86_model <<4 ) | cpu->x86_mask; + ms = (cpu->x86_model <<4 ) | cpu->x86_stepping;while ((range = *erratum++)) if ((cpu->x86 == AMD_MODEL_RANGE_FAMILY(range)) && (ms >= AMD_MODEL_RANGE_START(range)) &&
arch/x86/kernel/cpu/centaur.c +2 -2
@@ -136,7 +136,7 @@ static void init_centaur(struct cpuinfo_clear_cpu_cap (c,X86_FEATURE_TSC );break ;case 8 : -switch (c->x86_mask) { +switch (c->x86_stepping) {default : name ="2" ;break ;
@@ -211,7 +211,7 @@ centaur_size_cache(struct cpuinfo_x86 *c* - Note, it seems this may only be in engineering samples. */ if ((c->x86 ==6 ) && (c->x86_model ==9 ) && - (c->x86_mask ==1 ) && (size ==65 )) + (c->x86_stepping ==1 ) && (size ==65 )) size -=1 ;return size; }
arch/x86/kernel/cpu/common.c +4 -4
@@ -731,7 +731,7 @@ void cpu_detect(struct cpuinfo_x86 *c)cpuid (0x00000001 , &tfms, &misc, &junk, &cap0); c->x86 =x86_family (tfms); c->x86_model =x86_model (tfms); - c->x86_mask =x86_stepping (tfms); + c->x86_stepping =x86_stepping (tfms);if (cap0 & (1 <<19 )) { c->x86_clflush_size = ((misc >>8 ) &0xff ) *8 ;
@@ -1186,7 +1186,7 @@ static void identify_cpu(struct cpuinfo_ c->loops_per_jiffy = loops_per_jiffy; c->x86_cache_size =-1 ; c->x86_vendor =X86_VENDOR_UNKNOWN ; - c->x86_model = c->x86_mask =0 ;/* So far unknown... */ + c->x86_model = c->x86_stepping =0 ;/* So far unknown... */ c->x86_vendor_id[0 ] ='\0' ;/* Unset */ c->x86_model_id[0 ] ='\0' ;/* Unset */ c->x86_max_cores =1 ;
@@ -1378,8 +1378,8 @@ void print_cpu_info(struct cpuinfo_x86 *pr_cont (" (family: 0x%x, model: 0x%x" , c->x86, c->x86_model); -if (c->x86_mask || c->cpuid_level >=0 ) -pr_cont (", stepping: 0x%x)\n" , c->x86_mask); +if (c->x86_stepping || c->cpuid_level >=0 ) +pr_cont (", stepping: 0x%x)\n" , c->x86_stepping);else pr_cont (")\n" ); }
arch/x86/kernel/cpu/cyrix.c +1 -1
@@ -215,7 +215,7 @@ static void init_cyrix(struct cpuinfo_x8/* common case step number/rev -- exceptions handled below */ c->x86_model = (dir1 >>4 ) +1 ; - c->x86_mask = dir1 &0xf ; + c->x86_stepping = dir1 &0xf ;/* Now cook; the original recipe is by Channing Corn, from Cyrix. * We do the same thing for each generation: we work out
arch/x86/kernel/cpu/intel.c +9 -9
@@ -146,7 +146,7 @@ static bool bad_spectre_microcode(structfor (i =0 ; i <ARRAY_SIZE (spectre_bad_microcodes); i++) {if (c->x86_model == spectre_bad_microcodes[i].model && - c->x86_mask == spectre_bad_microcodes[i].stepping) + c->x86_stepping == spectre_bad_microcodes[i].stepping)return (c->microcode <= spectre_bad_microcodes[i].microcode); }return false;
@@ -193,7 +193,7 @@ static void early_init_intel(struct cpui* need the microcode to have already been loaded... so if it is * not, recommend a BIOS update and disable large pages. */ -if (c->x86 ==6 && c->x86_model ==0x1c && c->x86_mask <=2 && +if (c->x86 ==6 && c->x86_model ==0x1c && c->x86_stepping <=2 && c->microcode <0x20e ) {pr_warn ("Atom PSE erratum detected, BIOS microcode update recommended\n" );clear_cpu_cap (c,X86_FEATURE_PSE );
@@ -209,7 +209,7 @@ static void early_init_intel(struct cpui/* CPUID workaround for 0F33/0F34 CPU */ if (c->x86 ==0xF && c->x86_model ==0x3 - && (c->x86_mask ==0x3 || c->x86_mask ==0x4 )) + && (c->x86_stepping ==0x3 || c->x86_stepping ==0x4 )) c->x86_phys_bits =36 ;/*
@@ -307,7 +307,7 @@ int ppro_with_ram_bug(void)if (boot_cpu_data.x86_vendor ==X86_VENDOR_INTEL && boot_cpu_data.x86 ==6 && boot_cpu_data.x86_model ==1 && - boot_cpu_data.x86_mask <8 ) { + boot_cpu_data.x86_stepping <8 ) {pr_info ("Pentium Pro with Errata#50 detected. Taking evasive action.\n" );return 1 ; }
@@ -324,7 +324,7 @@ static void intel_smp_check(struct cpuin* Mask B, Pentium, but not Pentium MMX */ if (c->x86 ==5 && - c->x86_mask >=1 && c->x86_mask <=4 && + c->x86_stepping >=1 && c->x86_stepping <=4 && c->x86_model <=3 ) {/* * Remember we have B step Pentia with bugs
@@ -367,7 +367,7 @@ static void intel_workarounds(struct cpu* SEP CPUID bug: Pentium Pro reports SEP but doesn't have it until * model 3 mask 3 */ -if ((c->x86<<8 | c->x86_model<<4 | c->x86_mask) <0x633 ) +if ((c->x86<<8 | c->x86_model<<4 | c->x86_stepping) <0x633 )clear_cpu_cap (c,X86_FEATURE_SEP );/*
@@ -385,7 +385,7 @@ static void intel_workarounds(struct cpu* P4 Xeon erratum 037 workaround. * Hardware prefetcher may cause stale data to be loaded into the cache. */ -if ((c->x86 ==15 ) && (c->x86_model ==1 ) && (c->x86_mask ==1 )) { +if ((c->x86 ==15 ) && (c->x86_model ==1 ) && (c->x86_stepping ==1 )) {if (msr_set_bit (MSR_IA32_MISC_ENABLE ,MSR_IA32_MISC_ENABLE_PREFETCH_DISABLE_BIT ) >0 ) {pr_info ("CPU: C0 stepping P4 Xeon detected.\n" );
@@ -400,7 +400,7 @@ static void intel_workarounds(struct cpu* Specification Update"). */ if (boot_cpu_has (X86_FEATURE_APIC ) && (c->x86<<8 | c->x86_model<<4 ) ==0x520 && - (c->x86_mask <0x6 || c->x86_mask ==0xb )) + (c->x86_stepping <0x6 || c->x86_stepping ==0xb ))set_cpu_bug (c,X86_BUG_11AP );
@@ -647,7 +647,7 @@ static void init_intel(struct cpuinfo_x8case 6 :if (l2 ==128 ) p ="Celeron (Mendocino)" ; -else if (c->x86_mask ==0 || c->x86_mask ==5 ) +else if (c->x86_stepping ==0 || c->x86_stepping ==5 ) p ="Celeron-A" ;break ;
arch/x86/kernel/cpu/intel_rdt.c +1 -1
@@ -771,7 +771,7 @@ static __init void rdt_quirks(void)cache_alloc_hsw_probe ();break ;case INTEL_FAM6_SKYLAKE_X : -if (boot_cpu_data.x86_mask <=4 ) +if (boot_cpu_data.x86_stepping <=4 )set_rdt_options ("!cmt,!mbmtotal,!mbmlocal,!l3cat" ); } }
arch/x86/kernel/cpu/microcode/intel.c +2 -2
@@ -921,7 +921,7 @@ static bool is_blacklisted(unsigned int*/ if (c->x86 ==6 && c->x86_model ==INTEL_FAM6_BROADWELL_X && - c->x86_mask ==0x01 && + c->x86_stepping ==0x01 && llc_size_per_core >2621440 && c->microcode <0x0b000021 ) {pr_err_once ("Erratum BDF90: late loading with revision < 0x0b000021 (0x%x) disabled.\n" , c->microcode);
@@ -944,7 +944,7 @@ static enum ucode_state request_microcodreturn UCODE_NFOUND ;sprintf (name,"intel-ucode/%02x-%02x-%02x" , - c->x86, c->x86_model, c->x86_mask); + c->x86, c->x86_model, c->x86_stepping);if (request_firmware_direct (&firmware, name, device)) {pr_debug ("data file %s load failed\n" , name);
arch/x86/kernel/cpu/mtrr/generic.c +1 -1
@@ -859,7 +859,7 @@ int generic_validate_add_page(unsigned l*/ if (is_cpu (INTEL ) && boot_cpu_data.x86 ==6 && boot_cpu_data.x86_model ==1 && - boot_cpu_data.x86_mask <=7 ) { + boot_cpu_data.x86_stepping <=7 ) {if (base & ((1 << (22 -PAGE_SHIFT )) -1 )) {pr_warn ("mtrr: base(0x%lx000) is not 4 MiB aligned\n" , base);return -EINVAL ;
arch/x86/kernel/cpu/mtrr/main.c +2 -2
@@ -711,8 +711,8 @@ void __init mtrr_bp_init(void)if (boot_cpu_data.x86_vendor ==X86_VENDOR_INTEL && boot_cpu_data.x86 ==0xF && boot_cpu_data.x86_model ==0x3 && - (boot_cpu_data.x86_mask ==0x3 || - boot_cpu_data.x86_mask ==0x4 )) + (boot_cpu_data.x86_stepping ==0x3 || + boot_cpu_data.x86_stepping ==0x4 )) phys_addr =36 ; size_or_mask =SIZE_OR_MASK_BITS (phys_addr);
arch/x86/kernel/cpu/proc.c +2 -2
@@ -72,8 +72,8 @@ static int show_cpuinfo(struct seq_file c->x86_model, c->x86_model_id[0] ? c->x86_model_id : "unknown"); -if (c->x86_mask || c->cpuid_level >=0 ) -seq_printf (m,"stepping\t: %d\n" , c->x86_mask); +if (c->x86_stepping || c->cpuid_level >=0 ) +seq_printf (m,"stepping\t: %d\n" , c->x86_stepping);else seq_puts (m,"stepping\t: unknown\n" );if (c->microcode)
arch/x86/kernel/head_32.S +2 -2
@@ -37,7 +37,7 @@ #define X86 new_cpu_data+CPUINFO_x86 #define X86_VENDOR new_cpu_data+CPUINFO_x86_vendor #define X86_MODEL new_cpu_data+CPUINFO_x86_model -#define X86_MASK new_cpu_data+CPUINFO_x86_mask +#define X86_STEPPING new_cpu_data+CPUINFO_x86_stepping #define X86_HARD_MATH new_cpu_data+CPUINFO_hard_math #define X86_CPUID new_cpu_data+CPUINFO_cpuid_level #define X86_CAPABILITY new_cpu_data+CPUINFO_x86_capability
@@ -332,7 +332,7 @@ ENTRY(startup_32_smp) shrb $4,%al movb %al,X86_MODEL andb $0x0f,%cl # mask mask revision - movb %cl,X86_MASK + movb %cl,X86_STEPPING movl %edx,X86_CAPABILITY .Lis486:
arch/x86/kernel/mpparse.c +1 -1
@@ -407,7 +407,7 @@ static inline void __init construct_defa processor.apicver = mpc_default_type >4 ?0x10 :0x01 ; processor.cpuflag =CPU_ENABLED ; processor.cpufeature = (boot_cpu_data.x86 <<8 ) | - (boot_cpu_data.x86_model <<4 ) | boot_cpu_data.x86_mask; + (boot_cpu_data.x86_model <<4 ) | boot_cpu_data.x86_stepping; processor.featureflag = boot_cpu_data.x86_capability[CPUID_1_EDX ]; processor.reserved[0 ] =0 ; processor.reserved[1 ] =0 ;
arch/x86/lib/cpu.c +1 -1
@@ -18,7 +18,7 @@ unsigned int x86_model(unsigned int sig) {unsigned int fam, model; - fam =x86_family (sig); + fam =x86_family (sig); model = (sig >>4 ) &0xf ;
drivers/char/hw_random/via-rng.c +1 -1
@@ -162,7 +162,7 @@ static int via_rng_init(struct hwrng *rn/* Enable secondary noise source on CPUs where it is present. */ /* Nehemiah stepping 8 and higher */ -if ((c->x86_model ==9 ) && (c->x86_mask >7 )) +if ((c->x86_model ==9 ) && (c->x86_stepping >7 )) lo |=VIA_NOISESRC2 ;/* Esther */
drivers/cpufreq/acpi-cpufreq.c +1 -1
@@ -629,7 +629,7 @@ static int acpi_cpufreq_blacklist(structif (c->x86_vendor ==X86_VENDOR_INTEL ) {if ((c->x86 ==15 ) && (c->x86_model ==6 ) && - (c->x86_mask ==8 )) { + (c->x86_stepping ==8 )) {pr_info ("Intel(R) Xeon(R) 7100 Errata AL30, processors may lock up on frequency changes: disabling acpi-cpufreq\n" );return -ENODEV ; }
drivers/cpufreq/longhaul.c +3 -3
@@ -775,7 +775,7 @@ static int longhaul_cpu_init(struct cpufbreak ;case 7 : -switch (c->x86_mask) { +switch (c->x86_stepping) {case 0 : longhaul_version =TYPE_LONGHAUL_V1 ; cpu_model =CPU_SAMUEL2 ;
@@ -787,7 +787,7 @@ static int longhaul_cpu_init(struct cpufbreak ; case 1 ... 15: longhaul_version =TYPE_LONGHAUL_V2 ; -if (c->x86_mask <8 ) { +if (c->x86_stepping <8 ) { cpu_model =CPU_SAMUEL2 ; cpuname ="C3 'Samuel 2' [C5B]" ; }else {
@@ -814,7 +814,7 @@ static int longhaul_cpu_init(struct cpuf numscales =32 ;memcpy (mults, nehemiah_mults,sizeof (nehemiah_mults));memcpy (eblcr, nehemiah_eblcr,sizeof (nehemiah_eblcr)); -switch (c->x86_mask) { +switch (c->x86_stepping) { case 0 ... 1: cpu_model =CPU_NEHEMIAH ; cpuname ="C3 'Nehemiah A' [C5XLOE]" ;
drivers/cpufreq/p4-clockmod.c +1 -1
@@ -168,7 +168,7 @@ static int cpufreq_p4_cpu_init(struct cp#endif /* Errata workaround */ - cpuid = (c->x86 <<8 ) | (c->x86_model <<4 ) | c->x86_mask; + cpuid = (c->x86 <<8 ) | (c->x86_model <<4 ) | c->x86_stepping;switch (cpuid) {case 0x0f07 :case 0x0f0a :
drivers/cpufreq/powernow-k7.c +1 -1
@@ -131,7 +131,7 @@ static int check_powernow(void)return 0 ; } -if ((c->x86_model ==6 ) && (c->x86_mask ==0 )) { +if ((c->x86_model ==6 ) && (c->x86_stepping ==0 )) {pr_info ("K7 660[A0] core detected, enabling errata workarounds\n" ); have_a0 =1 ; }
drivers/cpufreq/speedstep-centrino.c +2 -2
@@ -37,7 +37,7 @@ struct cpu_id {__u8 x86;/* CPU family */ __u8 x86_model;/* model */ -__u8 x86_mask;/* stepping */ +__u8 x86_stepping;/* stepping */ };enum {
@@ -277,7 +277,7 @@ static int centrino_verify_cpu_id(const {if ((c->x86 == x->x86) && (c->x86_model == x->x86_model) && - (c->x86_mask == x->x86_mask)) + (c->x86_stepping == x->x86_stepping))return 1 ;return 0 ; }
drivers/cpufreq/speedstep-lib.c +3 -3
@@ -272,9 +272,9 @@ unsigned int speedstep_detect_processor( ebx =cpuid_ebx (0x00000001 ); ebx &=0x000000FF ; -pr_debug ("ebx value is %x, x86_mask is %x\n" , ebx, c->x86_mask); +pr_debug ("ebx value is %x, x86_stepping is %x\n" , ebx, c->x86_stepping); -switch (c->x86_mask) { +switch (c->x86_stepping) {case 4 :/* * B-stepping [M-P4-M]
@@ -361,7 +361,7 @@ unsigned int speedstep_detect_processor( msr_lo, msr_hi);if ((msr_hi & (1 <<18 )) && (relaxed_check ?1 : (msr_hi & (3 <<24 )))) { -if (c->x86_mask ==0x01 ) { +if (c->x86_stepping ==0x01 ) {pr_debug ("early PIII version\n" );return SPEEDSTEP_CPU_PIII_C_EARLY ; }else
drivers/crypto/padlock-aes.c +1 -1
@@ -512,7 +512,7 @@ static int __init padlock_init(void) printk(KERN_NOTICE PFX "Using VIA PadLock ACE for AES algorithm.\n"); -if (c->x86 ==6 && c->x86_model ==15 && c->x86_mask ==2 ) { +if (c->x86 ==6 && c->x86_model ==15 && c->x86_stepping ==2 ) { ecb_fetch_blocks =MAX_ECB_FETCH_BLOCKS ; cbc_fetch_blocks =MAX_CBC_FETCH_BLOCKS ; printk(KERN_NOTICE PFX "VIA Nano stepping 2 detected: enabling workaround.\n");
drivers/edac/amd64_edac.c +1 -1
@@ -3147,7 +3147,7 @@ static struct amd64_family_type *per_famstruct amd64_family_type *fam_type =NULL ; pvt->ext_model = boot_cpu_data.x86_model >>4 ; - pvt->stepping = boot_cpu_data.x86_mask; + pvt->stepping = boot_cpu_data.x86_stepping; pvt->model = boot_cpu_data.x86_model; pvt->fam = boot_cpu_data.x86;
drivers/hwmon/coretemp.c +3 -3
@@ -268,13 +268,13 @@ static int adjust_tjmax(struct cpuinfo_xfor (i =0 ; i <ARRAY_SIZE (tjmax_model_table); i++) {const struct tjmax_model *tm = &tjmax_model_table[i];if (c->x86_model == tm->model && - (tm->mask ==ANY || c->x86_mask == tm->mask)) + (tm->mask ==ANY || c->x86_stepping == tm->mask))return tm->tjmax; }/* Early chips have no MSR for TjMax */ -if (c->x86_model ==0xf && c->x86_mask <4 ) +if (c->x86_model ==0xf && c->x86_stepping <4 ) usemsr_ee =0 ;if (c->x86_model >0xe && usemsr_ee) {
@@ -425,7 +425,7 @@ static int chk_ucode_version(unsigned in* Readings might stop update when processor visited too deep sleep, * fixed for stepping D0 (6EC). */ -if (c->x86_model ==0xe && c->x86_mask <0xc && c->microcode <0x39 ) { +if (c->x86_model ==0xe && c->x86_stepping <0xc && c->microcode <0x39 ) {pr_err ("Errata AE18 not fixed, update BIOS or microcode of the CPU!\n" );return -ENODEV ; }
drivers/hwmon/hwmon-vid.c +1 -1
@@ -293,7 +293,7 @@ u8 vid_which_vrm(void)if (c->x86 <6 )/* Any CPU with family lower than 6 */ return 0 ;/* doesn't have VID */ - vrm_ret =find_vrm (c->x86, c->x86_model, c->x86_mask, c->x86_vendor); + vrm_ret =find_vrm (c->x86, c->x86_model, c->x86_stepping, c->x86_vendor);if (vrm_ret ==134 ) vrm_ret =get_via_model_d_vrm ();if (vrm_ret ==0 )
drivers/hwmon/k10temp.c +1 -1
@@ -226,7 +226,7 @@ static bool has_erratum_319(struct pci_d* and AM3 formats, but that's the best we can do. */ return boot_cpu_data.x86_model <4 || - (boot_cpu_data.x86_model ==4 && boot_cpu_data.x86_mask <=2 ); + (boot_cpu_data.x86_model ==4 && boot_cpu_data.x86_stepping <=2 ); } static int k10temp_probe(struct pci_dev *pdev,
drivers/hwmon/k8temp.c +1 -1
@@ -187,7 +187,7 @@ static int k8temp_probe(struct pci_dev *return -ENOMEM ; model = boot_cpu_data.x86_model; - stepping = boot_cpu_data.x86_mask; + stepping = boot_cpu_data.x86_stepping;/* feature available since SH-C0, exclude older revisions */ if ((model == 4 && stepping == 0) ||
drivers/video/fbdev/geode/video_gx.c +1 -1
@@ -127,7 +127,7 @@ void gx_set_dclk_frequency(struct fb_infint timeout =1000 ;/* Rev. 1 Geode GXs use a 14 MHz reference clock instead of 48 MHz. */ -if (cpu_data (0 ).x86_mask ==1 ) { +if (cpu_data (0 ).x86_stepping ==1 ) { pll_table = gx_pll_table_14MHz; pll_table_len =ARRAY_SIZE (gx_pll_table_14MHz); }else {
Greg Kroah-Hartman
maintainerPATCH 85/163 x86/spectre: Fix an error message
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Dan Carpenter <[email protected]>
commit 9de29eac8d2189424d81c0d840cd0469aa3d41c8 upstream.
If i = ARRAY_SIZE(mitigation_options) then we accidentally print garbage from one space beyond the end of the mitigation_options[] array.
--- arch/x86/kernel/cpu/bugs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/cpu/bugs.c +1 -1
@@ -174,7 +174,7 @@ static enum spectre_v2_mitigation_cmd __ }if (i >=ARRAY_SIZE (mitigation_options)) { -pr_err ("unknown option (%s). Switching to AUTO select\n" , mitigation_options[i].option); +pr_err ("unknown option (%s). Switching to AUTO select\n" , arg);return SPECTRE_V2_CMD_AUTO ; } }
Greg Kroah-Hartman
maintainerPATCH 86/163 x86/cpu: Change type of x86_cache_size variable to unsigned int
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Gustavo A. R. Silva <[email protected]>
commit 24dbc6000f4b9b0ef5a9daecb161f1907733765a upstream.
Currently, x86_cache_size is of type int, which makes no sense as we will never have a valid cache size equal or less than 0. So instead of initializing this variable to -1, it can perfectly be initialized to 0 and use it as an unsigned variable instead.
Addresses-Coverity-ID: 1464429
--- arch/x86/include/asm/processor.h | 2 +- arch/x86/kernel/cpu/common.c | 2 +- arch/x86/kernel/cpu/microcode/intel.c | 2 +- arch/x86/kernel/cpu/proc.c | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-)
arch/x86/include/asm/processor.h +1 -1
@@ -109,7 +109,7 @@ struct cpuinfo_x86 {char x86_vendor_id[16 ];char x86_model_id[64 ];/* in KB - valid for CPUS which support this call: */ -int x86_cache_size; +unsigned int x86_cache_size;int x86_cache_alignment;/* In bytes */ /* Cache QoS architectural values: */ int x86_cache_max_rmid;/* max index */
arch/x86/kernel/cpu/common.c +1 -1
@@ -1184,7 +1184,7 @@ static void identify_cpu(struct cpuinfo_int i; c->loops_per_jiffy = loops_per_jiffy; - c->x86_cache_size =-1 ; + c->x86_cache_size =0 ; c->x86_vendor =X86_VENDOR_UNKNOWN ; c->x86_model = c->x86_stepping =0 ;/* So far unknown... */ c->x86_vendor_id[0 ] ='\0' ;/* Unset */
arch/x86/kernel/cpu/microcode/intel.c +1 -1
@@ -982,7 +982,7 @@ static struct microcode_ops microcode_instatic int __init calc_llc_size_per_core (struct cpuinfo_x86 *c) { -u64 llc_size = c->x86_cache_size *1024 ; +u64 llc_size = c->x86_cache_size *1024ULL ;do_div (llc_size, c->x86_max_cores);
arch/x86/kernel/cpu/proc.c +2 -2
@@ -91,8 +91,8 @@ static int show_cpuinfo(struct seq_file }/* Cache size */ -if (c->x86_cache_size >=0 ) -seq_printf (m,"cache size\t: %d KB\n" , c->x86_cache_size); +if (c->x86_cache_size) +seq_printf (m,"cache size\t: %u KB\n" , c->x86_cache_size);show_cpuinfo_core (m, c, cpu);show_cpuinfo_misc (m, c);
Greg Kroah-Hartman
maintainerPATCH 87/163 x86/entry/64: Fix CR3 restore in paranoid_exit()
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Ingo Molnar <[email protected]>
commit e48657573481a5dff7cfdc3d57005c80aa816500 upstream.
Josh Poimboeuf noticed the following bug:
"The paranoid exit code only restores the saved CR3 when it switches back
to the user GS. However, even in the kernel GS case, it's possible that it needs to restore a user CR3, if for example, the paranoid exception occurred in the syscall exit path between SWITCH_TO_USER_CR3_STACK and SWAPGS."
Josh also confirmed via targeted testing that it's possible to hit this bug.
Fix the bug by also restoring CR3 in the paranoid_exit_no_swapgs branch.
The reason we haven't seen this bug reported by users yet is probably because "paranoid" entry points are limited to the following cases:
idtentry double_fault do_double_fault has_error_code=1 paranoid=2 idtentry debug do_debug has_error_code=0 paranoid=1 shift_ist=DEBUG_STACK idtentry int3 do_int3 has_error_code=0 paranoid=1 shift_ist=DEBUG_STACK idtentry machine_check do_mce has_error_code=0 paranoid=1
Amongst those entry points only machine_check is one that will interrupt an IRQS-off critical section asynchronously - and machine check events are rare.
The other main asynchronous entries are NMI entries, which can be very high-freq with perf profiling, but they are special: they don't use the 'idtentry' macro but are open coded and restore user CR3 unconditionally so don't have this bug.
--- arch/x86/entry/entry_64.S | 1 + 1 file changed, 1 insertion(+)
arch/x86/entry/entry_64.S +1 -0
@@ -1168,6 +1168,7 @@ ENTRY(paranoid_exit) jmp .Lparanoid_exit_restore .Lparanoid_exit_no_swapgs: TRACE_IRQS_IRETQ_DEBUG + RESTORE_CR3 scratch_reg=%rbx save_reg=%r14 .Lparanoid_exit_restore: jmp restore_regs_and_return_to_kernel END(paranoid_exit)
Greg Kroah-Hartman
maintainerPATCH 88/163 drm/ttm: Dont add swapped BOs to swap-LRU list
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Felix Kuehling <[email protected]>
commit fd5002d6a3c602664b07668a24df4ef7a43bf078 upstream.
A BO that's already swapped would be added back to the swap-LRU list for example if its validation failed under high memory pressure. This could later lead to swapping it out again and leaking previous swap storage.
This commit adds a condition to prevent that from happening.
v2: Check page_flags instead of swap_storage
--- drivers/gpu/drm/ttm/ttm_bo.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/ttm/ttm_bo.c +2 -1
@@ -175,7 +175,8 @@ void ttm_bo_add_to_lru(struct ttm_bufferlist_add_tail (&bo->lru, &man->lru[bo->priority]);kref_get (&bo->list_kref); -if (bo->ttm && !(bo->ttm->page_flags &TTM_PAGE_FLAG_SG )) { +if (bo->ttm && !(bo->ttm->page_flags & + (TTM_PAGE_FLAG_SG |TTM_PAGE_FLAG_SWAPPED ))) {list_add_tail (&bo->swap, &bo->glob->swap_lru[bo->priority]);kref_get (&bo->list_kref);
Greg Kroah-Hartman
maintainerPATCH 89/163 drm/ttm: Fix buf pointer update in ttm_bo_vm_access_kmap() (v2)
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Tom St Denis <[email protected]>
commit 95244db2d3f743f37e69446a2807dd1a42750542 upstream.
The buf pointer was not being incremented inside the loop meaning the same block of data would be read or written repeatedly.
(v2) Change 'buf' pointer to uint8_t* type
--- drivers/gpu/drm/ttm/ttm_bo_vm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/ttm/ttm_bo_vm.c +2 -1
@@ -299,7 +299,7 @@ static void ttm_bo_vm_close(struct vm_arstatic int ttm_bo_vm_access_kmap (struct ttm_buffer_object *bo,unsigned long offset, -void *buf,int len,int write) +uint8_t *buf,int len,int write) {unsigned long page = offset >>PAGE_SHIFT ;unsigned long bytes_left = len;
@@ -328,6 +328,7 @@ static int ttm_bo_vm_access_kmap(structttm_bo_kunmap (&map); page++; + buf += bytes; bytes_left -= bytes; offset =0 ; }while (bytes_left);
Greg Kroah-Hartman
maintainerPATCH 90/163 drm/qxl: unref cursor bo when finished with it
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Ray Strode <[email protected]>
commit 16c6db3688734b27487a42d0c2a1062d0b2bad03 upstream.
qxl_cursor_atomic_update allocs a bo for the cursor that it never frees up at the end of the function.
This commit fixes that.
--- drivers/gpu/drm/qxl/qxl_display.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/gpu/drm/qxl/qxl_display.c +3 -1
@@ -575,7 +575,7 @@ static void qxl_cursor_atomic_update(strstruct qxl_cursor_cmd *cmd;struct qxl_cursor *cursor;struct drm_gem_object *obj; -struct qxl_bo *cursor_bo, *user_bo =NULL ; +struct qxl_bo *cursor_bo =NULL , *user_bo =NULL ;int ret;void *user_ptr;int size =64 *64 *4 ;
@@ -645,6 +645,8 @@ static void qxl_cursor_atomic_update(strqxl_push_cursor_ring_release (qdev, release,QXL_CMD_CURSOR , false);qxl_release_fence_buffer_objects (release); +qxl_bo_unref (&cursor_bo); +return ; out_backoff:
Greg Kroah-Hartman
maintainerPATCH 91/163 drm/qxl: reapply cursor after resetting primary
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Ray Strode <[email protected]>
commit 9428088c90b6f7d5edd2a1b0d742c75339b36f6e upstream.
QXL associates mouse state with its primary plane.
Destroying a primary plane and putting a new one in place has the side effect of destroying the cursor as well.
This commit changes the driver to reapply the cursor any time a new primary is created. It achieves this by keeping a reference to the cursor bo on the qxl_crtc struct.
This fix is very similar to
commit 4532b241a4b7 ("drm/qxl: reapply cursor after SetCrtc calls")
which got implicitly reverted as part of implementing the atomic modeset feature.
Cc: Gerd Hoffmann <[email protected]>
Cc: Dave Airlie <[email protected]>
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1512097
--- drivers/gpu/drm/qxl/qxl_display.c | 59 ++++++++++++++++++++++++++++++++++++++ drivers/gpu/drm/qxl/qxl_drv.h | 2 + 2 files changed, 61 insertions(+)
drivers/gpu/drm/qxl/qxl_display.c +59 -0
@@ -289,6 +289,7 @@ static void qxl_crtc_destroy(struct drm_ {struct qxl_crtc *qxl_crtc =to_qxl_crtc (crtc); +qxl_bo_unref (&qxl_crtc->cursor_bo);drm_crtc_cleanup (crtc);kfree (qxl_crtc); }
@@ -495,6 +496,53 @@ static int qxl_primary_atomic_check(strureturn 0 ; } +static int qxl_primary_apply_cursor (struct drm_plane *plane) +{ +struct drm_device *dev = plane->dev; +struct qxl_device *qdev = dev->dev_private; +struct drm_framebuffer *fb = plane->state->fb; +struct qxl_crtc *qcrtc =to_qxl_crtc (plane->state->crtc); +struct qxl_cursor_cmd *cmd; +struct qxl_release *release; +int ret =0 ; + +if (!qcrtc->cursor_bo) +return 0 ; + + ret =qxl_alloc_release_reserved (qdev,sizeof (*cmd), +QXL_RELEASE_CURSOR_CMD , + &release,NULL ); +if (ret) +return ret; + + ret =qxl_release_list_add (release, qcrtc->cursor_bo); +if (ret) + goto out_free_release; + + ret =qxl_release_reserve_list (release, false); +if (ret) + goto out_free_release; + + cmd = (struct qxl_cursor_cmd *)qxl_release_map (qdev, release); + cmd->type =QXL_CURSOR_SET ; + cmd->u.set.position.x = plane->state->crtc_x + fb->hot_x; + cmd->u.set.position.y = plane->state->crtc_y + fb->hot_y; + + cmd->u.set.shape =qxl_bo_physical_address (qdev, qcrtc->cursor_bo,0 ); + + cmd->u.set.visible =1 ; +qxl_release_unmap (qdev, release, &cmd->release_info); + +qxl_push_cursor_ring_release (qdev, release,QXL_CMD_CURSOR , false); +qxl_release_fence_buffer_objects (release); + +return ret; + +out_free_release: +qxl_release_free (qdev, release); +return ret; +} +static void qxl_primary_atomic_update (struct drm_plane *plane,struct drm_plane_state *old_state) {
@@ -510,6 +558,7 @@ static void qxl_primary_atomic_update(st .x2 = qfb->base.width, .y2 = qfb->base.height }; +int ret;bool same_shadow = false;if (old_state->fb) {
@@ -531,6 +580,11 @@ static void qxl_primary_atomic_update(stif (!same_shadow)qxl_io_destroy_primary (qdev); bo_old->is_primary = false; + + ret =qxl_primary_apply_cursor (plane); +if (ret) +DRM_ERROR ( +"could not set cursor after creating primary" ); }if (!bo->is_primary) {
@@ -571,6 +625,7 @@ static void qxl_cursor_atomic_update(strstruct drm_device *dev = plane->dev;struct qxl_device *qdev = dev->dev_private;struct drm_framebuffer *fb = plane->state->fb; +struct qxl_crtc *qcrtc =to_qxl_crtc (plane->state->crtc);struct qxl_release *release;struct qxl_cursor_cmd *cmd;struct qxl_cursor *cursor;
@@ -628,6 +683,10 @@ static void qxl_cursor_atomic_update(str cmd->u.set.shape =qxl_bo_physical_address (qdev, cursor_bo,0 ); cmd->type =QXL_CURSOR_SET ; + +qxl_bo_unref (&qcrtc->cursor_bo); + qcrtc->cursor_bo = cursor_bo; + cursor_bo =NULL ; }else { ret =qxl_release_reserve_list (release, true);
drivers/gpu/drm/qxl/qxl_drv.h +2 -0
@@ -111,6 +111,8 @@ struct qxl_bo_list {struct qxl_crtc {struct drm_crtc base;int index; + +struct qxl_bo *cursor_bo; };struct qxl_output {
Greg Kroah-Hartman
maintainerPATCH 92/163 drm/amd/powerplay: Fix smu_table_entry.handle type
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Andrey Grodzovsky <[email protected]>
commit adab595d16abe48e9c097f000bf8921d35b28fb7 upstream.
The handle describes kernel logical address, should be unsigned long and not uint32_t.
Fixes KASAN error and GFP on driver unload.
--- drivers/gpu/drm/amd/powerplay/smumgr/rv_smumgr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/powerplay/smumgr/rv_smumgr.h +1 -1
@@ -40,7 +40,7 @@ struct smu_table_entry {uint32_t table_addr_high;uint32_t table_addr_low;uint8_t *table; -uint32_t handle; +unsigned long handle; };struct smu_table_array {
Greg Kroah-Hartman
maintainerPATCH 93/163 drm/ast: Load lut in crtc_commit
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Daniel Vetter <[email protected]>
commit 24b8ef699e8221d2b7f813adaab13eec053e1507 upstream.
In the past the ast driver relied upon the fbdev emulation helpers to call ->load_lut at boot-up. But since
commit b8e2b0199cc377617dc238f5106352c06dcd3fa2
Author: Peter Rosin <[email protected]> Date: Tue Jul 4 12:36:57 2017 +0200
drm/fb-helper: factor out pseudo-palette
that's cleaned up and drivers are expected to boot into a consistent lut state. This patch fixes that.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=198123
--- drivers/gpu/drm/ast/ast_mode.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/ast/ast_mode.c +1 -0
@@ -644,6 +644,7 @@ static void ast_crtc_commit(struct drm_c {struct ast_private *ast = crtc->dev->dev_private;ast_set_index_reg_mask (ast,AST_IO_SEQ_PORT ,0x1 ,0xdf ,0 ); +ast_crtc_load_lut (crtc); }
Greg Kroah-Hartman
maintainerPATCH 94/163 drm: Check for lessee in DROP_MASTER ioctl
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Keith Packard <[email protected]>
commit 761e05a702f5d537ffcca1ba933f9f0a968aa022 upstream.
Don't let a lessee control what the current DRM master is set to; that's the job of the "real" master. Otherwise, the lessee would disable all access to master operations for the owner and all lessees under it.
This matches the same check made in the SET_MASTER ioctl.
--- drivers/gpu/drm/drm_auth.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/gpu/drm/drm_auth.c +6 -0
@@ -230,6 +230,12 @@ int drm_dropmaster_ioctl(struct drm_deviif (!dev->master) goto out_unlock; +if (file_priv->master->lessor !=NULL ) { +DRM_DEBUG_LEASE ("Attempt to drop lessee %d as master\n" , file_priv->master->lessee_id); + ret = -EINVAL ; + goto out_unlock; + } + ret =0 ;drm_drop_master (dev, file_priv); out_unlock:
Greg Kroah-Hartman
maintainerPATCH 95/163 arm64: Add missing Falkor part number for branch predictor hardening
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Shanker Donthineni <[email protected]>
commit 16e574d762ac5512eb922ac0ac5eed360b7db9d8 upstream.
References to CPU part number MIDR_QCOM_FALKOR were dropped from the mailing list patch due to mainline/arm64 branch dependency. So this patch adds the missing part number.
--- arch/arm64/kernel/cpu_errata.c | 9 +++++++++ arch/arm64/kvm/hyp/switch.c | 4 +++- 2 files changed, 12 insertions(+), 1 deletion(-)
arch/arm64/kernel/cpu_errata.c +9 -0
@@ -408,6 +408,15 @@ const struct arm64_cpu_capabilities arm6 }, { .capability = ARM64_HARDEN_BRANCH_PREDICTOR, +MIDR_ALL_VERSIONS (MIDR_QCOM_FALKOR ), + .enable = qcom_enable_link_stack_sanitization, + }, + { + .capability =ARM64_HARDEN_BP_POST_GUEST_EXIT , + MIDR_ALL_VERSIONS(MIDR_QCOM_FALKOR), + }, + { + .capability =ARM64_HARDEN_BRANCH_PREDICTOR ,MIDR_ALL_VERSIONS (MIDR_BRCM_VULCAN ), .enable = enable_smccc_arch_workaround_1, },
arch/arm64/kvm/hyp/switch.c +3 -1
@@ -400,8 +400,10 @@ again:u32 midr =read_cpuid_id ();/* Apply BTAC predictors mitigation to all Falkor chips */ -if ((midr &MIDR_CPU_MODEL_MASK ) ==MIDR_QCOM_FALKOR_V1 ) +if (((midr &MIDR_CPU_MODEL_MASK ) ==MIDR_QCOM_FALKOR ) || + ((midr &MIDR_CPU_MODEL_MASK ) ==MIDR_QCOM_FALKOR_V1 )) {__qcom_hyp_sanitize_btac_predictors (); + } } fp_enabled =__fpsimd_enabled ();
Greg Kroah-Hartman
maintainerPATCH 96/163 drm/radeon: Add dpm quirk for Jet PRO (v2)
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Alex Deucher <[email protected]>
commit 239b5f64e12b1f09f506c164dff0374924782979 upstream.
Fixes stability issues.
v2: clamp sclk to 600 Mhz
--- drivers/gpu/drm/radeon/si_dpm.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/gpu/drm/radeon/si_dpm.c +5 -0
@@ -2984,6 +2984,11 @@ static void si_apply_state_adjust_rules( (rdev->pdev->device == 0x6667)) { max_sclk =75000 ; } +if ((rdev->pdev->revision ==0xC3 ) || + (rdev->pdev->device ==0x6665 )) { + max_sclk =60000 ; + max_mclk =80000 ; + } }else if (rdev->family ==CHIP_OLAND ) { if ((rdev->pdev->revision == 0xC7) || (rdev->pdev->revision == 0x80) ||
Greg Kroah-Hartman
maintainerPATCH 97/163 drm/radeon: adjust tested variable
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Julia Lawall <[email protected]>
commit 3a61b527b4e1f285d21b6e9e623dc45cf8bb391f upstream.
Check the variable that was most recently initialized.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression x, y, f, g, e, m;
statement S1,S2,S3,S4;
@@
x = f(...);
if (\(<+...x...+>\&e\)) S1 else S2
(
x = g(...);
|
m = g(...,&x,...);
|
y = g(...);
*if (e)
S3 else S4
)
// </smpl>
--- drivers/gpu/drm/radeon/radeon_uvd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/radeon/radeon_uvd.c +1 -1
@@ -995,7 +995,7 @@ int radeon_uvd_calc_upll_dividers(struct/* calc dclk divider with current vco freq */ dclk_div =radeon_uvd_calc_upll_post_div (vco_freq, dclk, pd_min, pd_even); -if (vclk_div > pd_max) +if (dclk_div > pd_max)break ;/* vco is too big, it has to stop */ /* calc score with current vco freq */
Greg Kroah-Hartman
maintainerPATCH 98/163 x86/smpboot: Fix uncore_pci_remove() indexing bug when hot-removing a physical CPU
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Masayoshi Mizuma <[email protected]>
commit 295cc7eb314eb3321fb6d67ca6f7305f5c50d10f upstream.
When a physical CPU is hot-removed, the following warning messages are shown while the uncore device is removed in uncore_pci_remove():
WARNING: CPU: 120 PID: 5 at arch/x86/events/intel/uncore.c:988 uncore_pci_remove+0xf1/0x110 ... CPU: 120 PID: 5 Comm: kworker/u1024:0 Not tainted 4.15.0-rc8 #1 Workqueue: kacpi_hotplug acpi_hotplug_work_fn ... Call Trace: pci_device_remove+0x36/0xb0 device_release_driver_internal+0x145/0x210 pci_stop_bus_device+0x76/0xa0 pci_stop_root_bus+0x44/0x60 acpi_pci_root_remove+0x1f/0x80 acpi_bus_trim+0x54/0x90 acpi_bus_trim+0x2e/0x90 acpi_device_hotplug+0x2bc/0x4b0 acpi_hotplug_work_fn+0x1a/0x30 process_one_work+0x141/0x340 worker_thread+0x47/0x3e0 kthread+0xf5/0x130
When uncore_pci_remove() runs, it tries to get the package ID to clear the value of uncore_extra_pci_dev[].dev[] by using topology_phys_to_logical_pkg(). The warning messesages are shown because topology_phys_to_logical_pkg() returns -1.
arch/x86/events/intel/uncore.c:
static void uncore_pci_remove(struct pci_dev *pdev)
{
...
phys_id = uncore_pcibus_to_physid(pdev->bus);
...
pkg = topology_phys_to_logical_pkg(phys_id); // returns -1
for (i = 0; i < UNCORE_EXTRA_PCI_DEV_MAX; i++) {
if (uncore_extra_pci_dev[pkg].dev[i] == pdev) {
uncore_extra_pci_dev[pkg].dev[i] = NULL;
break;
}
}
WARN_ON_ONCE(i >= UNCORE_EXTRA_PCI_DEV_MAX); // <=========== HERE!!topology_phys_to_logical_pkg() tries to find cpuinfo_x86->phys_proc_id that matches the phys_pkg argument.
arch/x86/kernel/smpboot.c:
int topology_phys_to_logical_pkg(unsigned int phys_pkg)
{
int cpu; for_each_possible_cpu(cpu) {
struct cpuinfo_x86 *c = &cpu_data(cpu);
if (c->initialized && c->phys_proc_id == phys_pkg)
return c->logical_proc_id;
}
return -1;}
However, the phys_proc_id was already set to 0 by remove_siblinginfo() when the CPU was offlined.
So, topology_phys_to_logical_pkg() cannot find the correct logical_proc_id and always returns -1.
As the result, uncore_pci_remove() calls WARN_ON_ONCE() and the warning messages are shown.
What is worse is that the bogus 'pkg' index results in two bugs:
- We dereference uncore_extra_pci_dev[] with a negative index
- We fail to clean up a stale pointer in uncore_extra_pci_dev[][]
To fix these bugs, remove the clearing of ->phys_proc_id from remove_siblinginfo().
This should not cause any problems, because ->phys_proc_id is not used after it is hot-removed and it is re-set while hot-adding.
--- arch/x86/kernel/smpboot.c | 1 - 1 file changed, 1 deletion(-)
arch/x86/kernel/smpboot.c +0 -1
@@ -1431,7 +1431,6 @@ static void remove_siblinginfo(int cpu)cpumask_clear (cpu_llc_shared_mask (cpu));cpumask_clear (topology_sibling_cpumask (cpu));cpumask_clear (topology_core_cpumask (cpu)); - c->phys_proc_id =0 ; c->cpu_core_id =0 ;cpumask_clear_cpu (cpu, cpu_sibling_setup_mask);recompute_smt_state ();
Greg Kroah-Hartman
maintainerPATCH 99/163 rtc-opal: Fix handling of firmware error codes, prevent busy loops
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Stewart Smith <[email protected]>
commit 5b8b58063029f02da573120ef4dc9079822e3cda upstream.
According to the OPAL docs:
skiboot-5.2.5/doc/opal-api/opal-rtc-read-3.txt
skiboot-5.2.5/doc/opal-api/opal-rtc-write-4.txt
OPAL_HARDWARE may be returned from OPAL_RTC_READ or OPAL_RTC_WRITE and this indicates either a transient or permanent error.
Prior to this patch, Linux was not dealing with OPAL_HARDWARE being a permanent error particularly well, in that you could end up in a busy loop.
This was not too hard to trigger on an AMI BMC based OpenPOWER machine doing a continuous "ipmitool mc reset cold" to the BMC, the result of that being that we'd get stuck in an infinite loop in opal_get_rtc_time().
We now retry a few times before returning the error higher up the stack.
--- drivers/rtc/rtc-opal.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-)
drivers/rtc/rtc-opal.c +10 -2
@@ -58,6 +58,7 @@ static void tm_to_opal(struct rtc_time *static int opal_get_rtc_time (struct device *dev,struct rtc_time *tm) {long rc =OPAL_BUSY ; +int retries =10 ;u32 y_m_d;u64 h_m_s_ms;__be32 __y_m_d;
@@ -67,8 +68,11 @@ static int opal_get_rtc_time(struct devi rc =opal_rtc_read (&__y_m_d, &__h_m_s_ms);if (rc ==OPAL_BUSY_EVENT )opal_poll_events (NULL ); -else +else if (retries-- && (rc ==OPAL_HARDWARE + || rc ==OPAL_INTERNAL_ERROR ))msleep (10 ); +else if (rc !=OPAL_BUSY && rc !=OPAL_BUSY_EVENT ) +break ; }if (rc !=OPAL_SUCCESS )
@@ -84,6 +88,7 @@ static int opal_get_rtc_time(struct devistatic int opal_set_rtc_time (struct device *dev,struct rtc_time *tm) {long rc =OPAL_BUSY ; +int retries =10 ;u32 y_m_d =0 ;u64 h_m_s_ms =0 ;
@@ -92,8 +97,11 @@ static int opal_set_rtc_time(struct devi rc =opal_rtc_write (y_m_d, h_m_s_ms);if (rc ==OPAL_BUSY_EVENT )opal_poll_events (NULL ); -else +else if (retries-- && (rc ==OPAL_HARDWARE + || rc ==OPAL_INTERNAL_ERROR ))msleep (10 ); +else if (rc !=OPAL_BUSY && rc !=OPAL_BUSY_EVENT ) +break ; }return rc ==OPAL_SUCCESS ?0 : -EIO ;
Greg Kroah-Hartman
maintainerPATCH 100/163 mbcache: initialize entry->e_referenced in mb_cache_entry_create()
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Alexander Potapenko <[email protected]>
commit 3876bbe27d04b848750d5310a37d6b76b593f648 upstream.
KMSAN reported use of uninitialized |entry->e_referenced| in a condition in mb_cache_shrink():
==================================================================
BUG: KMSAN: use of uninitialized memory in mb_cache_shrink+0x3b4/0xc50 fs/mbcache.c:287 CPU: 2 PID: 816 Comm: kswapd1 Not tainted 4.11.0-rc5+ #2877 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:16 [inline] dump_stack+0x172/0x1c0 lib/dump_stack.c:52 kmsan_report+0x12a/0x180 mm/kmsan/kmsan.c:927 __msan_warning_32+0x61/0xb0 mm/kmsan/kmsan_instr.c:469 mb_cache_shrink+0x3b4/0xc50 fs/mbcache.c:287 mb_cache_scan+0x67/0x80 fs/mbcache.c:321 do_shrink_slab mm/vmscan.c:397 [inline] shrink_slab+0xc3d/0x12d0 mm/vmscan.c:500 shrink_node+0x208f/0x2fd0 mm/vmscan.c:2603 kswapd_shrink_node mm/vmscan.c:3172 [inline] balance_pgdat mm/vmscan.c:3289 [inline] kswapd+0x160f/0x2850 mm/vmscan.c:3478 kthread+0x46c/0x5f0 kernel/kthread.c:230 ret_from_fork+0x29/0x40 arch/x86/entry/entry_64.S:430 chained origin: save_stack_trace+0x37/0x40 arch/x86/kernel/stacktrace.c:59 kmsan_save_stack_with_flags mm/kmsan/kmsan.c:302 [inline] kmsan_save_stack mm/kmsan/kmsan.c:317 [inline] kmsan_internal_chain_origin+0x12a/0x1f0 mm/kmsan/kmsan.c:547 __msan_store_shadow_origin_1+0xac/0x110 mm/kmsan/kmsan_instr.c:257 mb_cache_entry_create+0x3b3/0xc60 fs/mbcache.c:95 ext4_xattr_cache_insert fs/ext4/xattr.c:1647 [inline] ext4_xattr_block_set+0x4c82/0x5530 fs/ext4/xattr.c:1022 ext4_xattr_set_handle+0x1332/0x20a0 fs/ext4/xattr.c:1252 ext4_xattr_set+0x4d2/0x680 fs/ext4/xattr.c:1306 ext4_xattr_trusted_set+0x8d/0xa0 fs/ext4/xattr_trusted.c:36 __vfs_setxattr+0x703/0x790 fs/xattr.c:149 __vfs_setxattr_noperm+0x27a/0x6f0 fs/xattr.c:180 vfs_setxattr fs/xattr.c:223 [inline] setxattr+0x6ae/0x790 fs/xattr.c:449 path_setxattr+0x1eb/0x380 fs/xattr.c:468 SYSC_lsetxattr+0x8d/0xb0 fs/xattr.c:490 SyS_lsetxattr+0x77/0xa0 fs/xattr.c:486 entry_SYSCALL_64_fastpath+0x13/0x94 origin: save_stack_trace+0x37/0x40 arch/x86/kernel/stacktrace.c:59 kmsan_save_stack_with_flags mm/kmsan/kmsan.c:302 [inline] kmsan_internal_poison_shadow+0xb1/0x1a0 mm/kmsan/kmsan.c:198 kmsan_kmalloc+0x7f/0xe0 mm/kmsan/kmsan.c:337 kmem_cache_alloc+0x1c2/0x1e0 mm/slub.c:2766 mb_cache_entry_create+0x283/0xc60 fs/mbcache.c:86 ext4_xattr_cache_insert fs/ext4/xattr.c:1647 [inline] ext4_xattr_block_set+0x4c82/0x5530 fs/ext4/xattr.c:1022 ext4_xattr_set_handle+0x1332/0x20a0 fs/ext4/xattr.c:1252 ext4_xattr_set+0x4d2/0x680 fs/ext4/xattr.c:1306 ext4_xattr_trusted_set+0x8d/0xa0 fs/ext4/xattr_trusted.c:36 __vfs_setxattr+0x703/0x790 fs/xattr.c:149 __vfs_setxattr_noperm+0x27a/0x6f0 fs/xattr.c:180 vfs_setxattr fs/xattr.c:223 [inline] setxattr+0x6ae/0x790 fs/xattr.c:449 path_setxattr+0x1eb/0x380 fs/xattr.c:468 SYSC_lsetxattr+0x8d/0xb0 fs/xattr.c:490 SyS_lsetxattr+0x77/0xa0 fs/xattr.c:486 entry_SYSCALL_64_fastpath+0x13/0x94 ==================================================================
--- fs/mbcache.c | 1 + 1 file changed, 1 insertion(+)
fs/mbcache.c +1 -0
@@ -94,6 +94,7 @@ int mb_cache_entry_create(struct mb_cach entry->e_key = key; entry->e_value = value; entry->e_reusable = reusable; + entry->e_referenced =0 ; head =mb_cache_entry_head (cache, key);hlist_bl_lock (head);hlist_bl_for_each_entry (dup, dup_node, head, e_hash_list) {
Greg Kroah-Hartman
maintainerPATCH 101/163 mmc: sdhci: Implement an SDHCI-specific bounce buffer
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Linus Walleij <[email protected]>
commit bd9b902798ab14d19ca116b10bde581ddff8f905 upstream.
The bounce buffer is gone from the MMC core, and now we found out that there are some (crippled) i.MX boards out there that have broken ADMA (cannot do scatter-gather), and also broken PIO so they must use SDMA. Closer examination shows a less significant slowdown also on SDMA-only capable Laptop hosts.
SDMA sets down the number of segments to one, so that each segment gets turned into a singular request that ping-pongs to the block layer before the next request/segment is issued.
Apparently it happens a lot that the block layer send requests that include a lot of physically discontiguous segments. My guess is that this phenomenon is coming from the file system.
These devices that cannot handle scatterlists in hardware can see major benefits from a DMA-contiguous bounce buffer.
This patch accumulates those fragmented scatterlists in a physically contiguous bounce buffer so that we can issue bigger DMA data chunks to/from the card.
When tested with a PCI-integrated host (1217:8221) that only supports SDMA:
0b:00.0 SD Host controller: O2 Micro, Inc. OZ600FJ0/OZ900FJ0/OZ600FJS
SD/MMC Card Reader Controller (rev 05)
This patch gave ~1Mbyte/s improved throughput on large reads and writes when testing using iozone than without the patch.
dmesg:
sdhci-pci 0000:0b:00.0: SDHCI controller found [1217:8221] (rev 5) mmc0 bounce up to 128 segments into one, max segment size 65536 bytes
mmc0: SDHCI controller on PCI [0000:0b:00.0] using DMA
On the i.MX SDHCI controllers on the crippled i.MX 25 and i.MX 35 the patch restores the performance to what it was before we removed the bounce buffers.
--- drivers/mmc/host/sdhci.c | 164 ++++++++++++++++++++++++++++++++++++++++++++--- drivers/mmc/host/sdhci.h | 3 2 files changed, 159 insertions(+), 8 deletions(-)
drivers/mmc/host/sdhci.c +156 -8
@@ -21,6 +21,7 @@#include <linux/dma-mapping.h> #include <linux/slab.h> #include <linux/scatterlist.h> +#include <linux/sizes.h> #include <linux/swiotlb.h> #include <linux/regulator/consumer.h> #include <linux/pm_runtime.h>
@@ -502,8 +503,35 @@ static int sdhci_pre_dma_transfer(structif (data->host_cookie ==COOKIE_PRE_MAPPED )return data->sg_count; - sg_count =dma_map_sg (mmc_dev (host->mmc), data->sg, data->sg_len, -mmc_get_dma_dir (data)); +/* Bounce write requests to the bounce buffer */ +if (host->bounce_buffer) { +unsigned int length = data->blksz * data->blocks; + +if (length > host->bounce_buffer_size) { +pr_err ("%s: asked for transfer of %u bytes exceeds bounce buffer %u bytes\n" , +mmc_hostname (host->mmc), length, + host->bounce_buffer_size); +return -EIO ; + } +if (mmc_get_dma_dir (data) ==DMA_TO_DEVICE ) { +/* Copy the data to the bounce buffer */ +sg_copy_to_buffer (data->sg, data->sg_len, + host->bounce_buffer, + length); + } +/* Switch ownership to the DMA */ +dma_sync_single_for_device (host->mmc->parent, + host->bounce_addr, + host->bounce_buffer_size, +mmc_get_dma_dir (data)); +/* Just a dummy value */ + sg_count =1 ; + }else { +/* Just access the data directly from memory */ + sg_count =dma_map_sg (mmc_dev (host->mmc), + data->sg, data->sg_len, +mmc_get_dma_dir (data)); + }if (sg_count ==0 )return -ENOSPC ;
@@ -673,6 +701,14 @@ static void sdhci_adma_table_post(struct } } +static u32 sdhci_sdma_address (struct sdhci_host *host) +{ +if (host->bounce_buffer) +return host->bounce_addr; +else +return sg_dma_address (host->data->sg); +} +static u8 sdhci_calc_timeout (struct sdhci_host *host,struct mmc_command *cmd) {u8 count;
@@ -858,8 +894,8 @@ static void sdhci_prepare_data(struct sd SDHCI_ADMA_ADDRESS_HI); }else {WARN_ON (sg_cnt !=1 ); -sdhci_writel (host,sg_dma_address (data->sg), -SDHCI_DMA_ADDRESS ); +sdhci_writel (host,sdhci_sdma_address (host), +SDHCI_DMA_ADDRESS ); } }
@@ -2248,7 +2284,12 @@ static void sdhci_pre_req(struct mmc_hos mrq->data->host_cookie =COOKIE_UNMAPPED ; -if (host->flags &SDHCI_REQ_USE_DMA ) +/* +* No pre-mapping in the pre hook if we're using the bounce buffer, +* for that we would need two bounce buffers since one buffer is +* in flight when this is getting called. +*/ +if (host->flags &SDHCI_REQ_USE_DMA && !host->bounce_buffer)sdhci_pre_dma_transfer (host, mrq->data,COOKIE_PRE_MAPPED ); }
@@ -2352,8 +2393,45 @@ static bool sdhci_request_done(struct sdstruct mmc_data *data = mrq->data;if (data && data->host_cookie ==COOKIE_MAPPED ) { -dma_unmap_sg (mmc_dev (host->mmc), data->sg, data->sg_len, -mmc_get_dma_dir (data)); +if (host->bounce_buffer) { +/* +* On reads, copy the bounced data into the +* sglist +*/ +if (mmc_get_dma_dir (data) ==DMA_FROM_DEVICE ) { +unsigned int length = data->bytes_xfered; + +if (length > host->bounce_buffer_size) { +pr_err ("%s: bounce buffer is %u bytes but DMA claims to have transferred %u bytes\n" , +mmc_hostname (host->mmc), + host->bounce_buffer_size, + data->bytes_xfered); +/* Cap it down and continue */ + length = host->bounce_buffer_size; + } +dma_sync_single_for_cpu ( + host->mmc->parent, + host->bounce_addr, + host->bounce_buffer_size, +DMA_FROM_DEVICE ); +sg_copy_from_buffer (data->sg, + data->sg_len, + host->bounce_buffer, + length); + }else { +/* No copying, just switch ownership */ +dma_sync_single_for_cpu ( + host->mmc->parent, + host->bounce_addr, + host->bounce_buffer_size, +mmc_get_dma_dir (data)); + } + }else { +/* Unmap the raw data */ +dma_unmap_sg (mmc_dev (host->mmc), data->sg, + data->sg_len, +mmc_get_dma_dir (data)); + } data->host_cookie =COOKIE_UNMAPPED ; } }
@@ -2636,7 +2714,8 @@ static void sdhci_data_irq(struct sdhci_*/ if (intmask &SDHCI_INT_DMA_END ) {u32 dmastart, dmanow; - dmastart =sg_dma_address (host->data->sg); + + dmastart =sdhci_sdma_address (host); dmanow = dmastart + host->data->bytes_xfered;/* * Force update to the next DMA block boundary.
@@ -3217,6 +3296,68 @@ void __sdhci_read_caps(struct sdhci_host }EXPORT_SYMBOL_GPL (__sdhci_read_caps); +static int sdhci_allocate_bounce_buffer (struct sdhci_host *host) +{ +struct mmc_host *mmc = host->mmc; +unsigned int max_blocks; +unsigned int bounce_size; +int ret; + +/* +* Cap the bounce buffer at 64KB. Using a bigger bounce buffer +* has diminishing returns, this is probably because SD/MMC +* cards are usually optimized to handle this size of requests. +*/ + bounce_size =SZ_64K ; +/* +* Adjust downwards to maximum request size if this is less +* than our segment size, else hammer down the maximum +* request size to the maximum buffer size. +*/ +if (mmc->max_req_size < bounce_size) + bounce_size = mmc->max_req_size; + max_blocks = bounce_size /512 ; + +/* +* When we just support one segment, we can get significant +* speedups by the help of a bounce buffer to group scattered +* reads/writes together. +*/ + host->bounce_buffer =devm_kmalloc (mmc->parent, + bounce_size, +GFP_KERNEL ); +if (!host->bounce_buffer) { +pr_err ("%s: failed to allocate %u bytes for bounce buffer, falling back to single segments\n" , +mmc_hostname (mmc), + bounce_size); +/* +* Exiting with zero here makes sure we proceed with +* mmc->max_segs == 1. +*/ +return 0 ; + } + + host->bounce_addr =dma_map_single (mmc->parent, + host->bounce_buffer, + bounce_size, +DMA_BIDIRECTIONAL ); + ret =dma_mapping_error (mmc->parent, host->bounce_addr); +if (ret) +/* Again fall back to max_segs == 1 */ +return 0 ; + host->bounce_buffer_size = bounce_size; + +/* Lie about this since we're bouncing */ + mmc->max_segs = max_blocks; + mmc->max_seg_size = bounce_size; + mmc->max_req_size = bounce_size; + +pr_info ("%s bounce up to %u segments into one, max segment size %u bytes\n" , +mmc_hostname (mmc), max_blocks, bounce_size); + +return 0 ; +} +int sdhci_setup_host (struct sdhci_host *host) {struct mmc_host *mmc;
@@ -3713,6 +3854,13 @@ int sdhci_setup_host(struct sdhci_host **/ mmc->max_blk_count = (host->quirks &SDHCI_QUIRK_NO_MULTIBLOCK ) ?1 :65535 ; +if (mmc->max_segs ==1 ) { +/* This may alter mmc->*_blk_* parameters */ + ret =sdhci_allocate_bounce_buffer (host); +if (ret) +return ret; + } +return 0 ; unreg:
drivers/mmc/host/sdhci.h +3 -0
@@ -440,6 +440,9 @@ struct sdhci_host {int irq;/* Device IRQ */ void __iomem *ioaddr;/* Mapped address */ +char *bounce_buffer;/* For packing SDMA reads/writes */ +dma_addr_t bounce_addr; +unsigned int bounce_buffer_size;const struct sdhci_ops *ops;/* Low level hw interface */
Greg Kroah-Hartman
maintainerPATCH 102/163 mmc: bcm2835: Dont overwrite max frequency unconditionally
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Phil Elwell <[email protected]>
commit 118032be389009b07ecb5a03ffe219a89d421def upstream.
The optional DT parameter max-frequency could init the max bus frequency. So take care of this, before setting the max bus frequency.
--- drivers/mmc/host/bcm2835.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/mmc/host/bcm2835.c +2 -1
@@ -1265,7 +1265,8 @@ static int bcm2835_add_host(struct bcm28char pio_limit_string[20 ];int ret; - mmc->f_max = host->max_clk; +if (!mmc->f_max || mmc->f_max > host->max_clk) + mmc->f_max = host->max_clk; mmc->f_min = host->max_clk /SDCDIV_MAX_CDIV ; mmc->max_busy_timeout = ~0 / (mmc->f_max /1000 );
Greg Kroah-Hartman
maintainerPATCH 103/163 Revert "mmc: meson-gx: include tx phase in the tuning process"
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Jerome Brunet <[email protected]>
commit fe0e58048f005fdce315eb4d185e5c160be4ac01 upstream.
This reverts commit 0a44697627d17a66d7dc98f17aeca07ca79c5c20.
This commit was initially intended to fix problems with hs200 and hs400 on some boards, mainly the odroid-c2. The OC2 (Rev 0.2) I have performs well in this modes, so I could not confirm these issues.
We've had several reports about the issues being still present on (some) OC2, so apparently, this change does not do what it was supposed to do. Maybe the eMMC signal quality is on the edge on the board. This may explain the variability we see in term of stability, but this is just a guess. Lowering the max_frequency to 100Mhz seems to do trick for those affected by the issue
Worse, the commit created new issues (CRC errors and hangs) on other boards, such as the kvim 1 and 2, the p200 or the libretech-cc.
According to amlogic, the Tx phase should not be tuned and left in its default configuration, so it is best to just revert the commit.
--- drivers/mmc/host/meson-gx-mmc.c | 19 +------------------ 1 file changed, 1 insertion(+), 18 deletions(-)
drivers/mmc/host/meson-gx-mmc.c +1 -18
@@ -716,22 +716,6 @@ static int meson_mmc_clk_phase_tuning(ststatic int meson_mmc_execute_tuning (struct mmc_host *mmc,u32 opcode) {struct meson_host *host =mmc_priv (mmc); -int ret; - -/* -* If this is the initial tuning, try to get a sane Rx starting -* phase before doing the actual tuning. -*/ -if (!mmc->doing_retune) { - ret =meson_mmc_clk_phase_tuning (mmc, opcode, host->rx_clk); - -if (ret) -return ret; - } - - ret =meson_mmc_clk_phase_tuning (mmc, opcode, host->tx_clk); -if (ret) -return ret;return meson_mmc_clk_phase_tuning (mmc, opcode, host->rx_clk); }
@@ -762,9 +746,8 @@ static void meson_mmc_set_ios(struct mmcif (!IS_ERR (mmc->supply.vmmc))mmc_regulator_set_ocr (mmc, mmc->supply.vmmc, ios->vdd); -/* Reset phases */ +/* Reset rx phase */ clk_set_phase (host->rx_clk,0 ); -clk_set_phase (host->tx_clk,270 );break ;
Greg Kroah-Hartman
maintainerPATCH 104/163 mlx5: fix mlx5_get_vector_affinity to start from completion vector 0
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Sagi Grimberg <[email protected]>
commit 2572cf57d75a7f91835d9a38771e9e76d575d122 upstream.
The consumers of this routine expects the affinity map of of vector index relative to the first completion vector. The upper layers are not aware of internal/private completion vectors that mlx5 allocates for its own usage.
Hence, return the affinity map of vector index relative to the first completion vector.
--- include/linux/mlx5/driver.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/mlx5/driver.h +1 -1
@@ -1238,7 +1238,7 @@ mlx5_get_vector_affinity(struct mlx5_corint eqn;int err; - err =mlx5_vector2eqn (dev, vector, &eqn, &irq); + err =mlx5_vector2eqn (dev,MLX5_EQ_VEC_COMP_BASE + vector, &eqn, &irq);if (err)return NULL ;
Greg Kroah-Hartman
maintainerPATCH 105/163 Revert "apple-gmux: lock iGP IO to protect from vgaarb changes"
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Lukas Wunner <[email protected]>
commit d6fa7588fd7a8def4c747c0c574ce85d453e3788 upstream.
Commit 4eebd5a4e726 ("apple-gmux: lock iGP IO to protect from vgaarb changes") amended this driver's ->probe hook to lock decoding of normal (non-legacy) I/O space accesses to the integrated GPU on dual-GPU MacBook Pros. The lock stays in place until the driver is unbound.
The change was made to work around an issue with the out-of-tree nvidia graphics driver (available at http://www.nvidia.com/object/unix.html).
It contains the following sequence in nvidia/nv.c:
#if defined(CONFIG_VGA_ARB) && !defined(NVCPU_PPC64LE) #if defined(VGA_DEFAULT_DEVICE) vga_tryget(VGA_DEFAULT_DEVICE, VGA_RSRC_LEGACY_MASK); #endif vga_set_legacy_decoding(dev, VGA_RSRC_NONE); #endif
This code was reported to cause deadlocks with VFIO already in 2013:
https://devtalk.nvidia.com/default/topic/545560
I've reported the issue to Nvidia developers once more in 2017:
https://www.spinics.net/lists/dri-devel/msg138754.html
On the MacBookPro10,1, this code apparently breaks backlight control (which is handled by apple-gmux via an I/O region starting at 0x700), as reported by Petri Hodju:
https://bugzilla.kernel.org/show_bug.cgi?id=86121
I tried to replicate Petri's observations on my MacBook9,1, which uses the same Intel Ivy Bridge + Nvidia GeForce GT 650M architecture, to no avail. On my machine apple-gmux' I/O region remains accessible even with the nvidia driver loaded and commit 4eebd5a4e726 reverted. Petri reported that apple-gmux becomes accessible again after a suspend/resume cycle because the BIOS changed the VGA routing on the root port to the Nvidia GPU. Perhaps this is a BIOS issue after all that can be fixed with an update?
In any case, the change made by commit 4eebd5a4e726 has turned out to cause two new issues:
* Wilfried Klaebe reports a deadlock when launching Xorg because it opens /dev/vga_arbiter and calls vga_get(), but apple-gmux is holding a lock on I/O space indefinitely. It looks like apple-gmux' current behavior is an abuse of the vgaarb API as locks are not meant to be held for longer periods:
https://bugzilla.kernel.org/show_bug.cgi?id=88861#c11
https://bugzilla.kernel.org/attachment.cgi?id=217541
* On dual GPU MacBook Pros introduced since 2013, the integrated GPU is powergated on boot und thus becomes invisible to Linux unless a custom EFI protocol is used to leave it powered on. (A patch exists but is not in mainline yet due to several negative side effects.) On these machines, locking I/O to the integrated GPU (as done by 4eebd5a4e726) fails and backlight control is therefore broken:
https://bugzilla.kernel.org/show_bug.cgi?id=105051
So let's revert commit 4eebd5a4e726 please. Users experiencing the issue with the proprietary nvidia driver can comment out the above- quoted problematic code as a workaround (or try updating the BIOS).
--- drivers/platform/x86/apple-gmux.c | 48 -------------------------------------- 1 file changed, 1 insertion(+), 47 deletions(-)
drivers/platform/x86/apple-gmux.c +1 -47
@@ -24,7 +24,6 @@#include <linux/delay.h> #include <linux/pci.h> #include <linux/vga_switcheroo.h> -#include <linux/vgaarb.h> #include <acpi/video.h> #include <asm/io.h>
@@ -54,7 +53,6 @@ struct apple_gmux_data {bool indexed;struct mutex index_lock; -struct pci_dev *pdev;struct backlight_device *bdev;/* switcheroo data */
@@ -599,23 +597,6 @@ static int gmux_resume(struct device *dereturn 0 ; } -static struct pci_dev *gmux_get_io_pdev (void ) -{ -struct pci_dev *pdev =NULL ; - -while ((pdev =pci_get_class (PCI_CLASS_DISPLAY_VGA <<8 , pdev))) { -u16 cmd; - -pci_read_config_word (pdev,PCI_COMMAND , &cmd); -if (!(cmd &PCI_COMMAND_IO )) -continue ; - -return pdev; - } - -return NULL ; -} -static int is_thunderbolt (struct device *dev,void *data) {return to_pci_dev (dev)->is_thunderbolt;
@@ -631,7 +612,6 @@ static int gmux_probe(struct pnp_dev *pnint ret = -ENXIO ;acpi_status status;unsigned long long gpe; -struct pci_dev *pdev =NULL ;if (apple_gmux_data)return -EBUSY ;
@@ -682,7 +662,7 @@ static int gmux_probe(struct pnp_dev *pn ver_minor = (version >>16 ) &0xff ; ver_release = (version >>8 ) &0xff ; }else { -pr_info ("gmux device not present or IO disabled\n" ); +pr_info ("gmux device not present\n" ); ret = -ENODEV ; goto err_release; }
@@ -690,23 +670,6 @@ static int gmux_probe(struct pnp_dev *pnpr_info ("Found gmux version %d.%d.%d [%s]\n" , ver_major, ver_minor, ver_release, (gmux_data->indexed ?"indexed" :"classic" )); -/* -* Apple systems with gmux are EFI based and normally don't use -* VGA. In addition changing IO+MEM ownership between IGP and dGPU -* disables IO/MEM used for backlight control on some systems. -* Lock IO+MEM to GPU with active IO to prevent switch. -*/ - pdev =gmux_get_io_pdev (); -if (pdev &&vga_tryget (pdev, -VGA_RSRC_NORMAL_IO |VGA_RSRC_NORMAL_MEM )) { -pr_err ("IO+MEM vgaarb-locking for PCI:%s failed\n" , -pci_name (pdev)); - ret = -EBUSY ; - goto err_release; - }else if (pdev) -pr_info ("locked IO for PCI:%s\n" ,pci_name (pdev)); - gmux_data->pdev = pdev; -memset (&props,0 ,sizeof (props)); props.type =BACKLIGHT_PLATFORM ; props.max_brightness =gmux_read32 (gmux_data,GMUX_PORT_MAX_BRIGHTNESS );
@@ -822,10 +785,6 @@ err_enable_gpe: err_notify:backlight_device_unregister (bdev); err_release: -if (gmux_data->pdev) -vga_put (gmux_data->pdev, -VGA_RSRC_NORMAL_IO |VGA_RSRC_NORMAL_MEM ); -pci_dev_put (pdev);release_region (gmux_data->iostart, gmux_data->iolen); err_free:kfree (gmux_data);
@@ -845,11 +804,6 @@ static void gmux_remove(struct pnp_dev * &gmux_notify_handler); } -if (gmux_data->pdev) { -vga_put (gmux_data->pdev, -VGA_RSRC_NORMAL_IO |VGA_RSRC_NORMAL_MEM ); -pci_dev_put (gmux_data->pdev); - }backlight_device_unregister (gmux_data->bdev);release_region (gmux_data->iostart, gmux_data->iolen);
Greg Kroah-Hartman
maintainerPATCH 106/163 jbd2: fix sphinx kernel-doc build warnings
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Tobin C. Harding <[email protected]>
commit f69120ce6c024aa634a8fc25787205e42f0ccbe6 upstream.
Sphinx emits various (26) warnings when building make target 'htmldocs'. Currently struct definitions contain duplicate documentation, some as kernel-docs and some as standard c89 comments. We can reduce duplication while cleaning up the kernel docs.
Move all kernel-docs to right above each struct member. Use the set of all existing comments (kernel-doc and c89). Add documentation for missing struct members and function arguments.
--- fs/jbd2/transaction.c | 5 include/linux/jbd2.h | 431 +++++++++++++++++++++++++++++++------------------- 2 files changed, 272 insertions(+), 164 deletions(-)
fs/jbd2/transaction.c +4 -1
@@ -495,8 +495,10 @@ void jbd2_journal_free_reserved(handle_tEXPORT_SYMBOL (jbd2_journal_free_reserved);/** -* int jbd2_journal_start_reserved(handle_t *handle) - start reserved handle +* int jbd2_journal_start_reserved() - start reserved handle * @handle: handle to start +* @type: for handle statistics +* @line_no: for handle statistics * * Start handle that has been previously reserved with jbd2_journal_reserve(). * This attaches @handle to the running transaction (or creates one if there's
@@ -626,6 +628,7 @@ error_out:* int jbd2_journal_restart() - restart a handle . * @handle: handle to restart * @nblocks: nr credits requested +* @gfp_mask: memory allocation flags (for start_this_handle) * * Restart a handle for a multi-transaction filesystem * operation.
include/linux/jbd2.h +268 -163
651 lines not on this page · raw message
Greg Kroah-Hartman
maintainerPATCH 107/163 ext4: fix a race in the ext4 shutdown path
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Harshad Shirwadkar <[email protected]>
commit abbc3f9395c76d554a9ed27d4b1ebfb5d9b0e4ca upstream.
This patch fixes a race between the shutdown path and bio completion handling. In the ext4 direct io path with async io, after submitting a bio to the block layer, if journal starting fails, ext4_direct_IO_write() would bail out pretending that the IO failed. The caller would have had no way of knowing whether or not the IO was successfully submitted. So instead, we return -EIOCBQUEUED in this case. Now, the caller knows that the IO was submitted. The bio completion handler takes care of the error.
Tested: Ran the shutdown xfstest test 461 in loop for over 2 hours across 4 machines resulting in over 400 runs. Verified that the race didn't occur. Usually the race was seen in about 20-30 iterations.
--- fs/ext4/inode.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-)
fs/ext4/inode.c +12 -4
@@ -3767,10 +3767,18 @@ static ssize_t ext4_direct_IO_write(stru/* Credits for sb + inode write */ handle =ext4_journal_start (inode,EXT4_HT_INODE ,2 );if (IS_ERR (handle)) { -/* This is really bad luck. We've written the data -* but cannot extend i_size. Bail out and pretend -* the write failed... */ - ret =PTR_ERR (handle); +/* +* We wrote the data but cannot extend +* i_size. Bail out. In async io case, we do +* not return error here because we have +* already submmitted the corresponding +* bio. Returning error here makes the caller +* think that this IO is done and failed +* resulting in race with bio's completion +* handler. +*/ +if (!ret) + ret =PTR_ERR (handle);if (inode->i_nlink)ext4_orphan_del (NULL , inode);
Greg Kroah-Hartman
maintainerPATCH 108/163 ext4: save error to disk in __ext4_grp_locked_error()
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Zhouyi Zhou <[email protected]>
commit 06f29cc81f0350261f59643a505010531130eea0 upstream.
In the function __ext4_grp_locked_error(), __save_error_info() is called to save error info in super block block, but does not sync that information to disk to info the subsequence fsck after reboot.
This patch writes the error information to disk. After this patch, I think there is no obvious EXT4 error handle branches which leads to "Remounting filesystem read-only" will leave the disk partition miss the subsequence fsck.
--- fs/ext4/super.c | 1 + 1 file changed, 1 insertion(+)
fs/ext4/super.c +1 -0
@@ -742,6 +742,7 @@ __acquires(bitlock) }ext4_unlock_group (sb, grp); +ext4_commit_super (sb,1 );ext4_handle_error (sb);/* * We only get here in the ERRORS_RO case; relocking the group
Greg Kroah-Hartman
maintainerPATCH 109/163 ext4: correct documentation for grpid mount option
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Ernesto A. Fernández <[email protected]>
commit 9f0372488cc9243018a812e8cfbf27de650b187b upstream.
The grpid option is currently described as being the same as nogrpid.
--- Documentation/filesystems/ext4.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/filesystems/ext4.txt +1 -1
@@ -233,7 +233,7 @@ data_err=ignore(*) Just print an error m data_err=abort Abort the journal if an error occurs in a file data buffer in ordered mode. -grpid Give objects the same group ID as their creator. +grpid New objects have the group ID of their parent. bsdgroups nogrpid (*) New objects have the group ID of their creator.
Greg Kroah-Hartman
maintainerPATCH 110/163 mm: hide a #warning for COMPILE_TEST
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Arnd Bergmann <[email protected]>
commit af27d9403f5b80685b79c88425086edccecaf711 upstream.
We get a warning about some slow configurations in randconfig kernels:
mm/memory.c:83:2: error: #warning Unfortunate NUMA and NUMA Balancing config, growing page-frame for last_cpupid. [-Werror=cpp]
The warning is reasonable by itself, but gets in the way of randconfig build testing, so I'm hiding it whenever CONFIG_COMPILE_TEST is set.
The warning was added in 2013 in commit 75980e97dacc ("mm: fold page->_last_nid into page->flags where possible").
--- mm/memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
mm/memory.c +1 -1
@@ -81,7 +81,7 @@#include "internal.h" -#ifdef LAST_CPUPID_NOT_IN_PAGE_FLAGS +#if defined(LAST_CPUPID_NOT_IN_PAGE_FLAGS ) && !defined(CONFIG_COMPILE_TEST )#warning Unfortunate NUMA and NUMA Balancing config, growing page-frame for last_cpupid.#endif
Greg Kroah-Hartman
maintainerPATCH 111/163 mm: Fix memory size alignment in devm_memremap_pages_release()
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Jan H. Schönherr <[email protected]>
commit 10a0cd6e4932b5078215b1ec2c896597eec0eff9 upstream.
The functions devm_memremap_pages() and devm_memremap_pages_release() use different ways to calculate the section-aligned amount of memory. The latter function may use an incorrect size if the memory region is small but straddles a section border.
Use the same code for both.
--- kernel/memremap.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
kernel/memremap.c +2 -1
@@ -301,7 +301,8 @@ static void devm_memremap_pages_release(/* pages are dead and unused, undo the arch mapping */ align_start = res->start & ~(SECTION_SIZE -1 ); - align_size =ALIGN (resource_size (res),SECTION_SIZE ); + align_size =ALIGN (res->start +resource_size (res),SECTION_SIZE ) + - align_start;mem_hotplug_begin ();arch_remove_memory (align_start, align_size);
Greg Kroah-Hartman
maintainerPATCH 112/163 MIPS: Fix typo BIG_ENDIAN to CPU_BIG_ENDIAN
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Corentin Labbe <[email protected]>
commit 2e6522c565522a2e18409c315c49d78c8b74807b upstream.
MIPS_GENERIC selects some options conditional on BIG_ENDIAN which does not exist.
Replace BIG_ENDIAN with CPU_BIG_ENDIAN which is the correct kconfig name. Note that BMIPS_GENERIC does the same which confirms that this patch is needed.
Patchwork: https://patchwork.linux-mips.org/patch/18495/
--- arch/mips/Kconfig | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
arch/mips/Kconfig +6 -6
@@ -119,12 +119,12 @@ config MIPS_GENERIC select SYS_SUPPORTS_MULTITHREADING select SYS_SUPPORTS_RELOCATABLE select SYS_SUPPORTS_SMARTMIPS - select USB_EHCI_BIG_ENDIAN_DESC if BIG_ENDIAN - select USB_EHCI_BIG_ENDIAN_MMIO if BIG_ENDIAN - select USB_OHCI_BIG_ENDIAN_DESC if BIG_ENDIAN - select USB_OHCI_BIG_ENDIAN_MMIO if BIG_ENDIAN - select USB_UHCI_BIG_ENDIAN_DESC if BIG_ENDIAN - select USB_UHCI_BIG_ENDIAN_MMIO if BIG_ENDIAN + select USB_EHCI_BIG_ENDIAN_DESC if CPU_BIG_ENDIAN + select USB_EHCI_BIG_ENDIAN_MMIO if CPU_BIG_ENDIAN + select USB_OHCI_BIG_ENDIAN_DESC if CPU_BIG_ENDIAN + select USB_OHCI_BIG_ENDIAN_MMIO if CPU_BIG_ENDIAN + select USB_UHCI_BIG_ENDIAN_DESC if CPU_BIG_ENDIAN + select USB_UHCI_BIG_ENDIAN_MMIO if CPU_BIG_ENDIAN select USE_OF help Select this to build a kernel which aims to support multiple boards,
Greg Kroah-Hartman
maintainerPATCH 113/163 MIPS: CPS: Fix MIPS_ISA_LEVEL_RAW fallout
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: James Hogan <[email protected]>
commit 8dbc1864b74f5dea5a3f7c30ca8fd358a675132f upstream.
Commit 17278a91e04f ("MIPS: CPS: Fix r1 .set mt assembler warning") added .set MIPS_ISA_LEVEL_RAW to silence warnings about .set mt on r1, however this can result in a MOVE being encoded as a 64-bit DADDU instruction on certain version of binutils (e.g. 2.22), and reserved instruction exceptions at runtime on 32-bit hardware.
Reduce the sizes of the push/pop sections to include only instructions that are part of the MT ASE or which won't convert to 64-bit instructions after .set mips64r2/mips64r6.
Patchwork: https://patchwork.linux-mips.org/patch/18578/
--- arch/mips/kernel/cps-vec.S | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-)
arch/mips/kernel/cps-vec.S +12 -5
@@ -388,15 +388,16 @@ LEAF(mips_cps_boot_vpes) #elif defined(CONFIG_MIPS_MT) - .set push - .set MIPS_ISA_LEVEL_RAW - .set mt - /* If the core doesn't support MT then return */ has_mt t0, 5f /* Enter VPE configuration state */ + .set push + .set MIPS_ISA_LEVEL_RAW + .set mt dvpe + .set pop + PTR_LA t1, 1f jr.hb t1 nop
@@ -422,6 +423,10 @@ LEAF(mips_cps_boot_vpes) mtc0 t0, CP0_VPECONTROL ehb + .set push + .set MIPS_ISA_LEVEL_RAW + .set mt + /* Skip the VPE if its TC is not halted */ mftc0 t0, CP0_TCHALT beqz t0, 2f
@@ -495,6 +500,8 @@ LEAF(mips_cps_boot_vpes) ehb evpe + .set pop + /* Check whether this VPE is meant to be running */ li t0, 1 sll t0, t0, a1
@@ -509,7 +516,7 @@ LEAF(mips_cps_boot_vpes) 1: jr.hb t0 nop -2: .set pop +2: #endif /* CONFIG_MIPS_MT_SMP */
Greg Kroah-Hartman
maintainerPATCH 114/163 MIPS: Fix incorrect mem=X@Y handling
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Marcin Nowakowski <[email protected]>
commit 67a3ba25aa955198196f40b76b329b3ab9ad415a upstream.
Commit 73fbc1eba7ff ("MIPS: fix mem=X@Y commandline processing") added a fix to ensure that the memory range between PHYS_OFFSET and low memory address specified by mem= cmdline argument is not later processed by free_all_bootmem. This change was incorrect for systems where the commandline specifies more than 1 mem argument, as it will cause all memory between PHYS_OFFSET and each of the memory offsets to be marked as reserved, which results in parts of the RAM marked as reserved (Creator CI20's u-boot has a default commandline argument 'mem=256M@0x0 mem=768M@0x30000000').
Change the behaviour to ensure that only the range between PHYS_OFFSET and the lowest start address of the memories is marked as protected.
This change also ensures that the range is marked protected even if it's only defined through the devicetree and not only via commandline arguments.
Patchwork: https://patchwork.linux-mips.org/patch/18562/
--- arch/mips/kernel/setup.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-)
arch/mips/kernel/setup.c +12 -4
@@ -375,6 +375,7 @@ static void __init bootmem_init(void)unsigned long reserved_end;unsigned long mapstart = ~0UL ;unsigned long bootmap_size; +phys_addr_t ramstart = (phys_addr_t )ULLONG_MAX ;bool bootmap_valid = false;int i;
@@ -395,7 +396,8 @@ static void __init bootmem_init(void) max_low_pfn =0 ;/* -* Find the highest page frame number we have available. +* Find the highest page frame number we have available +* and the lowest used RAM address */ for (i =0 ; i < boot_mem_map.nr_map; i++) {unsigned long start, end;
@@ -407,6 +409,8 @@ static void __init bootmem_init(void) end =PFN_DOWN (boot_mem_map.map[i].addr + boot_mem_map.map[i].size); + ramstart =min (ramstart, boot_mem_map.map[i].addr); +#ifndef CONFIG_HIGHMEM /* * Skip highmem here so we get an accurate max_low_pfn if low
@@ -436,6 +440,13 @@ static void __init bootmem_init(void) mapstart =max (reserved_end, start); } +/* +* Reserve any memory between the start of RAM and PHYS_OFFSET +*/ +if (ramstart >PHYS_OFFSET ) +add_memory_region (PHYS_OFFSET , ramstart -PHYS_OFFSET , +BOOT_MEM_RESERVED ); +if (min_low_pfn >= max_low_pfn)panic ("Incorrect memory mapping !!!" );if (min_low_pfn >ARCH_PFN_OFFSET ) {
@@ -664,9 +675,6 @@ static int __init early_parse_mem(char *add_memory_region (start, size,BOOT_MEM_RAM ); -if (start && start >PHYS_OFFSET ) -add_memory_region (PHYS_OFFSET , start -PHYS_OFFSET , -BOOT_MEM_RESERVED );return 0 ; }early_param ("mem" , early_parse_mem);
Greg Kroah-Hartman
maintainerPATCH 115/163 PCI: Disable MSI for HiSilicon Hip06/Hip07 only in Root Port mode
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Dongdong Liu <[email protected]>
commit deb86999323661c019ef2740eb9d479d1e526b5c upstream.
HiSilicon Hip06/Hip07 can operate as either a Root Port or an Endpoint. It always advertises an MSI capability, but it can only generate MSIs when in Endpoint mode.
The device has the same Vendor and Device IDs in both modes, so check the Class Code and disable MSI only when operating as a Root Port.
--- drivers/pci/quirks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/quirks.c +1 -1
@@ -1636,8 +1636,8 @@ static void quirk_pcie_mch(struct pci_deDECLARE_PCI_FIXUP_FINAL (PCI_VENDOR_ID_INTEL ,PCI_DEVICE_ID_INTEL_E7520_MCH , quirk_pcie_mch);DECLARE_PCI_FIXUP_FINAL (PCI_VENDOR_ID_INTEL ,PCI_DEVICE_ID_INTEL_E7320_MCH , quirk_pcie_mch);DECLARE_PCI_FIXUP_FINAL (PCI_VENDOR_ID_INTEL ,PCI_DEVICE_ID_INTEL_E7525_MCH , quirk_pcie_mch); -DECLARE_PCI_FIXUP_FINAL (PCI_VENDOR_ID_HUAWEI ,0x1610 , quirk_pcie_mch); +DECLARE_PCI_FIXUP_CLASS_FINAL (PCI_VENDOR_ID_HUAWEI ,0x1610 ,PCI_CLASS_BRIDGE_PCI ,8 , quirk_pcie_mch);/* * It's possible for the MSI to get corrupted if shpc and acpi
Greg Kroah-Hartman
maintainerPATCH 116/163 PCI: iproc: Fix NULL pointer dereference for BCMA
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Ray Jui <[email protected]>
commit 3b65ca50d24ce33cb92d88840e289135c92b40ed upstream.
With the inbound DMA mapping supported added, the iProc PCIe driver parses DT property "dma-ranges" through call to "of_pci_dma_range_parser_init()". In the case of BCMA, this results in a NULL pointer deference due to a missing of_node.
Fix this by adding a guard in pcie-iproc-platform.c to only enable the inbound DMA mapping logic when DT property "dma-ranges" is present.
--- drivers/pci/host/pcie-iproc-platform.c | 7 +++++++ drivers/pci/host/pcie-iproc.c | 8 +++++--- drivers/pci/host/pcie-iproc.h | 2 ++ 3 files changed, 14 insertions(+), 3 deletions(-)
drivers/pci/host/pcie-iproc-platform.c +7 -0
@@ -92,6 +92,13 @@ static int iproc_pcie_pltfm_probe(struct pcie->need_ob_cfg = true; } +/* +* DT nodes are not used by all platforms that use the iProc PCIe +* core driver. For platforms that require explict inbound mapping +* configuration, "dma-ranges" would have been present in DT +*/ + pcie->need_ib_cfg =of_property_read_bool (np,"dma-ranges" ); +/* PHY use is optional */ pcie->phy =devm_phy_get (dev,"pcie-phy" );if (IS_ERR (pcie->phy)) {
drivers/pci/host/pcie-iproc.c +5 -3
@@ -1378,9 +1378,11 @@ int iproc_pcie_setup(struct iproc_pcie * } } - ret =iproc_pcie_map_dma_ranges (pcie); -if (ret && ret != -ENOENT ) - goto err_power_off_phy; +if (pcie->need_ib_cfg) { + ret =iproc_pcie_map_dma_ranges (pcie); +if (ret && ret != -ENOENT ) + goto err_power_off_phy; + }#ifdef CONFIG_ARM pcie->sysdata.private_data = pcie;
drivers/pci/host/pcie-iproc.h +2 -0
@@ -74,6 +74,7 @@ struct iproc_msi;* @ob: outbound mapping related parameters * @ob_map: outbound mapping related parameters specific to the controller * +* @need_ib_cfg: indicates SW needs to configure the inbound mapping window * @ib: inbound mapping related parameters * @ib_map: outbound mapping region related parameters *
@@ -101,6 +102,7 @@ struct iproc_pcie {struct iproc_pcie_ob ob;const struct iproc_pcie_ob_map *ob_map; +bool need_ib_cfg;struct iproc_pcie_ib ib;const struct iproc_pcie_ib_map *ib_map;
Greg Kroah-Hartman
maintainerPATCH 117/163 PCI: pciehp: Assume NoCompl+ for Thunderbolt ports
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Lukas Wunner <[email protected]>
commit 493fb50e958c1c6deef7feff0b8c3855def78d75 upstream.
Certain Thunderbolt 1 controllers claim to support Command Completed events (value of 0b in the No Command Completed Support field of the Slot Capabilities register) but in reality they neither set the Command Completed bit in the Slot Status register nor signal a Command Completed interrupt:
8086:1513 CV82524 [Light Ridge 4C 2010] 8086:151a DSL2310 [Eagle Ridge 2C 2011] 8086:151b CVL2510 [Light Peak 2C 2010] 8086:1547 DSL3510 [Cactus Ridge 4C 2012] 8086:1548 DSL3310 [Cactus Ridge 2C 2012] 8086:1549 DSL2210 [Port Ridge 1C 2011]
All known newer chips (Redwood Ridge and onwards) set No Command Completed Support, indicating that they do not support Command Completed events.
The user-visible impact is that after unplugging such a device, 2 seconds elapse until pciehp is unbound. That's because on ->remove, pcie_write_cmd() is called via pcie_disable_notification() and every call to pcie_write_cmd() takes 2 seconds (1 second for each invocation of pcie_wait_cmd()):
[ 337.942727] pciehp 0000:0a:00.0:pcie204: Timeout on hotplug command 0x1038 (issued 21176 msec ago) [ 340.014735] pciehp 0000:0a:00.0:pcie204: Timeout on hotplug command 0x0000 (issued 2072 msec ago)
That by itself has always been unpleasant, but the situation has become worse with commit cc27b735ad3a ("PCI/portdrv: Turn off PCIe services during shutdown"): Now pciehp is unbound on ->shutdown. Because Thunderbolt controllers typically have 4 hotplug ports, every reboot and shutdown is now delayed by 8 seconds, plus another 2 seconds for every attached Thunderbolt 1 device.
Thunderbolt hotplug slots are not physical slots that one inserts cards into, but rather logical hotplug slots implemented in silicon. Devices appear beyond those logical slots once a PCI tunnel is established on top of the Thunderbolt Converged I/O switch. One would expect commands written to the Slot Control register to be executed immediately by the silicon, so for simplicity we always assume NoCompl+ for Thunderbolt ports.
--- drivers/pci/hotplug/pciehp_hpc.c | 7 +++++++ 1 file changed, 7 insertions(+)
drivers/pci/hotplug/pciehp_hpc.c +7 -0
@@ -848,6 +848,13 @@ struct controller *pcie_init(struct pcieif (pdev->hotplug_user_indicators) slot_cap &= ~(PCI_EXP_SLTCAP_AIP |PCI_EXP_SLTCAP_PIP ); +/* +* We assume no Thunderbolt controllers support Command Complete events, +* but some controllers falsely claim they do. +*/ +if (pdev->is_thunderbolt) + slot_cap |=PCI_EXP_SLTCAP_NCCS ; + ctrl->slot_cap = slot_cap;mutex_init (&ctrl->ctrl_lock);init_waitqueue_head (&ctrl->queue);
Greg Kroah-Hartman
maintainerPATCH 118/163 PCI: keystone: Fix interrupt-controller-node lookup
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Johan Hovold <[email protected]>
commit eac56aa3bc8af3d9b9850345d0f2da9d83529134 upstream.
Fix child-node lookup during initialisation which was using the wrong OF-helper and ended up searching the whole device tree depth-first starting at the parent rather than just matching on its children.
To make things worse, the parent pci node could end up being prematurely freed as of_find_node_by_name() drops a reference to its first argument. Any matching child interrupt-controller node was also leaked.
--- drivers/pci/dwc/pci-keystone.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/pci/dwc/pci-keystone.c +4 -1
@@ -178,7 +178,7 @@ static int ks_pcie_get_irq_controller_in }/* interrupt controller is in a child node */ - *np_temp =of_find_node_by_name (np_pcie, controller); + *np_temp =of_get_child_by_name (np_pcie, controller);if (!(*np_temp)) {dev_err (dev,"Node for %s is absent\n" , controller);return -EINVAL ;
@@ -187,6 +187,7 @@ static int ks_pcie_get_irq_controller_in temp =of_irq_count (*np_temp);if (!temp) {dev_err (dev,"No IRQ entries in %s\n" , controller); +of_node_put (*np_temp);return -EINVAL ; }
@@ -204,6 +205,8 @@ static int ks_pcie_get_irq_controller_inbreak ; } +of_node_put (*np_temp); +if (temp) { *num_irqs = temp;return 0 ;
Greg Kroah-Hartman
maintainerPATCH 119/163 video: fbdev: atmel_lcdfb: fix display-timings lookup
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Johan Hovold <[email protected]>
commit 9cb18db0701f6b74f0c45c23ad767b3ebebe37f6 upstream.
Fix child-node lookup during probe, which ended up searching the whole device tree depth-first starting at the parent rather than just matching on its children.
To make things worse, the parent display node was also prematurely freed.
Note that the display and timings node references are never put after a successful dt-initialisation so the nodes would leak on later probe deferrals and on driver unbind.
--- drivers/video/fbdev/atmel_lcdfb.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
drivers/video/fbdev/atmel_lcdfb.c +7 -1
@@ -1119,7 +1119,7 @@ static int atmel_lcdfb_of_init(struct at goto put_display_node; } - timings_np =of_find_node_by_name (display_np,"display-timings" ); + timings_np =of_get_child_by_name (display_np,"display-timings" );if (!timings_np) {dev_err (dev,"failed to find display-timings node\n" ); ret = -ENODEV ;
@@ -1140,6 +1140,12 @@ static int atmel_lcdfb_of_init(struct atfb_add_videomode (&fb_vm, &info->modelist); } +/* +* FIXME: Make sure we are not referencing any fields in display_np +* and timings_np and drop our references to them before returning to +* avoid leaking the nodes on probe deferral and driver unbind. +*/ +return 0 ; put_timings_node:
Greg Kroah-Hartman
maintainerPATCH 120/163 console/dummy: leave .con_font_get set to NULL
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Nicolas Pitre <[email protected]>
commit 724ba8b30b044aa0d94b1cd374fc15806cdd6f18 upstream.
When this method is set, the caller expects struct console_font fields to be properly initialized when it returns. Leave it unset otherwise nonsensical (leaked kernel stack) values are returned to user space.
--- drivers/video/console/dummycon.c | 1 - 1 file changed, 1 deletion(-)
drivers/video/console/dummycon.c +0 -1
@@ -67,7 +67,6 @@ const struct consw dummy_con = { .con_switch = DUMMY, .con_blank = DUMMY, .con_font_set = DUMMY, - .con_font_get = DUMMY, .con_font_default = DUMMY, .con_font_copy = DUMMY, };
Greg Kroah-Hartman
maintainerPATCH 121/163 rbd: whitelist RBD_FEATURE_OPERATIONS feature bit
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Ilya Dryomov <[email protected]>
commit e573427a440fd67d3f522357d7ac901d59281948 upstream.
This feature bit restricts older clients from performing certain maintenance operations against an image (e.g. clone, snap create). krbd does not perform maintenance operations.
--- drivers/block/rbd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/block/rbd.c +3 -1
@@ -124,11 +124,13 @@ static int atomic_dec_return_safe(atomic#define RBD_FEATURE_STRIPINGV2 (1ULL<<1)#define RBD_FEATURE_EXCLUSIVE_LOCK (1ULL<<2)#define RBD_FEATURE_DATA_POOL (1ULL<<7) +#define RBD_FEATURE_OPERATIONS (1ULL<<8)#define RBD_FEATURES_ALL (RBD_FEATURE_LAYERING | \ RBD_FEATURE_STRIPINGV2 | \ RBD_FEATURE_EXCLUSIVE_LOCK | \ - RBD_FEATURE_DATA_POOL) + RBD_FEATURE_DATA_POOL | \ + RBD_FEATURE_OPERATIONS)/* Features supported by this (client software) implementation. */
Greg Kroah-Hartman
maintainerPATCH 122/163 xen: Fix {set,clear}_foreign_p2m_mapping on autotranslating guests
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Simon Gaiser <[email protected]>
commit 781198f1f373c3e350dbeb3af04a7d4c81c1b8d7 upstream.
Commit 82616f9599a7 ("xen: remove tests for pvh mode in pure pv paths") removed the check for autotranslation from {set,clear}_foreign_p2m_mapping but those are called by grant-table.c also on PVH/HVM guests.
--- arch/x86/xen/p2m.c | 6 ++++++ 1 file changed, 6 insertions(+)
arch/x86/xen/p2m.c +6 -0
@@ -694,6 +694,9 @@ int set_foreign_p2m_mapping(struct gnttaint i, ret =0 ;pte_t *pte; +if (xen_feature (XENFEAT_auto_translated_physmap)) +return 0 ; +if (kmap_ops) { ret =HYPERVISOR_grant_table_op (GNTTABOP_map_grant_ref, kmap_ops, count);
@@ -736,6 +739,9 @@ int clear_foreign_p2m_mapping(struct gnt {int i, ret =0 ; +if (xen_feature (XENFEAT_auto_translated_physmap)) +return 0 ; +for (i =0 ; i < count; i++) {unsigned long mfn =__pfn_to_mfn (page_to_pfn (pages[i]));unsigned long pfn =page_to_pfn (pages[i]);
Greg Kroah-Hartman
maintainerPATCH 123/163 xenbus: track caller request id
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Joao Martins <[email protected]>
commit 29fee6eed2811ff1089b30fc579a2d19d78016ab upstream.
Commit fd8aa9095a95 ("xen: optimize xenbus driver for multiple concurrent xenstore accesses") optimized xenbus concurrent accesses but in doing so broke UABI of /dev/xen/xenbus. Through /dev/xen/xenbus applications are in charge of xenbus message exchange with the correct header and body. Now, after the mentioned commit the replies received by application will no longer have the header req_id echoed back as it was on request (see specification below for reference), because that particular field is being overwritten by kernel.
struct xsd_sockmsg
{
uint32_t type; /* XS_??? */
uint32_t req_id;/* Request identifier, echoed in daemon's response. */ uint32_t tx_id; /* Transaction id (0 if not related to a transaction). */
uint32_t len; /* Length of data following this. */
/* Generally followed by nul-terminated string(s). */
};
Before there was only one request at a time so req_id could simply be forwarded back and forth. To allow simultaneous requests we need a different req_id for each message thus kernel keeps a monotonic increasing counter for this field and is written on every request irrespective of userspace value.
Forwarding again the req_id on userspace requests is not a solution because we would open the possibility of userspace-generated req_id colliding with kernel ones. So this patch instead takes another route which is to artificially keep user req_id while keeping the xenbus logic as is. We do that by saving the original req_id before xs_send(), use the private kernel counter as req_id and then once reply comes and was validated, we restore back the original req_id.
--- drivers/xen/xenbus/xenbus.h | 1 + drivers/xen/xenbus/xenbus_comms.c | 1 + drivers/xen/xenbus/xenbus_xs.c | 3 +++ 3 files changed, 5 insertions(+)
drivers/xen/xenbus/xenbus.h +1 -0
@@ -76,6 +76,7 @@ struct xb_req_data {struct list_head list;wait_queue_head_t wq;struct xsd_sockmsg msg; +uint32_t caller_req_id;enum xsd_sockmsg_type type;char *body;const struct kvec *vec;
drivers/xen/xenbus/xenbus_comms.c +1 -0
@@ -309,6 +309,7 @@ static int process_msg(void) goto out;if (req->state == xb_req_state_wait_reply) { + req->msg.req_id = req->caller_req_id; req->msg.type = state.msg.type; req->msg.len = state.msg.len; req->body = state.body;
drivers/xen/xenbus/xenbus_xs.c +3 -0
@@ -227,6 +227,8 @@ static void xs_send(struct xb_req_data * req->state = xb_req_state_queued;init_waitqueue_head (&req->wq); +/* Save the caller req_id and restore it later in the reply */ + req->caller_req_id = req->msg.req_id; req->msg.req_id =xs_request_enter (req);mutex_lock (&xb_write_mutex);
@@ -310,6 +312,7 @@ static void *xs_talkv(struct xenbus_tran req->num_vecs = num_vecs; req->cb = xs_wake_up; + msg.req_id =0 ; msg.tx_id = t.id; msg.type = type; msg.len =0 ;
Greg Kroah-Hartman
maintainerPATCH 124/163 seq_file: fix incomplete reset on read from zero offset
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Miklos Szeredi <[email protected]>
commit cf5eebae2cd28d37581507668605f4d23cd7218d upstream.
When resetting iterator on a zero offset we need to discard any data already in the buffer (count), and private state of the iterator (version).
For example this bug results in first line being repeated in /proc/mounts if doing a zero size read before a non-zero size read.
--- fs/seq_file.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
fs/seq_file.c +4 -1
@@ -181,8 +181,11 @@ ssize_t seq_read(struct file *file, char* if request is to read from zero offset, reset iterator to first * record as it might have been already advanced by previous requests */ -if (*ppos ==0 ) +if (*ppos ==0 ) { m->index =0 ; + m->version =0 ; + m->count =0 ; + }/* Don't assume *ppos is where we left it */ if (unlikely (*ppos != m->read_pos)) {
Greg Kroah-Hartman
maintainerPATCH 125/163 tracing: Fix parsing of globs with a wildcard at the beginning
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Steven Rostedt (VMware) <[email protected]>
commit 07234021410bbc27b7c86c18de98616c29fbe667 upstream.
Al Viro reported:
For substring - sure, but what about something like "*a*b" and "a*b"? AFAICS, filter_parse_regex() ends up with identical results in both cases - MATCH_GLOB and *search = "a*b". And no way for the caller to tell one from another.
Testing this with the following:
# cd /sys/kernel/tracing # echo '*raw*lock' > set_ftrace_filter bash: echo: write error: Invalid argument
With this patch:
# echo '*raw*lock' > set_ftrace_filter # cat set_ftrace_filter _raw_read_trylock _raw_write_trylock _raw_read_unlock _raw_spin_unlock _raw_write_unlock _raw_spin_trylock _raw_spin_lock _raw_write_lock _raw_read_lock
Al recommended not setting the search buffer to skip the first '*' unless we know we are not using MATCH_GLOB. This implements his suggested logic.
--- kernel/trace/trace_events_filter.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)
kernel/trace/trace_events_filter.c +4 -5
@@ -400,7 +400,6 @@ enum regex_type filter_parse_regex(charfor (i =0 ; i < len; i++) {if (buff[i] =='*' ) {if (!i) { - *search = buff +1 ; type =MATCH_END_ONLY ; }else if (i == len -1 ) {if (type ==MATCH_END_ONLY )
@@ -410,14 +409,14 @@ enum regex_type filter_parse_regex(char buff[i] =0 ;break ; }else {/* pattern continues, use full glob */ - type =MATCH_GLOB ; -break ; +return MATCH_GLOB ; } }else if (strchr ("[?\\" , buff[i])) { - type =MATCH_GLOB ; -break ; +return MATCH_GLOB ; } } +if (buff[0 ] =='*' ) + *search = buff +1 ;return type; }
Greg Kroah-Hartman
maintainerPATCH 126/163 mpls, nospec: Sanitize array index in mpls_label_ok()
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Dan Williams <[email protected]>
commit 3968523f855050b8195134da951b87c20bd66130 upstream.
mpls_label_ok() validates that the 'platform_label' array index from a userspace netlink message payload is valid. Under speculation the mpls_label_ok() result may not resolve in the CPU pipeline until after the index is used to access an array element. Sanitize the index to zero to prevent userspace-controlled arbitrary out-of-bounds speculation, a precursor for a speculative execution side channel vulnerability.
--- net/mpls/af_mpls.c | 24 ++++++++++++++---------- 1 file changed, 14 insertions(+), 10 deletions(-)
net/mpls/af_mpls.c +14 -10
@@ -8,6 +8,7 @@#include <linux/ipv6.h> #include <linux/mpls.h> #include <linux/netconf.h> +#include <linux/nospec.h> #include <linux/vmalloc.h> #include <linux/percpu.h> #include <net/ip.h>
@@ -935,24 +936,27 @@ errout:return err; } -static bool mpls_label_ok (struct net *net,unsigned int index, +static bool mpls_label_ok (struct net *net,unsigned int *index,struct netlink_ext_ack *extack) { +bool is_ok = true; +/* Reserved labels may not be set */ -if (index <MPLS_LABEL_FIRST_UNRESERVED ) { +if (*index <MPLS_LABEL_FIRST_UNRESERVED ) {NL_SET_ERR_MSG (extack,"Invalid label - must be MPLS_LABEL_FIRST_UNRESERVED or higher" ); -return false; + is_ok = false; }/* The full 20 bit range may not be supported. */ -if (index >= net->mpls.platform_labels) { +if (is_ok && *index >= net->mpls.platform_labels) {NL_SET_ERR_MSG (extack,"Label >= configured maximum in platform_labels" ); -return false; + is_ok = false; } -return true; + *index =array_index_nospec (*index, net->mpls.platform_labels); +return is_ok; } static int mpls_route_add(struct mpls_route_config *cfg,
@@ -975,7 +979,7 @@ static int mpls_route_add(struct mpls_ro index =find_free_label (net); } -if (!mpls_label_ok (net, index, extack)) +if (!mpls_label_ok (net, &index, extack)) goto errout;/* Append makes no sense with mpls */
@@ -1052,7 +1056,7 @@ static int mpls_route_del(struct mpls_ro index = cfg->rc_label; -if (!mpls_label_ok (net, index, extack)) +if (!mpls_label_ok (net, &index, extack)) goto errout;mpls_route_update (net, index,NULL , &cfg->rc_nlinfo);
@@ -1810,7 +1814,7 @@ static int rtm_to_route_config(struct sk goto errout;if (!mpls_label_ok (cfg->rc_nlinfo.nl_net, - cfg->rc_label, extack)) + &cfg->rc_label, extack)) goto errout;break ; }
@@ -2137,7 +2141,7 @@ static int mpls_getroute(struct sk_buff goto errout; } -if (!mpls_label_ok (net, in_label, extack)) { +if (!mpls_label_ok (net, &in_label, extack)) { err = -EINVAL ; goto errout; }
Greg Kroah-Hartman
maintainerPATCH 127/163 rtlwifi: rtl8821ae: Fix connection lost problem correctly
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Larry Finger <[email protected]>
commit c713fb071edc0efc01a955f65a006b0e1795d2eb upstream.
There has been a coding error in rtl8821ae since it was first introduced, namely that an 8-bit register was read using a 16-bit read in _rtl8821ae_dbi_read(). This error was fixed with commit 40b368af4b75 ("rtlwifi: Fix alignment issues"); however, this change led to instability in the connection. To restore stability, this change was reverted in commit b8b8b16352cd ("rtlwifi: rtl8821ae: Fix connection lost problem").
Unfortunately, the unaligned access causes machine checks in ARM architecture, and we were finally forced to find the actual cause of the problem on x86 platforms. Following a suggestion from Pkshih <[email protected]>, it was found that increasing the ASPM L1 latency from 0 to 7 fixed the instability. This parameter was varied to see if a smaller value would work; however, it appears that 7 is the safest value. A new symbol is defined for this quantity, thus it can be easily changed if necessary.
--- drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c | 5 +++-- drivers/net/wireless/realtek/rtlwifi/wifi.h | 1 + 2 files changed, 4 insertions(+), 2 deletions(-)
drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c +3 -2
@@ -1123,7 +1123,7 @@ static u8 _rtl8821ae_dbi_read(struct rtl }if (0 == tmp) { read_addr =REG_DBI_RDATA + addr %4 ; - ret =rtl_read_word (rtlpriv, read_addr); + ret =rtl_read_byte (rtlpriv, read_addr); }return ret; }
@@ -1165,7 +1165,8 @@ static void _rtl8821ae_enable_aspm_back_ } tmp =_rtl8821ae_dbi_read (rtlpriv,0x70f ); -_rtl8821ae_dbi_write (rtlpriv,0x70f , tmp |BIT (7 )); +_rtl8821ae_dbi_write (rtlpriv,0x70f , tmp |BIT (7 ) | +ASPM_L1_LATENCY <<3 ); tmp =_rtl8821ae_dbi_read (rtlpriv,0x719 );_rtl8821ae_dbi_write (rtlpriv,0x719 , tmp |BIT (3 ) |BIT (4 ));
drivers/net/wireless/realtek/rtlwifi/wifi.h +1 -0
@@ -99,6 +99,7 @@#define RTL_USB_MAX_RX_COUNT 100#define QBSS_LOAD_SIZE 5#define MAX_WMMELE_LENGTH 64 +#define ASPM_L1_LATENCY 7#define TOTAL_CAM_ENTRY 32
Greg Kroah-Hartman
maintainerPATCH 128/163 arm64: proc: Set PTE_NG for table entries to avoid traversing them twice
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Will Deacon <[email protected]>
commit 2ce77f6d8a9ae9ce6d80397d88bdceb84a2004cd upstream.
When KASAN is enabled, the swapper page table contains many identical mappings of the zero page, which can lead to a stall during boot whilst the G -> nG code continually walks the same page table entries looking for global mappings.
This patch sets the nG bit (bit 11, which is IGNORED) in table entries after processing the subtree so we can easily skip them if we see them a second time.
--- arch/arm64/mm/proc.S | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-)
arch/arm64/mm/proc.S +9 -5
@@ -189,7 +189,8 @@ ENDPROC(idmap_cpu_replace_ttbr1) dc cvac, cur_\()\type\()p // Ensure any existing dirty dmb sy // lines are written back before ldr \type, [cur_\()\type\()p] // loading the entry - tbz \type, #0, next_\()\type // Skip invalid entries + tbz \type, #0, skip_\()\type // Skip invalid and + tbnz \type, #11, skip_\()\type // non-global entries .endm .macro __idmap_kpti_put_pgtable_ent_ng, type
@@ -249,8 +250,9 @@ ENTRY(idmap_kpti_install_ng_mappings) add end_pgdp, cur_pgdp, #(PTRS_PER_PGD * 8) do_pgd: __idmap_kpti_get_pgtable_ent pgd tbnz pgd, #1, walk_puds - __idmap_kpti_put_pgtable_ent_ng pgd next_pgd: + __idmap_kpti_put_pgtable_ent_ng pgd +skip_pgd: add cur_pgdp, cur_pgdp, #8 cmp cur_pgdp, end_pgdp b.ne do_pgd
@@ -278,8 +280,9 @@ walk_puds: add end_pudp, cur_pudp, #(PTRS_PER_PUD * 8) do_pud: __idmap_kpti_get_pgtable_ent pud tbnz pud, #1, walk_pmds - __idmap_kpti_put_pgtable_ent_ng pud next_pud: + __idmap_kpti_put_pgtable_ent_ng pud +skip_pud: add cur_pudp, cur_pudp, 8 cmp cur_pudp, end_pudp b.ne do_pud
@@ -298,8 +301,9 @@ walk_pmds: add end_pmdp, cur_pmdp, #(PTRS_PER_PMD * 8) do_pmd: __idmap_kpti_get_pgtable_ent pmd tbnz pmd, #1, walk_ptes - __idmap_kpti_put_pgtable_ent_ng pmd next_pmd: + __idmap_kpti_put_pgtable_ent_ng pmd +skip_pmd: add cur_pmdp, cur_pmdp, #8 cmp cur_pmdp, end_pmdp b.ne do_pmd
@@ -317,7 +321,7 @@ walk_ptes: add end_ptep, cur_ptep, #(PTRS_PER_PTE * 8) do_pte: __idmap_kpti_get_pgtable_ent pte __idmap_kpti_put_pgtable_ent_ng pte -next_pte: +skip_pte: add cur_ptep, cur_ptep, #8 cmp cur_ptep, end_ptep b.ne do_pte
Greg Kroah-Hartman
maintainerPATCH 129/163 xprtrdma: Fix calculation of ri_max_send_sges
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Chuck Lever <[email protected]>
commit 1179e2c27efe21167ec9d882b14becefba2ee990 upstream.
Commit 16f906d66cd7 ("xprtrdma: Reduce required number of send SGEs") introduced the rpcrdma_ia::ri_max_send_sges field. This fixes a problem where xprtrdma would not work if the device's max_sge capability was small (low single digits).
At least RPCRDMA_MIN_SEND_SGES are needed for the inline parts of each RPC. ri_max_send_sges is set to this value:
ia->ri_max_send_sges = max_sge - RPCRDMA_MIN_SEND_SGES;
Then when marshaling each RPC, rpcrdma_args_inline uses that value to determine whether the device has enough Send SGEs to convey an NFS WRITE payload inline, or whether instead a Read chunk is required.
More recently, commit ae72950abf99 ("xprtrdma: Add data structure to manage RDMA Send arguments") used the ri_max_send_sges value to calculate the size of an array, but that commit erroneously assumed ri_max_send_sges contains a value similar to the device's max_sge, and not one that was reduced by the minimum SGE count.
This assumption results in the calculated size of the sendctx's Send SGE array to be too small. When the array is used to marshal an RPC, the code can write Send SGEs into the following sendctx element in that array, corrupting it. When the device's max_sge is large, this issue is entirely harmless; but it results in an oops in the provider's post_send method, if dev.attrs.max_sge is small.
So let's straighten this out: ri_max_send_sges will now contain a value with the same meaning as dev.attrs.max_sge, which makes the code easier to understand, and enables rpcrdma_sendctx_create to calculate the size of the SGE array correctly.
--- net/sunrpc/xprtrdma/rpc_rdma.c | 2 +- net/sunrpc/xprtrdma/verbs.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
net/sunrpc/xprtrdma/rpc_rdma.c +1 -1
@@ -143,7 +143,7 @@ static bool rpcrdma_args_inline(struct rif (xdr->page_len) { remaining = xdr->page_len; offset =offset_in_page (xdr->page_base); - count =0 ; + count =RPCRDMA_MIN_SEND_SGES ;while (remaining) { remaining -= min_t(unsigned int,PAGE_SIZE - offset, remaining);
net/sunrpc/xprtrdma/verbs.c +1 -1
@@ -509,7 +509,7 @@ rpcrdma_ep_create(struct rpcrdma_ep *ep,pr_warn ("rpcrdma: HCA provides only %d send SGEs\n" , max_sge);return -ENOMEM ; } - ia->ri_max_send_sges = max_sge -RPCRDMA_MIN_SEND_SGES ; + ia->ri_max_send_sges = max_sge;if (ia->ri_device->attrs.max_qp_wr <=RPCRDMA_BACKWARD_WRS ) { dprintk("RPC: %s: insufficient wqe's available\n",
Greg Kroah-Hartman
maintainerPATCH 130/163 xprtrdma: Fix BUG after a device removal
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Chuck Lever <[email protected]>
commit e89e8d8fcdc6751e86ccad794b052fe67e6ad619 upstream.
Michal Kalderon reports a BUG that occurs just after device removal:
[ 169.112490] rpcrdma: removing device qedr0 for 192.168.110.146:20049 [ 169.143909] BUG: unable to handle kernel NULL pointer dereference at 0000000000000010 [ 169.181837] IP: rpcrdma_dma_unmap_regbuf+0xa/0x60 [rpcrdma]
The RPC/RDMA client transport attempts to allocate some resources on demand. Registered buffers are one such resource. These are allocated (or re-allocated) by xprt_rdma_allocate to hold RPC Call and Reply messages. A hardware resource is associated with each of these buffers, as they can be used for a Send or Receive Work Request.
If a device is removed from under an NFS/RDMA mount, the transport layer is responsible for releasing all hardware resources before the device can be finally unplugged. A BUG results when the NFS mount hasn't yet seen much activity: the transport tries to release resources that haven't yet been allocated.
rpcrdma_free_regbuf() already checks for this case, so just move that check to cover the DEVICE_REMOVAL case as well.
--- net/sunrpc/xprtrdma/verbs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
net/sunrpc/xprtrdma/verbs.c +3 -3
@@ -1476,6 +1476,9 @@ __rpcrdma_dma_map_regbuf(struct rpcrdma_static void rpcrdma_dma_unmap_regbuf (struct rpcrdma_regbuf *rb) { +if (!rb) +return ; +if (!rpcrdma_regbuf_is_mapped (rb))return ;
@@ -1491,9 +1494,6 @@ rpcrdma_dma_unmap_regbuf(struct rpcrdma_void rpcrdma_free_regbuf (struct rpcrdma_regbuf *rb) { -if (!rb) -return ; -rpcrdma_dma_unmap_regbuf (rb);kfree (rb); }
Greg Kroah-Hartman
maintainerPATCH 131/163 blk-wbt: account flush requests correctly
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Jens Axboe <[email protected]>
commit 5235553d821433e1f4fa720fd025d2c4b7ee9994 upstream.
Mikulas reported a workload that saw bad performance, and figured out what it was due to various other types of requests being accounted as reads. Flush requests, for instance. Due to the high latency of those, we heavily throttle the writes to keep the latencies in balance. But they really should be accounted as writes.
Fix this by checking the exact type of the request. If it's a read, account as a read, if it's a write or a flush, account as a write. Any other request we disregard. Previously everything would have been mistakenly accounted as reads.
--- block/blk-wbt.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)
block/blk-wbt.c +9 -1
@@ -697,7 +697,15 @@ u64 wbt_default_latency_nsec(struct requstatic int wbt_data_dir (const struct request *rq) { -return rq_data_dir (rq); +const int op =req_op (rq); + +if (op ==REQ_OP_READ ) +return READ ; +else if (op ==REQ_OP_WRITE || op ==REQ_OP_FLUSH ) +return WRITE ; + +/* don't account */ +return -1 ; }int wbt_init (struct request_queue *q)
Greg Kroah-Hartman
maintainerPATCH 132/163 target/iscsi: avoid NULL dereference in CHAP auth error path
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: David Disseldorp <[email protected]>
commit ce512d79d0466a604793addb6b769d12ee326822 upstream.
If chap_server_compute_md5() fails early, e.g. via CHAP_N mismatch, then crypto_free_shash() is called with a NULL pointer which gets dereferenced in crypto_shash_tfm().
--- drivers/target/iscsi/iscsi_target_auth.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/target/iscsi/iscsi_target_auth.c +2 -1
@@ -421,7 +421,8 @@ static int chap_server_compute_md5( auth_ret =0 ; out:kzfree (desc); -crypto_free_shash (tfm); +if (tfm) +crypto_free_shash (tfm);kfree (challenge);kfree (challenge_binhex);return auth_ret;
Greg Kroah-Hartman
maintainerPATCH 133/163 iscsi-target: make sure to wake up sleeping login worker
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Florian Westphal <[email protected]>
commit 1c130ae00b769a2e2df41bad3d6051ee8234b636 upstream.
Mike Christie reports:
Starting in 4.14 iscsi logins will fail around 50% of the time.
Problem appears to be that iscsi_target_sk_data_ready() callback may return without doing anything in case it finds the login work queue is still blocked in sock_recvmsg().
Nicholas Bellinger says:
It would indicate users providing their own ->sk_data_ready() callback must be responsible for waking up a kthread context blocked on sock_recvmsg(..., MSG_WAITALL), when a second ->sk_data_ready() is received before the first sock_recvmsg(..., MSG_WAITALL) completes.
So, do this and invoke the original data_ready() callback -- in case of tcp sockets this takes care of waking the thread.
Disclaimer: I do not understand why this problem did not show up before tcp prequeue removal.
(Drop WARN_ON usage - nab)
--- drivers/target/iscsi/iscsi_target_nego.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/target/iscsi/iscsi_target_nego.c +3 -0
@@ -432,6 +432,9 @@ static void iscsi_target_sk_data_ready(sif (test_and_set_bit (LOGIN_FLAGS_READ_ACTIVE , &conn->login_flags)) {write_unlock_bh (&sk->sk_callback_lock);pr_debug ("Got LOGIN_FLAGS_READ_ACTIVE=1, conn: %p >>>>\n" , conn); +if (iscsi_target_sk_data_ready == conn->orig_data_ready) +return ; + conn->orig_data_ready (sk);return ; }
Greg Kroah-Hartman
maintainerPATCH 134/163 dm: correctly handle chained bios in dec_pending()
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: NeilBrown <[email protected]>
commit 8dd601fa8317243be887458c49f6c29c2f3d719f upstream.
dec_pending() is given an error status (possibly 0) to be recorded against a bio. It can be called several times on the one 'struct dm_io', and it is careful to only assign a non-zero error to io->status. However when it then assigned io->status to bio->bi_status, it is not careful and could overwrite a genuine error status with 0.
This can happen when chained bios are in use. If a bio is chained beneath the bio that this dm_io is handling, the child bio might complete and set bio->bi_status before the dm_io completes.
This has been possible since chained bios were introduced in 3.14, and has become a lot easier to trigger with commit 18a25da84354 ("dm: ensure bio submission follows a depth-first tree walk") as that commit caused dm to start using chained bios itself.
A particular failure mode is that if a bio spans an 'error' target and a working target, the 'error' fragment will complete instantly and set the ->bi_status, and the other fragment will normally complete a little later, and will clear ->bi_status.
The fix is simply to only assign io_error to bio->bi_status when io_error is not zero.
--- drivers/md/dm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/md/dm.c +2 -1
@@ -817,7 +817,8 @@ static void dec_pending(struct dm_io *ioqueue_io (md, bio); }else {/* done with normal IO or empty flush */ - bio->bi_status = io_error; +if (io_error) + bio->bi_status = io_error;bio_endio (bio); } }
Greg Kroah-Hartman
maintainerPATCH 135/163 Btrfs: fix deadlock in run_delalloc_nocow
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Liu Bo <[email protected]>
commit e89166990f11c3f21e1649d760dd35f9e410321c upstream.
@cur_offset is not set back to what it should be (@cow_start) if btrfs_next_leaf() returns something wrong, and the range [cow_start, cur_offset) remains locked forever.
--- fs/btrfs/inode.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
fs/btrfs/inode.c +4 -1
@@ -1330,8 +1330,11 @@ next_slot: leaf = path->nodes[0 ];if (path->slots[0 ] >=btrfs_header_nritems (leaf)) { ret =btrfs_next_leaf (root, path); -if (ret <0 ) +if (ret <0 ) { +if (cow_start != (u64)-1 ) + cur_offset = cow_start; goto error; + }if (ret >0 )break ; leaf = path->nodes[0 ];
Greg Kroah-Hartman
maintainerPATCH 136/163 Btrfs: fix crash due to not cleaning up tree log blocks dirty bits
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Liu Bo <[email protected]>
commit 1846430c24d66e85cc58286b3319c82cd54debb2 upstream.
In cases that the whole fs flips into readonly status due to failures in critical sections, then log tree's blocks are still dirty, and this leads to a crash during umount time, the crash is about use-after-free,
umount
-> close_ctree
-> stop workers
-> iput(btree_inode)
-> iput_final
-> write_inode_now
-> ...
-> queue job on stop'd workers--- fs/btrfs/tree-log.c | 9 +++++++++ 1 file changed, 9 insertions(+)
fs/btrfs/tree-log.c +9 -0
@@ -2494,6 +2494,9 @@ static noinline int walk_down_log_tree(sclean_tree_block (fs_info, next);btrfs_wait_tree_block_writeback (next);btrfs_tree_unlock (next); + }else { +if (test_and_clear_bit (EXTENT_BUFFER_DIRTY , &next->bflags)) +clear_extent_buffer_dirty (next); } WARN_ON(root_owner !=
@@ -2574,6 +2577,9 @@ static noinline int walk_up_log_tree(strclean_tree_block (fs_info, next);btrfs_wait_tree_block_writeback (next);btrfs_tree_unlock (next); + }else { +if (test_and_clear_bit (EXTENT_BUFFER_DIRTY , &next->bflags)) +clear_extent_buffer_dirty (next); }WARN_ON (root_owner !=BTRFS_TREE_LOG_OBJECTID );
@@ -2652,6 +2658,9 @@ static int walk_log_tree(struct btrfs_trclean_tree_block (fs_info, next);btrfs_wait_tree_block_writeback (next);btrfs_tree_unlock (next); + }else { +if (test_and_clear_bit (EXTENT_BUFFER_DIRTY , &next->bflags)) +clear_extent_buffer_dirty (next); } WARN_ON(log->root_key.objectid !=
Greg Kroah-Hartman
maintainerPATCH 137/163 Btrfs: fix extent state leak from tree log
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Liu Bo <[email protected]>
commit 55237a5f2431a72435e3ed39e4306e973c0446b7 upstream.
It's possible that btrfs_sync_log() bails out after one of the two btrfs_write_marked_extents() which convert extent state's state bit into EXTENT_NEED_WAIT from EXTENT_DIRTY/EXTENT_NEW, however only EXTENT_DIRTY and EXTENT_NEW are searched by free_log_tree() so that those extent states with EXTENT_NEED_WAIT lead to memory leak.
--- fs/btrfs/tree-log.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
fs/btrfs/tree-log.c +3 -2
@@ -3049,13 +3049,14 @@ static void free_log_tree(struct btrfs_twhile (1 ) { ret =find_first_extent_bit (&log->dirty_log_pages, -0 , &start, &end,EXTENT_DIRTY |EXTENT_NEW , +0 , &start, &end, +EXTENT_DIRTY |EXTENT_NEW |EXTENT_NEED_WAIT ,NULL );if (ret)break ;clear_extent_bits (&log->dirty_log_pages, start, end, -EXTENT_DIRTY |EXTENT_NEW ); +EXTENT_DIRTY |EXTENT_NEW |EXTENT_NEED_WAIT ); }/*
Greg Kroah-Hartman
maintainerPATCH 138/163 Btrfs: fix btrfs_evict_inode to handle abnormal inodes correctly
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Liu Bo <[email protected]>
commit e8f1bc1493855e32b7a2a019decc3c353d94daf6 upstream.
This regression is introduced in
commit 3d48d9810de4 ("btrfs: Handle uninitialised inode eviction").
There are two problems,
a) it is ->destroy_inode() that does the final free on inode, not ->evict_inode(),
b) clear_inode() must be called before ->evict_inode() returns.
This could end up hitting BUG_ON(inode->i_state != (I_FREEING | I_CLEAR)); in evict() because I_CLEAR is set in clear_inode().
--- fs/btrfs/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/btrfs/inode.c +1 -1
@@ -5266,7 +5266,7 @@ void btrfs_evict_inode(struct inode *inotrace_btrfs_inode_evict (inode);if (!root) { -kmem_cache_free (btrfs_inode_cachep,BTRFS_I (inode)); +clear_inode (inode);return ; }
Greg Kroah-Hartman
maintainerPATCH 139/163 Btrfs: fix use-after-free on root->orphan_block_rsv
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Liu Bo <[email protected]>
commit 1a932ef4e47984dee227834667b5ff5a334e4805 upstream.
I got these from running generic/475,
WARNING: CPU: 0 PID: 26384 at fs/btrfs/inode.c:3326 btrfs_orphan_commit_root+0x1ac/0x2b0 [btrfs] BUG: unable to handle kernel NULL pointer dereference at 0000000000000010 IP: btrfs_block_rsv_release+0x1c/0x70 [btrfs] Call Trace: btrfs_orphan_release_metadata+0x9f/0x200 [btrfs] btrfs_orphan_del+0x10d/0x170 [btrfs] btrfs_setattr+0x500/0x640 [btrfs] notify_change+0x7ae/0x870 do_truncate+0xca/0x130 vfs_truncate+0x2ee/0x3d0 do_sys_truncate+0xaf/0xf0 SyS_truncate+0xe/0x10 entry_SYSCALL_64_fastpath+0x1f/0x96
The race is between btrfs_orphan_commit_root and btrfs_orphan_del,
t1 t2btrfs_orphan_commit_root btrfs_orphan_del
spin_lock
check (&root->orphan_inodes)
root->orphan_block_rsv = NULL;
spin_unlock
atomic_dec(&root->orphan_inodes);
access root->orphan_block_rsvAccessing root->orphan_block_rsv must be done before decreasing root->orphan_inodes.
--- fs/btrfs/inode.c | 34 +++++++++++++++++++++------------- 1 file changed, 21 insertions(+), 13 deletions(-)
fs/btrfs/inode.c +21 -13
@@ -3369,6 +3369,11 @@ int btrfs_orphan_add(struct btrfs_trans_ ret =btrfs_orphan_reserve_metadata (trans, inode);ASSERT (!ret);if (ret) { +/* +* dec doesn't need spin_lock as ->orphan_block_rsv +* would be released only if ->orphan_inodes is +* zero. +*/ atomic_dec (&root->orphan_inodes);clear_bit (BTRFS_INODE_ORPHAN_META_RESERVED , &inode->runtime_flags);
@@ -3383,12 +3388,17 @@ int btrfs_orphan_add(struct btrfs_trans_if (insert >=1 ) { ret =btrfs_insert_orphan_item (trans, root,btrfs_ino (inode));if (ret) { -atomic_dec (&root->orphan_inodes);if (reserve) {clear_bit (BTRFS_INODE_ORPHAN_META_RESERVED , &inode->runtime_flags);btrfs_orphan_release_metadata (inode); } +/* +* btrfs_orphan_commit_root may race with us and set +* ->orphan_block_rsv to zero, in order to avoid that, +* decrease ->orphan_inodes after everything is done. +*/ +atomic_dec (&root->orphan_inodes);if (ret != -EEXIST ) {clear_bit (BTRFS_INODE_HAS_ORPHAN_ITEM , &inode->runtime_flags);
@@ -3420,28 +3430,26 @@ static int btrfs_orphan_del(struct btrfs {struct btrfs_root *root = inode->root;int delete_item =0 ; -int release_rsv =0 ;int ret =0 ; -spin_lock (&root->orphan_lock);if (test_and_clear_bit (BTRFS_INODE_HAS_ORPHAN_ITEM , &inode->runtime_flags)) delete_item =1 ; +if (delete_item && trans) + ret =btrfs_del_orphan_item (trans, root,btrfs_ino (inode)); +if (test_and_clear_bit (BTRFS_INODE_ORPHAN_META_RESERVED , &inode->runtime_flags)) - release_rsv =1 ; -spin_unlock (&root->orphan_lock); +btrfs_orphan_release_metadata (inode); -if (delete_item) { +/* +* btrfs_orphan_commit_root may race with us and set ->orphan_block_rsv +* to zero, in order to avoid that, decrease ->orphan_inodes after +* everything is done. +*/ +if (delete_item)atomic_dec (&root->orphan_inodes); -if (trans) - ret =btrfs_del_orphan_item (trans, root, -btrfs_ino (inode)); - } - -if (release_rsv) -btrfs_orphan_release_metadata (inode);return ret; }
Greg Kroah-Hartman
maintainerPATCH 140/163 Btrfs: fix unexpected -EEXIST when creating new inode
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Liu Bo <[email protected]>
commit 900c9981680067573671ecc5cbfa7c5770be3a40 upstream.
The highest objectid, which is assigned to new inode, is decided at the time of initializing fs roots. However, in cases where log replay gets processed, the btree which fs root owns might be changed, so we have to search it again for the highest objectid, otherwise creating new inode would end up with -EEXIST.
--- fs/btrfs/tree-log.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)
fs/btrfs/tree-log.c +18 -0
@@ -28,6 +28,7 @@#include "hash.h" #include "compression.h" #include "qgroup.h" +#include "inode-map.h" /* magic values for the inode_only field in btrfs_log_inode: *
@@ -5715,6 +5716,23 @@ again: path); } +if (!ret && wc.stage ==LOG_WALK_REPLAY_ALL ) { +struct btrfs_root *root = wc.replay_dest; + +btrfs_release_path (path); + +/* +* We have just replayed everything, and the highest +* objectid of fs roots probably has changed in case +* some inode_item's got replayed. +* +* root->objectid_mutex is not acquired as log replay +* could only happen during mount. +*/ + ret =btrfs_find_highest_objectid (root, + &root->highest_objectid); + } + key.offset = found_key.offset -1 ; wc.replay_dest->log_root =NULL ;free_extent_buffer (log->node);
Greg Kroah-Hartman
maintainerPATCH 141/163 9p/trans_virtio: discard zero-length reply
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Greg Kurz <[email protected]>
commit 26d99834f89e76514076d9cd06f61e56e6a509b8 upstream.
When a 9p request is successfully flushed, the server is expected to just mark it as used without sending a 9p reply (ie, without writing data into the buffer). In this case, virtqueue_get_buf() will return len == 0 and we must not report a REQ_STATUS_RCVD status to the client, otherwise the client will erroneously assume the request has not been flushed.
--- net/9p/trans_virtio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
net/9p/trans_virtio.c +2 -1
@@ -160,7 +160,8 @@ static void req_done(struct virtqueue *vspin_unlock_irqrestore (&chan->lock, flags);/* Wakeup if anyone waiting for VirtIO ring space. */ wake_up (chan->vc_wq); -p9_client_cb (chan->client, req,REQ_STATUS_RCVD ); +if (len) +p9_client_cb (chan->client, req,REQ_STATUS_RCVD ); } }
Greg Kroah-Hartman
maintainerPATCH 142/163 mtd: nand: vf610: set correct ooblayout
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Stefan Agner <[email protected]>
commit ea56fb282368ea08c2a313af6b55cb597aec4db1 upstream.
With commit 3cf32d180227 ("mtd: nand: vf610: switch to mtd_ooblayout_ops") the driver started to use the NAND cores default large page ooblayout. However, shortly after commit 6a623e076944 ("mtd: nand: add ooblayout for old hamming layout") changed the default layout to the old hamming layout, which is not what vf610_nfc is using. Specify the default large page layout explicitly.
--- drivers/mtd/nand/vf610_nfc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/mtd/nand/vf610_nfc.c +2 -4
@@ -752,10 +752,8 @@ static int vf610_nfc_probe(struct platfoif (mtd->oobsize >64 ) mtd->oobsize =64 ; -/* -* mtd->ecclayout is not specified here because we're using the -* default large page ECC layout defined in NAND core. -*/ +/* Use default large page ECC layout defined in NAND core */ +mtd_set_ooblayout (mtd, &nand_ooblayout_lp_ops);if (chip->ecc.strength ==32 ) { nfc->ecc_mode =ECC_60_BYTE ; chip->ecc.bytes =60 ;
Greg Kroah-Hartman
maintainerPATCH 143/163 ALSA: hda - Fix headset mic detection problem for two Dell machines
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Hui Wang <[email protected]>
commit 3f2f7c553d077be6a30cb96b2976a2c940bf5335 upstream.
One of them has the codec of alc256 and the other one has the codec of alc289.
--- sound/pci/hda/patch_realtek.c | 9 +++++++++ 1 file changed, 9 insertions(+)
sound/pci/hda/patch_realtek.c +9 -0
@@ -6613,6 +6613,11 @@ static const struct snd_hda_pin_quirk al {0x14, 0x90170110}, {0x21, 0x02211020}), SND_HDA_PIN_QUIRK(0x10ec0256, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE, + {0x12, 0x90a60130}, + {0x14, 0x90170110}, + {0x14, 0x01011020}, + {0x21, 0x0221101f}), + SND_HDA_PIN_QUIRK(0x10ec0256, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE, ALC256_STANDARD_PINS), SND_HDA_PIN_QUIRK(0x10ec0256, 0x1043, "ASUS", ALC256_FIXUP_ASUS_MIC, {0x14, 0x90170110},
@@ -6681,6 +6686,10 @@ static const struct snd_hda_pin_quirk al {0x12, 0x90a60120}, {0x14, 0x90170110}, {0x21, 0x0321101f}), + SND_HDA_PIN_QUIRK(0x10ec0289, 0x1028, "Dell", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE, + {0x12, 0xb7a60130}, + {0x14, 0x90170110}, + {0x21, 0x04211020}), SND_HDA_PIN_QUIRK(0x10ec0290, 0x103c, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1, ALC290_STANDARD_PINS, {0x15, 0x04211040},
Greg Kroah-Hartman
maintainerPATCH 144/163 ALSA: usb-audio: Fix UAC2 get_ctl request with a RANGE attribute
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Kirill Marinushkin <[email protected]>
commit 447cae58cecd69392b74a4a42cd0ab9cabd816af upstream.
The layout of the UAC2 Control request and response varies depending on the request type. With the current implementation, only the Layout 2 Parameter Block (with the 2-byte sized RANGE attribute) is handled properly. For the Control requests with the 1-byte sized RANGE attribute (Bass Control, Mid Control, Tremble Control), the response is parsed incorrectly.
This commit:
* fixes the wLength field value in the request
* fixes parsing the range values from the response
--- sound/usb/mixer.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-)
sound/usb/mixer.c +11 -7
@@ -347,17 +347,20 @@ static int get_ctl_value_v2(struct usb_m int validx, int *value_ret) { struct snd_usb_audio *chip = cval->head.mixer->chip; -unsigned char buf[4 +3 *sizeof (__u32)];/* enough space for one range */ +/* enough space for one range */ +unsigned char buf[sizeof (__u16) +3 *sizeof (__u32)];unsigned char *val; -int idx =0 , ret, size; +int idx =0 , ret, val_size, size;__u8 bRequest; + val_size =uac2_ctl_value_size (cval->val_type); +if (request ==UAC_GET_CUR ) { bRequest =UAC2_CS_CUR ; - size =uac2_ctl_value_size (cval->val_type); + size = val_size; }else { bRequest =UAC2_CS_RANGE ; - size =sizeof (buf); + size =sizeof (__u16) +3 * val_size; }memset (buf,0 ,sizeof (buf));
@@ -390,16 +393,17 @@ error: val = buf +sizeof (__u16);break ;case UAC_GET_MAX : - val = buf +sizeof (__u16) *2 ; + val = buf +sizeof (__u16) + val_size;break ;case UAC_GET_RES : - val = buf +sizeof (__u16) *3 ; + val = buf +sizeof (__u16) + val_size *2 ;break ;default :return -EINVAL ; } - *value_ret =convert_signed_value (cval,snd_usb_combine_bytes (val,sizeof (__u16))); + *value_ret =convert_signed_value (cval, +snd_usb_combine_bytes (val, val_size));return 0 ; }
Greg Kroah-Hartman
maintainerPATCH 145/163 ALSA: hda/realtek - Add headset mode support for Dell laptop
In reply to Greg Kroah-Hartman4.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Kailang Yang <[email protected]>
commit 40e2c4e5a7efcd50983aacbddd3c617e776018bf upstream.
This platform had two Dmic and single Dmic.
This update was for single Dmic.
This commit was for two Dmic.
--- sound/pci/hda/patch_realtek.c | 2 ++ 1 file changed, 2 insertions(+)
sound/pci/hda/patch_realtek.c +2 -0
@@ -6199,6 +6199,8 @@ static const struct snd_pci_quirk alc269SND_PCI_QUIRK (0x1028 ,0x075d ,"Dell AIO" ,ALC298_FIXUP_SPK_VOLUME ),SND_PCI_QUIRK (0x1028 ,0x0798 ,"Dell Inspiron 17 7000 Gaming" ,ALC256_FIXUP_DELL_INSPIRON_7559_SUBWOOFER ),SND_PCI_QUIRK (0x1028 ,0x082a ,"Dell XPS 13 9360" ,ALC256_FIXUP_DELL_XPS_13_HEADPHONE_NOISE ), +SND_PCI_QUIRK (0x1028 ,0x084b ,"Dell" ,ALC274_FIXUP_DELL_AIO_LINEOUT_VERB ), +SND_PCI_QUIRK (0x1028 ,0x084e ,"Dell" ,ALC274_FIXUP_DELL_AIO_LINEOUT_VERB ),SND_PCI_QUIRK (0x1028 ,0x164a ,"Dell" ,ALC293_FIXUP_DELL1_MIC_NO_PRESENCE ),SND_PCI_QUIRK (0x1028 ,0x164b ,"Dell" ,ALC293_FIXUP_DELL1_MIC_NO_PRESENCE ), SND_PCI_QUIRK(0x103c, 0x1586, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC2),