Skip to contentSkip to conversation

gfs2: Fsync parent directories

PATCH New Andreas Gruenbacher 4 participants 7 messages Feb 19, 2018 – Feb 26, 2018 GFS2 file system

lore
Share & tools
lore

Andreas Gruenbacher

author maintainer
#0 lore raw

PATCH 1/1 gfs2: Fsync parent directories

When fsyncing a new file, also fsync the directory the files is in, recursively. This is how Linux filesystems should behave nowadays, even if not mandated by POSIX.

Based on ext4 commits 14ece1028, d59729f4e, and 9f713878f.

Fixes xfstests generic/322, generic/376.

---
 fs/gfs2/dir.c    |  3 ++-
 fs/gfs2/dir.h    |  2 +-
 fs/gfs2/file.c   | 37 +++++++++++++++++++++++++++++++++++++
 fs/gfs2/incore.h |  1 +
 4 files changed, 41 insertions(+), 2 deletions(-)
fs/gfs2/dir.c +2 -1
index 7c21aea..5dbcf9d 100644
@@ -1797,7 +1797,7 @@ static u16 gfs2_inode_ra_len(const struct gfs2_inode *ip)
  */
 
 int gfs2_dir_add(struct inode *inode, const struct qstr *name,
-		 const struct gfs2_inode *nip, struct gfs2_diradd *da)
+		 struct gfs2_inode *nip, struct gfs2_diradd *da)
 {
 	struct gfs2_inode *ip = GFS2_I(inode);
 	struct buffer_head *bh = da->bh;
@@ -1832,6 +1832,7 @@ int gfs2_dir_add(struct inode *inode, const struct qstr *name,
 			ip->i_inode.i_mtime = ip->i_inode.i_ctime = tv;
 			if (S_ISDIR(nip->i_inode.i_mode))
 				inc_nlink(&ip->i_inode);
+			set_bit(GIF_NEWENTRY, &nip->i_flags);
 			mark_inode_dirty(inode);
 			error = 0;
 			break;
fs/gfs2/dir.h +1 -1
index e1b309c..8c07423 100644
@@ -32,7 +32,7 @@ extern struct inode *gfs2_dir_search(struct inode *dir,
 extern int gfs2_dir_check(struct inode *dir, const struct qstr *filename,
 			  const struct gfs2_inode *ip);
 extern int gfs2_dir_add(struct inode *inode, const struct qstr *filename,
-			const struct gfs2_inode *ip, struct gfs2_diradd *da);
+			struct gfs2_inode *ip, struct gfs2_diradd *da);
 static inline void gfs2_dir_no_add(struct gfs2_diradd *da)
 {
 	if (da->bh)
fs/gfs2/file.c +37 -0
index 739a47c..9669991 100644
@@ -631,6 +631,39 @@ static int gfs2_release(struct inode *inode, struct file *file)
 	return 0;
 }
 
+static int gfs2_sync_parent(struct inode *inode)
+{
+	struct gfs2_inode *ip = GFS2_I(inode);
+	int ret = 0;
+
+	if (!test_bit(GIF_NEWENTRY, &ip->i_flags))
+		return 0;
+	inode = igrab(inode);
+	while (test_bit(GIF_NEWENTRY, &ip->i_flags)) {
+		struct dentry *dentry;
+		struct inode *next;
+
+		clear_bit(GIF_NEWENTRY, &ip->i_flags);
+		dentry = d_find_any_alias(inode);
+		if (!dentry)
+			break;
+		next = igrab(d_inode(dentry->d_parent));
+		dput(dentry);
+		if (!next)
+			break;
+		iput(inode);
+		inode = next;
+		ip = GFS2_I(inode);
+
+		ret = sync_inode_metadata(inode, 1);
+		if (ret)
+			break;
+		gfs2_ail_flush(ip->i_gl, 1);
+	}
+	iput(inode);
+	return ret;
+}
+
 /**
  * gfs2_fsync - sync the dirty data for a file (across the cluster)
  * @file: the file that points to the dentry
@@ -683,6 +716,10 @@ static int gfs2_fsync(struct file *file, loff_t start, loff_t end,
 		gfs2_ail_flush(ip->i_gl, 1);
 	}
 
+	ret = gfs2_sync_parent(inode);
+	if (ret)
+		return ret;
+
 	if (mapping->nrpages)
 		ret = file_fdatawait_range(file, start, end);
 
fs/gfs2/incore.h +1 -0
index e0557b8..e81c5eb 100644
@@ -386,6 +386,7 @@ enum {
 	GIF_ORDERED		= 4,
 	GIF_FREE_VFS_INODE      = 5,
 	GIF_GLOP_PENDING	= 6,
+	GIF_NEWENTRY		= 7,
 };
 
 struct gfs2_inode {
Signature · 1 line
1.8.3.1
#1 lore raw

PATCH 1/1 gfs2: Fsync parent directories

Hi Andreas,

----- Original Message -----

| When fsyncing a new file, also fsync the directory the files is in,
| recursively.  This is how Linux filesystems should behave nowadays,
| even if not mandated by POSIX.
| 
| Based on ext4 commits 14ece1028, d59729f4e, and 9f713878f.
| 
| Fixes xfstests generic/322, generic/376.
| 
| Signed-off-by: Andreas Gruenbacher <[email protected]>
| ---

It seems like the patch should be calling gfs2_inode_lookup on the parent directory or something, rather than a simple i_grab, and possibly even holding (nw) the parent directory's i_gl glock. Otherwise, the call to gfs2_ail_flush may reference an i_gl that might not exist. I'm concerned about other nodes in the cluster referencing and/or changing the parent directory inode while this is happening. I'm not sure if it's possible. Maybe Nate has a test to check cluster coherency for directories as well as files?

Regards,

Bob Peterson
Red Hat File Systems

#2 lore raw

PATCH 1/1 gfs2: Fsync parent directories

In reply to Andreas Gruenbacher
Quoted 3 lines · Andreas Gruenbacher

When fsyncing a new file, also fsync the directory the files is in, recursively. This is how Linux filesystems should behave nowadays, even if not mandated by POSIX.

I think that is bullshit. Maybe it is what google wants for ext4 non-journal mode which no one else uses anyway. but it certainly is anything but normal Linux semantics.

author maintainer
#3 lore raw

PATCH 1/1 gfs2: Fsync parent directories

Quoted 8 lines · Christoph Hellwig
Quoted 3 lines · Andreas Gruenbacher

When fsyncing a new file, also fsync the directory the files is in, recursively. This is how Linux filesystems should behave nowadays, even if not mandated by POSIX.

I think that is bullshit. Maybe it is what google wants for ext4 non-journal mode which no one else uses anyway. but it certainly is anything but normal Linux semantics.

Here's some code from xfstest generic/322:

  _mount_flakey
  $XFS_IO_PROG -f -c "pwrite 0 1M" -c "fsync" $SCRATCH_MNT/foo \
    > $seqres.full 2>&1 || _fail "xfs_io failed"
  mv $SCRATCH_MNT/foo $SCRATCH_MNT/bar
  $XFS_IO_PROG -c "fsync" $SCRATCH_MNT/bar
  md5sum $SCRATCH_MNT/bar | _filter_scratch

_flakey_drop_and_remount

md5sum $SCRATCH_MNT/bar | _filter_scratch
_unmount_flakey

Note that there is no fsync for the parent directory ($SCRATCH_MNT), yet the test obviously expects the directory to be synced as well. This isn't implemented as in this patch on all filesystems, but the major ones all show this behavior. So where's the bullshit?

Thanks,
Andreas

#4 lore raw

PATCH 1/1 gfs2: Fsync parent directories

Quoted 21 lines · Andreas Gruenbacher
Quoted 8 lines · Christoph Hellwig
Quoted 3 lines · Andreas Gruenbacher

When fsyncing a new file, also fsync the directory the files is in, recursively. This is how Linux filesystems should behave nowadays, even if not mandated by POSIX.

I think that is bullshit. Maybe it is what google wants for ext4 non-journal mode which no one else uses anyway. but it certainly is anything but normal Linux semantics.

Here's some code from xfstest generic/322:

  _mount_flakey
  $XFS_IO_PROG -f -c "pwrite 0 1M" -c "fsync" $SCRATCH_MNT/foo \
    > $seqres.full 2>&1 || _fail "xfs_io failed"
  mv $SCRATCH_MNT/foo $SCRATCH_MNT/bar
  $XFS_IO_PROG -c "fsync" $SCRATCH_MNT/bar
  md5sum $SCRATCH_MNT/bar | _filter_scratch

_flakey_drop_and_remount

Quoted 7 lines

md5sum $SCRATCH_MNT/bar | _filter_scratch
_unmount_flakey

Note that there is no fsync for the parent directory ($SCRATCH_MNT), yet the test obviously expects the directory to be synced as well. This isn't implemented as in this patch on all filesystems, but the major ones all show this behavior. So where's the bullshit?

This test is for filesystems that have strictly ordered metadata journalling. All the filesystems that fstests supports via _require_metadata_journalling() have strictly ordered metadata journalling/crash recovery semantics. (i.e. xfs, ext4, btrfs, and f2fs (IIRC)).

IOWs, if the filesystem is designed with strictly ordered metadata, then fsync()ing a new file also implies that all references to the new file are also on stable storage because they happened before the fsync on the file was issued. i.e. the directory is fsync'd implicitly because it was modified by the same operation that created the file. Hence if the file creation is made stable, so must be the directory modification done during file creation.

This has nothing to do with POSIX or what the "linux standard" is - this is testing whether the implementation of strictly ordered metadata journalling is correct or not. If gfs2 does not have strictly ordered metadata journalling, then it probably shouldn't run these tests....

Cheers,

Dave.

Signature · 2 lines
Dave Chinner
dchinner at redhat.com
#5 lore raw

PATCH 1/1 gfs2: Fsync parent directories

Quoted 8 lines · Dave Chinner

IOWs, if the filesystem is designed with strictly ordered metadata, then fsync()ing a new file also implies that all references to the new file are also on stable storage because they happened before the fsync on the file was issued. i.e. the directory is fsync'd implicitly because it was modified by the same operation that created the file. Hence if the file creation is made stable, so must be the directory modification done during file creation.

Quoted 5 lines

This has nothing to do with POSIX or what the "linux standard" is - this is testing whether the implementation of strictly ordered metadata journalling is correct or not. If gfs2 does not have strictly ordered metadata journalling, then it probably shouldn't run these tests....

Exactly. Also this is not just for new entries but also things like rename. So trying to come up with some adjocs hacks here seems wrong.

That being said as far as I know gfs2 does transactional metadata updates and has one single global log. Why doesn't it get these things right by default?

author maintainer
#6 lore raw

PATCH 1/1 gfs2: Fsync parent directories

Quoted 15 lines · Christoph Hellwig
Quoted 8 lines · Dave Chinner

IOWs, if the filesystem is designed with strictly ordered metadata, then fsync()ing a new file also implies that all references to the new file are also on stable storage because they happened before the fsync on the file was issued. i.e. the directory is fsync'd implicitly because it was modified by the same operation that created the file. Hence if the file creation is made stable, so must be the directory modification done during file creation.

Quoted 5 lines

This has nothing to do with POSIX or what the "linux standard" is - this is testing whether the implementation of strictly ordered metadata journalling is correct or not. If gfs2 does not have strictly ordered metadata journalling, then it probably shouldn't run these tests....

Quoted 7 lines

Exactly. Also this is not just for new entries but also things like rename. So trying to come up with some adjocs hacks here seems wrong.

That being said as far as I know gfs2 does transactional metadata updates and has one single global log. Why doesn't it get these things right by default?

GFS2 does do metadata journaling. I was under the assumption that gfs2's ordering model differs, but it turns out that all that was missing was a log flush in iop->fsync in case the inode is clean but a log flush hasn't been done for it, yet.

Thanks,
Andreas