dt-bindings: fpga: Consolidate bridge properties
Subsystems (3)
Moritz Fischer
maintainerPATCH 1/1 dt-bindings: fpga: Consolidate bridge properties
Consolidate bridge properties in a single file, instead of duplicating the same optional property over and over again.
Signed-off-by Moritz Fischer <[email protected]>
Cc Alan Tull <[email protected]>
Cc Rob Herring <[email protected]>
--- .../devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt | 5 +---- .../devicetree/bindings/fpga/altera-freeze-bridge.txt | 5 +---- .../devicetree/bindings/fpga/altera-hps2fpga-bridge.txt | 5 +---- Documentation/devicetree/bindings/fpga/fpga-bridge.txt | 15 +++++++++++++++ .../devicetree/bindings/fpga/xilinx-pr-decoupler.txt | 8 ++------ 5 files changed, 20 insertions(+), 18 deletions(-) create mode 100644 Documentation/devicetree/bindings/fpga/fpga-bridge.txt
Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt +1 -4
@@ -3,10 +3,7 @@ Altera FPGA To SDRAM Bridge Driver Required properties: - compatible : Should contain "altr,socfpga-fpga2sdram-bridge" -Optional properties: -- bridge-enable : 0 if driver should disable bridge at startup - 1 if driver should enable bridge at startup - Default is to leave bridge in current state. +See Documentation/devicetree/bindings/fpga/fpga-bridge.txt for generic bindings. Example: fpga_bridge3: fpga-bridge@ffc25080 {
Documentation/devicetree/bindings/fpga/altera-freeze-bridge.txt +1 -4
@@ -10,10 +10,7 @@ Required properties: - compatible : Should contain "altr,freeze-bridge-controller" - regs : base address and size for freeze bridge module -Optional properties: -- bridge-enable : 0 if driver should disable bridge at startup - 1 if driver should enable bridge at startup - Default is to leave bridge in current state. +See Documentation/devicetree/bindings/fpga/fpga-bridge.txt for generic bindings. Example: freeze-controller@100000450 {
Documentation/devicetree/bindings/fpga/altera-hps2fpga-bridge.txt +1 -4
@@ -9,10 +9,7 @@ Required properties: - resets : Phandle and reset specifier for this bridge's reset - clocks : Clocks used by this module. -Optional properties: -- bridge-enable : 0 if driver should disable bridge at startup. - 1 if driver should enable bridge at startup. - Default is to leave bridge in its current state. +See Documentation/devicetree/bindings/fpga/fpga-bridge.txt for generic bindings. Example: fpga_bridge0: fpga-bridge@ff400000 {
Documentation/devicetree/bindings/fpga/fpga-bridge.txt new file +15 -0
@@ -0,0 +1,15 @@ +FPGA Bridge Device Tree Binding + +Moritz Fischer 2018 (Consolidated from previous bindings) + +Optional properties: +- bridge-enable : 0 if driver should disable bridge at startup + 1 if driver should enable bridge at startup + Default is to leave bridge in current state. + +Example: + fpga_bridge3: fpga-bridge@ffc25080 { + compatible = "altr,socfpga-fpga2sdram-bridge"; + reg = <0xffc25080 0x4>; + bridge-enable = <0>; + };
Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt +2 -6
@@ -18,12 +18,8 @@ Required properties: - clocks : input clock to IP - clock-names : should contain "aclk" -Optional properties: -- bridge-enable : 0 if driver should disable bridge at startup - 1 if driver should enable bridge at startup - Default is to leave bridge in current state. - -See Documentation/devicetree/bindings/fpga/fpga-region.txt for generic bindings. +See Documentation/devicetree/bindings/fpga/fpga-region.txt and +Documentation/devicetree/bindings/fpga/fpga-bridge.txt for generic bindings. Example: fpga-bridge@100000450 {
Signature · 1 line
2.16.1
On Wed, Feb 21, 2018 at 11:33 AM, Moritz Fischer <[email protected]> wrote:
Hi Moritz,
Thanks!
Quoted 4 lines
Consolidate bridge properties in a single file, instead of duplicating the same optional property over and over again.
Signed-off-by Moritz Fischer <[email protected]>
Acked-by Alan Tull <[email protected]>
Quoted 102 lines
Cc Alan Tull <[email protected]>Cc Rob Herring <[email protected]>--- .../devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt | 5 +---- .../devicetree/bindings/fpga/altera-freeze-bridge.txt | 5 +---- .../devicetree/bindings/fpga/altera-hps2fpga-bridge.txt | 5 +---- Documentation/devicetree/bindings/fpga/fpga-bridge.txt | 15 +++++++++++++++ .../devicetree/bindings/fpga/xilinx-pr-decoupler.txt | 8 ++------ 5 files changed, 20 insertions(+), 18 deletions(-) create mode 100644 Documentation/devicetree/bindings/fpga/fpga-bridge.txtDocumentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt +1
-4@@ -3,10 +3,7 @@ Altera FPGA To SDRAM Bridge Driver Required properties: - compatible : Should contain "altr,socfpga-fpga2sdram-bridge" -Optional properties: -- bridge-enable : 0 if driver should disable bridge at startup - 1 if driver should enable bridge at startup - Default is to leave bridge in current state. +See Documentation/devicetree/bindings/fpga/fpga-bridge.txt for generic bindings. Example: fpga_bridge3: fpga-bridge@ffc25080 {Documentation/devicetree/bindings/fpga/altera-freeze-bridge.txt +1
-4@@ -10,10 +10,7 @@ Required properties: - compatible : Should contain "altr,freeze-bridge-controller" - regs : base address and size for freeze bridge module -Optional properties: -- bridge-enable : 0 if driver should disable bridge at startup - 1 if driver should enable bridge at startup - Default is to leave bridge in current state. +See Documentation/devicetree/bindings/fpga/fpga-bridge.txt for generic bindings. Example: freeze-controller@100000450 {Documentation/devicetree/bindings/fpga/altera-hps2fpga-bridge.txt +1
-4@@ -9,10 +9,7 @@ Required properties: - resets : Phandle and reset specifier for this bridge's reset - clocks : Clocks used by this module. -Optional properties: -- bridge-enable : 0 if driver should disable bridge at startup. - 1 if driver should enable bridge at startup. - Default is to leave bridge in its current state. +See Documentation/devicetree/bindings/fpga/fpga-bridge.txt for generic bindings. Example: fpga_bridge0: fpga-bridge@ff400000 {Documentation/devicetree/bindings/fpga/fpga-bridge.txt new file +15
-0@@ -0,0 +1,15 @@ +FPGA Bridge Device Tree Binding + +Moritz Fischer 2018 (Consolidated from previous bindings) + +Optional properties: +- bridge-enable : 0 if driver should disable bridge at startup + 1 if driver should enable bridge at startup + Default is to leave bridge in current state. + +Example: + fpga_bridge3: fpga-bridge@ffc25080 { + compatible = "altr,socfpga-fpga2sdram-bridge"; + reg = <0xffc25080 0x4>; + bridge-enable = <0>; + };Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt +2
-7@@ -18,12 +18,8 @@ Required properties: - clocks : input clock to IP - clock-names : should contain "aclk" -Optional properties: -- bridge-enable : 0 if driver should disable bridge at startup - 1 if driver should enable bridge at startup - Default is to leave bridge in current state. - -See Documentation/devicetree/bindings/fpga/fpga-region.txt for generic bindings. +See Documentation/devicetree/bindings/fpga/fpga-region.txt and +Documentation/devicetree/bindings/fpga/fpga-bridge.txt for generic bindings. Example: fpga-bridge@100000450 { --2.16.1
Quoted 69 lines · Moritz Fischer
Consolidate bridge properties in a single file, instead of duplicating the same optional property over and over again.
Signed-off-by Moritz Fischer <[email protected]>Cc Alan Tull <[email protected]>Cc Rob Herring <[email protected]>--- .../devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt | 5 +---- .../devicetree/bindings/fpga/altera-freeze-bridge.txt | 5 +---- .../devicetree/bindings/fpga/altera-hps2fpga-bridge.txt | 5 +---- Documentation/devicetree/bindings/fpga/fpga-bridge.txt | 15 +++++++++++++++ .../devicetree/bindings/fpga/xilinx-pr-decoupler.txt | 8 ++------ 5 files changed, 20 insertions(+), 18 deletions(-) create mode 100644 Documentation/devicetree/bindings/fpga/fpga-bridge.txtDocumentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt +1
-4@@ -3,10 +3,7 @@ Altera FPGA To SDRAM Bridge Driver Required properties: - compatible : Should contain "altr,socfpga-fpga2sdram-bridge" -Optional properties: -- bridge-enable : 0 if driver should disable bridge at startup - 1 if driver should enable bridge at startup - Default is to leave bridge in current state. +See Documentation/devicetree/bindings/fpga/fpga-bridge.txt for generic bindings. Example: fpga_bridge3: fpga-bridge@ffc25080 {Documentation/devicetree/bindings/fpga/altera-freeze-bridge.txt +1
-4@@ -10,10 +10,7 @@ Required properties: - compatible : Should contain "altr,freeze-bridge-controller" - regs : base address and size for freeze bridge module -Optional properties: -- bridge-enable : 0 if driver should disable bridge at startup - 1 if driver should enable bridge at startup - Default is to leave bridge in current state. +See Documentation/devicetree/bindings/fpga/fpga-bridge.txt for generic bindings. Example: freeze-controller@100000450 {Documentation/devicetree/bindings/fpga/altera-hps2fpga-bridge.txt +1
-4@@ -9,10 +9,7 @@ Required properties: - resets : Phandle and reset specifier for this bridge's reset - clocks : Clocks used by this module. -Optional properties: -- bridge-enable : 0 if driver should disable bridge at startup. - 1 if driver should enable bridge at startup. - Default is to leave bridge in its current state. +See Documentation/devicetree/bindings/fpga/fpga-bridge.txt for generic bindings. Example: fpga_bridge0: fpga-bridge@ff400000 {Documentation/devicetree/bindings/fpga/fpga-bridge.txt new file +0
-0
Documentation/devicetree/bindings/fpga/fpga-bridge.txt line 3
Quoted 3 lines
Documentation/devicetree/bindings/fpga/fpga-bridge.txt new file +3
-0@@ -0,0 +1,15 @@ +FPGA Bridge Device Tree Binding + +Moritz Fischer 2018 (Consolidated from previous bindings)
nit: I would remove your name and year - it is visible from git log.
Quoted 22 lines
Documentation/devicetree/bindings/fpga/fpga-bridge.txt new file +12
-0+ +Optional properties: +- bridge-enable : 0 if driver should disable bridge at startup + 1 if driver should enable bridge at startup + Default is to leave bridge in current state. + +Example: + fpga_bridge3: fpga-bridge@ffc25080 { + compatible = "altr,socfpga-fpga2sdram-bridge"; + reg = <0xffc25080 0x4>; + bridge-enable = <0>; + };Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt +0
-1@@ -18,12 +18,8 @@ Required properties: - clocks : input clock to IP - clock-names : should contain "aclk" -Optional properties:
Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt Required properties: · line 25
Quoted 10 lines
Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt +2
-5-- bridge-enable : 0 if driver should disable bridge at startup - 1 if driver should enable bridge at startup - Default is to leave bridge in current state. - -See Documentation/devicetree/bindings/fpga/fpga-region.txt for generic bindings. +See Documentation/devicetree/bindings/fpga/fpga-region.txt and +Documentation/devicetree/bindings/fpga/fpga-bridge.txt for generic bindings. Example: fpga-bridge@100000450 {
Acked-by Michal Simek <[email protected]>
Thanks,
Michal
Moritz Fischer
maintainerQuoted 62 lines · Michal Simek
Quoted 61 lines · Moritz Fischer
Consolidate bridge properties in a single file, instead of duplicating the same optional property over and over again.
Signed-off-by Moritz Fischer <[email protected]>Cc Alan Tull <[email protected]>Cc Rob Herring <[email protected]>--- .../devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt | 5 +---- .../devicetree/bindings/fpga/altera-freeze-bridge.txt | 5 +---- .../devicetree/bindings/fpga/altera-hps2fpga-bridge.txt | 5 +---- Documentation/devicetree/bindings/fpga/fpga-bridge.txt | 15 +++++++++++++++ .../devicetree/bindings/fpga/xilinx-pr-decoupler.txt | 8 ++------ 5 files changed, 20 insertions(+), 18 deletions(-) create mode 100644 Documentation/devicetree/bindings/fpga/fpga-bridge.txtDocumentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt +1
-4@@ -3,10 +3,7 @@ Altera FPGA To SDRAM Bridge Driver Required properties: - compatible : Should contain "altr,socfpga-fpga2sdram-bridge" -Optional properties: -- bridge-enable : 0 if driver should disable bridge at startup - 1 if driver should enable bridge at startup - Default is to leave bridge in current state. +See Documentation/devicetree/bindings/fpga/fpga-bridge.txt for generic bindings. Example: fpga_bridge3: fpga-bridge@ffc25080 {Documentation/devicetree/bindings/fpga/altera-freeze-bridge.txt +1
-4@@ -10,10 +10,7 @@ Required properties: - compatible : Should contain "altr,freeze-bridge-controller" - regs : base address and size for freeze bridge module -Optional properties: -- bridge-enable : 0 if driver should disable bridge at startup - 1 if driver should enable bridge at startup - Default is to leave bridge in current state. +See Documentation/devicetree/bindings/fpga/fpga-bridge.txt for generic bindings. Example: freeze-controller@100000450 {Documentation/devicetree/bindings/fpga/altera-hps2fpga-bridge.txt +1
-4@@ -9,10 +9,7 @@ Required properties: - resets : Phandle and reset specifier for this bridge's reset - clocks : Clocks used by this module. -Optional properties: -- bridge-enable : 0 if driver should disable bridge at startup. - 1 if driver should enable bridge at startup. - Default is to leave bridge in its current state. +See Documentation/devicetree/bindings/fpga/fpga-bridge.txt for generic bindings.
Quoted 13 lines
Documentation/devicetree/bindings/fpga/fpga-bridge.txt line 3
Quoted 11 lines
Documentation/devicetree/bindings/fpga/altera-hps2fpga-bridge.txt +0
-0Example: fpga_bridge0: fpga-bridge@ff400000 {Documentation/devicetree/bindings/fpga/fpga-bridge.txt new file +3
-0@@ -0,0 +1,15 @@ +FPGA Bridge Device Tree Binding + +Moritz Fischer 2018 (Consolidated from previous bindings)nit: I would remove your name and year - it is visible from git log.
Yeah can get rid of that, I copied from fpga-region.txt :)
Quoted 36 lines
Quoted 23 lines
Documentation/devicetree/bindings/fpga/fpga-bridge.txt new file +12
-0+ +Optional properties: +- bridge-enable : 0 if driver should disable bridge at startup + 1 if driver should enable bridge at startup + Default is to leave bridge in current state. + +Example: + fpga_bridge3: fpga-bridge@ffc25080 { + compatible = "altr,socfpga-fpga2sdram-bridge"; + reg = <0xffc25080 0x4>; + bridge-enable = <0>; + };Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt +0
-1@@ -18,12 +18,8 @@ Required properties: - clocks : input clock to IP - clock-names : should contain "aclk" -Optional properties:Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt Required properties: · line 25
Quoted 10 lines
Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt +2
-5-- bridge-enable : 0 if driver should disable bridge at startup - 1 if driver should enable bridge at startup - Default is to leave bridge in current state. - -See Documentation/devicetree/bindings/fpga/fpga-region.txt for generic bindings. +See Documentation/devicetree/bindings/fpga/fpga-region.txt and +Documentation/devicetree/bindings/fpga/fpga-bridge.txt for generic bindings. Example: fpga-bridge@100000450 {Acked-by Michal Simek <[email protected]>
Quoted 6 lines
Thanks,
Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-fpga" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
- Moritz
Quoted 6 lines · Moritz Fischer
Consolidate bridge properties in a single file, instead of duplicating the same optional property over and over again.
Signed-off-by Moritz Fischer <[email protected]>Cc Alan Tull <[email protected]>Cc Rob Herring <[email protected]>
Quoted 8 lines
--- .../devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt | 5 +---- .../devicetree/bindings/fpga/altera-freeze-bridge.txt | 5 +---- .../devicetree/bindings/fpga/altera-hps2fpga-bridge.txt | 5 +---- Documentation/devicetree/bindings/fpga/fpga-bridge.txt | 15 +++++++++++++++ .../devicetree/bindings/fpga/xilinx-pr-decoupler.txt | 8 ++------ 5 files changed, 20 insertions(+), 18 deletions(-) create mode 100644 Documentation/devicetree/bindings/fpga/fpga-bridge.txt
Reviewed-by Rob Herring <[email protected]>