Skip to contentSkip to conversation

domctl: revert double increment of domctl version

PATCH In review Olaf Hering 3 participants 5 messages Feb 21, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 domctl: revert double increment of domctl version

Xen 4.10 has XEN_DOMCTL_INTERFACE_VERSION 0xe, staging should be fine with 0xf until the next release is prepared.

---
 xen/include/public/domctl.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
xen/include/public/domctl.h +1 -1
index ec7a860afc..501c44230b 100644
@@ -38,7 +38,7 @@
 #include "hvm/save.h"
 #include "memory.h"
 
-#define XEN_DOMCTL_INTERFACE_VERSION 0x00000010
+#define XEN_DOMCTL_INTERFACE_VERSION 0x0000000f
 
 /*
  * NB. xen_domctl.domain is an IN/OUT parameter for this operation.

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#1 lore raw
Quoted 13 lines · Olaf Hering

Xen 4.10 has XEN_DOMCTL_INTERFACE_VERSION 0xe, staging should be fine with 0xf until the next release is prepared.

---
 xen/include/public/domctl.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
xen/include/public/domctl.h +0 -0
index ec7a860afc..501c44230b 100644

xen/include/public/domctl.h line 42

Quoted 6 lines
xen/include/public/domctl.h +1 -1
@@ -38,7 +38,7 @@
 #include "hvm/save.h"
 #include "memory.h"
 
-#define XEN_DOMCTL_INTERFACE_VERSION 0x00000010
+#define XEN_DOMCTL_INTERFACE_VERSION 0x0000000f
 

The reason we bumped the number twice is because we want a dedicated number to denote the recent security fix.

Wei.

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#3 lore raw
In reply to Wei Liu
Quoted 17 lines · Wei Liu
Quoted 16 lines · Olaf Hering

Xen 4.10 has XEN_DOMCTL_INTERFACE_VERSION 0xe, staging should be fine with 0xf until the next release is prepared.

---
 xen/include/public/domctl.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
xen/include/public/domctl.h +0 -0
index ec7a860afc..501c44230b 100644
@@ -38,7 +38,7 @@
 #include "hvm/save.h"
 #include "memory.h"
 
Quoted 5 lines

xen/include/public/domctl.h line 42

Quoted 3 lines
xen/include/public/domctl.h +1 -1
-#define XEN_DOMCTL_INTERFACE_VERSION 0x00000010
+#define XEN_DOMCTL_INTERFACE_VERSION 0x0000000f
 

The reason we bumped the number twice is because we want a dedicated number to denote the recent security fix.

The double bump is there because Jan insisted upon it, so there is a number to burn if we decide to backport part of PV-in-PVH to Xen 4.10. It is currently unused.

I continue to think that this is a mistake (which is backed up by everyone else being confused about what is going on), and demonstrates the ineffectiveness of the *_INTERFACE_VERSIONS in general.

~Andrew

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#4 lore raw

Am Wed, 21 Feb 2018 17:53:54 +0000
schrieb Andrew Cooper <[email protected]>:

Quoted 3 lines

I continue to think that this is a mistake (which is backed up by everyone else being confused about what is going on), and demonstrates the ineffectiveness of the *_INTERFACE_VERSIONS in general.

Well, my change was cosmetic anyway.
I'm updating valgrind and noticed this small inconsistency in staging.

Olaf

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel