sbc: Fix stack overflow read in sbc_crc8.
PATCH 1/1 sbc: Fix stack overflow read in sbc_crc8.
When encoding or decoding with JOINT_STEREO and 8 subbands the crc_pos is 88 bits. In this case there are no extra bits which need to be added to the CRC, but there is still a read 1 byte past the end of the crc_header stack variable.
Signed-off-by Joshua Kessinger <[email protected]>
--- sbc/sbc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sbc/sbc.c +1 -1
@@ -190,7 +190,7 @@ static uint8_t sbc_crc8(const uint8_t *data, size_t len)for (i =0 ; i < len /8 ; i++) crc = crc_table[crc ^ data[i]]; - octet = data[i]; + octet = len %8 ? data[i] :0 ;for (i =0 ; i < len %8 ; i++) {char bit = ((octet ^ crc) &0x80 ) >>7 ;
Signature · 1 line
2.16.1.291.g4437f3f132-goog
Luiz Augusto von Dentz
maintainerHi Joshua,
Quoted 14 lines · Joshua Kessinger
When encoding or decoding with
JOINT_STEREOand 8 subbands thecrc_posis 88 bits. In this case there are no extra bits which need to be added to the CRC, but there is still a read 1 byte past the end of thecrc_headerstack variable.Signed-off-by Joshua Kessinger <[email protected]>--- sbc/sbc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)sbc/sbc.c +0
-0
sbc/sbc.c static uint8_t sbc_crc8(const uint8_t *data, size_t len)
Quoted 9 lines
sbc/sbc.c +1
-2@@ -190,7 +190,7 @@ static uint8_t sbc_crc8(const uint8_t *data, size_t len)for (i =0 ; i < len /8 ; i++) crc = crc_table[crc ^ data[i]]; - octet = data[i]; + octet = len %8 ? data[i] :0 ;for (i =0 ; i < len %8 ; i++) {char bit = ((octet ^ crc) &0x80 ) >>7 ; --
Looks like we forgot about this one, it is now applied after removing the signed-off-by line.
Signature · 1 line
Luiz Augusto von Dentz