mm: zsmalloc: Replace return type int with bool
Subsystems (2)
PATCH v3 1/1 mm: zsmalloc: Replace return type int with bool
zs_register_migration() returns either 0 or 1. So the return type int should be replaced with bool.
---
v2: Returning false in zs_register_migration() as return
type is bool
v3: Return true/false correctly incase of success/failure
mm/zsmalloc.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
mm/zsmalloc.c +6 -6
@@ -295,7 +295,7 @@ struct mapping_area { };#ifdef CONFIG_COMPACTION -static int zs_register_migration (struct zs_pool *pool); +static bool zs_register_migration (struct zs_pool *pool);static void zs_unregister_migration (struct zs_pool *pool);static void migrate_lock_init (struct zspage *zspage);static void migrate_read_lock (struct zspage *zspage);
@@ -306,7 +306,7 @@ struct mapping_area {#else static int zsmalloc_mount (void ) {return 0 ; }static void zsmalloc_unmount (void ) {} -static int zs_register_migration (struct zs_pool *pool) {return 0 ; } +static bool zs_register_migration (struct zs_pool *pool) {return false; }static void zs_unregister_migration (struct zs_pool *pool) {}static void migrate_lock_init (struct zspage *zspage) {}static void migrate_read_lock (struct zspage *zspage) {}
@@ -2101,17 +2101,17 @@ void zs_page_putback(struct page *page) .putback_page = zs_page_putback, }; -static int zs_register_migration (struct zs_pool *pool) +static bool zs_register_migration (struct zs_pool *pool) { pool->inode =alloc_anon_inode (zsmalloc_mnt->mnt_sb);if (IS_ERR (pool->inode)) { pool->inode =NULL ; -return 1 ; +return false; } pool->inode->i_mapping->private_data = pool; pool->inode->i_mapping->a_ops = &zsmalloc_aops; -return 0 ; +return true; }static void zs_unregister_migration (struct zs_pool *pool)
@@ -2409,7 +2409,7 @@ struct zs_pool *zs_create_pool(const char *name)/* debug only, don't abort if it fails */ zs_pool_stat_create (pool, name); -if (zs_register_migration (pool)) +if (zs_register_migration (pool) == false) goto err;/*
--
1.9.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Minchan Kim
maintainerQuoted 4 lines · Souptick Joarder
zs_register_migration()returns either 0 or 1. So the return type int should be replaced with bool.Signed-off-by Souptick Joarder <[email protected]>
As I said earlier, it is lack of justfication.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>