m68k: time: stop validating rtc_time in .read_time
Subsystems (2)
Alexandre Belloni
maintainerPATCH 1/1 m68k: time: stop validating rtc_time in .read_time
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback.
Signed-off-by Alexandre Belloni <[email protected]>
--- arch/m68k/kernel/time.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/m68k/kernel/time.c +1 -1
@@ -91,7 +91,7 @@ void read_persistent_clock(struct timespec *ts)static int rtc_generic_get_time (struct device *dev,struct rtc_time *tm) {mach_hwclk (0 , tm); -return rtc_valid_tm (tm); +return 0 ; }static int rtc_generic_set_time (struct device *dev,struct rtc_time *tm)
Signature · 1 line
2.16.1
Geert Uytterhoeven
maintainerHi Alexandre,
Quoted 4 lines · Alexandre Belloni
The RTC core is always calling
rtc_valid_tmafter theread_timecallback. It is not necessary to call it just before returning from the callback.Signed-off-by Alexandre Belloni <[email protected]>
Thank you, will apply and queue for v4.17.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds