parisc: time: stop validating rtc_time in .read_time
Subsystems (2)
Alexandre Belloni
maintainerPATCH 1/1 parisc: time: stop validating rtc_time in .read_time
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback.
Signed-off-by Alexandre Belloni <[email protected]>
--- arch/parisc/kernel/time.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/parisc/kernel/time.c +1 -1
@@ -173,7 +173,7 @@ static int rtc_generic_get_time(struct device *dev, struct rtc_time *tm)/* we treat tod_sec as unsigned, so this can work until year 2106 */ rtc_time64_to_tm (tod_data.tod_sec, tm); -return rtc_valid_tm (tm); +return 0 ; }static int rtc_generic_set_time (struct device *dev,struct rtc_time *tm)
Signature · 1 line
2.16.1
Quoted 4 lines · Alexandre Belloni
The RTC core is always calling
rtc_valid_tmafter theread_timecallback. It is not necessary to call it just before returning from the callback.Signed-off-by Alexandre Belloni <[email protected]>
Acked-by Helge Deller <[email protected]>
Thanks!
Helge
Quoted 18 lines
--- arch/parisc/kernel/time.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/parisc/kernel/time.c +1
-1@@ -173,7 +173,7 @@ static int rtc_generic_get_time(struct device *dev, struct rtc_time *tm)/* we treat tod_sec as unsigned, so this can work until year 2106 */ rtc_time64_to_tm (tod_data.tod_sec, tm); -return rtc_valid_tm (tm); +return 0 ; }static int rtc_generic_set_time (struct device *dev,struct rtc_time *tm)