Ion unit test with VGEM
v2 cover Ion unit test with VGEM
Hi,
This is v2 of the series to add a unit test to Ion with VGEM. From v1:
Ion hasn't had much in the way of unit tests and fixing that is something that needs to happen before it can move out of staging. The difficult part of testing parts of Ion is that it relies on having a kernel driver to actually make some of the dma_buf calls. The vgem DRM driver exists mostly for testing and works great for this case.
Changes since v1:
- Dropped RFC
- Feedback/review from Daniel Vetter about DRM ioctls
Thanks,
Laura
Laura Abbott (2):
selftests: ion: Remove some prints
selftests: ion: Add simple test with the vgem driver
tools/testing/selftests/android/ion/Makefile | 3 +- tools/testing/selftests/android/ion/config | 1 + tools/testing/selftests/android/ion/ionmap_test.c | 149 ++++++++++++++++++++++ tools/testing/selftests/android/ion/ionutils.c | 6 - 4 files changed, 152 insertions(+), 7 deletions(-) create mode 100644 tools/testing/selftests/android/ion/ionmap_test.c
Signature · 6 lines
2.14.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH v2 1/2 selftests: ion: Remove some prints
There's no need to print messages each time we alloc and free. Remove them.
---
v2: No changes
--- tools/testing/selftests/android/ion/ionutils.c | 6 ------ 1 file changed, 6 deletions(-)
tools/testing/selftests/android/ion/ionutils.c +0 -6
@@ -80,11 +80,6 @@ int ion_export_buffer_fd(struct ion_buffer_info *ion_info) heap_id =MAX_HEAP_COUNT +1 ;for (i =0 ; i < query.cnt; i++) {if (heap_data[i].type == ion_info->heap_type) { -printf ("--------------------------------------\n" ); -printf ("heap type: %d\n" , heap_data[i].type); -printf (" heap id: %d\n" , heap_data[i].heap_id); -printf ("heap name: %s\n" , heap_data[i].name); -printf ("--------------------------------------\n" ); heap_id = heap_data[i].heap_id;break ; }
@@ -204,7 +199,6 @@ void ion_close_buffer_fd(struct ion_buffer_info *ion_info)/* Finally, close the client fd */ if (ion_info->ionfd >0 )close (ion_info->ionfd); -printf ("<%s>: buffer release successfully....\n" , __func__); } }
Signature · 6 lines
2.14.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH v2 2/2 selftests: ion: Add simple test with the vgem driver
In reply to Laura AbbottIon is designed to be a framework used by other clients who perform operations on the buffer. Use the DRM vgem client as a simple consumer. In conjunction with the dma-buf sync ioctls, this tests the full attach/map path for the system heap.
---
v2: Introduce drmIoctl wrapper per suggestion of Daniel Vetter to better match how DRM ioctls actually work.
--- tools/testing/selftests/android/ion/Makefile | 3 +- tools/testing/selftests/android/ion/config | 1 + tools/testing/selftests/android/ion/ionmap_test.c | 149 ++++++++++++++++++++++ 3 files changed, 152 insertions(+), 1 deletion(-) create mode 100644 tools/testing/selftests/android/ion/ionmap_test.c
tools/testing/selftests/android/ion/Makefile +2 -1
@@ -2,7 +2,7 @@ INCLUDEDIR := -I. -I../../../../../drivers/staging/android/uapi/ CFLAGS := $(CFLAGS) $(INCLUDEDIR) -Wall -O2 -g -TEST_GEN_FILES := ionapp_export ionapp_import +TEST_GEN_FILES := ionapp_export ionapp_import ionmap_test all: $(TEST_GEN_FILES)
@@ -14,3 +14,4 @@ include ../../lib.mk $(OUTPUT)/ionapp_export: ionapp_export.c ipcsocket.c ionutils.c $(OUTPUT)/ionapp_import: ionapp_import.c ipcsocket.c ionutils.c +$(OUTPUT)/ionmap_test: ionmap_test.c ionutils.c
tools/testing/selftests/android/ion/config +1 -0
@@ -2,3 +2,4 @@ CONFIG_ANDROID=y CONFIG_STAGING=y CONFIG_ION=y CONFIG_ION_SYSTEM_HEAP=y +CONFIG_DRM_VGEM=y
tools/testing/selftests/android/ion/ionmap_test.c new file +149 -0
149 lines not on this page · raw message
Signature · 6 lines
2.14.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html