Skip to contentSkip to conversation

ndctl, test: explicitly request namespace size

PATCH New Ross Zwisler 1 participant 1 message Feb 21, 2018 libnvdimm: non-volatile memory device

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ndctl, test: explicitly request namespace size

The btt-pad-compat.sh test was failing for me because the namespace it was creating was 32 MiB in size, but it was trying to do 64 MiB worth of I/O using xxd. This happened because when we created the namespace we didn't specify a size, and in nfit_test we could have hit either a 64 MiB or a 32 MiB region. Vishal happened to be getting the 64 MiB region, and I happened to get the 32 MiB.

Fix this by explicitly requesting a namespace size of 64 MiB.

---
 test/btt-pad-compat.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
test/btt-pad-compat.sh +1 -1
index 4dfe8b0..a157c58 100755
@@ -137,7 +137,7 @@ copy_xxd_img()
 create_oldfmt_ns()
 {
 	# create null-uuid namespace
-	json=$($ndctl create-namespace -b "$bus" -t pmem -m raw -l 4096 -u 00000000-0000-0000-0000-000000000000)
+	json=$($ndctl create-namespace -b "$bus" -s 64M -t pmem -m raw -l 4096 -u 00000000-0000-0000-0000-000000000000)
 	eval "$(echo "$json" | sed -e "$json2var")"
 	[ -n "$dev" ] || err "$LINENO" 2
 	[ -n "$size" ] || err "$LINENO" 2
Signature · 6 lines
2.14.3

_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm