selftest: fix kselftest-merge depend on 'RUNTIME_TESTING_MENU'
Subsystems (8)
PATCH 1/1 selftest: fix kselftest-merge depend on 'RUNTIME_TESTING_MENU'
Since the 'commit d3deafaa8b5c ("lib/: make RUNTIME_TESTS a menuconfig to ease disabling it all")', the make kselftest-merge cannot merge the config dependencies of kselftest to the existing .config file.
These config dependencies of kselftest need to enable the 'CONFIG_RUNTIME_TESTING_MENU=y' at the same time.
--- tools/testing/selftests/bpf/config | 1 + tools/testing/selftests/firmware/config | 1 + tools/testing/selftests/kmod/config | 1 + tools/testing/selftests/lib/config | 1 + tools/testing/selftests/net/config | 1 + tools/testing/selftests/static_keys/config | 1 + tools/testing/selftests/sysctl/config | 1 + tools/testing/selftests/user/config | 1 + 8 files changed, 8 insertions(+)
tools/testing/selftests/bpf/config +1 -0
@@ -1,3 +1,4 @@ +CONFIG_RUNTIME_TESTING_MENU=y CONFIG_BPF=y CONFIG_BPF_SYSCALL=y CONFIG_NET_CLS_BPF=m
tools/testing/selftests/firmware/config +1 -0
@@ -1 +1,2 @@ +CONFIG_RUNTIME_TESTING_MENU=y CONFIG_TEST_FIRMWARE=y
tools/testing/selftests/kmod/config +1 -0
@@ -1,3 +1,4 @@ +CONFIG_RUNTIME_TESTING_MENU=y CONFIG_TEST_KMOD=m CONFIG_TEST_LKM=m CONFIG_XFS_FS=m
tools/testing/selftests/lib/config +1 -0
@@ -1,3 +1,4 @@ +CONFIG_RUNTIME_TESTING_MENU=y CONFIG_TEST_PRINTF=m CONFIG_TEST_BITMAP=m CONFIG_PRIME_NUMBERS=m
tools/testing/selftests/net/config +1 -0
@@ -1,3 +1,4 @@ +CONFIG_RUNTIME_TESTING_MENU=y CONFIG_USER_NS=y CONFIG_BPF_SYSCALL=y CONFIG_TEST_BPF=m
tools/testing/selftests/static_keys/config +1 -0
@@ -1 +1,2 @@ +CONFIG_RUNTIME_TESTING_MENU=y CONFIG_TEST_STATIC_KEYS=m
tools/testing/selftests/sysctl/config +1 -0
@@ -1 +1,2 @@ +CONFIG_RUNTIME_TESTING_MENU=y CONFIG_TEST_SYSCTL=y
tools/testing/selftests/user/config +1 -0
@@ -1 +1,2 @@ +CONFIG_RUNTIME_TESTING_MENU=y CONFIG_TEST_USER_COPY=m
Signature · 6 lines
2.16.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Luis R. Rodriguez
maintainerQuoted 9 lines · Zong Li
Since the 'commit
d3deafaa8b5c("lib/: makeRUNTIME_TESTSa menuconfig to ease disabling it all")', the make kselftest-merge cannot merge the config dependencies of kselftest to the existing .config file.These config dependencies of kselftest need to enable the '
CONFIG_RUNTIME_TESTING_MENU=y' at the same time.Signed-off-by Zong Li <zong at andestech.com>Cc Greentime Hu <greentime at andestech.com>
Please add respective Fixes: tag with the sha1sum, and commit name.
Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 6 lines · Zong Li
Since the 'commit
d3deafaa8b5c("lib/: makeRUNTIME_TESTSa menuconfig to ease disabling it all")', the make kselftest-merge cannot merge the config dependencies of kselftest to the existing .config file.These config dependencies of kselftest need to enable the '
CONFIG_RUNTIME_TESTING_MENU=y' at the same time.
Is this patch needed when patch sha 'f29c79906064 ("lib/Kconfig.debug: enable RUNTIME_TESTING_MENU")' find its way into the kernel ?
I think it's in linux-next now.
Cheers,
Anders
Quoted 81 lines
Signed-off-by Zong Li <[email protected]>Cc Greentime Hu <[email protected]>--- tools/testing/selftests/bpf/config | 1 + tools/testing/selftests/firmware/config | 1 + tools/testing/selftests/kmod/config | 1 + tools/testing/selftests/lib/config | 1 + tools/testing/selftests/net/config | 1 + tools/testing/selftests/static_keys/config | 1 + tools/testing/selftests/sysctl/config | 1 + tools/testing/selftests/user/config | 1 + 8 files changed, 8 insertions(+)tools/testing/selftests/bpf/config +1
-0@@ -1,3 +1,4 @@ +CONFIG_RUNTIME_TESTING_MENU=y CONFIG_BPF=y CONFIG_BPF_SYSCALL=y CONFIG_NET_CLS_BPF=mtools/testing/selftests/firmware/config +1
-0@@ -1 +1,2 @@ +CONFIG_RUNTIME_TESTING_MENU=y CONFIG_TEST_FIRMWARE=ytools/testing/selftests/kmod/config +1
-0@@ -1,3 +1,4 @@ +CONFIG_RUNTIME_TESTING_MENU=y CONFIG_TEST_KMOD=m CONFIG_TEST_LKM=m CONFIG_XFS_FS=mtools/testing/selftests/lib/config +1
-0@@ -1,3 +1,4 @@ +CONFIG_RUNTIME_TESTING_MENU=y CONFIG_TEST_PRINTF=m CONFIG_TEST_BITMAP=m CONFIG_PRIME_NUMBERS=mtools/testing/selftests/net/config +1
-0@@ -1,3 +1,4 @@ +CONFIG_RUNTIME_TESTING_MENU=y CONFIG_USER_NS=y CONFIG_BPF_SYSCALL=y CONFIG_TEST_BPF=mtools/testing/selftests/static_keys/config +1
-0@@ -1 +1,2 @@ +CONFIG_RUNTIME_TESTING_MENU=y CONFIG_TEST_STATIC_KEYS=mtools/testing/selftests/sysctl/config +1
-0@@ -1 +1,2 @@ +CONFIG_RUNTIME_TESTING_MENU=y CONFIG_TEST_SYSCTL=ytools/testing/selftests/user/config +1
-1@@ -1 +1,2 @@ +CONFIG_RUNTIME_TESTING_MENU=y CONFIG_TEST_USER_COPY=m --2.16.1
2018-02-23 3:57 GMT+08:00 Anders Roxell <anders.roxell at linaro.org>:
Quoted 11 lines · Zong Li
Quoted 6 lines
Since the 'commit
d3deafaa8b5c("lib/: makeRUNTIME_TESTSa menuconfig to ease disabling it all")', the make kselftest-merge cannot merge the config dependencies of kselftest to the existing .config file.These config dependencies of kselftest need to enable the '
CONFIG_RUNTIME_TESTING_MENU=y' at the same time.Is this patch needed when patch sha '
f29c79906064("lib/Kconfig.debug: enableRUNTIME_TESTING_MENU")' find its way into the kernel ?
I think it's in linux-next now.
Thanks. The patch sha 'f29c79906064 ("lib/Kconfig.debug: enable RUNTIME_TESTING_MENU")' can resolve the make kselftest-merge on default situation, but I think the kselftest-merge should resolve the dependencies
without the prerequisite, it should enable the 'RUNTIME_TESTING_MENU' when merging
the config of some selftests if RUNTIME_TESTING_MENU is not set.
Best Regards,
Zong Li
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 13 lines · Zong Li
2018-02-23 3:57 GMT+08:00 Anders Roxell <anders.roxell at linaro.org>:
Quoted 11 lines · Zong Li
Quoted 6 lines
Since the 'commit
d3deafaa8b5c("lib/: makeRUNTIME_TESTSa menuconfig to ease disabling it all")', the make kselftest-merge cannot merge the config dependencies of kselftest to the existing .config file.These config dependencies of kselftest need to enable the '
CONFIG_RUNTIME_TESTING_MENU=y' at the same time.Is this patch needed when patch sha '
f29c79906064("lib/Kconfig.debug: enableRUNTIME_TESTING_MENU")' find its way into the kernel ?
I think it's in linux-next now.
Quoted 7 lines
Thanks. The patch sha '
f29c79906064("lib/Kconfig.debug: enableRUNTIME_TESTING_MENU")' can resolve the make kselftest-merge on default situation, but I think the kselftest-merge should resolve the dependencies
without the prerequisite, it should enable the 'RUNTIME_TESTING_MENU' when merging
the config of some selftests ifRUNTIME_TESTING_MENUis not set.
I see your point, but should the be enabled in a common place that gets included per
default if running kselftest-merge and not in all config fragments?
Cheers,
Anders
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
2018-02-28 6:32 GMT+08:00 Anders Roxell <anders.roxell at linaro.org>:
Quoted 23 lines · Zong Li
Quoted 13 lines
2018-02-23 3:57 GMT+08:00 Anders Roxell <anders.roxell at linaro.org>:
Quoted 11 lines · Zong Li
Quoted 6 lines
Since the 'commit
d3deafaa8b5c("lib/: makeRUNTIME_TESTSa menuconfig to ease disabling it all")', the make kselftest-merge cannot merge the config dependencies of kselftest to the existing .config file.These config dependencies of kselftest need to enable the '
CONFIG_RUNTIME_TESTING_MENU=y' at the same time.Is this patch needed when patch sha '
f29c79906064("lib/Kconfig.debug: enableRUNTIME_TESTING_MENU")' find its way into the kernel ?
I think it's in linux-next now.Quoted 7 lines
Thanks. The patch sha '
f29c79906064("lib/Kconfig.debug: enableRUNTIME_TESTING_MENU")' can resolve the make kselftest-merge on default situation, but I think the kselftest-merge should resolve the dependencies
without the prerequisite, it should enable the 'RUNTIME_TESTING_MENU' when merging
the config of some selftests ifRUNTIME_TESTING_MENUis not set.
Quoted 6 lines
I see your point, but should the be enabled in a common place that gets included per
default if running kselftest-merge and not in all config fragments?Cheers,
Anders
I agree with you. It is better that the config fragments of each selftests is responsible for
enabling the specific configs they needed only.
Thanks for your reply.
Best Regard,
Zong Li
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html