drm/sun4i: Enable the output on the pins (tcon0)
RFC PATCH 1/1 drm/sun4i: Enable the output on the pins (tcon0)
From: Ondrej Jirman <megous-5qf/[email protected]>
I noticed that with 4.16-rc1 LVDS output on A83T based TBS A711 tablet doesn't work (there's output but it's garbled). I compared some older patches for LVDS support with the mainlined ones and this change is missing from mainline Linux.
I don't know what the register does exactly and the harcoded register value doesn't inspire much confidence that it will work in a general case, so I'm sending this RFC.
This patch fixes the issue on A83T.
--- drivers/gpu/drm/sun4i/sun4i_tcon.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/gpu/drm/sun4i/sun4i_tcon.c +3 -0
@@ -335,6 +335,9 @@ static void sun4i_tcon0_mode_set_lvds(struct sun4i_tcon *tcon,regmap_update_bits (tcon->regs,SUN4I_TCON_GCTL_REG ,SUN4I_TCON_GCTL_IOMAP_MASK ,SUN4I_TCON_GCTL_IOMAP_TCON0 ); + +/* Enable the output on the pins */ +regmap_write (tcon->regs,SUN4I_TCON0_IO_TRI_REG ,0xe0000000 ); } static void sun4i_tcon0_mode_set_rgb(struct sun4i_tcon *tcon,
Signature · 1 line
2.16.2
Maxime Ripard
AppliedQuoted 6 lines · megous at megous.com
From: Ondrej Jirman <[email protected]>
I noticed that with 4.16-rc1 LVDS output on A83T based TBS A711 tablet doesn't work (there's output but it's garbled). I compared some older patches for LVDS support with the mainlined ones and this change is missing from mainline Linux.
Quoted 7 lines
I don't know what the register does exactly and the harcoded register value doesn't inspire much confidence that it will work in a general case, so I'm sending this RFC.
This patch fixes the issue on A83T.
Signed-off-by Ondrej Jirman <[email protected]>
Applied, thanks!
Maxime
Signature · 10 lines
Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180226/342085a6/attachment.sig>