drm/p[111: add CONFIG_OF dependency
Subsystems (3)
PATCH 1/1 drm/p[111: add CONFIG_OF dependency
We cannot select a symbol without meeting its other dependencies:
warning: (DRM_PL111) selects DRM_DUMB_VGA_DAC which has unmet direct dependencies (HAS_IOMEM && DRM && DRM_BRIDGE && OF) drivers/gpu/drm/bridge/dumb-vga-dac.c: In function 'dumb_vga_probe':drivers/gpu/drm/bridge/dumb-vga-dac.c:207:13: error: 'struct drm_bridge' has no member named 'of_node'
vga->bridge.of_node = pdev->dev.of_node;
^Here it seems reasonable to depend on CONFIG_OF, as all platforms using this driver already require that anyway.
--- drivers/gpu/drm/pl111/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/pl111/Kconfig +1 -0
@@ -3,6 +3,7 @@ config DRM_PL111 depends on DRM depends on ARM || ARM64 || COMPILE_TEST depends on COMMON_CLK + depends on OF select DRM_KMS_HELPER select DRM_KMS_CMA_HELPER select DRM_GEM_CMA_HELPER
Signature · 1 line
2.9.0
Quoted 10 lines · Arnd Bergmann
We cannot select a symbol without meeting its other dependencies:
warning: (
DRM_PL111) selectsDRM_DUMB_VGA_DACwhich has unmet direct dependencies (HAS_IOMEM&& DRM &&DRM_BRIDGE&& OF)drivers/gpu/drm/bridge/dumb-vga-dac.c: In function 'dumb_vga_probe':drivers/gpu/drm/bridge/dumb-vga-dac.c:207:13: error: 'structdrm_bridge' has no member named 'of_node'vga->bridge.of_node = pdev->dev.of_node; ^Here it seems reasonable to depend on
CONFIG_OF, as all platforms using this driver already require that anyway.
Looks like we'll be going with
https://patchwork.freedesktop.org/patch/205580/
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 10 lines · Eric Anholt
Quoted 8 lines · Arnd Bergmann
We cannot select a symbol without meeting its other dependencies:
warning: (
DRM_PL111) selectsDRM_DUMB_VGA_DACwhich has unmet direct dependencies (HAS_IOMEM&& DRM &&DRM_BRIDGE&& OF)drivers/gpu/drm/bridge/dumb-vga-dac.c: In function 'dumb_vga_probe':drivers/gpu/drm/bridge/dumb-vga-dac.c:207:13: error: 'structdrm_bridge' has no member named 'of_node'vga->bridge.of_node = pdev->dev.of_node; ^
Quoted 6 lines
Quoted 2 lines
Here it seems reasonable to depend on
CONFIG_OF, as all platforms using this driver already require that anyway.Looks like we'll be going with
Ok, even better!
Arnd
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel