Skip to contentSkip to conversation

generic/47[23]: remove from auto/quick groups

PATCH In review Dave Chinner 2 participants 2 messages Feb 23, 2018 – Nov 28, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 generic/47[23]: remove from auto/quick groups

From: Dave Chinner <[email protected]>

generic/472 is for changes that are not upstream and seem dead in the water at the moment, so remove this test from the auto and quick groups until it's been resolved upstream and the changes merged.

generic/473 really doesn't seme useful. FIEMAP is a debugging interface, xfs_io is a debugging tool and so trying to make every filesytem report exactly the same thing for a ranged query just strikes me as the wrong thing to be doing. This fails on XFS, and there's no apparent resolution to that in sight, so remove the test from the auto and quick, too.

---
 tests/generic/group | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
tests/generic/group +2 -2
index b2ce7a66ce81..1e808865772f 100644
@@ -474,8 +474,8 @@
 469 auto quick
 470 auto quick dax
 471 auto quick rw
-472 auto quick rw
-473 auto quick
+472 rw
+473 broken
 474 auto quick shutdown metadata
 475 shutdown auto log metadata
 476 auto rw
Signature · 1 line
2.16.1
#1 lore raw
Quoted 6 lines · Dave Chinner

From: Dave Chinner <[email protected]>

generic/472 is for changes that are not upstream and seem dead in the water at the moment, so remove this test from the auto and quick groups until it's been resolved upstream and the changes merged.

Quoted 6 lines

generic/473 really doesn't seme useful. FIEMAP is a debugging interface, xfs_io is a debugging tool and so trying to make every filesytem report exactly the same thing for a ranged query just strikes me as the wrong thing to be doing. This fails on XFS, and there's no apparent resolution to that in sight, so remove the test from the auto and quick, too.

Hi Dave, Eryu

generic/473 with XFS got the mismatched extent info and was marked as a broken test:
-------------------------------
Hole + Data
0: [0..127]: hole
-1: [128..255]: data
+1: [128..135]: data
-------------------------------

Is this a correct behavior? If not, is this issue going to be fixed in the future?

Best Regards,
Xiao Yang

Quoted 20 lines
---
 tests/generic/group | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
tests/generic/group +2 -2
index b2ce7a66ce81..1e808865772f 100644
@@ -474,8 +474,8 @@
 469 auto quick
 470 auto quick dax
 471 auto quick rw
-472 auto quick rw
-473 auto quick
+472 rw
+473 broken
 474 auto quick shutdown metadata
 475 shutdown auto log metadata
 476 auto rw