Staging: rtl8192e: rtllib_crypt_tkip.c: Use __func__ instead of function name and proper code ident for else statement
PATCH 1/1 Staging: rtl8192e: rtllib_crypt_tkip.c: Use __func__ instead of function name and proper code ident for else statement
From: Debopriyo <[email protected]>
This is a patch to the rtllib_crypt_tkip.c file that fixes 2 issues found by the checkpatch.pl tool
1.Use of __func__ instead of function name
2.proper code identation for else statement
--- drivers/staging/rtl8192e/rtllib_crypt_tkip.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8192e/rtllib_crypt_tkip.c +2 -2
@@ -314,7 +314,7 @@ static int rtllib_tkip_encrypt(struct sk_buff *skb, int hdr_len, void *priv)tkip_mixing_phase2 (rc4key, tkey->key, tkey->tx_ttak, tkey->tx_iv16); }else - tkey->tx_phase1_done =1 ; + tkey->tx_phase1_done =1 ; len = skb->len - hdr_len;
@@ -512,7 +512,7 @@ static int michael_mic(struct crypto_ahash *tfm_michael, u8 *key, u8 *hdr,int err;if (tfm_michael ==NULL ) { -pr_warn ("michael_mic: tfm_michael == NULL\n" ); +pr_warn ("%s: tfm_michael == NULL\n" , __func__);return -1 ; }sg_init_table (sg,2 );
Signature · 6 lines
2.7.4 _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Greg KH
maintainerQuoted 6 lines · Debopriyo Ghosh
From: Debopriyo <[email protected]>
This is a patch to the
rtllib_crypt_tkip.cfile that fixes 2 issues found by the checkpatch.pl tool
1.Use of__func__instead of function name
2.proper code identation for else statement
When you have to list different things you are doing in a single patch, that's a huge sign you need to break the patch up into multiple ones.
Please do that here.
thanks,
greg k-h
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel