Skip to contentSkip to conversation

s390x/sclp: remove duplicate MAX_AVAIL_SLOTS define

PATCH In review Cornelia Huck 2 participants 3 messages Feb 23, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 s390x/sclp: remove duplicate MAX_AVAIL_SLOTS define

It's already defined in cpu.h (to the same value) and not used in the sclp code.

---
 include/hw/s390x/sclp.h | 1 -
 1 file changed, 1 deletion(-)
include/hw/s390x/sclp.h +0 -1
index 476cbf78f2..f9db243484 100644
@@ -35,7 +35,6 @@
 #define SCLP_FC_ASSIGN_ATTACH_READ_STOR         0xE00000000000ULL
 #define SCLP_STARTING_SUBINCREMENT_ID           0x10001
 #define SCLP_INCREMENT_UNIT                     0x10000
-#define MAX_AVAIL_SLOTS                         32
 #define MAX_STORAGE_INCREMENTS                  1020
 
 /* CPU hotplug SCLP codes */
Signature · 1 line
2.13.6
#1 lore raw
Quoted 14 lines · Cornelia Huck

It's already defined in cpu.h (to the same value) and not used in the sclp code.

---
 include/hw/s390x/sclp.h | 1 -
 1 file changed, 1 deletion(-)
include/hw/s390x/sclp.h +0 -0
index 476cbf78f2..f9db243484 100644

include/hw/s390x/sclp.h line 40

Quoted 7 lines
include/hw/s390x/sclp.h +0 -1
@@ -35,7 +35,6 @@
 #define SCLP_FC_ASSIGN_ATTACH_READ_STOR         0xE00000000000ULL
 #define SCLP_STARTING_SUBINCREMENT_ID           0x10001
 #define SCLP_INCREMENT_UNIT                     0x10000
-#define MAX_AVAIL_SLOTS                         32
 #define MAX_STORAGE_INCREMENTS                  1020
 
 /* CPU hotplug SCLP codes */

Do we need this define and s390_get_memslot_count at all after removing the hotplug code?

#2 lore raw
Quoted 20 lines · On Fri, 23 Feb 2018 11:02:15 +0100 Christian Borntraeger…
Quoted 19 lines · Cornelia Huck

It's already defined in cpu.h (to the same value) and not used in the sclp code.

---
 include/hw/s390x/sclp.h | 1 -
 1 file changed, 1 deletion(-)
include/hw/s390x/sclp.h +0 -1
index 476cbf78f2..f9db243484 100644
@@ -35,7 +35,6 @@
 #define SCLP_FC_ASSIGN_ATTACH_READ_STOR         0xE00000000000ULL
 #define SCLP_STARTING_SUBINCREMENT_ID           0x10001
 #define SCLP_INCREMENT_UNIT                     0x10000
-#define MAX_AVAIL_SLOTS                         32
 #define MAX_STORAGE_INCREMENTS                  1020
 
Quoted 5 lines

include/hw/s390x/sclp.h line 40

Quoted 2 lines
include/hw/s390x/sclp.h +0 -0
 /* CPU hotplug SCLP codes */

Do we need this define and s390_get_memslot_count at all after removing the hotplug code?

Indeed. Let's kill it with fire :)