Skip to contentSkip to conversation

lightnvm: fix bad block initialization

PATCH In review Heiner Litz 3 participants 4 messages Feb 23, 2018 – Feb 24, 2018 Block layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lightnvm: fix bad block initialization

fix reading bad block device information to correctly setup the per line blk_bitmap during lightnvm initialization

---
 drivers/lightnvm/pblk-init.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/lightnvm/pblk-init.c +2 -1
index 86a94a7faa96..e0eba150ac7e 100644
@@ -461,10 +461,11 @@ static int pblk_bb_line(struct pblk *pblk, struct pblk_line *line,
 	struct nvm_tgt_dev *dev = pblk->dev;
 	struct nvm_geo *geo = &dev->geo;
 	int i, bb_cnt = 0;
+	int blk_per_lun = geo->nr_chks * geo->plane_mode;
 
 	for (i = 0; i < blk_per_line; i++) {
 		struct pblk_lun *rlun = &pblk->luns[i];
-		u8 *lun_bb_log = bb_log + i * blk_per_line;
+		u8 *lun_bb_log = bb_log + i * blk_per_lun;
 
 		if (lun_bb_log[line->id] == NVM_BLK_T_FREE)
 			continue;
Signature · 1 line
2.14.1
#1 lore raw
Quoted 16 lines · Heiner Litz

fix reading bad block device information to correctly setup the per line blk_bitmap during lightnvm initialization

---
  drivers/lightnvm/pblk-init.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
drivers/lightnvm/pblk-init.c +0 -0
index 86a94a7faa96..e0eba150ac7e 100644
@@ -461,10 +461,11 @@ static int pblk_bb_line(struct pblk *pblk, struct pblk_line *line,
  	struct nvm_tgt_dev *dev = pblk->dev;
  	struct nvm_geo *geo = &dev->geo;

drivers/lightnvm/pblk-init.c static int pblk_bb_line(struct pblk *pblk, struct pblk_line *line, · line 471

Quoted 10 lines
drivers/lightnvm/pblk-init.c +2 -1
  	int i, bb_cnt = 0;
+	int blk_per_lun = geo->nr_chks * geo->plane_mode;
 
  	for (i = 0; i < blk_per_line; i++) {
  		struct pblk_lun *rlun = &pblk->luns[i];
-		u8 *lun_bb_log = bb_log + i * blk_per_line;
+		u8 *lun_bb_log = bb_log + i * blk_per_lun;
 
  		if (lun_bb_log[line->id] == NVM_BLK_T_FREE)
  			continue;

Thanks Heiner. Applied.

Reviewed-by
#2 lore raw
Quoted 26 lines · Matias Bjørling
Quoted 23 lines · Heiner Litz

fix reading bad block device information to correctly setup the per line blk_bitmap during lightnvm initialization

---
 drivers/lightnvm/pblk-init.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/lightnvm/pblk-init.c +2 -1
index 86a94a7faa96..e0eba150ac7e 100644
@@ -461,10 +461,11 @@ static int pblk_bb_line(struct pblk *pblk, struct pblk_line *line,
 	struct nvm_tgt_dev *dev = pblk->dev;
 	struct nvm_geo *geo = &dev->geo;
 	int i, bb_cnt = 0;
+	int blk_per_lun = geo->nr_chks * geo->plane_mode;
 
 	for (i = 0; i < blk_per_line; i++) {
 		struct pblk_lun *rlun = &pblk->luns[i];
-		u8 *lun_bb_log = bb_log + i * blk_per_line;
+		u8 *lun_bb_log = bb_log + i * blk_per_lun;
 
Quoted 4 lines

drivers/lightnvm/pblk-init.c static int pblk_bb_line(struct pblk *pblk, struct pblk_line *line, · line 471

Quoted 2 lines
drivers/lightnvm/pblk-init.c +0 -0
 		if (lun_bb_log[line->id] == NVM_BLK_T_FREE)
 			continue;

Thanks Heiner. Applied.

The patch looks good, but it is missing:

Fixes 36b3b712e81dc ("lightnvm: pblk: refactor bad block identification")

Matias, please add this when picking up.

Reviewed-by
#3 lore raw
In reply to Matias Bjørling
Quoted 26 lines · Matias Bjørling
Quoted 23 lines · Heiner Litz

fix reading bad block device information to correctly setup the per line blk_bitmap during lightnvm initialization

---
 drivers/lightnvm/pblk-init.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/lightnvm/pblk-init.c +2 -1
index 86a94a7faa96..e0eba150ac7e 100644
@@ -461,10 +461,11 @@ static int pblk_bb_line(struct pblk *pblk, struct pblk_line *line,
 	struct nvm_tgt_dev *dev = pblk->dev;
 	struct nvm_geo *geo = &dev->geo;
 	int i, bb_cnt = 0;
+	int blk_per_lun = geo->nr_chks * geo->plane_mode;
 
 	for (i = 0; i < blk_per_line; i++) {
 		struct pblk_lun *rlun = &pblk->luns[i];
-		u8 *lun_bb_log = bb_log + i * blk_per_line;
+		u8 *lun_bb_log = bb_log + i * blk_per_lun;
 
Quoted 4 lines

drivers/lightnvm/pblk-init.c static int pblk_bb_line(struct pblk *pblk, struct pblk_line *line, · line 471

Quoted 2 lines
drivers/lightnvm/pblk-init.c +0 -0
 		if (lun_bb_log[line->id] == NVM_BLK_T_FREE)
 			continue;

Thanks Heiner. Applied.

The patch looks good, but it is missing:

Fixes 36b3b712e81dc ("lightnvm: pblk: refactor bad block identification")

Matias, please add this when picking up.

PS:
Heiner: Matias' lightnvm.io address is [email protected]