xfs_scrub: make interpreter explicit to python3
PATCH 1/1 xfs_scrub: make interpreter explicit to python3
Using #!/usr/bin/env makes some package dependency tools such as rpm complain given that it cannot verify package dependencies. Making it explicit resolves this lint rant.
--- scrub/xfs_scrub_all.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
scrub/xfs_scrub_all.in +1 -1
@@ -1,4 +1,4 @@ -#!/usr/bin/env python3 +#!/usr/bin/python3 # Run online scrubbers in parallel, but avoid thrashing. #
Signature · 1 line
2.16.2
Quoted 5 lines · Luis R. Rodriguez
Using #!/usr/bin/env makes some package dependency tools such as rpm complain given that it cannot verify package dependencies. Making it explicit resolves this lint rant.
Signed-off-by Luis R. Rodriguez <[email protected]>
Looks ok,
--D
Quoted 21 lines
--- scrub/xfs_scrub_all.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)scrub/xfs_scrub_all.in +1
-1@@ -1,4 +1,4 @@ -#!/usr/bin/env python3 +#!/usr/bin/python3 # Run online scrubbers in parallel, but avoid thrashing. #Signature · 6 lines
2.16.2 -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 9 lines · Darrick J. Wong
Quoted 5 lines · Luis R. Rodriguez
Using #!/usr/bin/env makes some package dependency tools such as rpm complain given that it cannot verify package dependencies. Making it explicit resolves this lint rant.
Signed-off-by Luis R. Rodriguez <[email protected]>Looks ok,
Reviewed-by Darrick J. Wong <[email protected]>
intereting, my rpmbuild actually converts this on the fly. ;) But fine by me to hardcode it if Darrick says ok. :)
Thanks,
-Eric
Quoted 18 lines
--D
Quoted 16 lines
--- scrub/xfs_scrub_all.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)scrub/xfs_scrub_all.in +1
-1@@ -1,4 +1,4 @@ -#!/usr/bin/env python3 +#!/usr/bin/python3 # Run online scrubbers in parallel, but avoid thrashing. #Signature · 1 line
2.16.2
Quoted 8 lines · Eric Sandeen
Quoted 5 lines · Darrick J. Wong
Quoted 4 lines · Luis R. Rodriguez
Using #!/usr/bin/env makes some package dependency tools such as rpm complain given that it cannot verify package dependencies. Making it explicit resolves this lint rant.
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
Signed-off-by Luis R. Rodriguez <[email protected]>Looks ok,
Reviewed-by Darrick J. Wong <[email protected]>intereting, my rpmbuild actually converts this on the fly. ;) But fine by me to hardcode it if Darrick says ok. :)
Just a question though about this.
What if somebody/somedistro installs python3 on another $PATH?
It's been a while since I don't do any packaging stuff, so, I just wonder if this couldn't cause issues on distros using different install paths?
Cheers.
Quoted 25 lines
Thanks,
-EricQuoted 14 lines
--D
Quoted 12 lines
--- scrub/xfs_scrub_all.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)scrub/xfs_scrub_all.in +1
-1@@ -1,4 +1,4 @@ -#!/usr/bin/env python3 +#!/usr/bin/python3Quoted 4 lines
Quoted 4 lines
scrub/xfs_scrub_all.in +0
-0# Run online scrubbers in parallel, but avoid thrashing. #Signature · 1 line
2.16.2--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Signature · 1 line
Carlos
Quoted 18 lines · Carlos Maiolino
Quoted 8 lines · Eric Sandeen
Quoted 5 lines · Darrick J. Wong
Quoted 4 lines · Luis R. Rodriguez
Using #!/usr/bin/env makes some package dependency tools such as rpm complain given that it cannot verify package dependencies. Making it explicit resolves this lint rant.
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
Signed-off-by Luis R. Rodriguez <[email protected]>Looks ok,
Reviewed-by Darrick J. Wong <[email protected]>intereting, my rpmbuild actually converts this on the fly. ;) But fine by me to hardcode it if Darrick says ok. :)
Quoted 6 lines
Just a question though about this.
What if somebody/somedistro installs python3 on another $PATH?
It's been a while since I don't do any packaging stuff, so, I just wonder if this couldn't cause issues on distros using different install paths?
They can always patch in the path to their python3 executable.
Though, given the number of /usr/bin/python3 scripts floating around in Google, I'm guessing a distro would have to have a really good reason to put it elsewhere.
--D
Quoted 30 lines
Cheers.
Quoted 25 lines
Thanks,
-EricQuoted 14 lines
--D
Quoted 12 lines
--- scrub/xfs_scrub_all.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)scrub/xfs_scrub_all.in +1
-1@@ -1,4 +1,4 @@ -#!/usr/bin/env python3 +#!/usr/bin/python3Quoted 4 lines
Quoted 4 lines
scrub/xfs_scrub_all.in +0
-0# Run online scrubbers in parallel, but avoid thrashing. #Signature · 1 line
2.16.2--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.htmlSignature · 1 line
Carlos