Skip to contentSkip to conversation

czmq: bump to version v4.1.0

PATCH New Asaf Kahlon 2 participants 6 messages Feb 24, 2018 – Mar 5, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 czmq: bump to version v4.1.0

---
 package/czmq/czmq.hash | 2 +-
 package/czmq/czmq.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
package/czmq/czmq.hash +1 -1
index 526ea594b9..77fdda0863 100644
@@ -1,2 +1,2 @@
 # Locally calculated
-sha256 5c76de41f736f0c059e0b26174ef99200f2aba2fa38333683dbe4944b2f80555 czmq-5205ec201e97c3a652c17eb86b18b70350b54512.tar.gz
+sha256 2e87c19988d1168b70d7ec0fdce79aba4e92a6330959c3a2576c72b319acb478 czmq-v4.1.0.tar.gz
package/czmq/czmq.mk +1 -1
index 5305789d7a..c9a6b3c66a 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-CZMQ_VERSION = 5205ec201e97c3a652c17eb86b18b70350b54512
+CZMQ_VERSION = v4.1.0
 CZMQ_SITE = $(call github,zeromq,czmq,$(CZMQ_VERSION))
 
 # Autoreconf required as we use the git tree
Signature · 1 line
2.14.1
#1 lore raw

PATCH 1/1 czmq: bump to version v4.1.0

Hi Asaf,

Thank you for your contribution.

Quoted 19 lines · Asaf Kahlon
---
 package/czmq/czmq.hash | 2 +-
 package/czmq/czmq.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
package/czmq/czmq.hash +1 -1
index 526ea594b9..77fdda0863 100644
@@ -1,2 +1,2 @@
 # Locally calculated
-sha256 5c76de41f736f0c059e0b26174ef99200f2aba2fa38333683dbe4944b2f80555 czmq-5205ec201e97c3a652c17eb86b18b70350b54512.tar.gz
+sha256 2e87c19988d1168b70d7ec0fdce79aba4e92a6330959c3a2576c72b319acb478 czmq-v4.1.0.tar.gz
package/czmq/czmq.mk +0 -0
index 5305789d7a..c9a6b3c66a 100644

package/czmq/czmq.mk line 8

Quoted 6 lines
package/czmq/czmq.mk +1 -1
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-CZMQ_VERSION = 5205ec201e97c3a652c17eb86b18b70350b54512
+CZMQ_VERSION = v4.1.0
 CZMQ_SITE = $(call github,zeromq,czmq,$(CZMQ_VERSION))

There is an uploaded tarball for this release [1]. Please use that one instead.
It contains the configure script and the config directory, so no need anymore for CZMQ_AUTORECONF and CZMQ_CREATE_CONFIG_DIR.

Also, there are upstream md5 and sha1 sums, so please add those (with a
reference to the URL containing them). Since we don't consider md5 and sha1 strong enough, you'll have to keep the locally calculated sha256 as well.

Finally, please also add a hash for the license file while you're doing an
update. This will make it easier to detect changes in the license in the future.

Regards,
Arnout

package/czmq/czmq.mk line 10

Quoted 2 lines
package/czmq/czmq.mk +0 -0
 # Autoreconf required as we use the git tree
 

[1] https://github.com/zeromq/czmq/releases/download/v4.1.0/czmq-4.1.0.tar.gz

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
#2 lore raw

PATCH 1/1 czmq: bump to version v4.1.0

Hi Arnout, thanks for the productive comments.
I fixed all, but didn't change CZMQ_AUTORECONF because it seems all the autotools-related files were generated and expect autotools version of 1.14 and can't be compiled with 1.15.
I uploaded a new patch here. Tell me if there's something else you want to change.

---
 package/czmq/czmq.hash |  6 +++++-
 package/czmq/czmq.mk   | 10 ++--------
 2 files changed, 7 insertions(+), 9 deletions(-)
package/czmq/czmq.hash +3 -1
index 526ea594b9..c0a7176f8d 100644
@@ -1,2 +1,6 @@
+# From https://github.com/zeromq/czmq/releases
+md5 d29baef1079f19a2c6a360eb6be984f8 czmq-4.1.0.tar.gz
+sha1 1d201a87205811367f7c92cbbd36a899edda68bf czmq-4.1.0.tar.gz
 # Locally calculated
-sha256 5c76de41f736f0c059e0b26174ef99200f2aba2fa38333683dbe4944b2f80555

czmq-5205ec201e97c3a652c17eb86b18b70350b54512.tar.gz
+sha256 3befa35b4886b5298e8329b4f0aa5bb9bde0e7439bd3c5c53295cb988371fc11 czmq-4.1.0.tar.gz
+sha256 1f256ecad192880510e84ad60474eab7589218784b9a50bc7ceee34c2b91f1d5 LICENCE

package/czmq/czmq.mk +2 -2
index 5305789d7a..3c07845d9c 100644
@@ -4,8 +4,8 @@
 #
 ################################################################################
 
-CZMQ_VERSION = 5205ec201e97c3a652c17eb86b18b70350b54512
-CZMQ_SITE = $(call github,zeromq,czmq,$(CZMQ_VERSION))
+CZMQ_VERSION = 4.1.0
+CZMQ_SITE =

https://github.com/zeromq/czmq/releases/download/v$(CZMQ_VERSION)

# Autoreconf required as we use the git tree
CZMQ_AUTORECONF = YES
@@ -18,10 +18,4 @@ CZMQ_LICENSE_FILES = LICENSE
# host-python, so disable asciidoc entirely.
CZMQ_CONF_ENV = ac_cv_prog_czmq_have_asciidoc=no

-define CZMQ_CREATE_CONFIG_DIR
- mkdir -p $(@D)/config
-endef
-
-CZMQ_POST_PATCH_HOOKS += CZMQ_CREATE_CONFIG_DIR
-
$(eval $(autotools-package))

Signature · 5 lines
2.14.1



On Sat, Feb 24, 2018 at 7:47 PM, Arnout Vandecappelle <[email protected]>
Quoted 57 lines · wrote:

Hi Asaf,

Thank you for your contribution.

package/czmq/czmq.hash line 2

Quoted 13 lines · Asaf Kahlon
---
 package/czmq/czmq.hash | 2 +-
 package/czmq/czmq.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
package/czmq/czmq.hash +0 -1
index 526ea594b9..77fdda0863 100644
@@ -1,2 +1,2 @@
 # Locally calculated
-sha256 5c76de41f736f0c059e0b26174ef99200f2aba2fa38333683dbe4944b2f80555

czmq-5205ec201e97c3a652c17eb86b18b70350b54512.tar.gz

package/czmq/czmq.hash line 2

Quoted 1 line
package/czmq/czmq.hash +1 -0
+sha256 2e87c19988d1168b70d7ec0fdce79aba4e92a6330959c3a2576c72b319acb478

czmq-v4.1.0.tar.gz

package/czmq/czmq.mk line 5

Quoted 7 lines
package/czmq/czmq.mk +0 -0
index 5305789d7a..c9a6b3c66a 100644
@@ -4,7 +4,7 @@
 #
 ############################################################

####################

package/czmq/czmq.mk line 7

Quoted 4 lines
package/czmq/czmq.mk +1 -1
-CZMQ_VERSION = 5205ec201e97c3a652c17eb86b18b70350b54512
+CZMQ_VERSION = v4.1.0
 CZMQ_SITE = $(call github,zeromq,czmq,$(CZMQ_VERSION))

There is an uploaded tarball for this release [1]. Please use that one
instead.
It contains the configure script and the config directory, so no need anymore
for CZMQ_AUTORECONF and CZMQ_CREATE_CONFIG_DIR.

Also, there are upstream md5 and sha1 sums, so please add those (with a
reference to the URL containing them). Since we don't consider md5 and sha1 strong enough, you'll have to keep the locally calculated sha256 as well.

Finally, please also add a hash for the license file while you're doing an
update. This will make it easier to detect changes in the license in the future.

Regards,
Arnout

package/czmq/czmq.mk line 9

Quoted 2 lines
package/czmq/czmq.mk +0 -0
 # Autoreconf required as we use the git tree
 

[1] https://github.com/zeromq/czmq/releases/download/v4.1.0/
czmq-4.1.0.tar.gz
--

Quoted 7 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180226/ee749772/attachment.html>

#3 lore raw

PATCH 1/1 czmq: bump to version v4.1.0

Hi Asaf,

Quoted 4 lines · Asaf Kahlon

Hi Arnout, thanks for the productive comments.
I fixed all, but didn't change CZMQ_AUTORECONF because it seems all the autotools-related files were generated and expect autotools version of 1.14 and can't be compiled with 1.15.

This statement doesn't make sense to me. But I understand why it is needed, see
below.

Quoted 1 line

I uploaded a new patch here. Tell me if there's something else you want to change.

Thank you for that. However, you should still submit it as a proper patch in a
separate e-mail, using git send-email (not just pasting it in a mail). If you send it like this, it gets incorrectly line-wrapped and can't be applied.

Quoted 1 line
Signed-off-by Asaf Kahlon <asafka7 at gmail.com <mailto:[email protected]>>

If you want to keep me in Cc of new versions, you can add here a line:

Cc Arnout Vandecappelle <[email protected]>

and git send-email will also send it to me directly.

Quoted 1 line

---

The additional remarks (i.e. "I fixed all comments, but didn't change...") you
can put directly in the git commit message, here, below the --- line. That way, they will be in the mail but will not be included in the final git history.

Quoted 31 lines

?package/czmq/czmq.hash |? 6 +++++- ?package/czmq/czmq.mk <http://czmq.mk>? ?| 10 ++-------- ?2 files changed, 7 insertions(+), 9 deletions(-)

package/czmq/czmq.hash +3 -0
index 526ea594b9..c0a7176f8d 100644
@@ -1,2 +1,6 @@
+# From https://github.com/zeromq/czmq/releases
+md5 d29baef1079f19a2c6a360eb6be984f8 czmq-4.1.0.tar.gz
+sha1 1d201a87205811367f7c92cbbd36a899edda68bf czmq-4.1.0.tar.gz

?# Locally calculated
-sha256 5c76de41f736f0c059e0b26174ef99200f2aba2fa38333683dbe4944b2f80555 czmq-5205ec201e97c3a652c17eb86b18b70350b54512.tar.gz
+sha256 3befa35b4886b5298e8329b4f0aa5bb9bde0e7439bd3c5c53295cb988371fc11 czmq-4.1.0.tar.gz

package/czmq/czmq.hash +1 -0
+sha256 1f256ecad192880510e84ad60474eab7589218784b9a50bc7ceee34c2b91f1d5 LICENCE
package/czmq/czmq.mk renamed from package/czmq/czmq.mk <http://czmq.mk> +0 -0

<http://czmq.mk>
index 5305789d7a..3c07845d9c 100644

package/czmq/czmq.mk <http://czmq.mk> +0 -0
@@ -4,8 +4,8 @@

?# ?################################################################################ ?

package/czmq/czmq.mk <http://czmq.mk> +2 -2
-CZMQ_VERSION = 5205ec201e97c3a652c17eb86b18b70350b54512
-CZMQ_SITE = $(call github,zeromq,czmq,$(CZMQ_VERSION))
+CZMQ_VERSION = 4.1.0
+CZMQ_SITE = https://github.com/zeromq/czmq/releases/download/v$(CZMQ_VERSION)
Quoted 2 lines

?
?# Autoreconf required as we use the git tree

If autoreconf really is required, then this comment has to change, since now we
are no longer using the git tree but we're using a tarball that does contain the configure script. However, now I see why it is needed. So change this comment into:

# 0001-configure.ac-remove-Werror.patch touches configure.ac

I have made this small modification and applied to next, thanks! So there is no
need to resubmit now.

Regards,
Arnout

Quoted 12 lines

?CZMQ_AUTORECONF = YES

package/czmq/czmq.mk <http://czmq.mk> +0 -0
@@ -18,10 +18,4 @@ CZMQ_LICENSE_FILES = LICENSE

?# host-python, so disable asciidoc entirely.
?CZMQ_CONF_ENV = ac_cv_prog_czmq_have_asciidoc=no
?

package/czmq/czmq.mk <http://czmq.mk> +0 -6
-define CZMQ_CREATE_CONFIG_DIR
-mkdir -p $(@D)/config
-endef
-
-CZMQ_POST_PATCH_HOOKS += CZMQ_CREATE_CONFIG_DIR
-

?$(eval $(autotools-package))

[snip]

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
#4 lore raw

PATCH 1/1 czmq: bump to version v4.1.0

OK, thanks again. Though I still don't see the patch on next... DId you apply it?

Asaf.

Quoted 107 lines · Arnout Vandecappelle

Hi Asaf,

Quoted 3 lines · Asaf Kahlon

Hi Arnout, thanks for the productive comments.
I fixed all, but didn't change CZMQ_AUTORECONF because it seems all the autotools-related files were generated and expect autotools version of

1.14 and

Quoted 1 line

can't be compiled with 1.15.

This statement doesn't make sense to me. But I understand why it is
needed, see
below.

Quoted 1 line

I uploaded a new patch here. Tell me if there's something else you want

to change.

Thank you for that. However, you should still submit it as a proper patch
in a
separate e-mail, using git send-email (not just pasting it in a mail). If you
send it like this, it gets incorrectly line-wrapped and can't be applied.

Quoted 2 lines
Quoted 1 line

If you want to keep me in Cc of new versions, you can add here a line:

Cc Arnout Vandecappelle <[email protected]>

and git send-email will also send it to me directly.

Quoted 1 line

---

The additional remarks (i.e. "I fixed all comments, but didn't
change...") you
can put directly in the git commit message, here, below the --- line. That way,
they will be in the mail but will not be included in the final git history.

Quoted 14 lines
 package/czmq/czmq.hash |  6 +++++-
 package/czmq/czmq.mk <http://czmq.mk>   | 10 ++--------
 2 files changed, 7 insertions(+), 9 deletions(-)
package/czmq/czmq.hash +3 -1
index 526ea594b9..c0a7176f8d 100644
@@ -1,2 +1,6 @@
+# From https://github.com/zeromq/czmq/releases
+md5 d29baef1079f19a2c6a360eb6be984f8 czmq-4.1.0.tar.gz
+sha1 1d201a87205811367f7c92cbbd36a899edda68bf czmq-4.1.0.tar.gz
 # Locally calculated
-sha256 5c76de41f736f0c059e0b26174ef99200f2aba2fa38333683dbe4944b2f80555
Quoted 4 lines

czmq-5205ec201e97c3a652c17eb86b18b70350b54512.tar.gz
+sha256 3befa35b4886b5298e8329b4f0aa5bb9bde0e7439bd3c5c53295cb988371fc11 czmq-4.1.0.tar.gz
+sha256 1f256ecad192880510e84ad60474eab7589218784b9a50bc7ceee34c2b91f1d5

LICENCE

package/czmq/

Quoted 1 line
package/czmq/ renamed from package/czmq/czmq.mk <http://czmq.mk> +0 -0

czmq.mk

package/czmq/czmq.mk <http://czmq.mk> line 5

Quoted 7 lines

<http://czmq.mk>
index 5305789d7a..3c07845d9c 100644

package/czmq/czmq.mk <http://czmq.mk> +0 -0
@@ -4,8 +4,8 @@
 #
 ###########################################################

#####################

package/czmq/czmq.mk <http://czmq.mk> line 7

Quoted 5 lines
package/czmq/czmq.mk <http://czmq.mk> +2 -2
-CZMQ_VERSION = 5205ec201e97c3a652c17eb86b18b70350b54512
-CZMQ_SITE = $(call github,zeromq,czmq,$(CZMQ_VERSION))
+CZMQ_VERSION = 4.1.0
+CZMQ_SITE = https://github.com/zeromq/czmq/releases/download/v$(

CZMQ_VERSION)

package/czmq/czmq.mk <http://czmq.mk> line 8

Quoted 2 lines
package/czmq/czmq.mk <http://czmq.mk> +0 -0
 # Autoreconf required as we use the git tree

If autoreconf really is required, then this comment has to change, since
now we
are no longer using the git tree but we're using a tarball that does contain the
configure script. However, now I see why it is needed. So change this comment into:

# 0001-configure.ac-remove-Werror.patch touches configure.ac

I have made this small modification and applied to next, thanks! So there
is no
need to resubmit now.

Regards,
Arnout

Quoted 12 lines
package/czmq/czmq.mk <http://czmq.mk> +0 -6
 CZMQ_AUTORECONF = YES
@@ -18,10 +18,4 @@ CZMQ_LICENSE_FILES = LICENSE
 # host-python, so disable asciidoc entirely.
 CZMQ_CONF_ENV = ac_cv_prog_czmq_have_asciidoc=no
 
-define CZMQ_CREATE_CONFIG_DIR
-mkdir -p $(@D)/config
-endef
-
-CZMQ_POST_PATCH_HOOKS += CZMQ_CREATE_CONFIG_DIR
-
 $(eval $(autotools-package))

[snip]

Quoted 8 lines

--

Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180304/39dca0ae/attachment.html>

#5 lore raw

PATCH 1/1 czmq: bump to version v4.1.0

Quoted 1 line · Asaf Kahlon

OK, thanks again. Though I still don't see the patch on next... DId you apply it?

Sorry, I forgot to push. Thanks for the reminder, it should be there now.

Regards,
Arnout

[snip]

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF