Skip to contentSkip to conversation

Liblo : Disable werror

PATCH New Alex B 2 participants 3 messages Feb 25, 2018

lore
Share & tools
lore

Alex B

author
#0 lore raw

PATCH 1/2 Liblo : Disable werror

From: Alex <[email protected]>

Fixes :
http://autobuild.buildroot.net/results/61ab7e23d2ef62f055efc74a998e3c108a3cdb43

---
 package/liblo/liblo.mk | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
package/liblo/liblo.mk +4 -1
index 14b0527..c7d163d 100644
@@ -12,6 +12,9 @@ LIBLO_LICENSE_FILES = COPYING
 LIBLO_INSTALL_STAGING = YES
 
 # IPv6 support broken, issue known upstream
-LIBLO_CONF_OPTS = --disable-ipv6
+# werror - not needed for release.
+LIBLO_CONF_OPTS += \
+	--disable-ipv6 \
+	--disable-werror
 
 $(eval $(autotools-package))
Signature · 1 line
2.7.4
author
#1 lore raw

PATCH 2/2 Libo : Link libatomic

From: Alex <[email protected]>

Fixes :
http://autobuild.buildroot.net/results/c8b/c8bed3a3fa7d2b2258f573cbfcb01af07419e0bf/

---
 package/liblo/liblo.mk | 6 ++++++
 1 file changed, 6 insertions(+)
package/liblo/liblo.mk +6 -0
index c7d163d..67cc02c 100644
@@ -17,4 +17,10 @@ LIBLO_CONF_OPTS += \
 	--disable-ipv6 \
 	--disable-werror
 
+# Liblo uses atomics, so we need to link with
+# libatomic for the architectures who explicitly need libatomic.
+ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
+	LIBLO_CONF_ENV += LIBS="-latomic"
+endif
+
 $(eval $(autotools-package))
Signature · 1 line
2.7.4
#2 lore raw

PATCH 1/2 Liblo : Disable werror

In reply to Alex B

Hello,

Quoted 6 lines · Alex B

From: Alex <[email protected]>

Fixes :
http://autobuild.buildroot.net/results/61ab7e23d2ef62f055efc74a998e3c108a3cdb43

I've applied your two patches to next, after fixing a number of minor nits:

- The commit title should be "<package>: <description>", with package in lower-case, and no space before the colon.

- The author and Signed-off-by should have been your full first name + last name, like you did for your previous contributions.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com