Skip to contentSkip to conversation

arm64: dts: ls1046a: drop incomplete memory node

PATCH New Shawn Guo 2 participants 3 messages Feb 24, 2018 – Feb 26, 2018

Subsystems (2)
lore
Share & tools
lore

Shawn Guo

author
#0 lore raw

PATCH 1/1 arm64: dts: ls1046a: drop incomplete memory node

The memory node in fsl-ls1046a.dtsi has no 'reg' property, and causes the dtc warning below.

Warning (unit_address_vs_reg): Node /memory at 80000000 has a unit name, but no reg property

This is clearly an incomplete memory node. Let's drop it. Either a complete memory should be added, or bootloader needs to fill the node as a whole.

Cc Mingkai Hu <[email protected]>
Cc Shaohui Xie <[email protected]>
Cc Li Yang <[email protected]>
---
 arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 4 ----
 1 file changed, 4 deletions(-)
arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi +0 -4
index 606ea496f24e..cbf4b3e15c17 100644
@@ -129,10 +129,6 @@
 		};
 	};
 
-	memory at 80000000 {
-		device_type = "memory";
-	};
-
 	sysclk: sysclk {
 		compatible = "fixed-clock";
 		#clock-cells = <0>;
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 arm64: dts: ls1046a: drop incomplete memory node

Quoted 11 lines

-----Original Message-----
From: Shawn Guo [mailto:shawnguo at kernel.org]
Sent: Saturday, February 24, 2018 3:05 PM
To: linux-arm-kernel at lists.infradead.org
Cc: devicetree at vger.kernel.org; Shawn Guo <[email protected]>; Mingkai Hu <[email protected]>; Shaohui Xie <[email protected]>; Leo Li <[email protected]>
Subject: [PATCH] arm64: dts: ls1046a: drop incomplete memory node

Quoted 8 lines

The memory node in fsl-ls1046a.dtsi has no 'reg' property, and causes the dtc warning below.

Warning (unit_address_vs_reg): Node /memory at 80000000 has a unit name, but no reg property

This is clearly an incomplete memory node. Let's drop it. Either a complete memory should be added, or bootloader needs to fill the node as a whole.

Or we can put in a dummy reg property to be updated by bootloader like the mac-address property?

Quoted 27 lines
Cc Mingkai Hu <[email protected]>
Cc Shaohui Xie <[email protected]>
Cc Li Yang <[email protected]>
---
 arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 4 ----
 1 file changed, 4 deletions(-)
arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi +0 -5
index 606ea496f24e..cbf4b3e15c17 100644
@@ -129,10 +129,6 @@
 		};
 	};
 
-	memory at 80000000 {
-		device_type = "memory";
-	};
-
 	sysclk: sysclk {
 		compatible = "fixed-clock";
 		#clock-cells = <0>;
--

1.9.1

author
#2 lore raw

PATCH 1/1 arm64: dts: ls1046a: drop incomplete memory node

Quoted 14 lines · Leo Li
Quoted 14 lines

-----Original Message-----
From: Shawn Guo [mailto:shawnguo at kernel.org]
Sent: Saturday, February 24, 2018 3:05 PM
To: linux-arm-kernel at lists.infradead.org
Cc: devicetree at vger.kernel.org; Shawn Guo <[email protected]>; Mingkai Hu <[email protected]>; Shaohui Xie <[email protected]>; Leo Li <[email protected]>
Subject: [PATCH] arm64: dts: ls1046a: drop incomplete memory node

The memory node in fsl-ls1046a.dtsi has no 'reg' property, and causes the dtc warning below.

Quoted 7 lines
Quoted 5 lines

Warning (unit_address_vs_reg): Node /memory at 80000000 has a unit name, but no reg property

This is clearly an incomplete memory node. Let's drop it. Either a complete memory should be added, or bootloader needs to fill the node as a whole.

Or we can put in a dummy reg property to be updated by bootloader like the mac-address property?

Yeah, I'm fine with either way, as long as we get rid of the warning. I will post v2 shortly.

Shawn