xen: use hvc console for dom0
Subsystems (2)
Juergen Gross
maintainerPATCH 1/1 xen: use hvc console for dom0
Today the hvc console is added as a preferred console for pv domUs only. As this requires a boot parameter for getting dom0 messages per default add it for dom0, too.
--- arch/x86/xen/enlighten_pv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
arch/x86/xen/enlighten_pv.c +3 -1
@@ -1377,7 +1377,6 @@ asmlinkage __visible void __init xen_start_kernel(void)if (!xen_initial_domain ()) {add_preferred_console ("xenboot" ,0 ,NULL );add_preferred_console ("tty" ,0 ,NULL ); -add_preferred_console ("hvc" ,0 ,NULL );if (pci_xen) x86_init.pci.arch_init = pci_xen_init; }else {
@@ -1410,6 +1409,9 @@ asmlinkage __visible void __init xen_start_kernel(void)xen_boot_params_init_edd (); } + +add_preferred_console ("hvc" ,0 ,NULL ); +#ifdef CONFIG_PCI /* PCI BIOS service won't work from a PV guest. */ pci_probe &= ~PCI_PROBE_BIOS ;
Signature · 1 line
2.13.6
Hello Juergen,
arch/x86/xen/enlighten_pv.c
Quoted 10 lines · Juergen Gross
Today the hvc console is added as a preferred console for pv domUs only. As this requires a boot parameter for getting dom0 messages per default add it for dom0, too.
Signed-off-by Juergen Gross <[email protected]>--- arch/x86/xen/enlighten_pv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)arch/x86/xen/enlighten_pv.c +0
-0
Is this something x86 specific? Could it be a generic approach?
Quoted 21 lines
index
c047f42552e1..d27740a80c5e100644arch/x86/xen/enlighten_pv.c +3
-1@@ -1377,7 +1377,6 @@ asmlinkage __visible void __init xen_start_kernel(void)if (!xen_initial_domain ()) {add_preferred_console ("xenboot" ,0 ,NULL );add_preferred_console ("tty" ,0 ,NULL ); -add_preferred_console ("hvc" ,0 ,NULL );if (pci_xen) x86_init.pci.arch_init = pci_xen_init; }else {@@ -1410,6 +1409,9 @@ asmlinkage __visible void __init xen_start_kernel(void)xen_boot_params_init_edd (); } + +add_preferred_console ("hvc" ,0 ,NULL ); +#ifdef CONFIG_PCI /* PCI BIOS service won't work from a PV guest. */ pci_probe &= ~PCI_PROBE_BIOS ;
Signature · 1 line
*Andrii Anisov*
Juergen Gross
maintainerQuoted 8 lines · Andrii Anisov
Hello Juergen,
Quoted 4 lines · Juergen Gross
Today the hvc console is added as a preferred console for pv domUs only. As this requires a boot parameter for getting dom0 messages per default add it for dom0, too.
Quoted 7 lines
arch/x86/xen/enlighten_pv.c
Quoted 6 lines
Signed-off-by Juergen Gross <[email protected]>---
arch/x86/xen/enlighten_pv.c| 4 +++-1 file changed, 3 insertions(+), 1 deletion(-)arch/x86/xen/enlighten_pv.c +0
-0Is this something x86 specific? Could it be a generic approach?
In case ARM wants something similar I guess the test for xen_initial_domain() should be dropped in xen_early_init().
Stefano?
Juergen
Hi,
Quoted 14 lines · Juergen Gross
Quoted 13 lines · Andrii Anisov
Hello Juergen,
Quoted 9 lines · Juergen Gross
Today the hvc console is added as a preferred console for pv domUs only. As this requires a boot parameter for getting dom0 messages per default add it for dom0, too.
Signed-off-by Juergen Gross <[email protected]>--- arch/x86/xen/enlighten_pv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Quoted 5 lines
Quoted 2 lines
arch/x86/xen/enlighten_pv.c
Quoted 1 line
arch/x86/xen/enlighten_pv.c +0
-0Is this something x86 specific? Could it be a generic approach?
In case ARM wants something similar I guess the test for
xen_initial_domain()should be dropped inxen_early_init().
I am pretty sure we discussed to remove !xen_initial_domain() for Arm in the past. But I don't remember why the patch was not sent to remove it.
Anyway, I guess this should be fine to have hvc as a preferred console for the initial domain as well.
Cheers,
Signature · 1 line
Julien Grall
Quoted 20 lines · Julien Grall
Hi,
Quoted 17 lines · Juergen Gross
Quoted 15 lines · Andrii Anisov
Hello Juergen,
arch/x86/xen/enlighten_pv.c
Quoted 10 lines · Juergen Gross
Today the hvc console is added as a preferred console for pv domUs only. As this requires a boot parameter for getting dom0 messages per default add it for dom0, too.
Signed-off-by Juergen Gross <[email protected]>--- arch/x86/xen/enlighten_pv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)arch/x86/xen/enlighten_pv.c +0
-0Is this something x86 specific? Could it be a generic approach?
Quoted 7 lines
Quoted 2 lines
In case ARM wants something similar I guess the test for
xen_initial_domain()should be dropped inxen_early_init().I am pretty sure we discussed to remove !xen_initial_domain() for Arm in the past. But I don't remember why the patch was not sent to remove it.
Anyway, I guess this should be fine to have hvc as a preferred console for the initial domain as well.
Usually, Dom0 has access to several physical UARTs and/or VGA, making this patch less obviously desirable. I think that for Dom0 the best behavior would be to add "hvc0" as first console rather than last console, so that if the user specified something else, this call won't interfere with it.
Hi,
Quoted 26 lines · Stefano Stabellini
Quoted 25 lines · Julien Grall
Hi,
Quoted 14 lines · Juergen Gross
Quoted 13 lines · Andrii Anisov
Hello Juergen,
Quoted 9 lines · Juergen Gross
Today the hvc console is added as a preferred console for pv domUs only. As this requires a boot parameter for getting dom0 messages per default add it for dom0, too.
Signed-off-by Juergen Gross <[email protected]>--- arch/x86/xen/enlighten_pv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)Quoted 5 lines
Quoted 2 lines
arch/x86/xen/enlighten_pv.c
Quoted 1 line
arch/x86/xen/enlighten_pv.c +0
-0Is this something x86 specific? Could it be a generic approach?
In case ARM wants something similar I guess the test for
xen_initial_domain()should be dropped inxen_early_init().I am pretty sure we discussed to remove !xen_initial_domain() for Arm in the past. But I don't remember why the patch was not sent to remove it.
Quoted 8 lines
Quoted 2 lines
Anyway, I guess this should be fine to have hvc as a preferred console for the initial domain as well.
Usually, Dom0 has access to several physical UARTs and/or VGA, making this patch less obviously desirable. I think that for Dom0 the best behavior would be to add "hvc0" as first console rather than last console, so that if the user specified something else, this call won't interfere with it.
Well, that's exactly the goal of add_preferred_console. It will use hvc0 unless specified otherwise by the user on the command line.
Cheers,
Signature · 1 line
Julien Grall
Juergen Gross
maintainerQuoted 35 lines · Julien Grall
Hi,
Quoted 32 lines · Stefano Stabellini
Quoted 30 lines · Julien Grall
Hi,
Quoted 14 lines · Juergen Gross
Quoted 13 lines · Andrii Anisov
Hello Juergen,
Quoted 9 lines · Juergen Gross
Today the hvc console is added as a preferred console for pv domUs only. As this requires a boot parameter for getting dom0 messages per default add it for dom0, too.
Signed-off-by Juergen Gross <[email protected]>---
arch/x86/xen/enlighten_pv.c| 4 +++-1 file changed, 3 insertions(+), 1 deletion(-)Quoted 6 lines
Quoted 3 lines
arch/x86/xen/enlighten_pv.c
Quoted 2 lines
arch/x86/xen/enlighten_pv.c +0
-0Is this something x86 specific? Could it be a generic approach?
In case ARM wants something similar I guess the test for
xen_initial_domain()should be dropped inxen_early_init().I am pretty sure we discussed to remove !xen_initial_domain() for Arm in the
past. But I don't remember why the patch was not sent to remove it.Anyway, I guess this should be fine to have hvc as a preferred console for the
initial domain as well.
Quoted 8 lines
Quoted 5 lines
Usually, Dom0 has access to several physical UARTs and/or VGA, making this patch less obviously desirable. I think that for Dom0 the best behavior would be to add "hvc0" as first console rather than last console, so that if the user specified something else, this call won't interfere with it.
Well, that's exactly the goal of
add_preferred_console. It will use hvc0 unless specified otherwise by the user on the command line.
I suggest someone who can test it should post a patch for ARM.
Juergen
Juergen Gross
maintainerQuoted 35 lines · Julien Grall
Hi,
Quoted 32 lines · Stefano Stabellini
Quoted 30 lines · Julien Grall
Hi,
Quoted 14 lines · Juergen Gross
Quoted 13 lines · Andrii Anisov
Hello Juergen,
Quoted 9 lines · Juergen Gross
Today the hvc console is added as a preferred console for pv domUs only. As this requires a boot parameter for getting dom0 messages per default add it for dom0, too.
Signed-off-by Juergen Gross <[email protected]>---
arch/x86/xen/enlighten_pv.c| 4 +++-1 file changed, 3 insertions(+), 1 deletion(-)Quoted 6 lines
Quoted 3 lines
arch/x86/xen/enlighten_pv.c
Quoted 2 lines
arch/x86/xen/enlighten_pv.c +0
-0Is this something x86 specific? Could it be a generic approach?
In case ARM wants something similar I guess the test for
xen_initial_domain()should be dropped inxen_early_init().I am pretty sure we discussed to remove !xen_initial_domain() for Arm in the
past. But I don't remember why the patch was not sent to remove it.Anyway, I guess this should be fine to have hvc as a preferred console for the
initial domain as well.
Quoted 8 lines
Quoted 5 lines
Usually, Dom0 has access to several physical UARTs and/or VGA, making this patch less obviously desirable. I think that for Dom0 the best behavior would be to add "hvc0" as first console rather than last console, so that if the user specified something else, this call won't interfere with it.
Well, that's exactly the goal of
add_preferred_console. It will use hvc0 unless specified otherwise by the user on the command line.
I suggest someone who can test it should post a patch for ARM.
Juergen
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Hi,
Quoted 26 lines · Stefano Stabellini
Quoted 25 lines · Julien Grall
Hi,
Quoted 14 lines · Juergen Gross
Quoted 13 lines · Andrii Anisov
Hello Juergen,
Quoted 9 lines · Juergen Gross
Today the hvc console is added as a preferred console for pv domUs only. As this requires a boot parameter for getting dom0 messages per default add it for dom0, too.
Signed-off-by Juergen Gross <[email protected]>--- arch/x86/xen/enlighten_pv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)Quoted 5 lines
Quoted 2 lines
arch/x86/xen/enlighten_pv.c
Quoted 1 line
arch/x86/xen/enlighten_pv.c +0
-0Is this something x86 specific? Could it be a generic approach?
In case ARM wants something similar I guess the test for
xen_initial_domain()should be dropped inxen_early_init().I am pretty sure we discussed to remove !xen_initial_domain() for Arm in the past. But I don't remember why the patch was not sent to remove it.
Quoted 8 lines
Quoted 2 lines
Anyway, I guess this should be fine to have hvc as a preferred console for the initial domain as well.
Usually, Dom0 has access to several physical UARTs and/or VGA, making this patch less obviously desirable. I think that for Dom0 the best behavior would be to add "hvc0" as first console rather than last console, so that if the user specified something else, this call won't interfere with it.
Well, that's exactly the goal of add_preferred_console. It will use hvc0 unless specified otherwise by the user on the command line.
Cheers,
Signature · 6 lines
Julien Grall _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 20 lines · Julien Grall
Hi,
Quoted 17 lines · Juergen Gross
Quoted 15 lines · Andrii Anisov
Hello Juergen,
arch/x86/xen/enlighten_pv.c
Quoted 10 lines · Juergen Gross
Today the hvc console is added as a preferred console for pv domUs only. As this requires a boot parameter for getting dom0 messages per default add it for dom0, too.
Signed-off-by Juergen Gross <[email protected]>--- arch/x86/xen/enlighten_pv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)arch/x86/xen/enlighten_pv.c +0
-0Is this something x86 specific? Could it be a generic approach?
Quoted 7 lines
Quoted 2 lines
In case ARM wants something similar I guess the test for
xen_initial_domain()should be dropped inxen_early_init().I am pretty sure we discussed to remove !xen_initial_domain() for Arm in the past. But I don't remember why the patch was not sent to remove it.
Anyway, I guess this should be fine to have hvc as a preferred console for the initial domain as well.
Usually, Dom0 has access to several physical UARTs and/or VGA, making this patch less obviously desirable. I think that for Dom0 the best behavior would be to add "hvc0" as first console rather than last console, so that if the user specified something else, this call won't interfere with it.
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Hi,
Quoted 14 lines · Juergen Gross
Quoted 13 lines · Andrii Anisov
Hello Juergen,
Quoted 9 lines · Juergen Gross
Today the hvc console is added as a preferred console for pv domUs only. As this requires a boot parameter for getting dom0 messages per default add it for dom0, too.
Signed-off-by Juergen Gross <[email protected]>--- arch/x86/xen/enlighten_pv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Quoted 5 lines
Quoted 2 lines
arch/x86/xen/enlighten_pv.c
Quoted 1 line
arch/x86/xen/enlighten_pv.c +0
-0Is this something x86 specific? Could it be a generic approach?
In case ARM wants something similar I guess the test for
xen_initial_domain()should be dropped inxen_early_init().
I am pretty sure we discussed to remove !xen_initial_domain() for Arm in the past. But I don't remember why the patch was not sent to remove it.
Anyway, I guess this should be fine to have hvc as a preferred console for the initial domain as well.
Cheers,
Signature · 6 lines
Julien Grall _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
Juergen Gross
maintainerQuoted 8 lines · Andrii Anisov
Hello Juergen,
Quoted 4 lines · Juergen Gross
Today the hvc console is added as a preferred console for pv domUs only. As this requires a boot parameter for getting dom0 messages per default add it for dom0, too.
Quoted 7 lines
arch/x86/xen/enlighten_pv.c
Quoted 6 lines
Signed-off-by Juergen Gross <[email protected]>---
arch/x86/xen/enlighten_pv.c| 4 +++-1 file changed, 3 insertions(+), 1 deletion(-)arch/x86/xen/enlighten_pv.c +0
-0Is this something x86 specific? Could it be a generic approach?
In case ARM wants something similar I guess the test for xen_initial_domain() should be dropped in xen_early_init().
Stefano?
Juergen
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Hello Juergen,
arch/x86/xen/enlighten_pv.c
Quoted 10 lines · Juergen Gross
Today the hvc console is added as a preferred console for pv domUs only. As this requires a boot parameter for getting dom0 messages per default add it for dom0, too.
Signed-off-by Juergen Gross <[email protected]>--- arch/x86/xen/enlighten_pv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)arch/x86/xen/enlighten_pv.c +0
-0
Is this something x86 specific? Could it be a generic approach?
Quoted 21 lines
index
c047f42552e1..d27740a80c5e100644arch/x86/xen/enlighten_pv.c +3
-1@@ -1377,7 +1377,6 @@ asmlinkage __visible void __init xen_start_kernel(void)if (!xen_initial_domain ()) {add_preferred_console ("xenboot" ,0 ,NULL );add_preferred_console ("tty" ,0 ,NULL ); -add_preferred_console ("hvc" ,0 ,NULL );if (pci_xen) x86_init.pci.arch_init = pci_xen_init; }else {@@ -1410,6 +1409,9 @@ asmlinkage __visible void __init xen_start_kernel(void)xen_boot_params_init_edd (); } + +add_preferred_console ("hvc" ,0 ,NULL ); +#ifdef CONFIG_PCI /* PCI BIOS service won't work from a PV guest. */ pci_probe &= ~PCI_PROBE_BIOS ;
Signature · 8 lines
*Andrii Anisov* _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
Boris Ostrovsky
reviewerQuoted 22 lines · Juergen Gross
Today the hvc console is added as a preferred console for pv domUs only. As this requires a boot parameter for getting dom0 messages per default add it for dom0, too.
Signed-off-by Juergen Gross <[email protected]>--- arch/x86/xen/enlighten_pv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)arch/x86/xen/enlighten_pv.c +0
-1@@ -1377,7 +1377,6 @@ asmlinkage __visible void __init xen_start_kernel(void)if (!xen_initial_domain ()) {add_preferred_console ("xenboot" ,0 ,NULL );add_preferred_console ("tty" ,0 ,NULL ); -add_preferred_console ("hvc" ,0 ,NULL );if (pci_xen) x86_init.pci.arch_init = pci_xen_init; }else {
arch/x86/xen/enlighten_pv.c asmlinkage __visible void __init xen_start_kernel(void) · line 1414
Quoted 6 lines
arch/x86/xen/enlighten_pv.c +3
-0@@ -1410,6 +1409,9 @@ asmlinkage __visible void __init xen_start_kernel(void)xen_boot_params_init_edd (); } + +add_preferred_console ("hvc" ,0 ,NULL ); +
Won't this prevent dom0 output from showing up on vga console by default?
-boris
Quoted 3 lines
arch/x86/xen/enlighten_pv.c +0
-0#ifdef CONFIG_PCI /* PCI BIOS service won't work from a PV guest. */ pci_probe &= ~PCI_PROBE_BIOS ;
Juergen Gross
maintainerQuoted 24 lines · Boris Ostrovsky
Quoted 23 lines · Juergen Gross
Today the hvc console is added as a preferred console for pv domUs only. As this requires a boot parameter for getting dom0 messages per default add it for dom0, too.
Signed-off-by Juergen Gross <[email protected]>--- arch/x86/xen/enlighten_pv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)arch/x86/xen/enlighten_pv.c +0
-1@@ -1377,7 +1377,6 @@ asmlinkage __visible void __init xen_start_kernel(void)if (!xen_initial_domain ()) {add_preferred_console ("xenboot" ,0 ,NULL );add_preferred_console ("tty" ,0 ,NULL ); -add_preferred_console ("hvc" ,0 ,NULL );if (pci_xen) x86_init.pci.arch_init = pci_xen_init; }else {@@ -1410,6 +1409,9 @@ asmlinkage __visible void __init xen_start_kernel(void)
Quoted 7 lines
arch/x86/xen/enlighten_pv.c asmlinkage __visible void __init xen_start_kernel(void) · line 1414
Quoted 5 lines
arch/x86/xen/enlighten_pv.c +3
-0xen_boot_params_init_edd (); } + +add_preferred_console ("hvc" ,0 ,NULL ); +Won't this prevent dom0 output from showing up on vga console by default?
Right, we need to add "tty", too.
Will send V2.
Juergen
Juergen Gross
maintainerQuoted 24 lines · Boris Ostrovsky
Quoted 23 lines · Juergen Gross
Today the hvc console is added as a preferred console for pv domUs only. As this requires a boot parameter for getting dom0 messages per default add it for dom0, too.
Signed-off-by Juergen Gross <[email protected]>--- arch/x86/xen/enlighten_pv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)arch/x86/xen/enlighten_pv.c +0
-1@@ -1377,7 +1377,6 @@ asmlinkage __visible void __init xen_start_kernel(void)if (!xen_initial_domain ()) {add_preferred_console ("xenboot" ,0 ,NULL );add_preferred_console ("tty" ,0 ,NULL ); -add_preferred_console ("hvc" ,0 ,NULL );if (pci_xen) x86_init.pci.arch_init = pci_xen_init; }else {@@ -1410,6 +1409,9 @@ asmlinkage __visible void __init xen_start_kernel(void)
Quoted 7 lines
arch/x86/xen/enlighten_pv.c asmlinkage __visible void __init xen_start_kernel(void) · line 1414
Quoted 5 lines
arch/x86/xen/enlighten_pv.c +3
-0xen_boot_params_init_edd (); } + +add_preferred_console ("hvc" ,0 ,NULL ); +Won't this prevent dom0 output from showing up on vga console by default?
Right, we need to add "tty", too.
Will send V2.
Juergen
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Boris Ostrovsky
reviewerQuoted 22 lines · Juergen Gross
Today the hvc console is added as a preferred console for pv domUs only. As this requires a boot parameter for getting dom0 messages per default add it for dom0, too.
Signed-off-by Juergen Gross <[email protected]>--- arch/x86/xen/enlighten_pv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)arch/x86/xen/enlighten_pv.c +0
-1@@ -1377,7 +1377,6 @@ asmlinkage __visible void __init xen_start_kernel(void)if (!xen_initial_domain ()) {add_preferred_console ("xenboot" ,0 ,NULL );add_preferred_console ("tty" ,0 ,NULL ); -add_preferred_console ("hvc" ,0 ,NULL );if (pci_xen) x86_init.pci.arch_init = pci_xen_init; }else {
arch/x86/xen/enlighten_pv.c asmlinkage __visible void __init xen_start_kernel(void) · line 1414
Quoted 6 lines
arch/x86/xen/enlighten_pv.c +3
-0@@ -1410,6 +1409,9 @@ asmlinkage __visible void __init xen_start_kernel(void)xen_boot_params_init_edd (); } + +add_preferred_console ("hvc" ,0 ,NULL ); +
Won't this prevent dom0 output from showing up on vga console by default?
-boris
arch/x86/xen/enlighten_pv.c asmlinkage __visible void __init xen_start_kernel(void) · line 1417
Quoted 3 lines
arch/x86/xen/enlighten_pv.c +0
-0#ifdef CONFIG_PCI /* PCI BIOS service won't work from a PV guest. */ pci_probe &= ~PCI_PROBE_BIOS ;
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel