Skip to contentSkip to conversation

v4.16-rc0: missing includes in framebuffers break N900 compilation

PATCH Pavel Machek 2 participants 3 messages Feb 26, 2018 – Mar 2, 2018

Subsystems (2)
Framebuffer layer OMAP display subsystem and framebuffer support (DSS2)
lore
Share & tools
lore

Pavel Machek

author
#0 lore raw

I needed this to get -rc0 to compile.

Signed-off-by Pavel Machek <[email protected]>
drivers/video/fbdev/omap2/omapfb/dss/dss.c +1 -0
index 48c6500..990f1c9 100644
@@ -38,6 +38,7 @@
 #include <linux/regmap.h>
 #include <linux/of.h>
 #include <linux/regulator/consumer.h>
+#include <linux/pinctrl/consumer.h>
 #include <linux/suspend.h>
 #include <linux/component.h>
drivers/video/fbdev/omap2/omapfb/dss/hdmi_phy.c +1 -0
index 9a13c35..4862b12 100644
@@ -12,6 +12,7 @@
 #include <linux/err.h>
 #include <linux/io.h>
 #include <linux/platform_device.h>
+#include <linux/seq_file.h>
 #include <linux/slab.h>
 #include <video/omapfb_dss.h>
drivers/video/fbdev/omap2/omapfb/dss/hdmi_pll.c +1 -0
index eac3665..39014e2 100644
@@ -15,6 +15,7 @@
 #include <linux/err.h>
 #include <linux/io.h>
 #include <linux/platform_device.h>
+#include <linux/seq_file.h>
 #include <linux/clk.h>
 
 #include <video/omapfb_dss.h>
drivers/video/fbdev/omap2/omapfb/dss/hdmi_wp.c +1 -0
index 705373e..e93e7a7 100644
@@ -15,6 +15,7 @@
 #include <linux/io.h>
 #include <linux/platform_device.h>
 #include <video/omapfb_dss.h>
+#include <linux/seq_file.h>
 
 #include "dss.h"
 #include "hdmi.h"
Signature · 9 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180226/76cf8121/attachment.sig>
#1 lore raw

v4.16-rc1 has a fix (b9058afcd6c7).

Tomi

Quoted 54 lines · Pavel Machek

I needed this to get -rc0 to compile.

Signed-off-by Pavel Machek <[email protected]>
drivers/video/fbdev/omap2/omapfb/dss/dss.c +1 -0
index 48c6500..990f1c9 100644
@@ -38,6 +38,7 @@
 #include <linux/regmap.h>
 #include <linux/of.h>
 #include <linux/regulator/consumer.h>
+#include <linux/pinctrl/consumer.h>
 #include <linux/suspend.h>
 #include <linux/component.h>
drivers/video/fbdev/omap2/omapfb/dss/hdmi_phy.c +1 -0
index 9a13c35..4862b12 100644
@@ -12,6 +12,7 @@
 #include <linux/err.h>
 #include <linux/io.h>
 #include <linux/platform_device.h>
+#include <linux/seq_file.h>
 #include <linux/slab.h>
 #include <video/omapfb_dss.h>
drivers/video/fbdev/omap2/omapfb/dss/hdmi_pll.c +1 -0
index eac3665..39014e2 100644
@@ -15,6 +15,7 @@
 #include <linux/err.h>
 #include <linux/io.h>
 #include <linux/platform_device.h>
+#include <linux/seq_file.h>
 #include <linux/clk.h>
 
 #include <video/omapfb_dss.h>
drivers/video/fbdev/omap2/omapfb/dss/hdmi_wp.c +1 -0
index 705373e..e93e7a7 100644
@@ -15,6 +15,7 @@
 #include <linux/io.h>
 #include <linux/platform_device.h>
 #include <video/omapfb_dss.h>
+#include <linux/seq_file.h>
 
 #include "dss.h"
 #include "hdmi.h"
Signature · 2 lines
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
author
#2 lore raw
Quoted 1 line · Tomi Valkeinen

v4.16-rc1 has a fix (b9058afcd6c7).

Yep, thanks. I was bisecting sound problem on N900, so this hit me...

Pavel

Quoted 56 lines · Pavel Machek
Quoted 54 lines

I needed this to get -rc0 to compile.

Signed-off-by Pavel Machek <[email protected]>
drivers/video/fbdev/omap2/omapfb/dss/dss.c +1 -0
index 48c6500..990f1c9 100644
@@ -38,6 +38,7 @@
 #include <linux/regmap.h>
 #include <linux/of.h>
 #include <linux/regulator/consumer.h>
+#include <linux/pinctrl/consumer.h>
 #include <linux/suspend.h>
 #include <linux/component.h>
drivers/video/fbdev/omap2/omapfb/dss/hdmi_phy.c +1 -0
index 9a13c35..4862b12 100644
@@ -12,6 +12,7 @@
 #include <linux/err.h>
 #include <linux/io.h>
 #include <linux/platform_device.h>
+#include <linux/seq_file.h>
 #include <linux/slab.h>
 #include <video/omapfb_dss.h>
drivers/video/fbdev/omap2/omapfb/dss/hdmi_pll.c +1 -0
index eac3665..39014e2 100644
@@ -15,6 +15,7 @@
 #include <linux/err.h>
 #include <linux/io.h>
 #include <linux/platform_device.h>
+#include <linux/seq_file.h>
 #include <linux/clk.h>
 
 #include <video/omapfb_dss.h>
drivers/video/fbdev/omap2/omapfb/dss/hdmi_wp.c +1 -0
index 705373e..e93e7a7 100644
@@ -15,6 +15,7 @@
 #include <linux/io.h>
 #include <linux/platform_device.h>
 #include <video/omapfb_dss.h>
+#include <linux/seq_file.h>
 
 #include "dss.h"
 #include "hdmi.h"
Signature · 9 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180302/5c8e9edc/attachment-0001.sig>