Skip to contentSkip to conversation

genirq: Add wakeup sysfs node to show IRQ wakeup state

PATCH In review Andy Shevchenko 3 participants 3 messages Feb 26, 2018 – Feb 28, 2018 IRQ

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 genirq: Add wakeup sysfs node to show IRQ wakeup state

Surprisingly there is no simple way to see if the IRQ line in question is wakeup source or not.

Note that wakeup might be an OOB (out-of-band) source like GPIO line which makes things slightly more complicated.

Add a sysfs node to cover this case.

---
 Documentation/ABI/testing/sysfs-kernel-irq |  7 +++++++
 kernel/irq/irqdesc.c                       | 17 +++++++++++++++++
 2 files changed, 24 insertions(+)
Documentation/ABI/testing/sysfs-kernel-irq +7 -0
index eb074b100986..8910d0c4bcd8 100644
@@ -51,3 +51,10 @@ Date:		September 2016
 KernelVersion:	4.9
 Contact:	Craig Gallek <[email protected]>
 Description:	The type of the interrupt.  Either the string 'level' or 'edge'.
+
+What:		/sys/kernel/irq/<irq>/wakeup
+Date:		March 2018
+KernelVersion:	4.17
+Contact:	Andy Shevchenko <[email protected]>
+Description:	The wakeup state of the interrupt. Either the string
+		'enabled' or 'disabled'.
kernel/irq/irqdesc.c +17 -0
index 49b54e9979cc..d9ded088d336 100644
@@ -210,6 +210,22 @@ static ssize_t type_show(struct kobject *kobj,
 }
 IRQ_ATTR_RO(type);
 
+static ssize_t wakeup_show(struct kobject *kobj,
+			   struct kobj_attribute *attr, char *buf)
+{
+	struct irq_desc *desc = container_of(kobj, struct irq_desc, kobj);
+	ssize_t ret = 0;
+
+	raw_spin_lock_irq(&desc->lock);
+	ret = sprintf(buf, "%s\n",
+		      irqd_is_wakeup_set(&desc->irq_data) ? "enabled" : "disabled");
+	raw_spin_unlock_irq(&desc->lock);
+
+	return ret;
+
+}
+IRQ_ATTR_RO(wakeup);
+
 static ssize_t name_show(struct kobject *kobj,
 			 struct kobj_attribute *attr, char *buf)
 {
@@ -253,6 +269,7 @@ static struct attribute *irq_attrs[] = {
 	&chip_name_attr.attr,
 	&hwirq_attr.attr,
 	&type_attr.attr,
+	&wakeup_attr.attr,
 	&name_attr.attr,
 	&actions_attr.attr,
 	NULL
Signature · 1 line
2.16.1
#2 lore raw
In reply to Andy Shevchenko
genirq: Add wakeup sysfs node to show IRQ wakeup state
Commit-ID:  d61e2944b6364006e3d7a0152aaafda741c8c876
Gitweb:     https://git.kernel.org/tip/d61e2944b6364006e3d7a0152aaafda741c8c876
Author:     Andy Shevchenko <[email protected]>
AuthorDate: Mon, 26 Feb 2018 17:50:43 +0200
Committer:  Thomas Gleixner <[email protected]>
CommitDate: Wed, 28 Feb 2018 18:07:20 +0100

genirq: Add wakeup sysfs node to show IRQ wakeup state

Surprisingly there is no simple way to see if the IRQ line in question is wakeup source or not.

Note that wakeup might be an OOB (out-of-band) source like GPIO line which makes things slightly more complicated.

Add a sysfs node to cover this case.

---
 Documentation/ABI/testing/sysfs-kernel-irq |  7 +++++++
 kernel/irq/irqdesc.c                       | 17 +++++++++++++++++
 2 files changed, 24 insertions(+)
Documentation/ABI/testing/sysfs-kernel-irq +7 -0
index eb074b100986..8910d0c4bcd8 100644
@@ -51,3 +51,10 @@ Date:		September 2016
 KernelVersion:	4.9
 Contact:	Craig Gallek <[email protected]>
 Description:	The type of the interrupt.  Either the string 'level' or 'edge'.
+
+What:		/sys/kernel/irq/<irq>/wakeup
+Date:		March 2018
+KernelVersion:	4.17
+Contact:	Andy Shevchenko <[email protected]>
+Description:	The wakeup state of the interrupt. Either the string
+		'enabled' or 'disabled'.
kernel/irq/irqdesc.c +17 -0
index 49b54e9979cc..d9ded088d336 100644
@@ -210,6 +210,22 @@ static ssize_t type_show(struct kobject *kobj,
 }
 IRQ_ATTR_RO(type);
 
+static ssize_t wakeup_show(struct kobject *kobj,
+			   struct kobj_attribute *attr, char *buf)
+{
+	struct irq_desc *desc = container_of(kobj, struct irq_desc, kobj);
+	ssize_t ret = 0;
+
+	raw_spin_lock_irq(&desc->lock);
+	ret = sprintf(buf, "%s\n",
+		      irqd_is_wakeup_set(&desc->irq_data) ? "enabled" : "disabled");
+	raw_spin_unlock_irq(&desc->lock);
+
+	return ret;
+
+}
+IRQ_ATTR_RO(wakeup);
+
 static ssize_t name_show(struct kobject *kobj,
 			 struct kobj_attribute *attr, char *buf)
 {
@@ -253,6 +269,7 @@ static struct attribute *irq_attrs[] = {
 	&chip_name_attr.attr,
 	&hwirq_attr.attr,
 	&type_attr.attr,
+	&wakeup_attr.attr,
 	&name_attr.attr,
 	&actions_attr.attr,
 	NULL