dpaa: Augment linker line to include needed libraries for dpaa
PATCH 1/1 dpaa: Augment linker line to include needed libraries for dpaa
When preforming a shared library build, if the dpaa pmd is configured, the build fails when linking testpmd. This occurs because the makefile fails to include dependent libraries dpaa_mempool and dpaa_bus.
Fix is to simply include them in the makefile. We could perhaps fix this more generally by using the copy-dt-needed-entries linker option, but doing so has a significant effect on link order, which may be undesireable. Given this is fairly isolated, and that we have precident for this (see rte.app.mk), just add the needed libraries for this specific app
--- app/test-pmd/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
app/test-pmd/Makefile +1 -1
@@ -45,7 +45,7 @@ LDLIBS += -lrte_pmd_bond endif ifeq ($(CONFIG_RTE_LIBRTE_DPAA_PMD),y) -LDLIBS += -lrte_pmd_dpaa +LDLIBS += -lrte_pmd_dpaa -lrte_bus_dpaa -lrte_mempool_dpaa endif ifeq ($(CONFIG_RTE_LIBRTE_IXGBE_PMD),y)
Signature · 1 line
2.14.3
HI Neil,
Thanks for the patch. This issue was identified and fixed in the following patches (yet to be merged)
V1:http://dpdk.org/dev/patchwork/patch/35366/
V2: http://dpdk.org/dev/patchwork/patch/35369/
Regards,
Hemant
Quoted 43 lines
-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of Neil Horman
Sent: Tuesday, February 27, 2018 12:50 AM
To: [email protected]
Cc: Neil Horman <[email protected]>; Thomas Monjalon <[email protected]>; Ferruh Yigit <[email protected]>; Hemant Agrawal <[email protected]>
Subject: [dpdk-dev] [PATCH] dpaa: Augment linker line to include needed libraries for dpaa
Importance: HighWhen preforming a shared library build, if the dpaa pmd is configured, the build fails when linking testpmd. This occurs because the makefile fails to include dependent libraries
dpaa_mempoolanddpaa_bus.Fix is to simply include them in the makefile. We could perhaps fix this more generally by using the copy-dt-needed-entries linker option, but doing so has a significant effect on link order, which may be undesireable. Given this is fairly isolated, and that we have precident for this (see rte.app.mk), just add the needed libraries for this specific app
Signed-off-by Neil Horman <[email protected]>CC Thomas Monjalon <[email protected]>CC Ferruh Yigit <[email protected]>CC Hemant Agrawal <[email protected]>--- app/test-pmd/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)app/test-pmd/Makefile index renamed from app/test-pmd/Makefile +0
-0
ed588ab6d..77a02ca0d100644app/test-pmd/Makefile +1
-2@@ -45,7 +45,7 @@ LDLIBS += -lrte_pmd_bond endif ifeq ($(CONFIG_RTE_LIBRTE_DPAA_PMD),y) -LDLIBS += -lrte_pmd_dpaa +LDLIBS += -lrte_pmd_dpaa -lrte_bus_dpaa -lrte_mempool_dpaa endif ifeq ($(CONFIG_RTE_LIBRTE_IXGBE_PMD),y) --2.14.3