Skip to contentSkip to conversation

perf top: Fix annoying fallback message on older kernel

PATCH Applied [email protected] 4 participants 5 messages Feb 26, 2018 – Mar 7, 2018 perf events

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 perf top: Fix annoying fallback message on older kernel

From: Kan Liang <[email protected]>

On older (v4.4) kernels, the annoying fallback message can be observed in 'perf top'.

The 'perf top' has been changed to overwrite mode since 'commit ebebbf082357 ("perf top: Switch default mode to overwrite mode")' For the older kernels which don't have overwrite mode support, the 'perf top' will fall back to non-overwrite mode and print out the fallback message by ui__warning, which needs user's input to close.

The fallback message is not critical message for end users. Turning it to debug message which is printed when running with -vv.

Fixes ebebbf082357 ("perf top: Switch default mode to overwrite mode")
---
 tools/perf/builtin-top.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/builtin-top.c +1 -1
index b7c823b..35ac016 100644
@@ -991,7 +991,7 @@ static int perf_top_overwrite_fallback(struct perf_top *top,
 	evlist__for_each_entry(evlist, counter)
 		counter->attr.write_backward = false;
 	opts->overwrite = false;
-	ui__warning("fall back to non-overwrite mode\n");
+	pr_debug2("fall back to non-overwrite mode\n");
 	return 1;
 }
 
Signature · 1 line
2.7.4
maintainer Applied
#1 lore raw

Em Mon, Feb 26, 2018 at 10:17:10AM -0800, [email protected] escreveu:

Quoted 5 lines

The fallback message is not critical message for end users. Turning it to debug message which is printed when running with -vv.

Fixes ebebbf082357 ("perf top: Switch default mode to overwrite mode")

Thanks, applied.

- Arnaldo

#2 lore raw
In reply to [email protected]
Quoted 26 lines · * [email protected] <[email protected]> wrote:

From: Kan Liang <[email protected]>

On older (v4.4) kernels, the annoying fallback message can be observed in 'perf top'.

The 'perf top' has been changed to overwrite mode since 'commit ebebbf082357 ("perf top: Switch default mode to overwrite mode")' For the older kernels which don't have overwrite mode support, the 'perf top' will fall back to non-overwrite mode and print out the fallback message by ui__warning, which needs user's input to close.

The fallback message is not critical message for end users. Turning it to debug message which is printed when running with -vv.

Fixes ebebbf082357 ("perf top: Switch default mode to overwrite mode")
---
 tools/perf/builtin-top.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/builtin-top.c +0 -0
index b7c823b..35ac016 100644

tools/perf/builtin-top.c static int perf_top_overwrite_fallback(struct perf_top *top, · line 996

Quoted 7 lines
tools/perf/builtin-top.c +1 -1
@@ -991,7 +991,7 @@ static int perf_top_overwrite_fallback(struct perf_top *top,
 	evlist__for_each_entry(evlist, counter)
 		counter->attr.write_backward = false;
 	opts->overwrite = false;
-	ui__warning("fall back to non-overwrite mode\n");
+	pr_debug2("fall back to non-overwrite mode\n");
 	return 1;
 }

Thanks!

Ingo

#3 lore raw

[tip:perf/core] perf top: Fix annoying fallback message on older kernels

In reply to [email protected]
perf top: Fix annoying fallback message on older kernels
Commit-ID:  853745f5e6d95faaae6381c9a01dbd43de992fb3
Gitweb:     https://git.kernel.org/tip/853745f5e6d95faaae6381c9a01dbd43de992fb3
Author:     Kan Liang <[email protected]>
AuthorDate: Mon, 26 Feb 2018 10:17:10 -0800
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Mon, 26 Feb 2018 16:04:08 -0300

perf top: Fix annoying fallback message on older kernels

On older (e.g. v4.4) kernels, an annoying fallback message can be observed in 'perf top':

	┌─Warning:──────────────────────┐
	│fall back to non-overwrite mode│
	│                               │
	│                               │
	│Press any key...               │
	└───────────────────────────────┘

The 'perf top' utility has been changed to overwrite mode since commit ebebbf082357 ("perf top: Switch default mode to overwrite mode").

For older kernels which don't have overwrite mode support, 'perf top' will fall back to non-overwrite mode and print out the fallback message using ui__warning(), which needs user's input to close.

The fallback message is not critical for end users. Turning it to debug message which is printed when running with -vv.

Cc Kan Liang <[email protected]>
Fixes ebebbf082357 ("perf top: Switch default mode to overwrite mode")
---
 tools/perf/builtin-top.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/builtin-top.c +1 -1
index b7c823ba8374..35ac016fcb98 100644
@@ -991,7 +991,7 @@ static int perf_top_overwrite_fallback(struct perf_top *top,
 	evlist__for_each_entry(evlist, counter)
 		counter->attr.write_backward = false;
 	opts->overwrite = false;
-	ui__warning("fall back to non-overwrite mode\n");
+	pr_debug2("fall back to non-overwrite mode\n");
 	return 1;
 }
 
#4 lore raw

[tip:perf/urgent] perf top: Fix annoying fallback message on older kernels

In reply to [email protected]
perf top: Fix annoying fallback message on older kernels
Commit-ID:  626af862da9c650e80bdea44684be9334f8eb75b
Gitweb:     https://git.kernel.org/tip/626af862da9c650e80bdea44684be9334f8eb75b
Author:     Kan Liang <[email protected]>
AuthorDate: Mon, 26 Feb 2018 10:17:10 -0800
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Mon, 5 Mar 2018 11:48:56 -0300

perf top: Fix annoying fallback message on older kernels

On older (e.g. v4.4) kernels, an annoying fallback message can be observed in 'perf top':

	┌─Warning:──────────────────────┐
	│fall back to non-overwrite mode│
	│                               │
	│                               │
	│Press any key...               │
	└───────────────────────────────┘

The 'perf top' utility has been changed to overwrite mode since commit ebebbf082357 ("perf top: Switch default mode to overwrite mode").

For older kernels which don't have overwrite mode support, 'perf top' will fall back to non-overwrite mode and print out the fallback message using ui__warning(), which needs user's input to close.

The fallback message is not critical for end users. Turning it to debug message which is printed when running with -vv.

Cc Kan Liang <[email protected]>
Fixes ebebbf082357 ("perf top: Switch default mode to overwrite mode")
---
 tools/perf/builtin-top.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/builtin-top.c +1 -1
index b7c823ba8374..35ac016fcb98 100644
@@ -991,7 +991,7 @@ static int perf_top_overwrite_fallback(struct perf_top *top,
 	evlist__for_each_entry(evlist, counter)
 		counter->attr.write_backward = false;
 	opts->overwrite = false;
-	ui__warning("fall back to non-overwrite mode\n");
+	pr_debug2("fall back to non-overwrite mode\n");
 	return 1;
 }