Skip to contentSkip to conversation

Makefile: add u-boot-spl.srec target

PATCH New Marek Vasut 2 participants 7 messages Feb 26, 2018 – Feb 27, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 Makefile: add u-boot-spl.srec target

The u-boot-spl.srec is needed for some platforms, add target to generate this file.

Cc Nobuhiro Iwamatsu <[email protected]>
Cc Tom Rini <[email protected]>
---
 Makefile | 5 +++++
 1 file changed, 5 insertions(+)
Makefile +5 -0
index 57cb4b87d9..a3ce04947a 100644
@@ -926,6 +926,11 @@ OBJCOPYFLAGS_u-boot.srec := -O srec
 u-boot.hex u-boot.srec: u-boot FORCE
 	$(call if_changed,objcopy)
 
+OBJCOPYFLAGS_u-boot-spl.srec = $(OBJCOPYFLAGS_u-boot.srec)
+
+spl/u-boot-spl.srec: spl/u-boot-spl FORCE
+	$(call if_changed,objcopy)
+
 OBJCOPYFLAGS_u-boot-nodtb.bin := -O binary \
 		$(if $(CONFIG_X86_16BIT_INIT),-R .start16 -R .resetvec)
 
Signature · 1 line
2.16.1
#1 lore raw

PATCH 2/2 ARM: rmobile: Build u-boot-spl.srec on Gen2

The u-boot-spl.srec is needed for the minimon update on Gen2 SoCs, conveniently generate this file if SPL is enabled.

Cc Nobuhiro Iwamatsu <[email protected]>
Cc Tom Rini <[email protected]>
---
 include/configs/rcar-gen2-common.h | 4 ++++
 1 file changed, 4 insertions(+)
include/configs/rcar-gen2-common.h +4 -0
index 1ceee9a429..6069220406 100644
@@ -15,6 +15,10 @@
 #define CONFIG_SETUP_MEMORY_TAGS
 #define CONFIG_INITRD_TAG
 
+#ifdef CONFIG_SPL
+#define CONFIG_SPL_TARGET	"spl/u-boot-spl.srec"
+#endif
+
 #undef	CONFIG_SHOW_BOOT_PROGRESS
 
 #define CONFIG_ARCH_CPU_INIT
Signature · 1 line
2.16.1
#2 lore raw

PATCH 2/2 ARM: rmobile: Build u-boot-spl.srec on Gen2

Quoted 15 lines · Marek Vasut

The u-boot-spl.srec is needed for the minimon update on Gen2 SoCs, conveniently generate this file if SPL is enabled.

Cc Nobuhiro Iwamatsu <[email protected]>
Cc Tom Rini <[email protected]>
---
 include/configs/rcar-gen2-common.h | 4 ++++
 1 file changed, 4 insertions(+)
include/configs/rcar-gen2-common.h +0 -0
index 1ceee9a429..6069220406 100644

include/configs/rcar-gen2-common.h line 24

Quoted 10 lines
include/configs/rcar-gen2-common.h +4 -0
@@ -15,6 +15,10 @@
 #define CONFIG_SETUP_MEMORY_TAGS
 #define CONFIG_INITRD_TAG
 
+#ifdef CONFIG_SPL
+#define CONFIG_SPL_TARGET	"spl/u-boot-spl.srec"
+#endif
+
 #undef	CONFIG_SHOW_BOOT_PROGRESS
 
 #define CONFIG_ARCH_CPU_INIT

Can you please convert CONFIG_SPL_TARGET to CONFIG_SPL_BUILD_TARGET, to match CONFIG_BUILD_TARGET and migrate it after CONFIG_BUILD_TARGET? Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180226/2c273c13/attachment.sig>
#3 lore raw

PATCH 2/2 ARM: rmobile: Build u-boot-spl.srec on Gen2

Quoted 26 lines · Tom Rini
Quoted 24 lines · Marek Vasut

The u-boot-spl.srec is needed for the minimon update on Gen2 SoCs, conveniently generate this file if SPL is enabled.

Cc Nobuhiro Iwamatsu <[email protected]>
Cc Tom Rini <[email protected]>
---
 include/configs/rcar-gen2-common.h | 4 ++++
 1 file changed, 4 insertions(+)
include/configs/rcar-gen2-common.h +4 -0
index 1ceee9a429..6069220406 100644
@@ -15,6 +15,10 @@
 #define CONFIG_SETUP_MEMORY_TAGS
 #define CONFIG_INITRD_TAG
 
+#ifdef CONFIG_SPL
+#define CONFIG_SPL_TARGET	"spl/u-boot-spl.srec"
+#endif
+
 #undef	CONFIG_SHOW_BOOT_PROGRESS
 
Quoted 6 lines

include/configs/rcar-gen2-common.h line 24

Quoted 1 line
include/configs/rcar-gen2-common.h +0 -0
 #define CONFIG_ARCH_CPU_INIT

Can you please convert CONFIG_SPL_TARGET to CONFIG_SPL_BUILD_TARGET, to match CONFIG_BUILD_TARGET and migrate it after CONFIG_BUILD_TARGET? Thanks!

Yeah, after the release. I dont plan to mess with it before the release. Or are you planning to convert BUILD_TARGET to Kconfig _before_ ?

Signature · 2 lines
Best regards,
Marek Vasut
#4 lore raw

PATCH 2/2 ARM: rmobile: Build u-boot-spl.srec on Gen2

Quoted 27 lines · Marek Vasut
Quoted 26 lines · Tom Rini
Quoted 24 lines · Marek Vasut

The u-boot-spl.srec is needed for the minimon update on Gen2 SoCs, conveniently generate this file if SPL is enabled.

Cc Nobuhiro Iwamatsu <[email protected]>
Cc Tom Rini <[email protected]>
---
 include/configs/rcar-gen2-common.h | 4 ++++
 1 file changed, 4 insertions(+)
include/configs/rcar-gen2-common.h +4 -0
index 1ceee9a429..6069220406 100644
@@ -15,6 +15,10 @@
 #define CONFIG_SETUP_MEMORY_TAGS
 #define CONFIG_INITRD_TAG
 
+#ifdef CONFIG_SPL
+#define CONFIG_SPL_TARGET	"spl/u-boot-spl.srec"
+#endif
+
 #undef	CONFIG_SHOW_BOOT_PROGRESS
 
Quoted 8 lines
Quoted 5 lines

include/configs/rcar-gen2-common.h line 24

Quoted 1 line
include/configs/rcar-gen2-common.h +0 -0
 #define CONFIG_ARCH_CPU_INIT

Can you please convert CONFIG_SPL_TARGET to CONFIG_SPL_BUILD_TARGET, to match CONFIG_BUILD_TARGET and migrate it after CONFIG_BUILD_TARGET? Thanks!

Yeah, after the release. I dont plan to mess with it before the release. Or are you planning to convert BUILD_TARGET to Kconfig _before_ ?

I would be happy enough to take both of those at this point, yes, as they can be easily verified. Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180226/cc4af432/attachment.sig>
#5 lore raw

PATCH 2/2 ARM: rmobile: Build u-boot-spl.srec on Gen2

Quoted 34 lines · Tom Rini
Quoted 33 lines · Marek Vasut
Quoted 31 lines · Tom Rini
Quoted 15 lines · Marek Vasut

The u-boot-spl.srec is needed for the minimon update on Gen2 SoCs, conveniently generate this file if SPL is enabled.

Cc Nobuhiro Iwamatsu <[email protected]>
Cc Tom Rini <[email protected]>
---
 include/configs/rcar-gen2-common.h | 4 ++++
 1 file changed, 4 insertions(+)
include/configs/rcar-gen2-common.h +0 -0
index 1ceee9a429..6069220406 100644

include/configs/rcar-gen2-common.h line 24

Quoted 10 lines
include/configs/rcar-gen2-common.h +4 -0
@@ -15,6 +15,10 @@
 #define CONFIG_SETUP_MEMORY_TAGS
 #define CONFIG_INITRD_TAG
 
+#ifdef CONFIG_SPL
+#define CONFIG_SPL_TARGET	"spl/u-boot-spl.srec"
+#endif
+
 #undef	CONFIG_SHOW_BOOT_PROGRESS
 
 #define CONFIG_ARCH_CPU_INIT

Can you please convert CONFIG_SPL_TARGET to CONFIG_SPL_BUILD_TARGET, to match CONFIG_BUILD_TARGET and migrate it after CONFIG_BUILD_TARGET? Thanks!

Quoted 5 lines
Quoted 2 lines

Yeah, after the release. I dont plan to mess with it before the release. Or are you planning to convert BUILD_TARGET to Kconfig _before_ ?

I would be happy enough to take both of those at this point, yes, as they can be easily verified. Thanks!

I'll add it to my todo ...

Signature · 2 lines
Best regards,
Marek Vasut
#6 lore raw

PATCH 1/2 Makefile: add u-boot-spl.srec target

In reply to Marek Vasut
Quoted 5 lines · Marek Vasut

The u-boot-spl.srec is needed for some platforms, add target to generate this file.

Cc Nobuhiro Iwamatsu <[email protected]>
Cc Tom Rini <[email protected]>
Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180226/7b2ed351/attachment.sig>