lightnvm: Avoid validation of default op value
PATCH RESEND 1/1 lightnvm: Avoid validation of default op value
Fixes 38401d231de65 ("lightnvm: set target over-provision on create ioctl")
Signed-off-by Heiner Litz <[email protected]>
--- drivers/lightnvm/core.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/lightnvm/core.c +2 -4
@@ -304,11 +304,9 @@ static int __nvm_config_extended(struct nvm_dev *dev, }/* op not set falls into target's default */ -if (e->op ==0xFFFF ) +if (e->op ==0xFFFF ) { e->op =NVM_TARGET_DEFAULT_OP ; - -if (e->op <NVM_TARGET_MIN_OP || - e->op >NVM_TARGET_MAX_OP ) { + }else if (e->op <NVM_TARGET_MIN_OP || e->op >NVM_TARGET_MAX_OP ) {pr_err ("nvm: invalid over provisioning value\n" );return -EINVAL ; }
Signature · 1 line
2.14.1
Quoted 28 lines · Heiner Litz
Fixes 38401d231de65 ("lightnvm: set target over-provision on create ioctl")Signed-off-by Heiner Litz <[email protected]>---
drivers/lightnvm/core.c| 6 ++----1 file changed, 2 insertions(+), 4 deletions(-)drivers/lightnvm/core.c +2
-5@@ -304,11 +304,9 @@ static int __nvm_config_extended(struct nvm_dev *dev, }/* op not set falls into target's default */ -if (e->op ==0xFFFF ) +if (e->op ==0xFFFF ) { e->op =NVM_TARGET_DEFAULT_OP ; - -if (e->op <NVM_TARGET_MIN_OP || - e->op >NVM_TARGET_MAX_OP ) { + }else if (e->op <NVM_TARGET_MIN_OP || e->op >NVM_TARGET_MAX_OP ) {pr_err ("nvm: invalid over provisioning value\n" );return -EINVAL ; } --
Quoted 1 line
2.14.1
Thanks for applying the changes. Looks good to me now.
Quoted 16 lines · Heiner Litz
Fixes 38401d231de65 ("lightnvm: set target over-provision on create ioctl")Signed-off-by Heiner Litz <[email protected]>--- drivers/lightnvm/core.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)drivers/lightnvm/core.c +0
-0@@ -304,11 +304,9 @@ static int __nvm_config_extended(struct nvm_dev *dev, }/* op not set falls into target's default */
drivers/lightnvm/core.c static int __nvm_config_extended(struct nvm_dev *dev, · line 312
Quoted 10 lines
drivers/lightnvm/core.c +2
-4-if (e->op ==0xFFFF ) +if (e->op ==0xFFFF ) { e->op =NVM_TARGET_DEFAULT_OP ; - -if (e->op <NVM_TARGET_MIN_OP || - e->op >NVM_TARGET_MAX_OP ) { + }else if (e->op <NVM_TARGET_MIN_OP || e->op >NVM_TARGET_MAX_OP ) {pr_err ("nvm: invalid over provisioning value\n" );return -EINVAL ; }
Thanks Heiner. Applied.